- 19 Jun, 2020 36 commits
-
-
David Bertoni authored
The DownloadExtensionTest_Download_InvalidURLs was timing out on Mac and causing a free-after-use issue on Asan builds. Splitting the test into two parts has fixed the issue with timeouts. The Asan failure is no longer present. The tests passed 3000 iterations on the bots without any issues. Bug: 392288 Change-Id: I90416d1fc9e0a6621f6ea3b3bf737a66cc2bb5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229321 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#780121}
-
Yoshifumi Inoue authored
This patch changes |selection_test()| in "drag-into-marker.html" for ease of maintenance and help to enable EditingNG. Bug: 679977, 707656 Change-Id: Ib0ce65fc816791790454d9114dad2d92db7c0a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251861 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#780120}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/404049010310..b1ca66dca905 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058147,chromium:1059455,chromium:1094506 Tbr: atotic@google.com Change-Id: I84a315f48924ac4f7dea2897c5370dbfcf0333a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253218Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780119}
-
Marijn Kruisselbrink authored
Bug: 1086845 Change-Id: I1630dcff89198ea968ff49ff353d793ae19c10b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253242 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#780118}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/79ca92d952ae..7a82467d0db0 2020-06-18 ilnik@webrtc.org Fix vp9 svc singlecast mode and enable quality scaler for vp9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0ca8bb131a1eee7e541357f269536055238cd034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780117}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib94233b112da879a7af445d354d3eedf20f8c9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253151Reviewed-by:
-
Ben Pastene authored
HW tests aren't picking up the `luci-auth context ...` prefix. This should fix that. Bug: 1057152 Change-Id: I739df6433d1e5979863d6c382882dc6370bf7ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252564Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#780115}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592506745-dd4e30b5db51eb72110579247828d44bc4732ba7.profdata to chrome-win32-master-1592513989-cb1b2e433544322a6e074399b2bf791e5b9da4e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I005501d42f7de323a884fa631a5d80988ad6150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252476Reviewed-by:
-
Bo Liu authored
There is a crash if activity is recreated on rotation and the weblayer fragment is also destroyed and recreated. This is introduced in the CL that that keeps visibility across activities when fragment is retained: https://chromium-review.googlesource.com/c/chromium/src/+/2216311 Add a test to catch this. Reported in b/158864549 Change-Id: I51c43b102ea995fa5387df420bf0a7844670af71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252952Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780113}
-
Karandeep Bhatia authored
Tests exercising the DNR rule limits can currently time out since they may index up to 30K rules. Prevent this by allowing tests to override the rule limits. BUG=1092777, 1092776 Change-Id: I4126563a4f6c0e299470491232cd5c8798a6342e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244000Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/304dfa379c54..d610c751569a 2020-06-18 bsalomon@google.com Fix a unintended shader change in GrTextureEffect 2020-06-18 egdaniel@google.com Reland "Don't release vk memory allocator until context is deleted." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1081806 Tbr: djsollen@google.com Change-Id: Ib8867f630ea365f949569eb5048700e25fdfd050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253299Reviewed-by:
-
ziyangch authored
-CmaAudioOutputStreamInternal will be a pure push mode output stream. And CmaAudioOutputStream will keep the backend state control and push timer logic. Bug: internal b/152920790 Test: Cast from Youtube to Android TV device. Change-Id: Iadbb82a8017b8779a6c96a8473b1179469966242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242650 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#780110}
-
phillis authored
This is the first step towards consolidating OS integration logic to OsIntegrationManager. This patch adds just enough functionality to replace the OS logic in AppLaunchHandler. Bug: 1087219 Change-Id: I632327b9c7c86683e2b408ea361ee183aed13d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251198Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#780109}
-
tby authored
App icons in the suggested chips are circular, but our current set of file icons are square. Medium-term this will be addressed by the move to SVG from PNG icons, which will let us change this in-code. Until support for SVGs is in place, we need a temporary fix for experiments that add files to the suggestion chips. This CL adds a full set of circular GM2 file icons, replacing the handful of chip-customized file icons we had already. Bug: 1093669 Change-Id: I25b628e6b8c57dfdaf70fc976f44499100bc92c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247988Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#780108}
-
Thomas Guilbert authored
This CL removes the key based getters/setters for VideoFrameMetadata, in favor of directly using the base::Optionals<> fields of the same name. Change-Id: I811cb668883f937091de436bc656c9ce3f88a79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238361 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#780107}
-
Xida Chen authored
I believe these two histograms are useful, it can be a high level indication of touch regressions. So we should preserve these two histograms. Bug: 1041525, 1037589 Change-Id: Idd3e5015662eb86403c485b02e41bdc777b34299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248755Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780106}
-
James Cook authored
This removes the magic per-platform path filtering behavior. In particular, it allows mojoms with "chromeos" in the path to be used for non-chromeos build targets (e.g. lacros). Bug: none Change-Id: I98badef6971578b9e97194d16b06e79bacbab335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253183 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#780105}
-
Alexander Surkov authored
Bug: 1096512 Change-Id: Ia93a6f95545e1de67916401a490ea2ab239735ab AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251750 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780104}
-
Jeffrey Kardatzke authored
This is the mojo interface and implementation to adapt CdmStorage requests from the Chrome OS daemon to the CdmStorage mojo interface in Chrome. This will be passed into the CreateCdm mojo call in the CdmFactory to provide origin specific storage for the Chrome OS CDM. The implementation of the media::CdmFactory and media::ContentDecryptionModule interfaces that us this will live in the GPU process, which is why this component has the '_gpu' suffix on it. BUG=b:153111783 TEST=Unit test passes Change-Id: I20e175e22f462a96a3c09facf06df7233484dc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252684 Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780103}
-
Daniel Libby authored
This change builds on crrev.com/c/2229668 to plumb the window segment information from the content layer into Blink, where it is exposed via a JavaScript API. From RenderWidget, the root window segments are stored on the local WebFrameWidgetBase root, and returned via script through the FrameWidget interface. i2p: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/_1_ljYsaqrU/qOoHJ7MhAgAJ Explainer: https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md Change-Id: I9b80f189e41160fc490bd09191722cb20b7115e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246988 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780102}
-
Frank Tang authored
This reverts commit 06c8dc37. Reason for revert: Retry after fixed win clang bugs Binary-Size: Increase is temporary. Original change's description: > Revert "Roll ICU to fix sr-ME problem" > > This reverts commit e8aa67c5. > > Reason for revert: Breaking win32-archive-rel > https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/14063? > > TBR=dvallet@chromium.org > NOTRY=true > NOTREECHECKS=true > NOPRESUBMIT=true > > Change-Id: If0576038e2d07cf3e3ad5e5c35a64ff0007ee174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248392 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779634} TBR=calamity@chromium.org,jshin@chromium.org,dvallet@chromium.org,claudiomagni@chromium.org,ftang@chromium.org # Not skipping CQ checks because this is a reland. Roll ICU to fix sr-ME problem Include consistent locale script/region variants by using filterType language. Change expectation in locale_util_unittest since now icu will return it-IT and de-DE in the available locales after we include all the script/region variants. Correct expectation in currency_formatter_unittest and remove comments. https://chromium.googlesource.com/chromium/deps/icu.git/+log/9e7dae8..79326efe 79326ef Make visibility_hidden configuration only pass -fvisibility=hidden on Linux/Android/MacOS d3f776e Add back curr/en_* in android_small bbf7f88 Append a postfix to the icu target outputs on fuchsia (where target output is hardcoded) 7852ffc Use filterType: language 8d29692 Allow building icuuc/icui18n with -fvisibility=hidden Size will be reduced once we land ICU 68.1 which I reduced the break iterator data size. Binary-Size: Increase is temporary. Bug: v8:10599, v8:10601, 863749, 739812 Change-Id: Icb1ed09ca3679f60c8c77bf8e1f346f323b5e6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252026 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Martin Kustermann <kustermann@google.com> Cr-Commit-Position: refs/heads/master@{#780101}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592506745-f793491bcd6225e620fbbb39e10a569b00ffc767.profdata to chrome-win64-master-1592517558-a22b1521d7c950615c0a9ff92ae71c12468f78b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia9a0c5e9f6d18cc0d5d7d77df007cf6810656430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252477Reviewed-by:
-
chrome://internals/query-tiles.Findit authored
This reverts commit 7981cdda. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 780087 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc5ODFjZGRhM2U0Mzk4OTg1YTUwNTNhN2I3NDkyZjhjYTE4OGQ2MzAM Sample Failed Build: https://ci.chromium.org/b/8877108097544019312 Sample Failed Step: compile Original change's description: > Setup chrome://internals/query-tiles. > > - Setup chrome://internals for future merge. > - Complete the front end code for chrome://internals/query-tiles. > > Bug: 1066556 > Change-Id: I51529f6e11dd37e15df2b7a3da1864dbbc5da58b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247544 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780087} Change-Id: I454c0693ef4898dda3a2dc8c7d3386beb84d930f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253207 Cr-Commit-Position: refs/heads/master@{#780099}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22b0828640fb..4ac015d92df8 2020-06-18 huangs@chromium.org [DFM] Skip unneeded calls to DeviceUtils._FakeInstall(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1093238 Tbr: rmhasan@google.com Change-Id: I2cdc50d626e66b1de50c62165b1e1636dbe52ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253001Reviewed-by:
-
Charlene Yan authored
Bug: 1018230 Change-Id: I62de1dd2578f5fc738a15ef71fab6ab6b7310dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252646Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780097}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ca37e4df727..72e8dbac26a8 2020-06-18 tvanderlippe@chromium.org Do not minify when copying debugged sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I83cc83486e80ec7cf522aa6a9dcfe7a3f5dd8aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252526Reviewed-by:
-
Mustafa Emre Acer authored
The feature is fully launched and we now have allowlists pushed by the component updater. Remove the flag and clean up the tests. Change-Id: I86a2da492ae09748306f2c68846090cba05bff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253020 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#780095}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3673ac461dad..2410c8498c0b 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3cf3b4318198bda14fca6059113df008329331be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252587Reviewed-by:
-
Toni Barzic authored
The metric monitors the shelf alignment (bottom, left, or right), which is a core shelf setting. BUG=1081295 Change-Id: I96db7c5e30f18d9006174652012bddc5af114608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252603Reviewed-by:
-
Jacques Newman authored
Bug: 1096223 AX-Relnotes: n/a Change-Id: I7685e4e5b828a1d2ecc04398735506dde482dcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250786Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780092}
-
Mario Bianucci authored
In order to start having the browser process forward ink points to viz for delegated ink trails, add a flag onto the RenderFrameMetadata that lets the browser process know it should start. RenderFrameMetadataObserver will pick it up and ship it over to the browser process, where it will be picked up by RenderWidgetHostViewBase and saved for a future CL, where RWHVEventHandler will use it. Bug: 1052145 Change-Id: I8305292de6289dcec3fb4083666898161ae1dc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240356Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780091}
-
Trent Apted authored
Mostly this is missing nullability modifiers picked up by jscomp_error=lintChecks. Also clean up some white space in closure annotations. This just addresses the release code (test code to be done later after consolidating all the flags better). Bug: 892530 Change-Id: Ibb8c250bf7b5e3950f9bc477bad0fcffc3254bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253258Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#780090}
-
Chris Lu authored
This change will allow for mocking AutofillSaveCardInfoBarDelegateMobile. Bug: 1071914 Change-Id: I1175201dc0b286558211e111bb19a6c6d853856b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250702 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#780089}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib03d852d809386687f2770887a68f74b00c4c1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252637Reviewed-by:
-
chrome://internals/query-tilesHesen Zhang authored
- Setup chrome://internals for future merge. - Complete the front end code for chrome://internals/query-tiles. Bug: 1066556 Change-Id: I51529f6e11dd37e15df2b7a3da1864dbbc5da58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247544 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#780087}
-
gogerald authored
This CL fixes the bug in https://chromium-review.googlesource.com/c/chromium/src/+/2243334 Without setting the height to match_parent, it will be unscrollable when its content is short. Screen record before https://drive.google.com/file/d/1CUOz6ErGL2fxkF2pGAC_fGWEcTGy8hrD/view?usp=sharing Screen record after https://drive.google.com/file/d/1CeuBtjQbGRovJC8H0Vk-wY6wpWqmlQJ0/view?usp=sharing Bug: 1093506 Change-Id: Iff9df7ef0050885c02fe55676dbfa2046d6e78a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253143 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780086}
-
- 18 Jun, 2020 4 commits
-
-
Meilin Wang authored
This reverts commit 7e22905c. Reason for revert: fixed the test crashes. Original change's description: > Revert "ambient: container logic refactoring [part 1]." > > This reverts commit 7eab011b. > > Reason for revert: AmbientControllerTest failures > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg?limit=200 > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19204?blamelist=1#blamelist-tab > > Original change's description: > > ambient: container logic refactoring [part 1]. > > > > This CL is splitted from the original CL: > > https://chromium-review.googlesource.com/c/chromium/src/+/2199870 > > with all files changed on ambient/. side. > > > > Bug: b/156531168 > > Test: unittests. > > Change-Id: I4f84277c74c95419ac96e6cfaaa48081c407b243 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248878 > > Commit-Queue: Meilin Wang <meilinw@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779664} > > Change-Id: Ia9eaa3e0d856c7dabf2526c3566fa35cf415e17c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/156531168 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250602 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779737} Bug: b/156531168 Change-Id: I75b3385ffa72ac9fe5a9d90f2844180231e4fcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252656Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#780085}
-
Christopher Cameron authored
This file has gotten jumbled by keeping diffs small. This does nothing but move code around. TBR=geofflang Bug: 1092155 Change-Id: I6951d61ce1ae96cde61cd879c482bd8a20641f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251160Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#780084}
-
Xianzhu Wang authored
This a reduced version of crrev.com/c/2238519. That CL was reverted because of crbug.com/1094807 (DCHECK failure in cc::PictureLayerImpl::SetUseTransformedRasterization). The failure seems because of cc::PictureLayer::ShouldUseTransformedRasterization() may change after Update() before PushPropertiesTo. This CL removed the main-thread side change about transformed rasterization, but keeps the impl-side changes. > - Turned out that we can't enable LCD text with transformed > rasterization because the latter will cause translucent pixels along the > edges of the layer on which text may draw. This CL partly reverts > crrev.com/c/2229243 which enabled LCD text with transformed > rasterization. > > - When enabling transformed rasterization, we need to not only set > contents_opaque to false, but also need to let RasterSource clear canvas > before drawing because of the translucent pixels at edges. > Bug: 1077071 Change-Id: Ib67d054efb357a75f3c33d98c32cdb4fe5563612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247385Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c950e05bafcd..304dfa379c54 2020-06-18 brianosman@google.com Remove swizzling-store instructions from SkSL ByteCode 2020-06-18 fmalita@chromium.org [skottie] Add support for unprefixed valign/resizing props 2020-06-18 bsalomon@google.com Use child texture effects in ProcessorRefTest 2020-06-18 johnstiles@google.com Roll gn. 2020-06-18 fmalita@chromium.org [skrive] Start parsing the node hierarchy 2020-06-18 brianosman@google.com Remove swizzling-load instructions from SkSL ByteCode 2020-06-18 brianosman@google.com In SkSLSlide, directly use Viewer's shader error handler 2020-06-18 mtklein@google.com allow fallback to skvm blitter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Icc61f224925aaacf2fa9e43cff384346a3298f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252535Reviewed-by:
-
