GitLab

This allows DevicesChangedObserver to listen to desired events, instead of being woken up by change of uninterested devices.

BUG=137799
Review URL: https://chromiumcodereview.appspot.com/10836004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149103 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149102 0039d316-1c4b-4281-b951-d872f2087c98

A test that makes sure all the pages in the templates/public directory render
without erroring.

BUG=131095


Review URL: https://chromiumcodereview.appspot.com/10828042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149101 0039d316-1c4b-4281-b951-d872f2087c98

Now protoc.exe will be directly invoked.

This rolls cacheinvalidation from r218:r219
------------------------------------------------------------------------
r219 | ghcooper@gmail.com | 2012-07-20 17:44:14 -0700 (Fri, 20 Jul 2012) | 1 line

move protos out of v2/; use relative paths for proto imports
------------------------------------------------------------------------

This also rolls gyp from r1440:r1441
------------------------------------------------------------------------
r1441 | iannucci@chromium.org | 2012-07-26 17:54:17 -0700 (Thu, 26 Jul 2012) | 8 lines

Fix bug: non-cygwin actions incorrectly run options through _FixPath.

This adds an additional heuristic to the existing one. Now if an option begins
with either a '/' OR a '-', it assumes it's not a strict path.

Added a TODO which notes that the existing (and new) behavior will miss options
such as '--opt=a/posix/path', and '/opt:a/posix/path'.
Review URL: https://chromiumcodereview.appspot.com/10829049
------------------------------------------------------------------------


BUG=123026,113339
R=scottmg@chromium.org,cmp@chromium.org,nsylvain@chromium.org,jar@chromium.org,akalin@chromium.org,maruel@chromium.org

TEST=

Review URL: https://chromiumcodereview.appspot.com/10796051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149100 0039d316-1c4b-4281-b951-d872f2087c98

In order to manage device media gallery permissions, use a device id that is unique and persistent across device attachments. Therefore, extract device uuid from DiskInfo::InitializeFromResponse and use that identifier while dispatching media device attached notification event.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10830003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149099 0039d316-1c4b-4281-b951-d872f2087c98

TBRing becasue of a very trivial changes.

BUG=none
TBR=tbarzic@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149098 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96369
TEST=none
TBR=timurrrr
Review URL: https://chromiumcodereview.appspot.com/10830083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149096 0039d316-1c4b-4281-b951-d872f2087c98

Instead of including singleton.h in header files we can forward declare it,
and include only in the source file.

There is also a presubmit check for this, I didn't know ;)

R=willchan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10835029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131355
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10835036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149094 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wtc
BUG=
TEST=Swarm bots  stop failing the runhooks step

Review URL: https://chromiumcodereview.appspot.com/10829089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149092 0039d316-1c4b-4281-b951-d872f2087c98

Purpose of this change is to help future-proof the script. Since old versions
of this script may be run when signing old builds, removing this check for
too many args allows us to add new params on the calling side without breaking
old builds.

BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10826076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83382


Review URL: https://chromiumcodereview.appspot.com/10834073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149090 0039d316-1c4b-4281-b951-d872f2087c98

CHECK was to determine whether this failure is possible. It is.

BUG=139145

Review URL: https://chromiumcodereview.appspot.com/10823045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149087 0039d316-1c4b-4281-b951-d872f2087c98

The backing code that this referenced was removed some time ago in http://codereview.chromium.org/10453013/


Review URL: https://chromiumcodereview.appspot.com/10836013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149085 0039d316-1c4b-4281-b951-d872f2087c98

We have to do this to avoid potential kernel panic.  Will remove this entry once Apple fixes the issue and pushes the updates to users.

BUG=134015
TEST=
Review URL: https://chromiumcodereview.appspot.com/10837006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149084 0039d316-1c4b-4281-b951-d872f2087c98

This may help in tracking down any synchronization issues.


BUG=135546


Review URL: https://chromiumcodereview.appspot.com/10836018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149083 0039d316-1c4b-4281-b951-d872f2087c98

With Verizon's activation now coming in a separate modal dialog, there is no reason for us to restrict this to only once the user has logged in. Allows users to activate Verizon from the login screen or OOBE. The user should still not be able to activate from the lock screen though.

Also make the modal activation dialog the default option.

Review requested,
zelidrag@ - main review
sky@ - OWNER's review for,
  chrome/browser/ui/views/ash
  chrome/browser/ui/webui/chromeos/
sadrul@ - OWNER's review for,
  chrome/browser/chromeos/status

R=zelidrag@chromium.org,sky@chromium.org,sadrul@chromium.org
BUG=134475
TEST=The activation option is available at OOBE and the Login screens but not the lock screen. On selecting the activation option, the 3g activation dialog comes up.

Review URL: https://chromiumcodereview.appspot.com/10790133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149082 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129499
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10827014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137973
TEST=none
TBR=glider
Review URL: https://chromiumcodereview.appspot.com/10821098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149077 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=139726

Review URL: https://chromiumcodereview.appspot.com/10837012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149076 0039d316-1c4b-4281-b951-d872f2087c98

Failing on buildbots, but not locally/trybots.

BUG=139726
TBR=sergeyu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149074 0039d316-1c4b-4281-b951-d872f2087c98

Precise's gcc warns about variables that are set but never used.

BUG=none
TEST=compiles on Precise.


Review URL: https://chromiumcodereview.appspot.com/10829088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149073 0039d316-1c4b-4281-b951-d872f2087c98

- Define member functions of class OutputConfigurator in the order
  they were declared.

- Made struct CachedOutputDescription to be private member of class
  OutputConfigurator.  No need for it to be exposed publicly.

- Renamed "enum State" to "enum OutputState" to be more specific.

- In places where a large if block extend to the end of the function,
  use an early return to reduce indentation.

BUG=chromium-os:32857
TEST=build successfully

Change-Id: Id39dff3b38d16b2496df0df288a332fe29b2e37b
Signed-off-by: Simon Que <sque@chromium.org>


Review URL: https://chromiumcodereview.appspot.com/10824071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149072 0039d316-1c4b-4281-b951-d872f2087c98

Fix bug in SpdySession where map.erase() was called on an iterator when the underlying map had changed, making the iterator invalid.

BUG=139518
TEST=SpdySessionSpdy*Test.CloseSessionWithTwoCreatedStreams


Review URL: https://chromiumcodereview.appspot.com/10821086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149071 0039d316-1c4b-4281-b951-d872f2087c98

is_hidden() was already added to RWHI recently and they duplicate exact functionality.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10833052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149070 0039d316-1c4b-4281-b951-d872f2087c98

does not prevent caching of responses that are not 200,
and does not delete the cached response if not really needed.

For example, we should be able to cache redirects when the
request is made using a byte range.

BUG=134267
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10829069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149069 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10830077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149068 0039d316-1c4b-4281-b951-d872f2087c98

  and lookup the classes by name. This allows the binary to work with multiple
  versions of Xcode and doesn't tile the binary to an Xcode install location.
- Fix problem where the tool could log the wrong thing since basename()
  returns an internal buffer.

Review URL: https://chromiumcodereview.appspot.com/10828070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149067 0039d316-1c4b-4281-b951-d872f2087c98

R=binji@chromium.org
BUG=139161


Review URL: https://chromiumcodereview.appspot.com/10820058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149066 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149065 0039d316-1c4b-4281-b951-d872f2087c98

This will expose the bounding box for a WebGestureEvent in WebKit.

This patch only depends on http://trac.webkit.org/changeset/123520, so it is safe to land now.

BUG=138572
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10806092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112525

Review URL: https://chromiumcodereview.appspot.com/10831061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149063 0039d316-1c4b-4281-b951-d872f2087c98

This leak was introduced in r148926.

BUG=129825,139635


Review URL: https://chromiumcodereview.appspot.com/10821091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149062 0039d316-1c4b-4281-b951-d872f2087c98

We've been seeing a bunch of issues on this driver with NULL share handles and fences failing to finish, so for now it's safest to try turning off the image transport surface texture sharing.


BUG=133924
TEST=


Review URL: https://chromiumcodereview.appspot.com/10815045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139657

Review URL: https://chromiumcodereview.appspot.com/10827090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149060 0039d316-1c4b-4281-b951-d872f2087c98

Also guard in Initialize() against bad API/card combos.

BUG=139671


Review URL: https://chromiumcodereview.appspot.com/10832067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149059 0039d316-1c4b-4281-b951-d872f2087c98

This adds a stub implementation of
GDataContactsServiceInterface to be used by
(not-yet-checked-in) unit tests.

BUG=128805
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149055 0039d316-1c4b-4281-b951-d872f2087c98

createHTMLNotification has been removed from the W3C Notifications spec. We do not want it to be exposed for web pages. However, since quite a few extensions are still using it, we would still keep it to be exposed for extensions.

BUG=98061
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10808113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149054 0039d316-1c4b-4281-b951-d872f2087c98