- 19 Nov, 2018 40 commits
-
-
Ethan Xu authored
This is the first CL of web share target V2. The goal of this CL is to add support for three new fields: method, enctype, and fields. This is in reference to the new web share target spec. https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#share_target-member The purposes of each field are as follows: method: the HTTP method used for launching the web share target. Can be either GET or POST. enctype: the encoding method used for launching a POST request web share target. Can be either application/x-www-form-urlencoded or multipart/form-data. files: a sequence of files each containing a name and an accepted sequence of mime types. Note that this can only be populated if the method is POST and the enctype is multipart/form-data. Logic checks are performed in manifest_parser.cc to determine if the web share target has a valid combination of fields. Bug: 885308 Change-Id: I277fef7e1402620385cb28909a078eb09676c1fc Reviewed-on: https://chromium-review.googlesource.com/c/1240867 Commit-Queue: Ethan Xu <xuethan@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609511}
-
Gauthier Ambard authored
This CL changes how the computation of the content insets of the scroll view displaying the PDF is done on iOS 11. Bug: 903635 Change-Id: I5dc8d69b4fbf0a6e68db1481f1991c9bdbc0b43b Reviewed-on: https://chromium-review.googlesource.com/c/1341988 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#609510}
-
Charlie Andrews authored
The current comment suggests that it does, but it seems worthwhile to make it explicit given that the name of the event might suggest otherwise. Change-Id: Ie0ab5a95a462e9e493336644fa1d7f4ecd5edc42 Reviewed-on: https://chromium-review.googlesource.com/c/1340859Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#609509}
-
Corentin Wallez authored
BUG=chromium:901830 Change-Id: I491fa83b4fe6e817e9bfb285ed81ce3b4356088f Reviewed-on: https://chromium-review.googlesource.com/c/1341843Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609508}
-
Donn Denman authored
Conditionally disables this test due to flakiness on this configuration. BUG=906788 TBR=twellington@chromium.org Change-Id: Ief4f08ae1d9f8c73b3055d136af655498a97892f Reviewed-on: https://chromium-review.googlesource.com/c/1343361Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609507}
-
James Zern authored
lossless encoder speedups and memory reduction when decoding corrupt images Bug: 905157 Change-Id: I0122578ae12a3654ddb2b9dead13ef3823fddc19 Reviewed-on: https://chromium-review.googlesource.com/c/1337378Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#609506}
-
Jonathan Metzman authored
TBR=mmoroz@chromium.org Change-Id: Ida8773dbc2d4d13a04dc96b2afc84e1a8d0c94f4 Bug: 904877 Reviewed-on: https://chromium-review.googlesource.com/c/1343245Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609505}
-
Steven Valdez authored
Bug: 630147 Change-Id: I20541f77c7e9e8d5a0085452d2a883e24563083c Reviewed-on: https://chromium-review.googlesource.com/c/1330069 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#609504}
-
Sidney San Martín authored
This'll make it easier for me to delete surrounding code, and I can't find any references to it so I suspect that it's safe to prune. Bug: 868398 Change-Id: Ib62d77f87df261200c6e6c1b821f99ed707041b9 Reviewed-on: https://chromium-review.googlesource.com/c/1343058 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Benjamin authored
I noticed this going through apache error_log.txt trying to diagnose other failures (perl warns about uninitialized value). $STATUS_TEXTS is a reference to a hash, so it should be accessed via $STATUS_TEXTS->{$REDIRECT_CODE}. $STATUS_TEXTS{$REDIRECT_CODE} means it is accessing %STATUS_TEXTS. Switch to the latter. Bug: none Change-Id: I177105deb451e88e8f21ca4a7e0cce7b21727991 Reviewed-on: https://chromium-review.googlesource.com/c/1340561Reviewed-by: -
Manu Cornet authored
Bug: 904231 Change-Id: I0eeb3131339da7d9c3cbeb308e7df50acd85220d Reviewed-on: https://chromium-review.googlesource.com/c/1341648Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#609501}
-
Sorin Jianu authored
With this change, the configurator code injects both values. extra_info_["testrequest"] = "1"; extra_info_["testsource"] = "dev"; Bug: 906641 Change-Id: I4cd3f68b9b292f2d76b95d3678bd6df0cd437e73 Reviewed-on: https://chromium-review.googlesource.com/c/1343294Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609500}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5913160a7d40..1e54003639e3 git log 5913160a7d40..1e54003639e3 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 crouleau@chromium.org Fix help for --also-run-disabled-tests flag. Created with: gclient setdep -r src/third_party/catapult@1e54003639e3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ae7ab6c2d755ac83bf8536bde51f15f33bd476e Reviewed-on: https://chromium-review.googlesource.com/c/1342781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609499}
-
Robbie McElrath authored
This fixes 2 tests that were flaky on the waterfall. Diff patchsets 1 and 2 to see what changed. Original change's description: > Get NetworkChangeNotifier working on ChromeOS with network service. > > The current NetworkChangeNotifierChromeOS implementation won't work > with the network service enabled because it listens for network changes > from Shill, which only supports a single client. The browser process > has other dependencies on Shill, so it has to be the client for the time > being, meaning the network service can't directly listen for network > changes and has to be notified of them from the browser process. > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > the first will live in the browser process and listen to Shill, while > the second is the actual NetworkChangeNotifierChromeOS implementation > which will have an instance in both the browser and network processes. > Since NetworkChangeNotifierChromeOS can't actually listen for network > changes itself, it just gets notified of changes from part 1 via a new > method in NetworkChangeManager. When the thing listening to Shill sees > a network change, it notifies its local NetworkChangeNotifierChromeOS > instance, and calls the new NetworkChangeManager method, the > implementation of which then notifies the network service's > NetworkChangeNotifierChromeOS instance. > > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606665} Bug: 882610 Change-Id: I5547353ed5f944620548109c40eeb149fd85a710 Reviewed-on: https://chromium-review.googlesource.com/c/1338493 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#609498}
-
Roger McFarlane authored
Bug: 860285 Change-Id: I00282340aa8c16918237d1dbd5c69a9a5e0cb595 Reviewed-on: https://chromium-review.googlesource.com/c/1336550Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#609497}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dac70cc74650..21f7091b9a09 git log dac70cc74650..21f7091b9a09 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 yueherngl@google.com hatch: add new paladin Created with: gclient setdep -r src/third_party/chromite@21f7091b9a09 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I720089d83fb6df897a48af8aa7aa5590f0bf7423 Reviewed-on: https://chromium-review.googlesource.com/c/1343181Reviewed-by:
-
rbpotter authored
The scroller is now focusable due to Blink changes at r608013. Remove the outline and take it out of the tab order. Bug: 905604 Change-Id: Ib8154c691e1240b27118288950c8efdf46c803b6 Reviewed-on: https://chromium-review.googlesource.com/c/1343285Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609495}
-
Jun Choi authored
This reverts commit 7b0f2bb8. Reason for revert: Fails multiple IOS builds including Builder ios-slimnav <https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/191> Link to sample failure logs : https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929398908718170816/+/steps/ios_chrome_unittests__iPhone_6s_iOS_12.1_/0/logs/TextToSpeechListenerTest.ValidAudioDataTest/0 Original change's description: > Add web::NavigationContext::IsPlaceholderNavigation > > This is a step in multistep refactoring. The next steps will be: > > 1.) web::NavigationContext::URL is never set to placeholder > URL and always represents navigation URL > 2.) Same web::NavigationContext will be reused for placeholder > navigation to extend it's lifetime. > 3.) WebStateObserver::DidFinishNavigation will be caller after > placeholder navigation is finished and will use original > web::NavigationContext passed to WebStateObserver::DidStartNavigation > > This will partially fix crbug.com/903497 and will call > WebStateObserver::DidFinishNavigation after committed URL actually > changed. > > Bug: 903497 > Change-Id: Ib6ba96d664ac352d038787aa74ac844d07282789 > Reviewed-on: https://chromium-review.googlesource.com/c/1331044 > Reviewed-by: Danyao Wang <danyao@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609398} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: I8d7c9b66d752a792761d95ccf348f045eaa9de03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903497 Reviewed-on: https://chromium-review.googlesource.com/c/1343351Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609494}
-
Saman Sami authored
We only need to call this method during main frame navigation. TBR=apacible@chromium.org Bug: 893850 Change-Id: Id78fb02440f646c07de9bec3460cbb64809781f1 Reviewed-on: https://chromium-review.googlesource.com/c/1340702 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609493}
-
Antoine Labour authored
GL_REQUIRED_TEXTURE_IMAGE_UNITS_OES is a "get"-only enum, so even though it may be accepted by the texture_paramter validator (which has both "set" and "get" enums, as they are mostly the same), we need to handle it in Texture::SetParameter* and return GL_INVALID_ENUM. Some enums (e.g. GL_TEXTURE_SRGB_DECODE_EXT) were only handled in Texture::SetParameteri, so rework this a bit so that SetParameterf always delegates everything (including error cases) to SetParameteri, except for float params (which are only a handful), to avoid most of the duplication. Bug: 877754 Change-Id: I15c52f81e62544f90a15b914113c5c4816530cdb Reviewed-on: https://chromium-review.googlesource.com/c/1343357Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609492}
-
Quan Nguyen authored
This puts the method name more in line with Google C++ style, since snake_case should only be used with simple getters. Bug: 906676 Change-Id: I045aa7c8ac641b37854b38cf0934890ebbd88ca0 Reviewed-on: https://chromium-review.googlesource.com/c/1343250Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Changwan Ryu authored
When you use custom-schemed URLs across XHR, you will see an error saying that you cannot send an XHR from 'null' origin. This CL adds tests to compare the behavior between HTTP-schemed URL and custom-schemed URL such that the actual fix can pick it up. Bug: 898589, 900528, 896059 Change-Id: I43b4748a6595298d4ac6fdb216c8db1738719adf Reviewed-on: https://chromium-review.googlesource.com/c/1340999Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609490}
-
Ken Rockot authored
Migrates the unzip and patch services away from deprecated ServiceContext & EmbeddedServiceInfo stuff, instead using ServiceBinding with explicit Service instance construction where needed. Bug: 891780 Change-Id: I6382857974cf7f20f25ff16dd9ef21270e85d4d7 Reviewed-on: https://chromium-review.googlesource.com/c/1316442Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4065d45d2de1..a63cf8e80aa5 git log 4065d45d2de1..a63cf8e80aa5 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 rmistry@google.com Revert "Temporarily remove Android compile bot from CQ" 2018-11-19 csmartdalton@google.com Fix handling of dynamic state in GrAAFillRRectOp 2018-11-19 caryclark@skia.org fix pathops fuzzer timeout 2018-11-19 csmartdalton@google.com Add a dedicated Op for analytic round rects 2018-11-19 caryclark@skia.org font doc Created with: gclient setdep -r src/third_party/skia@a63cf8e80aa5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:906360,chromium:860021 TBR=csmartdalton@chromium.org Change-Id: I3c1331d3b9337150cdbf5a8e4d01a679231b2a6d Reviewed-on: https://chromium-review.googlesource.com/c/1343180Reviewed-by:
-
Noel Gordon authored
- use let and const and add doc comment annotations. - update LoadTimeData fake to include DRIVE_OFFLINE_COLLECTION_LABEL and DRIVE_SHARED_WITH_ME_COLLECTION_LABEL to avoid JS exceptions about them being missing / undefined when running the unittest. - rm duplicate NOT_MOUNTED_SINGLE_PROVIDING_EXTENSION definition. - use VolumeManagerCommon.Source types rather than bare strings. - create & install mock chrome.fileManagerPrivate. - create & install mock VolumeManager. - run JS formatter over the code. Bug: 905933 Change-Id: I7dabbb8ff72f79d290eaeffcb941280715f93660 Reviewed-on: https://chromium-review.googlesource.com/c/1343397 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609487}
-
Lukasz Anforowicz authored
These are most likely not recent regressions, but long-standing issues that got recently discovered because after r609379 made site-per-process the default mode for running layout tests. Using No-Try because no code is changed - only the test expectations (and we want to cycle WebKit Linux Trusty Leak bot green ASAP). Bug: 906809 Change-Id: I72c2da48fc0459b49c180843db34837eecfd0891 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1343063Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#609486}
-
Takumi Fujimoto authored
Record the event of user stopping a route in MediaRouter.Ui.FirstAction and MediaRouter.Ui.Action.StopRoute. The UIMediaSink struct now contains MediaRoute as a property, so that CastDialogView can determine whether a route is local or remote. Bug: 853369 Change-Id: I89052163e4de721164a1b4fe61e7b1cdeb1fad12 Reviewed-on: https://chromium-review.googlesource.com/c/1324131Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#609485}
-
Anand K. Mistry authored
BUG=None Change-Id: I259903cf7197ca584d2414dfd4a814e92d029e29 Reviewed-on: https://chromium-review.googlesource.com/c/1341430 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baafd0234bc7..26fa18517532 Created with: gclient setdep -r src-internal@26fa18517532 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia3720f4a5c011191e7babd11d58f68f302e7158a Reviewed-on: https://chromium-review.googlesource.com/c/1342812Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609483}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85340ce5166c..2e0c655bc6c5 git log 85340ce5166c..2e0c655bc6c5 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 yvesg@webrtc.org [Sanitizers] Don't retry failed tests. 2018-11-19 srte@webrtc.org Adds FieldTrialConstrained class. 2018-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3efc758c..9508bd7f (609210:609314) Created with: gclient setdep -r src/third_party/webrtc@2e0c655bc6c5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3b7936851d6ea007284d66439dde3f1b4abd69a7 Reviewed-on: https://chromium-review.googlesource.com/c/1343179Reviewed-by:
-
Gabriel Marin authored
Replace uses of new with std::make_unique or base::WrapUnique. See http://go/totw/126 for motivation. For scoped_refptr pointers use base::MakeRefCounted. BUG=b:116527691 TEST=Unit tests pass Change-Id: I42ffc6055b1d1d16dbc203e9b87d24b2295d0c76 Reviewed-on: https://chromium-review.googlesource.com/c/1340606 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
-
Benjamin Gordon authored
On a testimage build, the screen sharing permission dialog is automatically dismissed to allow Android CTS tests to record the screen. These tests do not expect to record the mouse cursor, so make sure it is automatically turned off at the same time. Bug: b:118833026 Test: CTS CtsViewTestCases passes on non-tablet devices Change-Id: I1633d270c01838e60b50a2370483452e829d1361 Reviewed-on: https://chromium-review.googlesource.com/c/1343358Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Cr-Commit-Position: refs/heads/master@{#609480}
-
Ovidio Henriquez authored
This change updates the GetAllGrantedObjects() method of UsbChooserContext to include the USB objects granted by the WebUsbAllowDevicesForUrls policy. The GetAllGrantedObjects() method removes user granted objects that are also granted permission by the policy. SiteSettingsHelper was modified to skip the policy objects until the UI is ready to display them. Design Doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I8442f588b0d7029062c67bbb2896cefeb558a887 Reviewed-on: https://chromium-review.googlesource.com/c/1297301 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#609479}
-
Xiaocheng Hu authored
CharacterIteratorTest.GetPositionWithEmitChar16Before used to fail with LayoutNG enabled, because it's actually a buggy case in legacy layout where TextIterator emits an extra character. This patch makes the test case skip the extra character when LayoutNG is enabled, and hence allows it to pass. Bug: 810579 Change-Id: Ie111735af3c94fe7b47eed7a993d1d374612caa6 Reviewed-on: https://chromium-review.googlesource.com/c/1340862Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609478}
-
Xianzhu Wang authored
This is a follow-up of https://chromium-review.googlesource.com/c/1258331 which rebaselined the test for non-SPv2. The rebaseline added focus ring in the expected png result. TBR=pdr@chromium.org Change-Id: Ied21d2512416d60d9dc1f856f7a60912c5337039 Reviewed-on: https://chromium-review.googlesource.com/c/1342999Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609477}
-
Toni Barzic authored
BUG=869574 Change-Id: I27bd06ee786ffaf5be22f237b37d716c3e97182d Reviewed-on: https://chromium-review.googlesource.com/c/1341239Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#609476}
-
Sunny Sachanandani authored
crrev.com/1318808 changed SwapChainPresenter to recreate video processor output view on every PresentToSwapChain in addition to lazy initializing the video device. A power regression was noticed on internal AVA bots around the same time. This is a speculative fix for the power regression by reverting to the old behavior of caching the output view. Bug: 894675 Change-Id: I4130129951d8b9d9efa9aaeee4ba78aa1ef3f778 Reviewed-on: https://chromium-review.googlesource.com/c/1341156 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Alexander Shah authored
Highlights frames queried during kMouseDown events in the asynchronous targeting path. https://screenshot.googleplex.com/4ioX6RouGkD https://drive.google.com/open?id=1IpyR6nKXG9H4s9_Zkko8QTzOB5RagkEZ R=riajiang@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ica3b0b77dde61aad465d36c3bdb20715cc206c65 Reviewed-on: https://chromium-review.googlesource.com/c/1286352 Commit-Queue: Alexander Shah <zandershah@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609474}
-
Esmael El-Moslimany authored
Pressing enter on Mac will open a rename folder dialog (F2 on other platforms). Bug: 854673 Change-Id: I659cfcedc42aec04c47f696df9c71edc7201ce0c Reviewed-on: https://chromium-review.googlesource.com/c/1341082 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
The EME spec has been updated to formalize the way to populate key statuses when key IDs are not available: Whenever a non-empty list is appropriate, such as when the key session represented by this object may contain key(s), populate the map with a single pair containing the one-byte key ID 0 and the MediaKeyStatus most appropriate for the aggregated status of this object. This CL updates the comments in MediaDrmBridge where we implementate this recommendataion to actually point to this part of the spec. Bug: 883895 Change-Id: Ic6a98dcaaaa7550230e9db361e9eb21f169f0644 Reviewed-on: https://chromium-review.googlesource.com/c/1342806Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609472}
-
