- 13 Nov, 2018 40 commits
-
-
Owen Min authored
These policies are encouraged to be set via cloud policy. Hide them from policy template and documentation. Change-Id: Ifb7c258daa4da6aeeccefbb61d11a0b68498507e Reviewed-on: https://chromium-review.googlesource.com/c/1332255Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607722}
-
Vasilii Sukhanov authored
This is exactly the same crash and fix as in https://chromium-review.googlesource.com/c/chromium/src/+/951002/ The fix is for 3 different crashes. - AutoSigninFirstRunDialogView::ControllerGone can trigger some accessibility events. The framework needs the title of the dialog. As a result the controller is dereferenced. - AutoSigninFirstRunDialogView::Accept and AutoSigninFirstRunDialogView::Cancel. On Mac those events may be triggered when the dialog already disappeared. Therefore, a NULL-check is required before pinging the controller. Bug: 904154 Change-Id: I58904340599227a5b06eb00a3d46f180bc2864a6 Reviewed-on: https://chromium-review.googlesource.com/c/1333659Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607721}
-
Jesse McKenna authored
Bug: 889029 Change-Id: I4fb7cf0011d067c24f26914009681563baf51d11 Reviewed-on: https://chromium-review.googlesource.com/c/1331949 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#607720}
-
Mike Wittman authored
This reverts commit ce0ec6fc. Reason for revert: While the perf regression may have been caused by the original CL, it was transient. Original change's description: > Partial revert of "Use preferred language in extension i18n" > > This is a logical revert of "Use preferred language in extension i18n" > (commit 693d01a6). Because of some > intervening changes causing more complicated merges, it's simpler to > just undo the side effects of the original change, leaving the changed > boilerplate intact. > > Reason for revert: Testing perf regression in crbug.com/898191 > > If this exonerates the original CL, we will revert this change. > Otherwise, we will clean up the boilerplate added for the original CL. > > Original change's description: > > Use preferred language in extension i18n > > > > When localizing an extension, prioritize the user's preferred language > > over the application locale. > > > > Normally, these are the same. In some cases, they differ. For example, > > the user may choose to display Chrome in "en-CA" (the intl.app_locale > > pref), but because we don't have translations for that, the actual > > UI locale is "en-GB". > > > > This CL makes extensions try to use the user's preferred locale for i18n > > ("en_CA"), falling back to the UI locale ("en_GB") if no locale > > directory is found for the preferred locale. > > > > This change also updates the "current_locale" manifest key to reflect > > the user's preferred locale, or the UI locale if intl.app_locale is > > unset. > > > > Note: Like the application locale, the preferred locale is only set at > > startup (and in certain situations in CrOS). If the user changes their > > intl.app_locale pref, they have to restart Chrome before extensions are > > re-localized, just like before. > > > > Bug: 874225 > > Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d > > Reviewed-on: https://chromium-review.googlesource.com/c/1244666 > > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600619} > > Bug: 898191 > Change-Id: Iaddceb16d61ffc5572a25ed31276443ea5b5baa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1308765 > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604819} TBR=lazyboy@chromium.org,michaelpg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 898191 Change-Id: Iead107f46039f01b5d5b97b36d1b8fb242f0aee3 Reviewed-on: https://chromium-review.googlesource.com/c/1334194Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607719}
-
Sergio Villar Senin authored
Partially migrates authentication_service_unitttest.mm to IdentityManager. In particular it does no longer observ OAuth2TokenService::Observer but IdentityManager::Observer. Apart from that a IdentityTestEnvironment was created to wrap all the testing factories used by the test. The IdentityManager returned by that object is then used to completely replace the calls to the SigninManager object. Bug: 890821 Change-Id: I0a04a4e8e605546a96606ecb9a3a2338e9060257 Reviewed-on: https://chromium-review.googlesource.com/c/1323552 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#607718}
-
Danyao Wang authored
This allows the slim nav bots to be added to the main waterfall. Bug: 807428 Change-Id: Ia5caca43734158f88c2292222a2cbcd70049bb75 Reviewed-on: https://chromium-review.googlesource.com/c/1334191 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607717}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78869faa9193..c14a383e61b4 git log 78869faa9193..c14a383e61b4 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 pasko@chromium.org androidStartupMetric: skip FCP events when startup is missing Created with: gclient setdep -r src/third_party/catapult@c14a383e61b4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900878 TBR=sullivan@chromium.org Change-Id: I521c24016a609b53682ae7ccc8b8e26e54f40f24 Reviewed-on: https://chromium-review.googlesource.com/c/1333863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607716}
-
Victor Vasiliev authored
R=bnc@chromium.org Change-Id: I37dddebc128654dc417ec7fbbcebe5679b3d9294 Reviewed-on: https://chromium-review.googlesource.com/c/1333139Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#607715}
-
gogerald authored
Bug: 806868 Change-Id: If15e7d8c188179b29347645fde3f4fe7b0cbf7d5 Reviewed-on: https://chromium-review.googlesource.com/c/1331140 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607714}
-
Peter Kasting authored
These passed 50 times in a row on Windows. This converts from watching NOTIFICATION_NAV_ENTRY_COMMIT to using a navigation observer in hopes of fixing observed flakiness in EnterToSearch. Bug: 69433, 133341, 133344, 133347, 133355, 133360, 146953, 408634, 431575, 751031, 751543, 823532, 841195 Change-Id: Ia8ce63c8a9aca1ea415fb99756b08409cbc8369c Reviewed-on: https://chromium-review.googlesource.com/c/1332257 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#607713}
-
Steven Valdez authored
Change-Id: I88932442b714820944b4608e106eaf47536bf00d Reviewed-on: https://chromium-review.googlesource.com/c/1329344 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#607712}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: I85c5d0efcdf3c954d7756d2ca2952c06c56dd509 Reviewed-on: https://chromium-review.googlesource.com/c/1333899 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607711}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44ca9a392ac6..c7e3af1ad928 git log 44ca9a392ac6..c7e3af1ad928 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 terelius@webrtc.org Remove rtc_event_log2stats. 2018-11-13 jonasolsson@webrtc.org Introduce DLOG to video and voiceengine. 2018-11-13 tomas.popela@gmail.com Reland "Add support for screen sharing with PipeWire on Wayland" 2018-11-13 alessiob@webrtc.org AGC2: adding level estimation option (RMS or peak-based). Created with: gclient setdep -r src/third_party/webrtc@c7e3af1ad928 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id5a0ea4e3980c70d91601c64b8f68a43b7469927 Reviewed-on: https://chromium-review.googlesource.com/c/1333860Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607710}
-
manuk authored
[Omnibox] Avoid removing the `www.` prefix during deduping when doing so would leave no host component. When sorting and deduping matches, match GURLs are stripped (`AutocompleteMatch::GURLToStrippedGURL`). Certain omnibox inputs, such as `http://www.` without inline autocomplete, produce matches with host compoments `www.`. Stripping `www.` in these cases would result in an empty url host component and, therefore, invalid `GURL`. Invoking `GURL::spec` on such invalid URLs would then cause a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds. Bug: 898554 Change-Id: I73461c65ba53891d6f3b52bc767c754b02c1ce3e Reviewed-on: https://chromium-review.googlesource.com/c/1331631 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607709}
-
Steve Anton authored
Bug: 874296 Change-Id: I1786acb3b64fa0450e76fe27300c178081d1e191 Reviewed-on: https://chromium-review.googlesource.com/c/1285528 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607708}
-
Anne Lim authored
Renamed strike_database.h/cc to legacy_strike_database.h/cc and strike_database_unittest.cc to legacy_strike_database_unittest.cc. This is so that the files for the new version of StrikeDatabase can take the old name. Bug: 884817 Change-Id: Id4d1496b792d93f7e38afdab1ddad0419ec27f10 Reviewed-on: https://chromium-review.googlesource.com/c/1330724Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#607707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52c961afab61..b822560337a6 Created with: gclient setdep -r src-internal@b822560337a6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie7f2520d9b91994c276613c5223ffd94cc4cb9e6 Reviewed-on: https://chromium-review.googlesource.com/c/1333859Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607706}
-
Justin Cohen authored
Remove the NTP and show the web view more quickly. WKWebView appears to run more slowly in certain circumstances when it is obscured by another view. Change-Id: I769d9e5602a0b19a0032d5bca2fc6c6d85f3d365 Reviewed-on: https://chromium-review.googlesource.com/c/1333873 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607705}
-
Ted Choc authored
This moves the bulk of the key handling into the view classes themselves and not the coordinator. BUG=898522 Change-Id: Ie2b517eca6d7ae9e27bc12a020880bc668897b56 Reviewed-on: https://chromium-review.googlesource.com/c/1331689Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607704}
-
danakj authored
R=chrishtr@chromium.org, piman@chromium.org, sky@chromium.org Change-Id: I851b632e4b09f1fd9f87229c69c7f6aff30b0ead Bug: 738465 Reviewed-on: https://chromium-review.googlesource.com/c/1330332Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#607703}
-
Antoine Labour authored
GpuProcessHost::ReportProcessCrash incorrectly early-outs in case of process launch failure, and fails to trigger fallback, causing a retry loop. Instead, correctly track if DidFailInitialize happened (which caused a fallback) and only early-out in that case. Bug: 876921 Change-Id: I561de5d73ce8afddf920fa3ff141524bd5797733 Reviewed-on: https://chromium-review.googlesource.com/c/1333129Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607702}
-
Mario Sanchez Prada authored
Remove the custom C++ class IdentityManagerObserver and rely on the new API from //services/identity/public/objc instead. Bug: 903262 Change-Id: I32c3d46bbd6c1cd45c092c859ef303d9cd6b240f Reviewed-on: https://chromium-review.googlesource.com/c/1326151 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607701}
-
Hao Zhang authored
Bug: 899057 Change-Id: I9a79e9a280ec0a937b44afd319f0dc3e516aef0f Reviewed-on: https://chromium-review.googlesource.com/c/1321471 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#607700}
-
Elly Fong-Jones authored
This change: 1) Has MenuController consider command to be an accelerator key, along with control and alt, for the purpose of not searching for mnemonics; 2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing which tells the menu to close for an accelerator Bug: 885138 Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a Reviewed-on: https://chromium-review.googlesource.com/c/1334147Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607699}
-
Yi Su authored
The new feature Custom Search Engine is ready on Chrome iOS right now. This CL adds a new metric to record when users change their default search engines on iOS. This metric will help us understand how iOS users use this new feature, and types of their selected default search engine. Bug: 433824 Change-Id: I4796dee43f177b20a4c69e832b82d9e429060f26 Reviewed-on: https://chromium-review.googlesource.com/c/1331468Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607698}
-
Brian Osman authored
Going to remove this, but I need to rebaseline some layout tests, so I have to temporarily move it from Skia's skia_for_chromium_defines to this location. Change-Id: I071e5d8536fb5ac8baa78e3eac3974ee4d9445d4 Reviewed-on: https://chromium-review.googlesource.com/c/1334091Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#607697}
-
jdoerrie authored
This change renames the already existing feature flag from kManagePasswordsAlternativeUIAndroid to kGooglePasswordManager to better reflect that the flag is platform agnostic. Bug: 904821 Change-Id: I5c7f0e529de53230578b0a25115b6d3428bbf940 Reviewed-on: https://chromium-review.googlesource.com/c/1333651Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#607696}
-
Erik Chen authored
Historically, we've disallowed toolchain/OS version mismatches to fallback on local toolchain. This prevents bots from silently succeeding [but building with the wrong toolchain]. Since the hermetic toolchain currently does not run on the latest OS version, this check is also affecting all developers, which we'd like to avoid. This CL temporarily disables the check. Bug: 904400 Change-Id: I4a3edc1218b50017a1dba96b54088986f48a6862 Reviewed-on: https://chromium-review.googlesource.com/c/1333877Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#607695}
-
Alexei Filippov authored
BUG=901165 Change-Id: Icbdb38619e2ee76d9fa17621718a7613cf72554c Reviewed-on: https://chromium-review.googlesource.com/c/1330716 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607694}
-
Chris Mumford authored
When clearing ChunkedDataPipeUploadDataStream::buf_ also set ChunkedDataPipeUploadDataStream::buf_len_ to zero as it signifies the length of buf_ which is now gone. Bug: None Change-Id: I470b46fcb5cd0615e1841780e3c9744763c85265 Reviewed-on: https://chromium-review.googlesource.com/c/1333657Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#607693}
-
Nikunj Bhagat authored
Bug: 904459 Change-Id: I3ab7093cb1d7eab93e5db8bc1ca6b7fa7d6ebcef Reviewed-on: https://chromium-review.googlesource.com/c/1331629 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607692}
-
Charlie Harrison authored
Currently, these are created with bare `new`, until they are threaded into the ContentSettingBubbleContents, where they are wrapped into a unique_ptr. This CL removes the bare new creation, so ownership passing is explicit. Bug: None Change-Id: Ieaecab0ecaa49ae0d732acb27615b6b2e328e167 Reviewed-on: https://chromium-review.googlesource.com/c/1333871Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#607691}
-
Steven Bennetts authored
This also introduces keyboard.mojom.ContainerType, replacing keyboard::ContainerType. BUG=876138 Change-Id: Ib09d9bfa6037b60381054dad8b68288dc73b832b Reviewed-on: https://chromium-review.googlesource.com/c/1330328 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#607690}
-
Ahmed Fakhry authored
This reverts commit 605cb278. Reason for revert: causes a crash immediately on initialization on ChromeOS Linux build: [85464:85464:1113/105356.761188:FATAL:shell.cc(281)] Check failed: instance_. #0 0x7f6445c3668f base::debug::StackTrace::StackTrace() #1 0x7f6445b6624b logging::LogMessage::~LogMessage() #2 0x7f643f32b5c2 ash::Shell::Get() #3 0x561d123191ba ChromeBrowserMainExtraPartsAsh::PreProfileInit() #4 0x561d10f06f2a ChromeBrowserMainParts::PreProfileInit() #5 0x561d10f07c8e ChromeBrowserMainPartsLinux::PreProfileInit() #6 0x561d1089bc26 chromeos::ChromeBrowserMainPartsChromeos::PreProfileInit() #7 0x561d10f05fee ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x561d10f05925 ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x561d1089b755 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f64434b766a content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f64439b1055 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f64434b6191 content::BrowserMainLoop::CreateStartupTasks() #13 0x7f64434b9d30 content::BrowserMainRunnerImpl::Initialize() #14 0x7f64434b3d62 content::BrowserMain() #15 0x7f6443fed756 content::ContentMainRunnerImpl::Run() #16 0x7f6434c3ff46 service_manager::Main() #17 0x7f6443feba44 content::ContentMain() #18 0x561d10094e63 ChromeMain #19 0x7f64352042b1 __libc_start_main #20 0x561d10094cda _start Original change's description: > ui_devtools: Encapsulate views server init; use Shell Env for Chrome OS. > > Use the ash::Shell aura::Env in single-process mash ui_devtools. > Keep a TODO for initializing ui_devtools in Ash for multi-process Mash. > Encapsulate server init, and the switch and port definitions. > > Bug: 896977 > Test: ui_devtools works well on Chrome OS single-process Mash. > Change-Id: I3cc285d5f8ee465d45795a3521e7e4eafa354414 > Reviewed-on: https://chromium-review.googlesource.com/c/1324373 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607408} TBR=sadrul@chromium.org,msw@chromium.org Change-Id: Iae50c4a7d67de9602596b0522da3fec0f472e092 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896977 Reviewed-on: https://chromium-review.googlesource.com/c/1334001Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0864a7ac638c..f9143725470b git log 0864a7ac638c..f9143725470b --date=short --no-merges --format='%ad %ae %s' 2018-11-13 geofflang@chromium.org Only use CompositorNativeWindow11 when the window is non-null. 2018-11-13 ynovikov@chromium.org Vulkan: refactor WrappedObject descendants Created with: gclient setdep -r src/third_party/angle@f9143725470b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9237b7e197941a754f000be7c84c71381815c4a1 Reviewed-on: https://chromium-review.googlesource.com/c/1333861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607688}
-
Lei Zhang authored
In chrome/ and chromeos/. These TearDown() overrides are pointless. Change-Id: I0e9c6d2a346bc40ecf45e30a8bac0914a987e3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1330913Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#607687}
-
Dominic Mazzoni authored
Change-Id: I77e9b4332bd9f67e04e65e2afca895314b278498 Reviewed-on: https://chromium-review.googlesource.com/c/1314140 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607686}
-
Elly Fong-Jones authored
This test uses NSButton as its dummy class for some test cases, but there is now a 10.14-specific behavior in ViewTreeValidator to ignore children of buttons because of the linked bug, which causes this test to fail on 10.14. Bug: 892176 Change-Id: I35bac3065ed1b2ded9466e63b6c27cd804b7180c Reviewed-on: https://chromium-review.googlesource.com/c/1333140 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607685}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: I605b7ff0aee6ec52254af8871efc7308f79d647a Reviewed-on: https://chromium-review.googlesource.com/c/1334098Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#607684}
-
Chris Harrelson authored
The foreground layer paints normal-flow and positive z-index non-composited children in the presence of a composited negative-z-index-child. In these cases, we should not consider the normal-flow or positive z-index non-composited children as contributing to opaqueness of the main graphics layer, since they paint elsewhere. Bug: 892137 Change-Id: I7bd6a4eab615881e4ec3931049f292b046202430 Reviewed-on: https://chromium-review.googlesource.com/c/1332699Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607683}
-