GitLab

This change further changes direct calls to Time::Now or the default
base::Clock instance to an OfflineClock module within classes which
need a Clock pointer to be passed into the class. This eliminates the
need for testing-only functions and further allows ease of testing.
This change is specific to production files and their related tests in:

chrome/browser/android/explore_sites/
components/offline_pages/core/model/

Bug: 906903
Change-Id: I02b84f65b77dc395310995c34ded41d92721aaeb
Reviewed-on: https://chromium-review.googlesource.com/c/1352813Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614797}

Original change's description:
> Revert "Share one GLContext for all RasterDecoder when virtual context is used."
>
> This reverts commit 1808a743.
>
> Reason for revert: Null-dereference READ in gpu::gles2::ContextState::api
> https://crbug.com/912981
>
> Original change's description:
> > Share one GLContext for all RasterDecoder when virtual context is used.
> >
> > With this CL, we will create a GLContextVirtual in RasterDecoderContextState,
> > and share it with all raster decoders, display compositoer, etc. It is a
> > temporary solution. In follow up CLs, we will share the one GLContext with
> > GLES2 as well. In that case, we will use GLContext directly instead of
> > GLContextVirtual.
> >
> > Change-Id: If9b8d1f32e58b32a9d9f8cd07aa10c30432e3183
> > Bug: 902904
> > Reviewed-on: https://chromium-review.googlesource.com/c/1357463
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#614694}
>
> TBR=penghuang@chromium.org,piman@chromium.org
>
> Change-Id: I2eb66f211d408988f30bfb870425da80e0eb7a4b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 902904
> Reviewed-on: https://chromium-review.googlesource.com/c/1368284
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614738}

TBR=penghuang@chromium.org,piman@chromium.org

Change-Id: Ie409d5d631509efa978a8741381cedbbbcdb3904
Bug: 902904
Reviewed-on: https://chromium-review.googlesource.com/c/1368031Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614796}

https://webrtc.googlesource.com/src.git/+log/10b051083c0d..4348ce240aae


git log 10b051083c0d..4348ce240aae --date=short --no-merges --format='%ad %ae %s'
2018-12-07 ilnik@webrtc.org Calculate min and max receive timestamps for packets in a video frame
2018-12-07 nisse@webrtc.org Convert all webrtc code to not access EncodedImage::_size directly.
2018-12-07 artit@webrtc.org Replace luci-go dependency to CIPD package


Created with:
  gclient setdep -r src/third_party/webrtc@4348ce240aae

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:851596
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I30370412edd578d87e1a5c88dacb976e648bcf4a
Reviewed-on: https://chromium-review.googlesource.com/c/1367968Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614795}

Bug: 869643
Change-Id: I85cfff694f3ce43d822c0126906e9266b3c39e9c
Reviewed-on: https://chromium-review.googlesource.com/c/1363838
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614794}

Bug: 913037
Change-Id: I2086df02bc0323c0a4b10cf3f24b628e62e28e39
Reviewed-on: https://chromium-review.googlesource.com/c/1368405Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614793}

- Renames InfobarCoordinator to InfobarContainerCoordinator to better match
its functionality.
- Renames InfobarContainerVC to LegacyInfobarContainerVC to support the
new Infobar design later on.

Bug: 911864
Change-Id: I111747f48c1cbca8ca3f4bc8a174952edf841d21
Reviewed-on: https://chromium-review.googlesource.com/c/1362467Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614792}

fast/repaint was the old directory before we moved all tests from it
to paint/invalidation.

Move one test left (fast/repaint/sub-frame-svg-background.html) into
paint/invalidation.

Remove extra baselines.

Change-Id: Ifb00ec3488d0baf81e73c756c2e89d2af9116200
Reviewed-on: https://chromium-review.googlesource.com/c/1368111
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614791}

When the NTP was open and an article fetch completed, it would cause
the list of articles to flicker and be completely replaced. This change
removes the flicker, and only articles below the edge of the screen are
replaced.

Bug: 911489
Change-Id: Id87b221e142533a0bf448a0efe2cdcdf43209dc0
Reviewed-on: https://chromium-review.googlesource.com/c/1363959
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614790}

to ensure we don't regress --disable-blink-features=BlinkGenPropertyTrees
badly when experimenting BGPT.

Bug: 836884
Change-Id: Ie857f69e90bae243b55993fac58d04c478cb3b48
Reviewed-on: https://chromium-review.googlesource.com/c/1368144
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614789}

This reverts commit 8b38b5d3.

Reason for revert: Root cause fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1367926, workaround
no longer necessary.

Original change's description:
> Add XR instrumentation web content workaround
> 
> Adds a workaround for https://crbug.com/908917 into the XR
> instrumentation test setup since attempts to work around the issue in
> the test runner haven't been completely successful. This workaround
> performs a swipe which should be a no-op when running a RenderTest,
> which seems to prevent the flakiness when doing pixel diffs.
> 
> Bug: 908917
> Change-Id: I38bf8fb5abe1c0a2bf19e044dd9237919ec2b019
> Reviewed-on: https://chromium-review.googlesource.com/c/1362293
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614250}

TBR=bsheedy@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 908917
Change-Id: Ie8ca239a9199cf805fb4f4d3257c1b142b3250d7
Reviewed-on: https://chromium-review.googlesource.com/c/1368037Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614788}

Use-after-free was happening at shutdown due to
MediaRouterDialogControllerViews getting destroyed without unregistering
itself. We make MRDCV retain a pointer to the dialog widget to make sure
it unregisters itself, because GetCurrentDialogWidget() may become null
before the actual widget is destroyed. Also do all of the cleanup in
OnWidgetClosing() instead of splitting with OnWidgetDestroying().

Bug: 905498
Change-Id: Idf9da7aaf33cd9db512681b688ebd95d0fae08ca
Reviewed-on: https://chromium-review.googlesource.com/c/1364295Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614787}

This reverts commit c8e53d0f.

Reason for revert: This breaks non-Android platforms.

VK_KHR_GET_MEMORY_REQUIREMENTS_2_EXTENSION_NAME is requested on Android only, yet a dependency on it is added to vulkan_function_pointers.cc on all platforms.

Original change's description:
> Import AHardwareBuffer into a Vulkan Image.
> 
> Added a utility function to create a vulkan image and import AHardwareBuffer
> created outside of vulkan device into a vulkan image.
> 
> Bug: 891060
> Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
> Reviewed-on: https://chromium-review.googlesource.com/c/1357658
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614518}

TBR=piman@chromium.org,ericrk@chromium.org,vikassoni@chromium.org

Change-Id: I11c1d39a43438699d72a93212eedef1d4230518a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891060
Reviewed-on: https://chromium-review.googlesource.com/c/1368406Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614786}

- Adding DCHECK to make sure CanAccessDataForOrigin() is only called
  on the UI or IO thread. This is needed for future CLs that will need
  to use information in the BrowserContext or ResourceContext to
  determine if data access is allowed.
- Fix existing code that was calling CanAccessDataForOrigin() on
  worker threads so that it doesn't trigger the new DCHECK.

Bug: 898281
Change-Id: I03ab137dad3fcec5c7c2152855816156489f91c0
Reviewed-on: https://chromium-review.googlesource.com/c/1359463
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614785}

This CL is changing the kind of observer used by the sampling profiler
wrapper class. The proposed implementation is to use the sync version
which is fixing early startup tracing/sampling.

The previous code was using a Async observer to keep the class
thread-safe. Unfortunately, the sampling profiler is not able to start
early enough on startup. The hooks are at the right place.

The reason why it's not working on startup is because the tasks queue is
already loaded of startup tasks to be executed on the main thread.
Thus, after activating tracing, there is a long gab between the point
where the tigger occurs and when the sampling profiler got created and
start to collect samples (e.g. OnTraceLogEnabled).

To avoid this delay, we prefer using a Sync observer. That forces the class
to be thread-safe.

R=oysteine@chromium.org
CC=​ssid@chromium.org, wittman@chromium.org

Change-Id: I02a1deb2f8aa705ccbf5fb6e7026f4588ca1b319
Reviewed-on: https://chromium-review.googlesource.com/c/1359293Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614784}

On O+, Android draws a translucent grey overlay over focused views when
the device is not in touch mode (as in, the user is using keyboard to
navigate rather than touch/mouse). Drawing this overlay over the entire
ContentView doesn't make sense, so we should just disable it.
We also have to disable it for the CompositorViewHolder, or when we
go between NativePages (like NTP) and WebContents, we animate into and
out of the grey overlay, because the CompositorViewHolder briefly
gains focus.

Bug: 912724, 908917
Change-Id: I97b7f688f06581e872898028a48e6e7b4546d710
Reviewed-on: https://chromium-review.googlesource.com/c/1367926Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614783}

This CL adds the missing metric combination as well as factoring out to
make metrics gathering code shareable with the google apps module.

Bug: 874154
Change-Id: Iba2a10264630185b5de236b58cee7b204f2f3054
Reviewed-on: https://chromium-review.googlesource.com/c/1344998
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614782}

They have:

A: http://schemas.android.com/apk/res/android:minSdkVersion(0x0101020c)=(type 0x10)0x18 (Raw: "24")

Rather than just:

A: http://schemas.android.com/apk/res/android:minSdkVersion(0x0101020c)=(type 0x10)0x18
Change-Id: Ib397ff275a58e7d0595be8d1611c99e4421b6364
Reviewed-on: https://chromium-review.googlesource.com/c/1367112Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614781}

This prevents hitting the dex method count limit.

TBR=yfriedman@chromium.org

Change-Id: I0c53dae4cf7244d55976f42e58ce4de4ff891855
Reviewed-on: https://chromium-review.googlesource.com/c/1368033Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614780}

IOSChromeLocalSessionEventRouter will observe multiple WebState objects
without using deprecated GlobalWebStateObserver.

Also removed browser state check in OnWebStateChange. This check was needed
because each WSO callback was called for both BrowserState objects. So the
router had to check if the call belongs to correct browser state. After this
CL there are no extra calls, hence no need for check.

Bug: 910894, 782269, 720786
Change-Id: Ie25ae62efea9edd4a981800d1a43b6ef28b35b14
Reviewed-on: https://chromium-review.googlesource.com/c/1359863
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614779}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7c38fee64ace..de797ddcb5d0


git log 7c38fee64ace..de797ddcb5d0 --date=short --no-merges --format='%ad %ae %s'
2018-12-07 ale64bit@users.noreply.github.com Check that certain decorations cannot be used more than once and/or are mutually exclusive (#2171)
2018-12-07 afdx@google.com Replace loop with selection (#2164)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@de797ddcb5d0

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I4fd77a288a5c3b6f50bc0d334f2d1f91d4179f37
Reviewed-on: https://chromium-review.googlesource.com/c/1368206Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614778}

This CL adds SigninHelper.resetSharedPrefs call to
OAuth2TokenServiceIntegrationTest.tearDown method.
OAuth2TokenServiceIntegrationTest has been causing many test failures in
different tests because of the state it has been leaving in shared
preferences.

Bug: 908542
Change-Id: I10df9d0ab1d268c7da3352ca87ae07659bfa55d2
Reviewed-on: https://chromium-review.googlesource.com/c/1368147Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614777}

Also adds ability for test to supply a mock NavigationController to
FakeFrame instances.

Bug: 893229
Change-Id: I63ddffcd4a13b49b9e67232161255bd72a11a0cb
Reviewed-on: https://chromium-review.googlesource.com/c/1334561Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614776}

This was used for testing the lock screen apps apis before note taking
app supported lock screen. It should not be needed anymore given that
the actual note taking app can be used for testing.

Change-Id: I3c678018bfb4e1dacb537fb7e3c58dcad2a4b92c
Reviewed-on: https://chromium-review.googlesource.com/c/1347770Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614775}

This change adds support for testing the presence of Chrome Password Manager's save fallback. The validation function checks if Chrome is showing the save fallback, and waits up to 5 seconds for Chrome to show the save fallback.

Bug: 847905
Change-Id: I1a55a170c89ff0384c647d8e7646de256f4f15d8
Reviewed-on: https://chromium-review.googlesource.com/c/1334552Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Cr-Commit-Position: refs/heads/master@{#614774}

When the lock screen is shown, the existing system Clipboard is replaced
with an empty version. Once the lock screen is destroyed, the old
Clipboard state is restored.

Bug: 902516
Change-Id: Ifc5b3cee992abd701fe1c80349f8d8ec84f91546
Reviewed-on: https://chromium-review.googlesource.com/c/1354332Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614773}

Change-Id: I06250421bf2ba402795eb171aa25860f45601db2
Reviewed-on: https://chromium-review.googlesource.com/c/1366780
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614772}

Extend V4L2Device::PreferredInputFormat() by adding |single_planar| arg
so that it can also return single-planar preferred input format.

BUG=b:73752373
TEST=pass VEA test

Change-Id: Iaabdf3d7a2239bbd4043c000193e52207fab8e10
Reviewed-on: https://chromium-review.googlesource.com/c/1361742
Commit-Queue: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614771}

Bug: 701825
Change-Id: Ib4e789ec1237782d9a6a65da6c24dac02713095b
Reviewed-on: https://chromium-review.googlesource.com/c/1367870
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614770}

The leak detector bot is more flaky on virtual/android/fullscreen tests
for unknown reasons (see: https://crbug.com/769885). With BGPT,
virtual/android/fullscreen/video-scrolled-iframe.html recently got more
flaky, though it flaked before BGPT was enabled too.

This patch marks virtual/android/fullscreen/video-scrolled-iframe.html
as skipped due to 2px of flakiness.

Bug: 912979, 769885
Change-Id: I941413dcd52b36401703ffdf85f52114aa7600aa
Reviewed-on: https://chromium-review.googlesource.com/c/1368107Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614769}

https://android.googlesource.com/platform/external/perfetto.git/+log/3dde0186457b..2e480713da7d


git log 3dde0186457b..2e480713da7d --date=short --no-merges --format='%ad %ae %s'
2018-12-07 fmayer@google.com Changes needed to run on OSS-Fuzz.


Created with:
  gclient setdep -r src/third_party/perfetto@2e480713da7d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:69150303
TBR=perfetto-bugs@google.com

Change-Id: Iee2cd94c09707ae7f19eb34433fe9f001581e24c
Reviewed-on: https://chromium-review.googlesource.com/c/1367867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614768}

Culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1361598

Bug: 912772
Tbr: danakj@chromium.org
Change-Id: I6262ca1623dc23e6004131fd60c86c62b13c593f
Reviewed-on: https://chromium-review.googlesource.com/c/1367928
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614767}

Without this flag, I get the error:

Stdout: BigQuery error in query operation: Cannot start a job without a project id.
Change-Id: I2480e312dc8934fa8d3f4de215bbb8803a98f6cc
Reviewed-on: https://chromium-review.googlesource.com/c/1366937Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614766}

Introduced OfflinerClient
- Moves handling of the watchdog timer into a smaller class, so it easier to
  reason about.
- Consolidates return paths of offliner -- cancellation now results in a
  completion callback.

Reorganized offliner completion handling in RequestCoordinator. Hopefully
making it easier to follow. Using switch instead if if/then so that enum values
added later are sure to be considered.

To go further, code to stop processing was simplified. StopOfflining() was
removed, and replaced with calls to StopProcessing(). How to continue after
processing stops is entirely determined by the RequestStatus of the stopped
request.

PauseRequests() and RemoveRequests() were changed to wait until the items are
updated before cancelling the in-flight request if it happens to match. This
was done to simplify the code: execution is more sequential, and we can now
depend on StopProcessing to continue request processing if appropriate. Also
this prevents a potential bug, where RemoveRequests() calls TryNextRequest while
the offliner is still in the middle of cancellation.

StopProcessing() is now private. Added CancelProcessing() to make it clear which
statuses callers can inject.


Bug: 906651
Change-Id: I89f3705e6bcfbc18599041b4ce2fb8add1b220af
Reviewed-on: https://chromium-review.googlesource.com/c/1361633Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#614765}

https://skia.googlesource.com/skia.git/+log/7a3805c348c3..a63593a10c1b


git log 7a3805c348c3..a63593a10c1b --date=short --no-merges --format='%ad %ae %s'
2018-12-07 brianosman@google.com Remove sample shading and dest color override


Created with:
  gclient setdep -r src/third_party/skia@a63593a10c1b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I67d0db329a251d3c1ada1bc12a84edb1a75aaf6f
Reviewed-on: https://chromium-review.googlesource.com/c/1367966Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614764}

The chromeos_* unit test suites are designed to run on Linux, not on
real hardware or in VMs. On the Chromium waterfall they are built
with the linux-chromeos configuration.

Developers using the "cros chrome-sdk" sometimes think they need to
build these targets and run them, either on their host workstation
or on device. The tests aren't expected to work in these environments,
so prevent them from being built.

Bug: 909073, 865693
Test: ninja -C out_eve/Release chromeos_unittests won't compile
Change-Id: Idf8c366f7001ea5bbc744ccba6e627d70f5efebb
Reviewed-on: https://chromium-review.googlesource.com/c/1358509
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614763}

To reduce GetDocument() usage.
As https://github.com/w3c/webappsec-csp/issues/146 has already been
closed and the Blink implemetation has been changed,
this UseCounter is no longer needed.

Bug: 878274
Change-Id: Icb55058d369b29992436229a9b971bc6f0b8f2a6
Reviewed-on: https://chromium-review.googlesource.com/c/1192303Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614762}

We can significantly speed up WebP rendering and reduce memory footprint
per image by decoding and storing lossy WebP images into their native
YUV format instead of unnecessarily converting to RGB.

This flag will be used to safely hide changes to the image decoding
paths until the feature is completely landed.

See bit.ly/webp-decoding-into-yuv for the design document and
crrev.com/c/1338461 for a working prototype CL in the GPU rasterization case.

Bug: 900264
Change-Id: I611d17199cae4724332d73a5606f20d4eedf9010
Reviewed-on: https://chromium-review.googlesource.com/c/1366858
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614761}

https://dawn.googlesource.com/dawn.git/+log/6f0e1f9d8235..67737f1d4a6c


git log 6f0e1f9d8235..67737f1d4a6c --date=short --no-merges --format='%ad %ae %s'
2018-12-07 cwallez@chromium.org WireServer: Don't allow freeing the Device
2018-12-07 cwallez@chromium.org WireServer: on destruction, free all objects.


Created with:
  gclient setdep -r src/third_party/dawn@67737f1d4a6c

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:907278,chromium:911155
TBR=cwallez@chromium.org

Change-Id: I5bd2d58ab3b7c21546f6cd52baa9f60eda9bba87
Reviewed-on: https://chromium-review.googlesource.com/c/1368204Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614760}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/6ad3fcddaf2b..59345cdef38c

$ git log 6ad3fcdda..59345cdef --date=short --no-merges --format='%ad %ae %s'
2018-12-06 ariza [CFF] Refix oss-fuzz 11714: set_blends (PR #1458) (#1460)
2018-12-06 behdad Fix likely check
2018-12-06 behdad Add default value to first argument of sub_array()
2018-12-06 behdad Add sub_array to hb_vector_t
2018-12-06 behdad Add default-value for second arg of sub_array()

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Change-Id: I43da06c24f22509b8ad010191c630e833a15a235
Reviewed-on: https://chromium-review.googlesource.com/c/1368044
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614759}

Bug: 912320
Change-Id: I2f6367902a43a211459442897ec277effd8fc402
Reviewed-on: https://chromium-review.googlesource.com/c/1368032
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614758}