- 28 Jun, 2018 40 commits
-
-
Fady Samuel authored
Android use cases do not need to worry about OnRenderFrameMetadataChangedAfterActivation notifications because changes either do not require synchronization or are synchronized directly via surface synchronization. This CL saves a few IPCs and should improve scrolling performance on Android when surface synchronization is enabled. Bug: 672962 Change-Id: I3fe26c56dde75394677ee2dee53f50f79e99f8f9 Reviewed-on: https://chromium-review.googlesource.com/1117198 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571003}
-
Alan Cutter authored
This CL enables users to tab to the hosted app menu button in hosted app windows from the web contents. The related browser test has been updated with secure site navigation to add coverage for PWA hosted app windows. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=345540&signed_aid=5deNZnjPxp-be66iybEtaw==&inline=1 Bug: 839180 Change-Id: Ibf4b4dab6bd6b4c5d721a9a2200477a56e4644a7 Reviewed-on: https://chromium-review.googlesource.com/1114401 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#571002}
-
John Rummell authored
If the U and V data is interleaved in the buffer, then the last row of data doesn't require a full stride. So only count RowBytes() for the last row when computing where the end of the data is. BUG=829443 TEST=new media_mojo_unittest passes Change-Id: I186e4dd9d2045f34897bbf2c1d71e04421e199b7 Reviewed-on: https://chromium-review.googlesource.com/1114335 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571001}
-
Yuly Novikov authored
conformance/textures/misc/tex-video-using-tex-unit-non-zero.html on Nexus 6P TBR=kbr@chromium.org Bug: 830901 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I46e417c564fe810d70fa7fa8b3614c6e8d16fa89 Reviewed-on: https://chromium-review.googlesource.com/1117316Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571000}
-
Andrew Grieve authored
Noticed this from: https://chromium-swarm.appspot.com/task?id=3e5bfa5ea894bf10&refresh=10&show_raw=1&wide_logs=true Post stating it's win32 only: https://github.com/python/mypy/issues/3872 Bug: 733612 Change-Id: I7bd8fc20e4793a225e093450ba902ae525af8ac9 Reviewed-on: https://chromium-review.googlesource.com/1117858Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570999}
-
Yoichi Osato authored
This patch stops painting selection on ellipsis like legacy implementation. This patch fixes: fast/css/text-overflow-ellipsis-vertical-select.html Rebases are image updates for that. Notes: FireFox and Edge don't paint it either. WebKit paints them when any truncated text were selected. No one (including NG) seems to have implemented the spec behavior: https://www.w3.org/TR/css-ui-4/#ellipsis-interaction > Selecting the ellipsis should select the ellipsed text. > If all of the ellipsed text is selected, UAs should show selection of the ellipsis. > Behavior of partially-selected ellipsed text is up to the UA. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4a9c3bc1904b762acefadaf6a90b511de4004078 Reviewed-on: https://chromium-review.googlesource.com/1116401 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570998}
-
Dominic Farolino authored
This CL removes our RequestInit implementation and replaces it with one the IDL compiler generates. R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 836873 Change-Id: I29c55be8756deb5053cec04a5f82677d48413533 Reviewed-on: https://chromium-review.googlesource.com/1116418Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#570997}
-
Tetsui Ohkubo authored
Recently, UnifiedSystemTray replaced SystemTray class. WebUILoginView ignored UnifiedSystemTray because I misunderstood views login will completely replace WebUILoginView. However, WebUILoginView is still used in OOBE screen, so we should fix it to also work with UnifiedSystemTray. TEST=manual BUG=853713 Change-Id: I3842eba971a928af5ba1599283c52f9711d83cc4 Reviewed-on: https://chromium-review.googlesource.com/1107520 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#570996}
-
Jay Civelli authored
Ensure we recreate the SharedURLLoaderFactory used by StoragePartition whenever SetGetURLLoaderFactoryForBrowserProcessCallbackForTesting() is called. This makes the URLLoaderInterceptor work properly with the SharedURLLoaderFactory returned by StoragePartition::GetURLLoaderFactoryForBrowserProcess(). Bug: 857250 Change-Id: Id913ba93322dc62c2c03d8acd4c31b53fc8d436e Reviewed-on: https://chromium-review.googlesource.com/1117822 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570995}
-
Kyle Milka authored
When a custom background is set the theme is considered both "default" and "dark" so the most visited notifications had their text-color set to white. Mark the ".dark.default" rules to not apply to MD icons. Bug: 854330 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1aa73da1032addfe73db2f821bd9d945be27e5dd Reviewed-on: https://chromium-review.googlesource.com/1115975Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#570994}
-
Ryan Landay authored
Currently, even if Stack#getMaxTabHeight() returns the maximum possible value (beyond which it's clamped to that value), we crop the tabs in the Android tab switcher somewhat when we scale them down. The overlapping tab switcher uses 90% scale, where this is not very apparent. It is apparent, however, in the nonoverlapping tab switcher, where we use 60% scale if there's more than one tab (we use 80% if there's only one). The root cause here is there's some odd/incorrect math that's causing certain sizes to not scale properly with the tab scale, so we actually end up cropping the tab too high and drawing the bottom border too high when content_scale < 1. After fixing that, it turns out that there's a small gap that appears between the tab thumbnail and the bottom border. I resolved this by raising the bottom border up by an amount equal to its own height. So there's still some cropping on the bottom of the tab with this CL, but it's an extremely small amount. Bug: 849401 Change-Id: I06c20e4a881e2d7a5b38bfc9e95ef8522c7c3921 Reviewed-on: https://chromium-review.googlesource.com/1115777 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#570993}
-
Khushal authored
R=piman@chromium.org Bug: 854416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2a34d72980d5acd8975319671cc9ca9637bf93c8 Reviewed-on: https://chromium-review.googlesource.com/1117706Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570992}
-
Ryan Hamilton authored
Change-Id: I06b9dadc7ce41ff9a0a85a6646d5aa392fae2f9d Reviewed-on: https://chromium-review.googlesource.com/1117559Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570991}
-
Klaus Weidner authored
For the first frame of an exclusive WebXR session, the JS animation loop may try to submit a frame without having received an exclusive FrameData response. In that case, use SubmitFrameMissing to skip the submission. For example, in shared buffer mode, the application is supposed to draw into a texture mailbox supplied in the exclusive FrameData response, and if that is not available the submission will fail. BUG=855722 Change-Id: I69966435520b294064164bfc970bf0f300d4ca39 Reviewed-on: https://chromium-review.googlesource.com/1117770Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#570990}
-
David Black authored
AssistantEmptyQuery should not be used with the SetPendingQuery API. If the intention is to clear the pending query, the ClearPendingQuery API should be used. I may converge these APIs later but this is just a quick fix to resolve the erroneous DCHECK. Bug: b:110859511 Change-Id: I1d55c70ad4f80aca4ada1dffb7ccba26647af9db Reviewed-on: https://chromium-review.googlesource.com/1117205Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#570989}
-
Bruno Kim Medeiros Cesar authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/0e2a5fd43dc3..f05c58b1e0ca $ git log 0e2a5fd43..f05c58b1e --date=short --no-merges --format='%ad %ae %s' 2018-06-20 derat system_api: Add ScreenDimImminent and DeferScreenDim. 2018-06-15 jkardatzke Add constants and protos for Debian package handling for cicerone 2018-06-25 jkardatzke Add hostname to ContainerSshKeysResponse 2018-06-06 brunokim Rename SupervisionTransition to is_child. 2018-06-05 ljusten authpolicy: Remove unused field Created with: roll-dep src/third_party/cros_system_api Bug: 836246 Change-Id: Icc948da3aa3b3b4c0f12df785a33b4b13178cdc7 Reviewed-on: https://chromium-review.googlesource.com/1117339Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Cr-Commit-Position: refs/heads/master@{#570988}
-
Kyle Qian authored
Previously, RemoteDeviceCache would blindly overwrite any existing device with a new one when SetRemoteDevices() was called. However, this can cause subtle bugs in the case where SetRemoteDevices() is called multiple times with devices possessing identical device IDs. Specifically, if a device with stale information replaces a more-recently-updated device, this can cause stale fields to replace new ones. This CL modifies RemoteDeviceCache by only updating the device residing in the cache when the incoming device has a last update timestamp that is more recent than the timestamp of the existing entry. Bug: 856746, 824568, 752273 Change-Id: I5a178ac8d360efef7ceb1c6dae7478484978515e Reviewed-on: https://chromium-review.googlesource.com/1117305 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570987}
-
Robbie McElrath authored
This checks ChildProcessSecurityPolicy before opening the requested files for upload. Bug: 845612 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I16538e38bcb0a44acaf8c6dab4342dea8872f81f Reviewed-on: https://chromium-review.googlesource.com/1098150 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Carlos Knippschild authored
Bug: 824807 Change-Id: Iaec899173324ad82ce702406077f3664b7db8e57 Reviewed-on: https://chromium-review.googlesource.com/1117746Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570985}
-
Ted Meyer authored
Bug: 857038 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id5564ce088b602a7284c7660b560c5529a1e820e Reviewed-on: https://chromium-review.googlesource.com/1117440Reviewed-by:
-
Bret Sepulveda authored
We increase the caption button size and inset the painting slightly to give visual space between them without creating an unclickable dead pixel. But the bounds inset operation always insets the same side regardless of language direction, so this patch changes which button is "last" to avoid the gaps being on the wrong side. Bug: 857007 Change-Id: Ibec7863264cf8efa6cc4ede822a1ae36963c7e93 Reviewed-on: https://chromium-review.googlesource.com/1117742 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570983}
-
Becky Zhou authored
Replace all texts color Google blue 500 & 700 with v2 Blue 600 #1A73E8 Bug: 834884 Change-Id: I86d31c506c09689532eb777e4e25f8308fecad16 Reviewed-on: https://chromium-review.googlesource.com/1108499Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570982}
-
Yuki Awano authored
- TalkBack (screen reader on Android) uses search key as modifier key. We want to pass search key accelerator without rewrite if user is navigating with TalkBack. Bug: 854917 Test: None Change-Id: I304f2c2013c95f4efbd9a57bdd6b47dfa5017411 Reviewed-on: https://chromium-review.googlesource.com/1111480Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Paul Miller authored
Although we may remove this histogram in m69, we want to keep getting data from all channels for the lifetime of m68 stable. BUG=855104 Change-Id: I1e24419bc30bfe8027e524f2a5751a3a2eb51509 Reviewed-on: https://chromium-review.googlesource.com/1115976Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570980}
-
Ryan Hansberry authored
Uses SecureChannelClient to keep a connection open with the appropriate remote device. This change also requires slightly tweaking HostScannerOperation to delay unregistering the remote device in question until ConnectionPreserver has fully had a chance to communicate with the Mojo SecureChannel service. Bug: 824568, 752273, 855813 Change-Id: I6c8c915ab1efbae9c77e08c9c9b2406a5b4de2ad Reviewed-on: https://chromium-review.googlesource.com/1117558 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Ehsan Karamad authored
The crash was introduced in 77e042ca when the logic for 'vertical-scroll' and wheel blocking handlers was implemented. The problem introduced was that it is possible to detach a wheel target inside the event handler but the code was ignoring that and would use node->GetDocument() right after dispatching the event. This CL fixes the issue by getting Document::IsVerticalScrollEnforced() before dispatching the event. Bug: 857013 Change-Id: I7331f475e8a839b0be017bc861b01a613ede82c1 Reviewed-on: https://chromium-review.googlesource.com/1117571Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570978}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8444b6a1bf03..a2c2a9d2a1e7 git log 8444b6a1bf03..a2c2a9d2a1e7 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 tsepez@chromium.org Add fxcrt::AutoRestorer<T>::AbandonRestoration(). 2018-06-27 thestig@chromium.org Update third_party/base/template_util.h. Created with: gclient setdep -r src/third_party/pdfium@a2c2a9d2a1e7 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If0a0b6660da90a8fb346bdddd3f3eb3e47ae083a Reviewed-on: https://chromium-review.googlesource.com/1117481Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570977}
-
Victor Costan authored
This CL modifies RestrictedCookieManager to allow renderers to set the SameSite and Priority CanonicalCookie attributes. Renderers must be allowed to set the SameSite and Priority attributes so that RestrictedCookieManager can be used to implement the document.cookie setter. Bug: 856364, 729800 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic0a520bc6c02c259ef22175c9eb161086fa18782 Reviewed-on: https://chromium-review.googlesource.com/1115586 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570976}
-
Alexey Kozyatinskiy authored
Lookup for inline breakpoints only at current line. If nothing found that try to set breakpoint at next breakable location inside current function. R=dgozman@chromium.org Bug: chromium:856665 Change-Id: I3b5d474815adf3778430813f0a6de1d79ae35fec Reviewed-on: https://chromium-review.googlesource.com/1114467 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570975}
-
Ryan Landay authored
If you open an NTP on Android, open the tab switcher, and then focus the NTP, there is often some jankiness at the end of the animation where the page very quickly appears to jump back-and-forth by a few pixels. It turns out that this happens when we switch from TabListSceneLayer (what we use to display the tab switcher) to StaticTabSceneLayer (what we use to show the tab during normal browsing): for the NTP, we never use the live layer in the tab switcher, so we have to use the static layer. When we switch to StaticTabSceneLayer, it (sometimes?) still uses the static layer very briefly, but displays it at not quite the right size, which causes the jumpiness before we switch back to the live layer. The fix is to make ContentLayer clip the static layer to the value of ComputedSize() in the case where should_clip == false. Bug: 748648 Change-Id: I2999ee1be91681d692e381a9aff230567ace20fc Reviewed-on: https://chromium-review.googlesource.com/1114349Reviewed-by:
-
Theresa authored
BUG=823531 Change-Id: Ib2ba65aa1b27af702b7470f579d484fb6def9c01 Reviewed-on: https://chromium-review.googlesource.com/1117751Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#570973}
-
Xu Xing authored
BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifa035eae568d9d4345f7476ee7484026a8c1aa99 Reviewed-on: https://chromium-review.googlesource.com/1116355 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570972}
-
Ryan Landay authored
TabLayer::SetProperties() currently has a param, inset_border, that changes the geometry logic for showing tabs in the tab switcher. Currently, we're always setting the param to true. We then use it to set another variable: const bool inset_toolbar = !inset_border; which is always false. This is immediately followed by this check, which always passes: if (!inset_toolbar) {...} In addition to being unnecessary, this param is also extremely confusing/misleading. We do actually start out with the toolbar inset on top of the tab thumbnail (before we fade it into the tab title), and we only inset the top and bottom borders, not the ones on the left and right. This CL removes this unnecessary logic. Bug: 849401 Change-Id: I5ccfa35f766baf477837be1d886a2974d0009a54 Reviewed-on: https://chromium-review.googlesource.com/1114330Reviewed-by: -
Darren Shen authored
KeyboardController listens to WindowObserver events on the parent container window. It updates the observer whenever the keyboard moves to a different display by removing the observer on the old root window and adding the observer on the new root window. See original patch that added the code: https://crrev.com/1008453002 We don't really need to do this as we already do that in Activate/ Deactivate keyboard. Bug: 845780 Change-Id: Idc25d5beadbe1f2233e184fd1c189a3fde05aa50 Reviewed-on: https://chromium-review.googlesource.com/1113714 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#570970}
-
Dmitry Gozman authored
This is a common part to be shared between StartNavigation and CommitNavigation paths. Bug: 789577 Change-Id: I3e90d158b411b9134bcd8d1a333c81875cff8753 Reviewed-on: https://chromium-review.googlesource.com/1107240Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570969}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/47bb72284a37..c03de9ae4eef git log 47bb72284a37..c03de9ae4eef --date=short --no-merges --format='%ad %ae %s' 2018-06-27 rockot@chromium.org Reland "Add Android mojo_core binaries to Chrome deployment" Created with: gclient setdep -r src/third_party/chromite@c03de9ae4eef The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:822034 TBR=chrome-os-gardeners@chromium.org Change-Id: I043a23d1a36caede27c009bf790e454b51473526 Reviewed-on: https://chromium-review.googlesource.com/1117539Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570968}
-
Chris Lu authored
Before: https://drive.google.com/file/d/1lkH7kzBhoc02yFuqiJFkArO5XGoRkgv4/view?usp=sharing After: https://drive.google.com/file/d/1HVNhe0k4rWch1oO6TFFLQkU17SL9fqLg/view?usp=sharing Bug: 856626 Change-Id: I022b5d8b54828855f836e0428d29d0ffde6bcdfd Reviewed-on: https://chromium-review.googlesource.com/1117743Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#570967}
-
Amy Qiu authored
Rename pages in key_noop_cases.py to be consistent with rendering page sets Bug: 847857 Change-Id: I432509b893a0943fd59ee40813fac520eaa59f9a Reviewed-on: https://chromium-review.googlesource.com/1117444Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570966}
-
Oriol Brufau authored
These properties provide the author with the ability to control borders through logical, rather than physical, direction and dimension mappings. Intent to Implement and Ship: CSS flow-relative margins, paddings and borders https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc Spec: https://drafts.csswg.org/css-logical/#border-properties BUG=850000 TEST=external/wpt/css/css-logical/logical-box-border-color.html TEST=external/wpt/css/css-logical/logical-box-border-style.html TEST=external/wpt/css/css-logical/logical-box-border-width.html The tests still have some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ide70c65777ed42e9ef34fbcb2f58ef85f62bad4c Reviewed-on: https://chromium-review.googlesource.com/1092695Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=856868 R=sky Change-Id: I4a1059e88aee7d6dadbb277742c770a11c1e7042 Reviewed-on: https://chromium-review.googlesource.com/1117274 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
