- 21 Jul, 2020 40 commits
-
-
Mehrdad Hessar authored
Bug: 1099030 Change-Id: Ibab49ba7816720c3abcba35dafd09be553788bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309140Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Cr-Commit-Position: refs/heads/master@{#790405}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 93a6ebbe. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic73a79c2780d253155f967a9f0af579265f6bbf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310109Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790404}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c29401c0..df76b72e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3607fb2a33e315036823aed599ac9b683ad537ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310149Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790403}
-
Evan Stade authored
DisplayCutoutController is split into DisplayCutoutController (destined for //components) and DisplayCutoutTabHelper (which stays in //chrome). Relocation/reuse will occur in a follow up CL. TBR=dtrainor@chromium.org Bug: 1095714 Change-Id: Ie119069ae4756baf73acc23d655665fce1d4c035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296888 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790402}
-
Torne (Richard Coles) authored
Move the dependency on downstream code needed for new Android releases from the APK target to the WebView Java target. This ensures that monochrome_public will also get the dependency when appropriate, and removes the need to duplicate this condition in the downstream targets. Bug: 1106471 Change-Id: Idc9938eb5dc7f0738f539ac8561bab7abc52f0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309810 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790401}
-
Mohsen Izadi authored
INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT has been removed from the code since r748271. Event.Latency.BlockingTime.* metrics that used to use this component were also removed in r780806. Similarly, Event.Latency.QueueingTime.* metrics are removed in r780806. INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT is not used anyomore in reporting latency metrics, but it still seems to be used by devtools, so we are not removing it, yet. This CL updates the latency_info.dot to match these changes. Bug: 849719 Change-Id: I0d5485bbb6b28f775459dbb2f7c930b3c19c5cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305118Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790400}
-
Sreeja Kamishetty authored
Bug: 1102629 Change-Id: Iaa4440558f32459c6253d669f65a2354d31c93fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309983Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#790399}
-
Adam Rice authored
The WebSocketReassembleShortMessages experiment, which uses the Net.WebSocket.CloseCode as one of its metrics, has been extended to beta, and will probably be extended to stable. Extend the life of the Net.WebSocket.CloseCode histogram all the way to December 2020 so hopefully we won't have to extend it again. BUG=1104953 Change-Id: I6e8edc2d7204628901e870c97a9248e5fcbe99b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298867 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790398}
-
Pavol Marko authored
This change makes PlatformKeysServiceImpl independent of BrowserContext/Profile. All BrowserContext-specific calls have been extracted into a PlatformKeysServiceImplDelegate. This has the advantage that for device-wide usage of the PlatformKeysService, a delegate can be created which does not depend on a Profile (avoiding using the sign-in Profile for that use case). The CertProvisioningScheduler use case has been migrated to this pattern. As the device-wide PlatformKeysService lives "forever" but the underlying system token NSSCertDatabase does not, PlatformKeysService can now explicitly "shut down" when the underlying NSSCertDatabase is being destroyed. After it is shut down all operations on the PlatformKeysService will fail with an error (except for removing observers). Note: The PlatformKeysService still works for the sign-in Profile which is important for the sign-in screen extensions use case. Bug: 1045895, 1073512 Test: browser_tests Change-Id: I09b855c61caaa744bf8618073eaa2854a609df84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188633 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#790397}
-
Joshua Pawlicki authored
This reverts commit 4d324410. Reason for revert: Breaks mac ASAN bot :( Original change's description: > Updater: AppWake starts the server instead of doing an update check. > > Bug: 1105589 > > Change-Id: I6d7e8b0b7858a4f1a538684758644f134318c0a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298045 > Commit-Queue: Mila Green <milagreen@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790139} TBR=sorin@chromium.org,waffles@chromium.org,milagreen@chromium.org,norberg@google.com Change-Id: I507f6a05ec9e7764b6517279579bbfbb93d12aa6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308872Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#790396}
-
arthursonzogni authored
Context: https://chromium-review.googlesource.com/c/chromium/src/+/2232320/2/content/browser/form_controls_browsertest.cc#141 This patch fixes the typo and uses the more common MAYBE_ pattern. BUG=1091661 Change-Id: I916faa0c88697ae4887d38ec4591c00a9330ae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307214Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790395}
-
Christopher Cameron authored
Bug: 894929 Change-Id: I6e3672659337dd4150de67cb62f5d5dcb27db9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309047 Auto-Submit: ccameron <ccameron@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790394}
-
David Roger authored
Screenshot with this CL: https://drive.google.com/file/d/1b-x0NrGnycEfV24EQ9pb_vKBHfPc2X60/view Mock: https://drive.google.com/file/d/1ckOFYd_eFQ1UK5byLkeXOuNqo0Fskxj2/view?usp=sharing Bug: 1076880 Change-Id: I5d0b4ab2194899039e97f86a90b1aa3d578bd78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292300Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#790393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83406a9d26a2..86079a48c157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andruud@google.com Change-Id: Ib406ebfd527185fc1d8bb3c31cbd2313d6dfc2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309970Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790392}
-
Victor Hugo Vianna Silva authored
This CL accomplishes two things. 1) Make sure test coverage is not lost when the feature is enabled. crrev.com/c/2299353 hardcoded that many tests should consider the feature as enabled/disabled. This CL makes sure that: a) Tests that are agnostic to the feature don't specify this. b) Most tests that do depend on the feature now use conditional setup/ expectations when appropriate. c) Only tests that are specific to one state of the feature (enabled/ disabled) specify this. 2) Make sure all existing tests pass when the feature is enabled. Bug: 1105795 Change-Id: I5825afe82041f7d91d7dcbf3d63f64ad74590ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309699 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790391}
-
Roberto Moura authored
Change-Id: Id063eac00a170b1e66a177bf705de712b7c060a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306038 Commit-Queue: Roberto Moura <mouraroberto@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#790390}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/97f9923235cf..c5d08140dbeb 2020-07-21 capn@google.com Regres: Don't test changes with negative scores If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3369195a91e592ccb1c7e46232705501551ecbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790389}
-
Anders Hartvoll Ruud authored
This eliminates the final call-site for MatchResult::AuthorRules, which means we can (in a future CL) remove MatchResult::UaRules, ::UserRules and ::AuthorRules. Also establish a common pattern for use-counting in StyleCascade, isolating as much use counting "noise" as possible into separate functions. Finally, this CL adds a unit test for kSummaryElementWithDisplayBlock- AuthorRule, since we didn't have one already. Change-Id: I4693fd8ee538da88fea0648eda8ccfac31818dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307238 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790388}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/57d7441b354d..62ab4833a6a1 2020-07-21 jacktfranklin@chromium.org Remove incorrect DEPs from formatter worker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba7911e9f340c026dab8cc712cea79484b3f163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309972Reviewed-by:
-
Stepan Khapugin authored
Remove this UI blocker because there's now one owned by the scene that's showing the FRE, so this one is unnecessary. Bug: none Change-Id: I742f0e432fdec3e33fd4434bcbba7c3440eba07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289858Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790386}
-
Jérôme Lebel authored
default_world_favicon was duplicated in: + ios/chrome/credential_provider_extension/ui/resources/ + ios/chrome/common/ui/resources/ This patch moves default_world_favicon.imageset to: + ios/chrome/common/ui/resources/ Change-Id: I997e35b4ee695b24c1b6ffbf66e97fc5e2131f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308720 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#790385}
-
Gavin Williams authored
Using on-blur simplifies closing the dropdown for clicks registered outside of print preview. And now that we don't have to specifically listen for clicks outside of print preview, on-click can be used instead of pointerdown. Bug: 1059607 Change-Id: I9225ec9e06e3197b9f2eae4ac078b29fa232a791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303368 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
-
Michele Mancina authored
Change-Id: Ia351a4496c5e782c283e2aea08e6d20393979391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297562 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#790383}
-
Richard Stotz authored
Bug: 1097126 Change-Id: I3775c97543b4603e910f5cf4ec1f5a7207fd7276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308420Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790382}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 Partially implement the QueueAccessReport function. A simple report is sent containing: - disposition - effective-policy - property but missing for now: - blocked-window-url - source-file - line-no - col-no - violation-type COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] this patch. Bug: chromium:1090273 Change-Id: Ib5ed9fc598f437459a6b57e35875be6fbf5a63b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273120 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790381}
-
Mugdha Lakhani authored
This is so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: Iedae9f5248d37da9aacd9c739719c9889c1949bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236482Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Marc Treib authored
It was referencing a closed bug. Bug: 1107741 Change-Id: I54d8c4a7eff4ebc555943ba0436f725f9da46c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309690 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#790379}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e875f72dc66f..c1eb58de32c0 2020-07-21 reed@google.com MallocPixelRef should always allocate as large as computeByteSize() says 2020-07-21 robertphillips@google.com Convert more tests to GrRecordingContext/GrDirectContext 2020-07-21 adlai@google.com Reland "Remove more GrContext imports & usage" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103827 Tbr: robertphillips@google.com Change-Id: I55a75abf9a0d247acbb41268e81b0b52b84f2443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309979Reviewed-by:
-
Mark Brand authored
Removes support for the legacy Ptr, Request, AssociatedPtr, AssociatedRequest types. This will break while there are .mojom files that use any of these types. Change-Id: I221115bc89989a73beebb2d5fcdd7fc51d60cfd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247727 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#790377}
-
Justin Cohen authored
This reverts commit 3fef6172. Reason for revert: This is still failing downstream. https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/12473 Brief investigation shows it may be related to the page loading under the toolbar. Original change's description: > [ios] Fix and reenable testChildTabOrdering EG test > > The fix was copied from context_menu_egtest.mm which is to add a matcher > for context menu button. > > Bug: 1106739 > Change-Id: I1e89c3ccbc081aa0ff254a0a8bef535ed02054a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304963 > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790046} TBR=eugenebut@chromium.org,michaeldo@chromium.org Change-Id: I81452aa5c8521f5f0b33ee7efb7db83873ce3f62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309070Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790376}
-
Shelley Vohr authored
https://chromium-review.googlesource.com/c/chromium/src/+/2295780 added UKM around prefetch accuracy stats, which involved an added line in PreconnectManager::TryToLaunchPreresolveJobs() that did not check the WeakPtr before using it. This fixes that. Change-Id: I3cdf84d0f84fb9cc59811817efb1bdd42d15cf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309029Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790375}
-
Jérôme Lebel authored
Adding UIBlockerManager protocol (implemented by AppState) and UIBlockerTarget protocol (implemented by SceneState), so ScopedUIBlocker is not dependent anymore to: //ios/chrome/app/application_delegate:application_delegate_internal //ios/chrome/browser/ui/main:scene And moving scoped_ui_blocker into its own target: //ios/chrome/browser/ui/scoped_ui_blocker Fixed: 1103565 Change-Id: I6cdb35bd0f9eda11b0c8033eede6f5d97a0ed588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288853 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Mentions: * disable_android_lint * use_errorprone_java_compiler * treat_warnings_as_errors TBR=docs update Change-Id: I4bf1e320058357bbf878aedacaa9641bfa169daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308272Reviewed-by:
-
Andrew Grieve authored
Bug: 1103108 Change-Id: I2d4fe20bfcd92b01913b99ab857f4da52e830a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309571 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790372}
-
Stephen Nusko authored
After http://crrev/c/2256225 we had two classes of flakes. 1) The impl_destoryed_ CopyOutputResult would be non empty. 2) The callback_count_ would be incorrect. The cause of 1) was in the change that introduced the flake we called SetViewportRectAndScale() after RunUntilIdle(), but SetViewportRectAndScale() was what prevented the CopyOutputResult returned to the impl callback from being non-empty. So if we RunUntilIdle() fast enough we would still prevent the drawing and the test would pass. So the fix is to immediately call SetViewportRectAndScale() after destroying the main to ensure its always fast enough. The cause of 2) was that RunUntilIdle() runs JUST the currently posted tasks, so there was a race between RunUntilIdle() being called and during the deconstruction of the layer PostTasking the callback. The fix is to only wait for the main callback in frame 3 so we can verify that it will happen before we destroy the impl layer. And wait for the impl at the end of the test. Bug: 1096962 Change-Id: Iad066a2316f2e4df3bdf53379c87a4697d6da8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294981Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Ben Kelly authored
This CL consists of the following changes: * Plumbing to remember the request method used to load a fetch Response. * Storing the request method alongside the Response in cache_storage. * Using this information in the padding computation. * Black box http web test. Bug: 1039882 Change-Id: Ifcf4a638b1de857260bf44e5683224410dc7bf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303770Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#790370}
-
Maksim Sisov authored
This patch resolves mostly to the following pattern: #if defined(USE_X11) DoThis(); #elif defined(USE_OZONE) OzonePlatform::DoThat(); #endif Two ifdefs are combined to a single ifdef now with if (IsUsingOzonePlatform()) condition is added. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ie8f8560ffb9ab7ab24b10412a5a612c3cc279373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250250 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#790369}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1a073785503..0bc68bd16484 2020-07-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision be103000..abd2dc65 (790129:790286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I532e7ffb44b83fdfa0d9ab253e320234b700b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309976Reviewed-by:
-
Hyunjune authored
getPointAtLength[1] on SVGGeometryElement should throw InvalidStateError for with non-rendered, so this patch throws InvalidStateError if there is no LayoutObject on the target element. [1] https://svgwg.org/svg2-draft/types.html#__svg__SVGGeometryElement__getPointAtLength Bug: 972979 Change-Id: I26eb5330127ebbca9fbf55d796ce8159a09bfcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147168 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#790367}
-
Vasilii Sukhanov authored
Fixed: 1066048 Change-Id: I37daeeec01b97dd14246635322b44b9649e32cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308716 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
