- 21 Oct, 2020 40 commits
-
-
Owen Min authored
Extension request only report only contains - profile id - extension request. But not - extension list - policies info Profile name and sign in user info only added on CrOS. Bug: 1137964 Change-Id: I76bc72acde86f149ac090d839d159ddb56b6bb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485276Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819442}
-
Ramin Halavati authored
Updates the DCHECKing when regular profile is destroyed to ensure no renderer process host is alive for any off-the-record profile. Bug: 1033903 Change-Id: I4971d68f6f958fcace723b3515b3ed44f8753866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478989Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819441}
-
Henrique Ferreiro authored
Internal is not a component in Monorail. The correct one is Internals. Change-Id: I8992e0f06dd876253d385f47f68889972fc6b44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489502Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#819440}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01771c17f1d6..07829f27ec5f 2020-10-21 bsalomon@google.com Revert "Perform bounding rect-relative calcs in full float in GrRRectBlurEffect" 2020-10-21 johnstiles@google.com Migrate additional FPs to `return` instead of `sk_OutColor`. 2020-10-21 johnstiles@google.com Wrap built-in symbol tables when a switch statement is cloned. 2020-10-21 bsalomon@google.com Perform bounding rect-relative calcs in full float in GrRRectBlurEffect 2020-10-21 johnstiles@google.com Create a basic IRNode pooling system. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1138810 Tbr: egdaniel@google.com Change-Id: Ieb6e35312e3171cdc45b992aec6ea63f3228ad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819439}
-
Sebastien Lalancette authored
The previous approach only allowed pasting the additional text in text boxes on iOS 12 (not the URL). Also, by having the text as first item, Chrome's omnibox was offering to search for the additional text rather than selecting the second pasteboard item (the URL). The fixes were to put the URL item first (omnibox fix), and also offer a plain text version of it (iOS 12 fix). Bug: 1136043 Change-Id: Ia104f50694982eaeea9651c9f4cf613f487e0a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490240 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819438}
-
Nicolas Ouellet-Payeur authored
Don't run DestroyProfileOnBrowserClose logic if Background Mode is enabled, i.e. wait for the entire browser to exit before destroying the Profile object. Bug: 88586, 566835 Change-Id: I593d5537fc494bab1cd435b65cfc57075d92cfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476173Reviewed-by:
-
Mario Sanchez Prada authored
As a precursor to crrev.com/c/2412309, this CL adds a new C++ struct, along with the relevant mojom traits for typemapping, that will now be used for IPC between the browser and renderer processes instead of directly using the blink.mojom.RendererPreferences mojo struct. This is needed in order to migrate PageMsg_SetRendererPrefs to Blink (see CL 2412309) since, even thought that message will now be received and handled inside Blink itself, it's still necessary to pass it back to //content/renderer as it's still needed in several places such as RenderView and //content/renderer/loader, and having the mojom struct only would cause trouble because we can't simply pass a Blink variant of that struct into //content. Having this C++ struct and its corresponding typemapping solves this problem since Blink will no longer receive the Blink variant of the mojo struct but just a blink::RendererPreferences, which can now be passed to //content/renderer for as long as it's still needed. Bug: 1102442 Change-Id: Id79fc6117c6b6a091644f41619aa6467550705cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445499Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#819436}
-
Peter Boström authored
Replaces pbos@ who no longer claims specific ownership to this directory with jkrcal@ whom he's pulled into every conversation about this code. Bug: None Change-Id: Iadee667490306ab72093811276243ef4c0a757c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490326 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819435}
-
Akira Baruah authored
Unsent metrics logs get trimmed if they're larger than a preset size. This change implements a new UMA metrics histogram called "UMA.UnsentLogs.DroppedSize" to record the size of each of these trimmed logs. Also adds a unit test case for a similar existing histogram that measures dropped log counts. Bug: None Test: metrics_unittests Change-Id: If6ed17a2a1327c2bd3d3a9da16926b91e72a6f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482322 Commit-Queue: Akira Baruah <akirabaruah@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#819434}
-
Jeffrey Kardatzke authored
These are changes that are intended to be somewhat generic for Chrome OS protected media playback and are required by the initial VAAPI integration. These calls will be made from within the Chrome VAAPI code. The corresponding change in Chrome OS is here (internal): http://crrev.com/i/3349775 BUG=b:153111783 TEST=Builds, also verified with full prototype Change-Id: I4ce0274f932b61db2162e05ba06e95ccd83103d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486116 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819433}
-
Eric Seckler authored
This moves the majority of AndroidBatteryMetrics from chrome/ to components/, so that we can reuse it for WebView/WebLayer in the future. The only aspect that remains in chrome/ is the detection of the app's visibility state, since this will have to be done some other way for WebView. Bug: 1102048 Change-Id: Ia8391fd5efd80411ac970c559cdf5db988ba9ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485794 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819432}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 591099 Change-Id: I2e166ff4851f3d0fc84e1cf2ef797886d4992471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490245Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819431}
-
Kuo-Hsin Yang authored
vovoy@chromium.org would take over the code review for Chrome OS tab manager from cylee@chromium.org. Change-Id: I9743e6d3b152467467b20e70fd96cb2b9b2929b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489112Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819430}
-
Anton Bikineev authored
The CL enables PCScan when 1) PA-Everywhere, 2) --enable-features=PartitionAllocPCScan. and makes sure that it's enabled after FeatureList is initialized. Bug: 11297512 Change-Id: Ibcf21a503cdf0cb1a085629ab77d4e87061f8fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473637 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Roberto Moura authored
The drop shadows helps contrast thumbnails when they overlap one another, i.e. during transitions between thumb strip and tab grid mode. Bug: 1127604 Change-Id: I23b55172d112461ed63e6087203dbf780dcd1728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487126 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3169c31f1f0e..f80cfd667638 2020-10-21 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I6e9546745d3a21fd1cce05b26dd8d21077ec20ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489752Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819427}
-
Peter Wen authored
Chrome makes use of these APIs. Rather than adding @SuppressWarnings for the RestrictedApi check for all classes that use these APIs, add a chrome-specific suppression for just these ones that are false positives. Bug: 1139442 Change-Id: I95dbf4ed84908a12242e31b103386fecee88a128 Fixed: 1139442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487846 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#819426}
-
Sergey Ulanov authored
ExternalVkImageSkiaRepresentation uses ExternalSemaphorePool to re-use semaphores. OutputPresenterFuchsia converts image semaphores to Zircon events and shares them with Scenic. Scenic waits for these events, but never resets them. As result the semaphores are often re-used in signaled state. This CL disables semaphore re-use on Fuchsia to avoid issue. Bug: 1140719 Change-Id: I9154535b59262d60cd602c7711315673cf2bad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487879 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819425}
-
Bill Budge authored
- Uses Blink getter to get actual cross-origin-isolated state. - Sets flags correctly. Bug: chromium:923807 Change-Id: I54101e10d89ef9b3e373f98eda2509cc97d38529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489924Reviewed-by:
-
Avi Drissman authored
Unlike a code signing cert, where a self-signed cert will not work, and where Apple provides both a development and a deployment cert, for the installer package a special cert is required, and a self- signed cert is a very good idea because Apple does not provide a development installer cert, just a deployment installer cert. Expand the documentation, and include a link to a Stack Exchange answer that describes how to make such a self-signed cert. Also, tweak the Google-internal link for the code signing development cert, as that is now where it can be found. Bug: none Change-Id: Idf8db4f14322a775c640180c19719a62feac5e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488026 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819423}
-
Mihai Sardarescu authored
Use std::make_unique to create unique pointers for BookmarkBubbleSignInDelegate. Bug: None Change-Id: Iabffb64eed63a554f4def7a0f2c1f68de38ec765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490043 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#819422}
-
Peng Huang authored
SkiaOutputSurfaceImpl::SubmitPaint() not always submits painting tasks to GPU. So sync token returned by it is not always valid. Fix the problem by renaming it to EndPaint() which will not submit tasks to GPU anymore and not return sync token. It also adds a new method Flush() which will submit pending tasks to GPU thread and provide a sync token. Bug: 1139697 Change-Id: I34fdd5e325ac2425399a9fc98ffcaa6052cddc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488302 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819421}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010210700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/FPS7GXWrnoUpSm7SUEXrX5w9y54l81RKV4hoZXUW3xEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170910313,b/170910490 Tbr: help-app@grotations.appspotmail.com Change-Id: I5dcc1e8d8acd7ca42c54ce19d330a68dd2c01910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819420}
-
Alex Gough authored
Input zip files do not need to be written, and are opened read only, e.g. https://source.chromium.org/chromium/chromium/src/+/master:components/services/unzip/public/cpp/unzip.cc;l=109 Bug: 1130762 Change-Id: I161ea1debe3b6ba7bf3a9f002bdb135be739eb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488399Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#819419}
-
Alex Gough authored
Input files do not need to be written and are opened readonly. Bug: 1130762 Change-Id: I23a6a610ae34c6eb0aa76f54f727458c55fd5e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488667Reviewed-by:
-
Sylvain Defresne authored
In preparation of supporting arm64 simulator build (for Apple Silicon macs), we need to decouple the fact that a build is a simulator build from the `target_cpu`. This was done by introducing a `target_environment` variable that can be set by the user (the default value is set using the same heuristic based on value of `target_cpu` if unset). Change the ios/web_view build script to explicitly set the variable. Also change gn_args from a string to a list of string and join them when creating the command-line to make the code easier to read. Bug: 1138425 Change-Id: I540ad628921dba9cd37a7599b68fd1d27bf59cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489866 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#819417}
-
Austin Sullivan authored
Modifies CreateIncognitoFileSystemContextForTesting method Bug: N/A Change-Id: I28a86cb4edb35d312899ac438e283bd502fd1722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487723Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#819416}
-
Yusuf Sengul authored
Bug: 1139587 Change-Id: I5e0166850dbccd5cc936d2e59417da085fa62632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482545 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#819415}
-
Jan Wilken Dörrie authored
This change replaces existing usages of autofill::PasswordForm with password_manager::PasswordForm in //components. TBR=dvadym,dullweber,arbesser,treib Bug: 1067347 Change-Id: Ide786bd54570dc99867dbf6e93057a95af1719f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487324Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819414}
-
Chris Lu authored
InfobarContainerCoordinator is not used in the Overlay implementation. User taps to badges in the overflow menu should just insert an overlay request into the OverlayRequestQueue. Bug: 1138106 Change-Id: Id20bfec51be0894a3a430ed90069fd8f668349e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488905 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#819413}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I532524fbd4ddf1ed699abf717de06cf56a1462ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490301Reviewed-by:
-
Roberto Moura authored
Add an opacity transformation to the tab grid's top toolbar when transitioning from thumb strip to tab grid. Bug: 1127604 Change-Id: I38c43eb556f2f02e7da2ff81a0d30dda7c60fea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485163 Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
Mohamed Amir Yosef authored
This is preparation for adding the functionality of moving multiple passwords from settings view. Mocks are in the linked bug. Bug: 1139263 Change-Id: Ib173b0625f2ee82542164b703c97a53cee997030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480162Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#819410}
-
Rohit Agarwal authored
This CL refactors the test code on profile and adds Incognito CCT tests. Bug: 1060940 Change-Id: I1e340b9dc34d080c1b2a191720c37d7c6db17cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489903Reviewed-by:
-
Tommy Li authored
For HistoryQuickProvider, we use an in-memory URL database called URLIndexPrivateData. This in-memory database is rebuilt from History if its own cache file is missing or corrupt. Previously, Android devices were limited to 1000 entries during the rebuild step, whereas other platforms had no limit. There are some pathological cases where unlimited is bad, such as when users are stuck in a redirect loop with autogenerated URLs that spam their history. This CL adds a 20,000 entry cap for all platforms, and that should be safe, as that will affect only 0.01% of Windows users. I plan to add further per-eTLD+1 caps and per-URL length caps as well in followup CLs. NOTE: This only affects the case where the HQP cache file is missing or corrupt, and the HQP index has to be rebuilt on startup from the History DB. This is an unusual case, so further work will be needed to address the typical present cache file case. Bug: 750845, 1032679 Change-Id: Ia9e309dd43e3272823d69c707cceb8abe1a192ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488384Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#819408}
-
Andrew Grieve authored
Abstracts the pattern of looping over weak references and removing stale ones. * Converts UnownedUserDataKey to use WeakSet since order does not matter. TBR=agrieve # Trivial refactor in AutofillManagerWrapper.java Bug: 1131047 Change-Id: Idf226faecb31de69f7b7bbae32d6c795dca3dca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477050 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819407}
-
Achuith Bhandarkar authored
BUG=chromium:1115622 TEST=chromeos-betty-arc-r-chrome Change-Id: I002720f117ca6bad652fe44d42222da4b584ac16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488900Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#819406}
-
Hai Bi authored
The ScopedService* publishing templates infer the service name from the supplied Interface class. It is sometimes desirable to publish a service under a manually-specified name, e.g. if the service isn't actually defined as [Discoverable], or it's needed to publish it under a different name. The templates now accept an explicit |name| parameter which defaults to the name of the Interface, if available. Bug: b/171256428 Test: locally tested and pass unit tests Change-Id: If206fea8a7555baea5806b8526be2affc1e0dc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486620 Commit-Queue: Hai Bi <bihai@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#819405}
-
rbpotter authored
Bug: 987318 Change-Id: I7c8943f15724e6387c5a1a9fc1666c1940422020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486459Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#819404}
-
David Grogan authored
Just a test, no behavior change. Fixed: 965672 Change-Id: Iaf1f86a92aa6c65e33736850ea2fbd5411db45d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488984Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819403}
-
