GitLab

https://pdfium.googlesource.com/pdfium.git/+log/148c14459dd2..578e24839231


git log 148c14459dd2..578e24839231 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 tsepez@chromium.org Store properties/attributes in CXFA_Node as span<>
2019-01-25 tsepez@chromium.org Pass attributes and properties to CFXA_Node as span<>


Created with:
  gclient setdep -r src/third_party/pdfium@578e24839231

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3918dc0d1e1ea47bd57bf88041835f86825abcc0
Reviewed-on: https://chromium-review.googlesource.com/c/1435725Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626247}

LoginInterstitialDelegate should take a OnceClosure, and all these
static methods (probably predating base::Callback) can be normal
methods.

This is some small cleanup to make the upcoming big change to
LoginHandler smaller.

Bug: 908926
Change-Id: Idec46fe691ac82b298ed6e90f8e5bcaac31e4a32
Reviewed-on: https://chromium-review.googlesource.com/c/1388039
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626246}

Gab, I've used your refactoring script for this, the rule is:
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class OneShotTimer;' in content:
    return False

  if 'class RepeatingTimer;' in content:
    return False

  if 'class RetainingOneShotTimer;' in content:
    return False

  matches = re.compile(r'(\n *[^/\n][^/\n][^/\n]*base::(OneShotTimer|RepeatingTimer|RetainingOneShotTimer)\b[^*])', re.DOTALL).findall(content)

  if not matches:
    return False

  found = False
  for match in matches:
    constant = 'YADAYADA'
    match_mod = match[0].replace('OneShotTimer', constant).replace('RepeatingTimer', constant).replace('RetainingOneShotTimer', constant).replace('const ', '')
    if not 'std::unique_ptr<base::%s' % constant in match_mod:
      found = True
      break
  if not found:
    return False

  updated_content = refactor_lib.AddInclude(file_path, content, "base/timer/timer.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

TBR=gab@chromium.org

Change-Id: I5a6a19371e5d7dc864ce9c8ae117e9ee9d54dd80
Reviewed-on: https://chromium-review.googlesource.com/c/1435748Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626245}

https://chromium-review.googlesource.com/c/chromium/src/+/1432881
changes the shield widget not be animated if the wallpaper blur is not
animated, and also delays the creation of the shield widget in some
cases. This CL adds a test for that logic.

Test: ash_unittests OverviewSessionTest.GridShieldAnimation
Bug: 924395
Change-Id: I0a9bbc415def682b7450d612b70a98ab6cdec1b4
Reviewed-on: https://chromium-review.googlesource.com/c/1432874
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626244}

Bug: 887150
Change-Id: Ic388bcf3a0bbce983f5537640d4cfe2b5affbd95
Reviewed-on: https://chromium-review.googlesource.com/c/1418732Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626243}

This patch adds updateAndCommit() which updates the subtree cooperatively
and then commits.

R=chrishtr@chromium.org

Bug: 882663
Change-Id: I14b906ff1ccf2ed57df082bfe883bb5d4c6e9ac3
Reviewed-on: https://chromium-review.googlesource.com/c/1422867
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626242}

This logic isn't needed any more, since cloud destinations get
fetched when login state changes, and we update the recent list when
destinations are inserted. It may also be contributing to some bugs
that so far are not reproducible.

Bug: 923914, 924889
Change-Id: Ibfef7f183a66da373d7d7f4775896d9ba39c22c3
Reviewed-on: https://chromium-review.googlesource.com/c/1436193Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626241}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60574b5f91b9..db34d87aff44


git log 60574b5f91b9..db34d87aff44 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@db34d87aff44

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ie46749243c66a9a6b7def0fe7044fcb4b084171e
Reviewed-on: https://chromium-review.googlesource.com/c/1437397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626240}

There are no metrics being recorded for clean task completion (ie. no
chrome crashes or OOMs during task running). This cl adds new
start/finish metrics to native background task in order to get a
percentage of tasks that fail unexpectedly.

Bug: 924644
Change-Id: Ic1a70ff5aad5aca633c5e50ed32b1dc53b60120f
Reviewed-on: https://chromium-review.googlesource.com/c/1428092
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626239}

Bug: 924341, 923634, 924539, 924811, 924866
Change-Id: I66c22718e7c0cdad0195504ee897a3991e1208f0
Reviewed-on: https://chromium-review.googlesource.com/c/1437054Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626238}

Clusterfuzz doesn't like it when there are two SimpleMenuModels in
existence. This CL fixes the reported TSAN crash, although I don't
completely understand why.

Bug: 918794
Change-Id: Ia3d9b341a1dc42cb8a956c283cac381dbb28e48c
Reviewed-on: https://chromium-review.googlesource.com/c/1435712Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626237}

Using wpt-import in Chromium 37c22eb5.
With Chromium commits locally applied on WPT:
f643497e "[resource-timing] Modify is_secure_context_ based on resource"
20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix"
40748e1e "Upstream fast/workers to external/wpt/workers: first batch."
6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I8d9aab2c79610e5284f7d36611b6e7d08e5ec089
Reviewed-on: https://chromium-review.googlesource.com/c/1435703Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626236}

Wrap the callback that notifies of changes instead and trigger updates
off of that. Remove the notion of Disabling the ETW exporter itself,
instead just use whether the provider is enabled or not.

Leave the flag for now and continue to conditionally enable. Follow
up change will remove the flag and always have the ability to export
trace events to ETW.

Bug: 781991
Change-Id: Ifb0d3c5669fca255ca4c0bcd9f84e4034995761b
Reviewed-on: https://chromium-review.googlesource.com/c/1423559Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#626235}

See bug for spec and screenshots.

Bug: b:123376557
Change-Id: I57a92c76edd72fbb2ed427483834aead6ab330cd
Reviewed-on: https://chromium-review.googlesource.com/c/1436183Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#626234}

https://chromium.googlesource.com/catapult.git/+log/1879ca54b916..514fe3e70db8


git log 1879ca54b916..514fe3e70db8 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 behdadb@chromium.org 95% Confidence Intervals for mean statistic:
2019-01-25 perezju@chromium.org [Telemetry] Remove video capture feature


Created with:
  gclient setdep -r src/third_party/catapult@514fe3e70db8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:908893,chromium:921000
TBR=sullivan@chromium.org

Change-Id: Ie1f76f37bd0f344d4ac0ed6673e4c5e12eaa4b4f
Reviewed-on: https://chromium-review.googlesource.com/c/1437012Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626233}

The observer uses a repeated field because a tab or window can be
backgrounded and foregrounded multiple times.

Bug: 921703
Change-Id: If03a3444a237d7c5abf0740a0a3c9c684caea013
Reviewed-on: https://chromium-review.googlesource.com/c/1421681Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626232}

Since the patch in CL1406976 for crbug.com/833797 landed (see [1]), there
is not any need to monitor this event since AccountManagerUIHandler is no
longer taking accounts out of the UI while data is being fetched, and so
there is no need to do this extra effort to make sure that such accounts
were added back once that fetch was complete.

Additionally, removing this method now paves the way to migrate away from
AccountTrackerService APIs entirely from AccountManagerUIHandler, and use
IdentityManager's APIs instead, so let's do it now as a precursor CL.

[1] https://crrev.com/c/1406976

Bug: 922785
Change-Id: I068e89eb7fa7774c3be0f9bf67e02a0b8dfb642d
Reviewed-on: https://chromium-review.googlesource.com/c/1437175Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626231}

The callback received by this method as a parameter is only meant
to be run once, so let's make it a base::OnceCallback to be more
explicit, and to make the lifetime of such callback more clear.

Bug: 924102
Change-Id: I3492b59c055d61ed91c65a0b5d9418c925048213
Reviewed-on: https://chromium-review.googlesource.com/c/1429984Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626230}

This ensures that the 'wake-lock' feature is not parsed in feature
policy directives unless the WakeLock runtime flag is enabled.

Bug: 925454
Change-Id: Ic8043be2f499295f4246d99866180c2aab222ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1436201Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626229}

AudioSinkAndroidAudioTrackImpl::SetPaused() only checked
pending_data_bytes_already_fed_, whereas FeedDataContinue() requires
both this and that pending_data_ exists. Hence we protect this call with
an additional check on pending_data_.

AudioVideoPipelineDeviceTest.Mp4Playback and
AudioVideoPipelineDeviceTest.PcmPlayback both pass reliably on android.

Bug: internal/123356146
Change-Id: Ibb562ab04c9dca1fdaca5b4df743b4a59ec49cbb
Reviewed-on: https://chromium-review.googlesource.com/c/1437192
Auto-Submit: Nate Steinbock <steinbock@google.com>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626228}

https://skia.googlesource.com/skia.git/+log/094ab18b457e..d41c1876d834


git log 094ab18b457e..d41c1876d834 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 borenet@google.com Add chromium_revision tag to SKP CIPD package
2019-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 59b1ed4a60fc..59d756e530c5 (1 commits)
2019-01-25 brianosman@google.com Remove --readPath/-r from DM
2019-01-25 bsalomon@google.com Actually reuse GrTexture if SkPromiseImageTexture used with multiple
2019-01-25 brianosman@google.com Switch DM JSON output to use SkJSONWriter
2019-01-25 bsalomon@google.com Remove GrGpuResource::abandon from the public API.
2019-01-25 bsalomon@google.com Change the meaning of GrBudgetedType::kUnbudgetedUncacheable.
2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ab37b0f2ca0..86f8bdb2934c (1 commits)
2019-01-25 bsalomon@google.com Require explicit GrWrapCacheable specification in more places.
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 76e400246439..6ab37b0f2ca0 (1 commits)
2019-01-24 ericrk@chromium.org Invalidate Vulkan CB state after vending it out via drawable
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9d803dd2..7fafb7b5 (477 commits)
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 47ca1b2fa399..59b1ed4a60fc (1 commits)
2019-01-24 bungeman@google.com Use only icu c api in shaper.
2019-01-24 bsalomon@google.com Replace bool purgeImmediately with enum GrWrapCacheable.
2019-01-24 halcanary@google.com gm: delete boilerplate
2019-01-24 hcm@google.com Update Skia milestone to 74
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4806a9be530f..76e400246439 (1 commits)
2019-01-24 brianosman@google.com Remove SkColorSpace::Gamut enum
2019-01-24 brianosman@google.com Remove nearly all use of SkColorSpaceTransferFn
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 djsollen@google.com Revert "Implement XP factory dumping"
2019-01-24 halcanary@google.com gm: use DEF_GM macro consistantly


Created with:
  gclient setdep -r src/third_party/skia@d41c1876d834

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:922851,chromium:922851,chromium:900965,chromium:922851
TBR=djsollen@chromium.org

Change-Id: Ib518e49466c2365644e176043f1b37a0418ac279
Reviewed-on: https://chromium-review.googlesource.com/c/1437009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626227}

https://chromium.googlesource.com/angle/angle.git/+log/59d756e530c5..5904ee3f58e3


git log 59d756e530c5..5904ee3f58e3 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 syoussefi@chromium.org Vulkan: Fix timestamp query units


Created with:
  gclient setdep -r src/third_party/angle@5904ee3f58e3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: Ib412bcc3af35f41c37a8ef6483023e1a81ea80f6
Reviewed-on: https://chromium-review.googlesource.com/c/1437496Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626226}

The class has most functionality implemented, so it's more of a test
helper class than a mock.

Change-Id: I70b8bd66835b65e9f6af83827a0ea3682e954b4a
Reviewed-on: https://chromium-review.googlesource.com/c/1435685Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626225}

This change is to support the Switch Access focus ring style described
in this spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQBEKUk1sS_U/files/MCHtA7U1iMGr6-mR9r6ArPGAjSutDL__KP4

Bug: 925103
Change-Id: I6aeda730fd8717282cb49867840010aea7a92f83
Reviewed-on: https://chromium-review.googlesource.com/c/1435435
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626224}

I had voiced concerns about this when NoDestructor was introduced as a
strictly preferred alternative to LazyInstance @
https://groups.google.com/a/chromium.org/d/msg/cxx/rs_iizoAu6w/Gi6s0pmwBQAJ.
This CL migrates LazyInstanceTest.PriorityInversionAtInitializationResolves
to the NoDestructor thread-safe scoped-static-initialization paradigm.

It seems to be okay after all and this CL locks this in on all platforms.

Bug: 925323
Change-Id: I679beaf23934840b6070a8592dd6d678992d6943
Reviewed-on: https://chromium-review.googlesource.com/c/1436198
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626223}

This CL adds the '-f FAKE' flag to apk_operations.py. This complements
the '-m MODULE' flag, but performs fake bundle module install instead.
Changes:
* Always delete the fake module directories:
  /data/local/tmp/modules/
  /data/data/<package_name>/files/splitcompat/ (needs root)
* If -f flags is given:
  * Constraints:
    (1) '-f base' is illegal.
    (2) Explicit '-m base' is required (prevents potential ambiguity
        in the future).
    (3) FAKE and MODULE must be disjoint.
  * Print warning if command line flags not set up for fake modules.
    This requires chrome/android/BUILD.gn to specify
      command_line_flags_file = 'chrome-command-line',
    which get passed to apk_operations.py: _InstallBundle() so it can
    read the command line flags and check.
  * Extract the FAKE module split APKs, then copy them to
    /data/local/tmp/modules/.
* Update chrome/android/BUILD.gn to specify
  which get passed to apk_operations.py: _InstallBundle() so that
  it can check for '--fake-feature-module-install' in command line,
  and print warning if missing.

Bug: 922051
Change-Id: I5bba49e1e7e66a4a00f1ed1ca4128a805d995e95
Reviewed-on: https://chromium-review.googlesource.com/c/1435515Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626222}

ASAN makes this fuzzer sufficiently slow that it hits the Run() timeout,
so disable the timeout in ASAN builds.

Bug: 924030
Change-Id: I38055a3a8982564d2300fe10d717651f27d32dfc
Reviewed-on: https://chromium-review.googlesource.com/c/1433392
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626221}

Came up in crbug/917004. Although these changes don't help crash server,
it's nice to have them work locally.

Change-Id: I7208b95bc1ea784b2f3050b7f2f8a8e223133e9f
Reviewed-on: https://chromium-review.googlesource.com/c/1437539
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626220}

Previously I did not consider that menus would be very tall. I was
unaware that shift-clicking the chrome icon would show a potentially
very long list of all active tabs. This resulted in a menu that would
not show up (bottom shelf) or show up clipped (side shelf).

Added some unit tests for the tall menu case, and also for the case
where the anchor bounds size is 0 (for example, a click).

Bug: 913278
Change-Id: I460db943df268f7b1534bbdcffca9d5b96e750ec
Reviewed-on: https://chromium-review.googlesource.com/c/1428603
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626219}

BUG=924872
TEST=None

Change-Id: I5df8485c1a978d8f7ec29516d2900445bf225244
Reviewed-on: https://chromium-review.googlesource.com/c/1435682
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626218}

All pages importing it have already been migrated to $i18n{}, so these
dependencies don't seem needed anymore.

This changes following pages:
* chrome://media-router
* chrome://md-user-manager

R=dpapad@chromium.org

Bug: 677338
Change-Id: I05bcfba71ca1c8446ddfb14335d404bc382fc523
Reviewed-on: https://chromium-review.googlesource.com/c/1425719Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626217}

Bug: 916176
Change-Id: I3418fdbceea18391bb09e957e4846accf1b28447
Reviewed-on: https://chromium-review.googlesource.com/c/1413072Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626216}

This CL also adds a new utility function to render the icon to be
checked. A follow-up CL will add a unit test to reproduce the analysis
that led to lowering this number.

Bug: 805600
Change-Id: I7b93e1eececa4bb70659d8a89f782d0d9cbc5f44
Reviewed-on: https://chromium-review.googlesource.com/c/1431478Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626215}

Previously missed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1412015

Bug: 827324
Change-Id: I265678736a857aaea394fdeb2d31860f73cf36ea
Reviewed-on: https://chromium-review.googlesource.com/c/1431516
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626214}

Bug: 921548
Change-Id: Ia8b315c56cc234cc32a06bbcd36720c29cf551d6
Reviewed-on: https://chromium-review.googlesource.com/c/1437537
Auto-Submit: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626213}

This renames UpdatePrimarySurfaceId() to
UpdateLocalSurfaceIdAndClientSurfaceEmbedder(), which better indicates what
it does.

There should be no functional change here, just docs/renaming.

BUG=none
TEST=none

Change-Id: Icfe5643c0225f2e158fe8843b03f08b7dec30495
Reviewed-on: https://chromium-review.googlesource.com/c/1437576
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626212}

Bug: 919356
Change-Id: I8b7769f6d6fef258f31dd16367d54b505284a7d8
Reviewed-on: https://chromium-review.googlesource.com/c/1437265
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626211}

In SuperSize console, clustering of symbols by name avoids collision by
checking object_path. But for symbols with missing object_path, such
collision is no longer guarded, and grouping can become too aggressive.

This CL softens the impact of missing object_path by using address to
resolve grouping for non-'**' symbols when object_path is missing.

Bug: 923936
Change-Id: I9856daa42ac93cd8b296324e8cfe5625e313bdac
Reviewed-on: https://chromium-review.googlesource.com/c/1431282Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626210}

Bug: 867008
Change-Id: I5d889fb6b023318e4d47dbc4818883d975c30960
Reviewed-on: https://chromium-review.googlesource.com/c/1422842Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626209}

Template URLs with nonzero prepopulate_id were implicitly
reordered by RemoveDuplicatePrepopulateIDs, though relative
order was preserved for elements with zero prepopulate_id.
This CL adjusts the algorithm to output the selected
representatives for each prepopulate_id in order of first
appearance in the original template_urls vector, stabilizing
the overall order (instead of partitioning as it did before).

Bug: 924268
Change-Id: Ic885065cbf20398dfff723a85aff35141e0cb9a5
Reviewed-on: https://chromium-review.googlesource.com/c/1428939
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626208}