- 04 Sep, 2019 40 commits
-
-
Michael Hablich authored
The previous owners are no longer working at Google and thus do not have access to UMA. R=yangguo@chromium.org, bmeurer@chromium.org Change-Id: I6b967c831d4ee6ea00de851e50087a5c6a3977c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777866Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#693057}
-
Benoît Lizé authored
Code pinning was an experiment, which is not supported on mainstream Android platforms. Remove the code for it. Bug: 929926 Change-Id: I5f0cbd8ba90e3c1b3eaa87850b41b16642257025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781148Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693056}
-
Jan Wilken Dörrie authored
TBR=lanwei@chromium.org Bug: 1000530 Change-Id: I87915513ddc6735bd383d5bd96d703cae79c65a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782842Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693055}
-
Eliot Courtney authored
New ArcPictureInPicture flag set to enabled by default determines whether picture-in-picture is enabled/disabled in ARC. Enabled does not necessarily mean the feature is activated in ARC, but rather that if the Android developer option setting is set to DEFAULT, then this flag can determine whether the feature is activated or not. Android CLs: ag/9303889 ag/9309348 allows PIP to run if "Default" is selected in developer options --disable-features=ArcPictureInPicture in /etc/chrome_dev.conf disallows PIP to run if "Default" is selected in developer options Bug: 140200582 Test: --enable-features=ArcPictureInPicture in /etc/chrome_dev.conf Change-Id: I84ffaf43baf750244f285b705f3ddfd8750b9431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783805Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693054}
-
Jeevan Shikaram authored
This CL changes the height of permission rows to match mocks. Old view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409972&signed_aid=4Um3E86MJiRgjVynZpjLcQ==&inline=1 New view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409971&signed_aid=IzrDIjCWG_3pVKqgbk0Vxg==&inline=1 Bug: 999929 Change-Id: I8806bc2d585ea6e32e5081120ebe0cfa4461112b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784025 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693053}
-
Luciano Pacheco authored
Scroll issue introduced CL:1636665, which replaced a call to mergeItems() method in a base class to super, however the immediate parent class |Grid| also has the mergeItems() method, which was interfering with the scroll. This CL reverts back to call this method from |List| base class. Test: manually Bug: 993068 Change-Id: I19d225dcc4277a409e824c7cac580c571ba1f051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783690 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#693052}
-
Jinsuk Kim authored
- If swiped over the peek threshold, fades to 50% opacity. - If items to show in the navigation sheet <= 3, skip peek state and expand fully. Bug: 991765, 991794 Change-Id: I64200e7405c51922c20d08c882036627148b5038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778102Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#693051}
-
Mike Dougherty authored
A JavaScript URL can not be created with an empty string. Attempting to do so will throw an exception, so check if the strings are non empty first. Additionally, postMessage can not be called with an empty string for the targetOrigin parameter. If the iframe element does not have a src attribute, use “*” instead to forward the context menu message to a child frame. Bug: 911899 Change-Id: I866bec11fa48c3a0ef5b95a6a628a64384d9da59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779423 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#693050}
-
Marc Treib authored
With this change, callers have to write new LoginDatabase(path, IsAccountStore(true)) instead of new LoginDatabase(path, /*is_account_store=*/true) which is clearer (no way to forget the comment), especially if any other (boolean) parameters are added at any later point. Bug: 998455 Change-Id: Ieb81b06ec86b628ecb2471a8be83b87b0807070e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782168Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#693049}
-
Vadym Doroshenko authored
Bug: 994291 Change-Id: I8b507abd244faa0058c575becf46aae7e6b3bb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780837 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693048}
-
Eric Willigers authored
The following are now implemented in WebAppRegistrar: - FindAppWithUrlInScope - IsLocallyInstalled This avoid repeated prompts to install a PWA that has already been installed. Bug: 891172,999418 Change-Id: I33343bb23ef022487d8ced1d7584ee4e08a18d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741726 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#693047}
-
Julie Jeongeun Kim authored
This CL converts NetworkContextClientRequest and NetworkContextClientPtr to new Mojo types. It also updates SetClient from network_context.mojom. Bug: 955171, 978694 Change-Id: If2cdeefd51b7989019f78a26b4e3ec066567ffb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781989Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#693046}
-
Yuzu Saijo authored
This CL enables OomIntervention purge v8 feature by default. This used to be overridden by Finch and was made true for 100%. bug: Change-Id: I4a10ffa4b128d8d7acfb13bba57c2e2f42843201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784024Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#693045}
-
Andrew Luo authored
Bug: 997267 Change-Id: Icb17aa6d3eb77ba14ca890eb9cc2eecaaf822787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768907 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#693044}
-
Shik Chen authored
The background page might be killed by Chrome when idle. Use onMessageExternal listener to prevent race condition when running test. The companion CL in Tast is CL:1779777. Bug: b:140358697 Test: With a manually added sleep(20), do $ tast run <dut> camera.CCAUIPreviewPerf Change-Id: I3b8b6e9a56f6cf69983f3984a59e9a423ef42d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781924Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#693043}
-
Hitoshi Yoshida authored
This reverts commit 5c872c1a. Reason for revert: Postpone landing the CL to change APIs Original change's description: > IDL: Fix invalid extended attributes > > An invliad extended attribute [Enabled] was used in IDLs of WebRTC, > and some APIs are visible regardless a runtime enabled feature. > This CL fixes the IDL description and hide them behind a flag. > > > Bug: 999690, 986069 > Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Florent Castelli <orphis@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693038} TBR=peria@chromium.org,hta@chromium.org,haraken@chromium.org,guidou@chromium.org,orphis@chromium.org Change-Id: I9d2ddcdf6de7cb79139c5b6e15eb8920d6a34d98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999690, 986069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783693Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#693042}
-
Luciano Pacheco authored
Move apps in //ui/file_manager/ to use chrome:// URL in unittest. After moving these apps, js_unit_tests build template and script aren't needed anymore, thus removing it. This is a follow up of CL:1767297. Bug: 991105 Change-Id: I51553b7dda063b35e8f957838e96f7599cd6df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775854 Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#693041}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e054ff2683ba..86c39c71262d git log e054ff2683ba..86c39c71262d --date=short --no-merges --format='%ad %ae %s' 2019-09-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 31b524cf60b7..a1bf69967a32 (8 commits) 2019-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 920100cd4246..fbc146e97f30 (6 commits) Created with: gclient setdep -r src/third_party/skia@86c39c71262d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:None,chromium:None Change-Id: I50a988cce59f22843519828cfef87e62552d8ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693040}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac9e322afcdc..80aa9325dba3 git log ac9e322afcdc..80aa9325dba3 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 vapier@chromium.org cros_run_unit_tests: make disabled test list a little nicer Created with: gclient setdep -r src/third_party/chromite@80aa9325dba3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3806f8bc163cc8c9359fa0f4224e47f173af7a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784198Reviewed-by:
-
Hitoshi Yoshida authored
An invliad extended attribute [Enabled] was used in IDLs of WebRTC, and some APIs are visible regardless a runtime enabled feature. This CL fixes the IDL description and hide them behind a flag. Bug: 999690, 986069 Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#693038}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b931165..f26909d1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I547dd8cdc2e682346bbecaff4f42412087a258a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784197Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693037}
-
Kurt Horimoto authored
Currently, the omnibox gets focused by VoiceOver when an overlay is displayed over the content area. This CL post a notification to focus the overlay UI's view upon completion of its presentation instead. Bug: 999394 Change-Id: I059fc6bf32a3a0e0ba06f94b88cf023e1278fa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777084Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693036}
-
Rika Fujimaki authored
We removed some uses of ScriptValue::GetScriptState() to remove ScriptState from ScriptValue. Since ScriptValue::GetIsolate() is used a lot, I separate the removal into some CLs. Bug: 998994 Change-Id: Id337541a94db1b80fa70255aefe7792339b67144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777353Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 021c0b6d. Reason for revert: suspected to break browser_tests and unit_tests. See https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/14987. Original change's description: > Add UMA metrics for crostini VM startup > > We currently have metrics for the installer, but no way to tell how > many people are experiencing errors starting crostini after that. > > Bug: 977201 > Change-Id: If828e4cefc10197ddc9dbdc5b867f68184975f29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773999 > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692991} TBR=bcwhite@chromium.org,joelhockey@chromium.org,nverne@chromium.org,sidereal@google.com Change-Id: I4693c92b96bfe574b881eaada755edcc1c81a61d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784263Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#693034}
-
Dominic Farolino authored
This CL renames the PrefetchRedirectError flag to PrefetchPrivacyChanges so the flag can be generalized to encapsulate more privacy-preserving changes proposed in [1]. Also implements the usage of kNoReferrer referrer policy when the privacy changes flag is enabled. A LinkLoader unit test is added to test that the referrer policy is set and persists correctly. It is likely too early to invest in WPTs for this change, since standards discussion must take place before we can determine this is the correct way forward. [1]: https://github.com/w3c/resource-hints/issues/82 R=kinuko@chromium.org, yhirano@chromium.org Bug: 988956 Change-Id: Id01771a1c077b0e018b311983e2d198733fec23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781303Reviewed-by:
-
Wei Lee authored
This CL removes all the usage of force-use-chrome-camera-app since we make CCA the default camera app started from R76. Bug: b/140463175, 953690 Test: Chrome can be compiled successfully Change-Id: Ib5430fc06c7c7420a3c04f21e3d0b5dbeeb4ec47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784023 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#693032}
-
En-Shuo Hsu authored
The change is related to CL:1765148 Add histogram information in histograms.xml to make the BT HFP wideband-speech packet loss stats visible on chromedashboard. BUG=chromium:961532 Change-Id: I04067b540c598a66a2c42959f8fbc66e016771cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781980Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: En-Shuo Hsu <enshuo@google.com> Cr-Commit-Position: refs/heads/master@{#693031}
-
Alex Danilo authored
CL:1599817 added horizontal scrolling to the directory tree, then CL:1617041 was required to help with positioning of the eject button for ejectable tree entries, then CL:1631535 fixed issues with positioning of Android app picker link caused by the scroll, then CL:1623649 fixed issues with the Polymer ripples being contained by the changes in use of CSS 'position', then CL:1710706, CL:1712350 and CL:1714391 corrected RTL rendering of the tree that was broken by the scroll change. UX review agrees that horizontal scrolling is unwanted. Undo the CSS/JS changes in the above set of CLs. Re-enable ripple effect on ejectable items in the tree by removing the use of 'visibility:hidden' on them. Bug: 660334, 992819, 965870 Tests: browser_tests --gtest_filter="DirectoryTree*Scroll*" Change-Id: I97a12c8da81f3e12040ec193f365c6ac944a4ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767456 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ad1bbf6e1e6..dffeb4a33ca1 Created with: gclient setdep -r src-internal@dffeb4a33ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I823b7744adb362e58ca4871e7a9852e5cd787151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784051Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693029}
-
Kent Tamura authored
This is a reland of d0b088a2 The difference from the original commit: Fix a decoded_data_document_parser.cc compilation error. Original change's description: > Move NavigationInitiator implementation from Document to a new class > > This CL reduces the esitmated pre-processed size of document.h > from 4.18MB to 3.05MB. > > Change-Id: Icf6ed523ace7f7ed827861b3fdb5b81923ed16cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782210 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693003} Bug: 242216 Change-Id: I09c8915b9e6a08967b558751bb93d5171e00d171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782406 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#693028}
-
Matt Falkenhagen authored
Change-Id: I3f6c46258741591eaa49137608b3434aefa396a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782376 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#693027}
-
pliard authored
This behavior causes the attached bug where serial devices get detached from the host. This behavior isn't going to work in general as unclaimed devices on ChromeOS are still claimable through webusb for example. This means that devices should get attached to ARCVM on demand/user decision rather than on connection. BUG=1763558, b:123374026 TEST=CrosUsbDetectorTest Change-Id: I3aa40bfb08bb2ce61ddb6c3ff47efffe0781b728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772783Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Auto-Submit: Philippe Liard <pliard@google.com> Commit-Queue: Philippe Liard <pliard@google.com> Cr-Commit-Position: refs/heads/master@{#693026}
-
Kuo Jen Wei authored
Bug: 955587, 994042 Change-Id: Ib01b012dac01b3b1afe086eb70260f8473731621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782373 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The test was using RunUntilIdle() to run the tasks posted to the IO thread as well as the database thread. It's better to use explicit RunLoops so it's clear what tasks are being waited on. This also helps remove the requirement in tests to set the database thread to the UI/IO thread[1], which will help unblock creating StoragePartitionImpl for tests, which will help unblock ServiceWorkerOnUI. As part of that direction, the CL also changes the test to use the database task runner explicitly when needed. However many other tests also use RunUntilIdle() like the background sync tests and depend on it to pump the database tasks, so I might not complete this work fully. [1] EmbeddedWorkerTestHelper's constructor creates ServiceWorkerContextWrapper and does: scoped_refptr<base::SequencedTaskRunner> database_task_runner = base::ThreadTaskRunnerHandle::Get(); wrapper_->InitOnCoreThread(..., std::move(database_task_runner), ... Bug: 1000141 Change-Id: I61efe2925a33b2b1afd62c407caee4c373476ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782458Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693024}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6be3ea7a7d72..e054ff2683ba git log 6be3ea7a7d72..e054ff2683ba --date=short --no-merges --format='%ad %ae %s' 2019-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 050ceed1..248662b1 (455 commits) Created with: gclient setdep -r src/third_party/skia@e054ff2683ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:None Change-Id: Ia8f52e41cc6f0f76dbfb4597c57bed767cfd8155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783807Reviewed-by:
-
Patrick Monette authored
With this interface, a class will be able to observe shared workers as they start and stop running, and be notified when clients connect to running instances. Bug: 993029 Change-Id: I469e937eb04cd7948e9888ba406c93c1b8cebbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762921Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Charlene Yan authored
Bug: 985382 Change-Id: I67f4df0176f802901ef08860f312f02d0bd18ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774312Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693021}
-
Marijn Kruisselbrink authored
This reverts commit 0f39ef65. Reason for revert: unrelated to the failures, test is still failing after the revert Original change's description: > Revert "[NativeFS] Change settings exceptions site list to read only." > > This reverts commit b203a35a. > > Reason for revert: suspected to break some browser_tests: see > - https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/82842 > - https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20CFI/builds/14865 > > Original change's description: > > [NativeFS] Change settings exceptions site list to read only. > > > > Actually being able to add/edit the list of blocked sites (other than removing > > existing blocks) from chrome://settings/content/filesystem behaves weirdly > > and doesn't actually match what other settings are doing. So instead use > > a read-only list. > > > > Bug: 999753, 999754 > > Change-Id: Ic06129dcaeda380cc734154dbf6926fb19618968 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779577 > > Reviewed-by: Dan Beam <dbeam@chromium.org> > > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#692874} > > TBR=dbeam@chromium.org,mek@chromium.org > > Change-Id: I0394389f87d9640b7e76b9f9460046c45aea88aa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 999753, 999754 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782375 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693013} TBR=dbeam@chromium.org,mek@chromium.org,yhirano@chromium.org Change-Id: Ib6e119881662967f84f4e4211c7bbd64911c8dd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999753, 999754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783715Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693020}
-
Maksim Sisov authored
Instead, we delegate creating the input method to OzonePlatforms. And if the linux ui set self as the factory, the ozone never creates a context factory and uses GtkUi impl, which is no-op for ozone. Bug: 1000127 Change-Id: Ie9c3723454aeed586c2e1d4df66ef26e8fdb9b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781459Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#693019}
-
Lily Chen authored
Display a warning message in the console when SameSiteByDefaultCookies is enabled and a cookie without a SameSite attribute (which is defaulted into Lax mode) gets sent on a request with an unsafe method. (This will happen if the cookie is less than 2 minutes old, as a temporary intervention to avoid breaking POST-based auth flows.) Bug: 990439 Change-Id: I0776acb18c829c06cfc2eab7d5a69da05a6c44d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779278Reviewed-by:
-
