- 20 Aug, 2020 40 commits
-
-
Tina Wang authored
The condition of showing the secondary message was set incorrectly. Bug: 1119859 Change-Id: Ifddaa442877f5219571b0fac0971a370be4e7303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366116 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#800200}
-
Ella Ge authored
It should be "Digital asset link". TBR=peconn@chromium.org Bug: 1109609 Change-Id: I59b5eb75493bdf884308ea98fcd7404ade060e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366285Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Auto-Submit: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#800199}
-
Caroline Rising authored
Create new mojom API to communicate between web ui and the browser process. Add ReadLaterPage handler which implements the read_later.mojom interface and ReadLaterUI. Bug: 1109316 Change-Id: Icc9b567bc7b1486f9a295c6e8f66a843190ee912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349981 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#800198}
-
Russ Hamilton authored
This method is needed so that we can leverage the filter for rate-limiting and deduplicating metrics on a per-report basis. Bug: 1112787 Change-Id: I230f06eff4c00479387ad1dcc88bf51a3a2034e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363688Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#800197}
-
Lei Zhang authored
OS_APPLE means OS_MAC or OS_IOS. Since OS_IOS is disallowed in chrome/, it makes more sense to use OS_MAC in chrome/ instead of OS_APPLE. Replace existing OS_APPLE usage with OS_MAC, and add a presubmit to check for OS_APPLE usage. Change-Id: I539f062f5f82a93dcbd861501421977e4f027517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365434Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800196}
-
Evan Stade authored
Regressed in f0fc9ffb. activity_bar_activity_bg.xml can be removed completely as it only existed for a pre-K workaround. Bug: 1119675 Change-Id: I9c22de1e769c743600afe4fa1a8de8cd9913ea19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366573 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#800195}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: I29c127303dfd816f5237bf3ea05cb4bb9a40cf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364821Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800194}
-
Liviu Tinta authored
During ScrollUnification, scrolling was moved to the compositor thread. CompositedScrollingMetricTest tests need to be updated to reflect this so they pass when the ScrollUnification flag is on. Bug: 1086625 Change-Id: Ib70f4830d8007463228f9dd9b1ac41318b4bada9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364055 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800193}
-
Tanmoy Mollik authored
This cl creates the SyncErrorCardPreference and resources that will be used by ManageSyncSettings. The onClickListeners for the buttons in the preference will be added on a separate cl. The button clicks will be handled by ManageSyncSettings. Screenshot: https://crbug.com/1107420#c2 Bug: 1107420 Change-Id: I13b22baefee474051cbb779c6eecfe4c40e3cb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339323 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800192}
-
Yifan Luo authored
This CL intends to create a prototyping Sanitizer API (https://github.com/WICG/sanitizer-api) at very beginning level. Change-Id: I7327a3440d544b61becd81f4c9b058ee4823ffc4 Bug: 1116418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346252 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#800191}
-
Jose Dapena Paz authored
These operators fail to build in GCC as the mojo StructPtr operator-> is not constexpr either: ../../components/performance_manager/v8_memory/v8_per_frame_memory_decorator.cc:60:13: error: call to non-‘constexpr’ function ‘mojo::StructPtr<S>::Struct* mojo::StructPtr<S>::operator->() const [with S = blink::mojom::PerFrameV8MemoryUsageData; mojo::StructPtr<S>::Struct = blink::mojom::PerFrameV8MemoryUsageData]’ 60 | return a->frame_token < b->frame_token; | ^~ ../../components/performance_manager/v8_memory/v8_per_frame_memory_decorator.cc: In member function ‘constexpr bool performance_manager::v8_memory::{anonymous}::SortByToken::operator()(const PerFrameUsagePtr&, const LocalFrameToken&)’: ../../components/performance_manager/v8_memory/v8_per_frame_memory_decorator.cc:65:13: error: call to non-‘constexpr’ function ‘mojo::StructPtr<S>::Struct* mojo::StructPtr<S>::operator->() const [with S = blink::mojom::PerFrameV8MemoryUsageData; mojo::StructPtr<S>::Struct = blink::mojom::PerFrameV8MemoryUsageData]’ 65 | return a->frame_token < b.value(); | ^~ Bug: 819294 Change-Id: I4dbd8ee5f1f4b00b19a21777c4c8c93fdd7f6f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367038Reviewed-by:François Doray <fdoray@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#800190}
-
Mason Freed authored
This previously had no use counter. I'm adding NOTRY here because branch day seems to be an impossible day to land changes to enums.xml. Hopefully this sails through. Feel free to revert if this breaks something. NOTRY=true Bug: 905922 Change-Id: I613782dc839a9afc9bce93406200557e4f81c024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363361 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#800189}
-
bttk authored
Bug: 1067118 Change-Id: Ieaa8deb577c0b7bfc55c3d6999b4ebcabfe96808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363223Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
-
Tao Wu authored
Change-Id: I2928f064f9948975d4b54e25d461ebefbbecf924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367114Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#800187}
-
David Bokan authored
This CL fixes a regression introduced in https://crrev.com/f888178b082f. In that CL, we enabled the "external" page scale factor propagation from the top level frame, that previously occurred only for OOPIFs, to also propagate to nested widgets like GuestViews and Portals. When an UpdateVisualProperties call is made on a child frame, we now update the external scale factor on these widgets. For the top level frame, we added a step to reset the external page scale factor; a top-level frame should never have an external scale (since it's top level, it has no parent which could scale it). However, the CL above made a mistake by also resetting the "from mainframe" page_scale_factor and is_pinch_gesture_active for the top- level frame. This is a mistake because these values are not exclusive to child frames like the external PSF. These values are used to decide to whether to propagate the PSF to child frames after a visual update; by resetting it to 1, when the PSF really was reset to 1, we'd avoid propagating that fact to the child frames, leaving them rastered at the previous scale. This CL removes the reset of these members to fix the issue. We also add comments and rename them to make their operation clearer. Bug: 1115900 Change-Id: I055abbe37cb3432ff85ef597ce89248023cd9be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363810Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800186}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/08a42d0acc75..7161209ef6f1 2020-08-20 ahassani@chromium.org cros_update: Delete it. 2020-08-19 mmortensen@google.com query_build_logs: Use += for append; use -n/-z rather than !-n/-z. 2020-08-19 dburger@chromium.org Enable CPE uploads for full builders. 2020-08-19 mikenichols@chromium.org upload_symbols: Modify failure logic for debug symbols 2020-08-19 cjmcdonald@chromium.org depgraph_visualization: Don't pass argv[0] to parser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I56f90cced7203761b433605dadebb1ff1dd15963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800185}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f2f2631. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f4e154cc "Origin isolation: finish off popup test coverage" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I852843ca837d22978370968e3eeceefc15867582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366284Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800184}
-
Nate Fischer authored
No change to logic. This unhides the setSafeBrowsingWhitelist boundary interface for the WebView AndroidX library. Bug: b/161949076 Test: Run AndroidX tests against local build Change-Id: I5cd39b09accce6819b8cd4f3f49a3416de40afd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354994Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800183}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81f4ba7e7dbf..87a7605160fd 2020-08-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0cc33b4a2813197f187fa299b544ff02aac8ec69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367019Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5be2204fa998..8c58b2beba89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mohsen@google.com,hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mohsen@google.com,hendrich@google.com Change-Id: I3d1632e349a48411261ad734a2518ec1fd12b4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367173Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800181}
-
Jeff Yoon authored
Not all EG2 tests run with xcode-parallelization. This is an arg that's primiarily used with simulators. Downstream, eg2 tests are also run on devices. Because simulators are defined in testing/buildbot, and because the xcode-parallelization arg is bound to platform and version (both defined by simulators), we move this arg down to testing. * Introduced support for mixins one level above variants such that a mixin defined here applies to all variants below. * Removed the --xcode-parallelization arg in the GN EG2 iOS template. * Added xcode-parallelization for all test targets that ran through the eg2 target upstream. Bug: 912681 Change-Id: Ie5cb45a14be0ecbb6fb64b7c8af6eea6f49df94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364031 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800180}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b36c2d9991f1..aef2982079e5 2020-08-20 sigurds@chromium.org Surface more info about security and isolation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If7b70a94969906a696e15ba540b3db6d86a6f2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367174Reviewed-by:
-
ckitagawa authored
|mInitialScaleFactor| causes scrollable subframes to their width to fit the size of their clip rect. This is not desirable, instead the subframe should inherit the current scale factor of their parent. Bug: 1099722 Change-Id: I0a45d52a59239b59a30d08349748ae80688c577c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363775 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800178}
-
Regan Hsu authored
Impacted - Arabic: https://nimb.ws/VMt1LI Hebrew: https://nimb.ws/f36byI Reference (unchanged) - English: https://nimb.ws/XFKJwq With regard to the placement of the dropdown - * left:0 is not needed at all - it is ignored in both ltr/rtl and struck out in the inspector. * right:0 causes the iron-dropdown to align to the right hand side of the window for rtl languages With regard to the click-ability of the burger icon * In rtl, #leftSpacer is covered by #centeredContent, so the burger icon is not clickable because #centeredContent is set at width 100% to accurately center the search box in narrow mode. A z-index of -1 is applied to #centeredContent narrow mode in order to place it beneath the #leftSpacer. #centerContent was set to 100% in order to avoid the use of CSS translate transform, which would remove the need for a child to be centered based off the positioning of its parent which varies since OsToolbar shifts based off of the width of the window. Using that property was hard to follow, so I decided against it in [1]. * The width of the #leftSpacer is shrunk to 20px in narrow mode so that it does not overlap with the OsSettingsSearchBox in any width, so that any part of the CrToolbarSearchField is clickable. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2337277 Bug: 1119638 Change-Id: I5c609f68b4ad0a8d4c4b89b12b1cf4dcc2a1d06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365974Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800177}
-
Guido Urdaneta authored
Bug: 1114029 Change-Id: I732e4c3c1820aec2c6b6cd1aa5fee3b52dae98b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367078Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800176}
-
Danila Kuzmin authored
Bug: 1084447 Change-Id: Ifb3ac180c673fff6de349018e649cd0f1d67f847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364615Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#800175}
-
Changwan Ryu authored
Bug: 1094366 Change-Id: Id07f37da45219bfdfffc7cc9ccdae60c97c1df01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365227Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800174}
-
Angela Yoeurng authored
Bug: 893183 Change-Id: Ib8eea4c29e68ec0483c1f97522ac516e6d18fb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360416 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#800173}
-
Kenneth Russell authored
This reverts commit b7c98d05. Reason for revert: assertion failures on Intel GPU bots per https://bugs.chromium.org/p/chromium/issues/detail?id=1119491#c4 Original change's description: > Work around where BRGA8 overlays are supported but not reported. > > On Intel GPUs where YUV hardware overlays are supported, BRGA8 > overlays seem to be supported, but the system fails to report > that. > > BUG=1119491 > TEST=manual, gpu_unittests > R=magchen@chromium.org > > Change-Id: I304aef3731f142c13c945ca22ce0df81afbcd21d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364580 > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Maggie Chen <magchen@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799901} TBR=zmo@chromium.org,sunnyps@chromium.org,magchen@chromium.org Change-Id: If3f17c4fcab42d31a8285d55ca20c5a24808dbae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367116Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800172}
-
Mohsen Izadi authored
This reverts commit a89614a1. Reason for revert: Seems to be causing heap-use-after-free failures on Linux ChromiumOS MSan/LSan/TSan builders: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20296 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38328 Original change's description: > Add time loading reporter for Chrome OS views-based multiprofile > > Bug: 1066489 > Change-Id: Iceeaee0f33dff50d75361d1f14e14299a37a0830 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292477 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800055} TBR=antrim@chromium.org,asvitkine@chromium.org,rsorokin@chromium.org,tellier@google.com Change-Id: Iaae1e4466b6b5ac06f609efacc2f02398ab27fd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367193Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800171}
-
Karel Král authored
Implement initializer list support for creating arrays and dictionaries in TracedValue::Build. Thus speed up adding debugging tracing of multiple parameters, including container types. Reland with fix the problem of: crrev.com/c/2346286 by keeping a copy of a std::string instead of just keeping a reference to it. Bug: 1043616 Change-Id: I731347c24eff278f6e0c47887267de4d280b654a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362657Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#800170}
-
Thomas Tellier authored
Bug: 1115024 Change-Id: I0a025910e4362c9a118d725293f7c5c2f477a33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362735 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
-
Caleb Raitto authored
Bug: 973801 Change-Id: Ie07f6fc6e2f86bcfc1c81ec49335cc3bcbf19c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363850 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#800168}
-
Yao Xiao authored
Add a new enum value HISTORY_DELETE to the FlocIdComputed_EventTrigger enum. When history is deleted, recompute the floc and log the event accordingly. Bug: 1062736 Change-Id: I236df7cc3246cef8f836de752d405e5c209e2395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364208 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#800167}
-
Matt Wolenetz authored
In preparation for moving the MediaSource core interface into the MediaSourceAttachment interface, this change factors out a necessary class for retaining the existing same-thread Oilpan collection of idle unreferenced attached HTMLMediaElement+MediaSource object groups. Specifically, adds MediaSourceTracer to specialize further in later changes in modules concrete implementations how to handle Oilpan tracing of an HTMLMediaElement and a MediaSource in same- versus cross-thread attachments. Includes same-thread concrete specialization in this change. Having this as a separate entity reduces complexity and fragility on both of those sides of the attachment. Note that a same thread non-oilpan concrete attachment cannot use "Member" since the attachment class is unmanaged. Hence the need for this MediaSourceTracer to encapsulate that "Member" linkage. BUG=878133 Change-Id: I4153ade37a1d4303af2604c2c2e18f701a79834d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363703Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#800166}
-
Stephen Sigwart authored
If you hover over the remove X, then quickly off the X and row, OnMouseEntered and OnMouseExited are not called on the row. This causes the row to display as focused and the X to show. You can also duplicate it by quickly sliding moving the mouse over the rows where the X button displays. Bug: 1109473 Change-Id: Ie5621f6e1d780d80ff46c34846856b3476f566f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333393 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#800165}
-
Ioana Pandele authored
The progress tracker is responsible for counting the credentials that have been processed by the check, as well as the number of credentials that are still to be processed. Since the bulk leak check tries to be as efficient as possible, it performs a deduplication step before starting to check passwords. In this step it canonicalizes each credential, and only processes the combinations that are unique. Since this number likely does not match the total number of saved passwords, the tracker updates the counts with the number of saved passwords that share the same canonicalized credential. TBR=andzaytsev@google.com Bug: 1102025, 1092444 Change-Id: I09dd04c0c563a70998e5a415956a619315d27656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363759 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800164}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d613f1e1be9..56d9df4fa53f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia6cd3d6444ec254ab00b7187828c577c4d60d849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366818Reviewed-by:
-
sauski authored
To provide additional insight into the of data collected in the Access Context Audit database, several UMA histograms are added: - Database size - Number of records - Unique cookie domain count - Unique storage API origin count - Unique top frame origin count Bug: 1101675 Change-Id: I2c8b6e309e74c98a56067796edc86b5a927fc967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358743Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#800162}
-
adamta authored
Adds IPH for top-level menu button of the Discover feed header in the NTP. Here is clip for the IPH appearing: http://shortn/_TejkyqTmah Bug: 1085419 Change-Id: I7a713d1e8cdb66fda3902ceb1f5db843bf414f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354904 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800161}
-
