- 30 May, 2014 40 commits
-
-
brettw@chromium.org authored
Rename "//ui/base:ui_base" to "//ui/base:base" to make it easier to specify BUG= R=jamesr@chromium.org Review URL: https://codereview.chromium.org/306113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273883 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
Having a library and an example both called nacl_io was confusing some tools (and some people). R=binji@chromium.org, binji Review URL: https://codereview.chromium.org/306973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273881 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
BUG=361862 TEST=power_LoadTest NOTRY=True Review URL: https://codereview.chromium.org/302003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273880 0039d316-1c4b-4281-b951-d872f2087c98
-
vkuzkokov@chromium.org authored
The previous version could cause race condition if for whatever reason ReleaseSoon finished releasing on another thread before we got to "foo = NULL" BUG= Review URL: https://codereview.chromium.org/301943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273879 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
TEST=ozone build BUG=377497 NOTRY=true TBR=dnicoara Review URL: https://codereview.chromium.org/308053006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273878 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
1. Fix registration in python prototype to work again 2. Fix sessions in python prototype to match current API on devsite 3. Fixed issue where "cyphertext" for sessions was going through double JSON serialization 4. Created empty session without encryption for testing purposes, this is different from the dummy session in that it is a complete passthrough BUG= NOTRY=true Review URL: https://codereview.chromium.org/306023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273877 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/303233008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273876 0039d316-1c4b-4281-b951-d872f2087c98
-
pastarmovj@chromium.org authored
This is the simpler version of actually making sure that even if it skipped it will not allow forced reenrollment to be circumvented. This option will be reintroduced in the first stable version to contain all other safeguards in place. BUG=378953 Review URL: https://codereview.chromium.org/306993004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273875 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
ProtocolHandlers are intended to handle all requests for a particular scheme, while UrlRequestInterceptors are intended to sit in front of ProtocolHandlers, and optionally take over handling of any request, regardless of scheme. Separating the classes removes some ambiguity and weirdness, particularly when passing a bunch of interceptors all over the place from content/ to chrome/ during initialization. BUG=373800 Review URL: https://codereview.chromium.org/282103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273874 0039d316-1c4b-4281-b951-d872f2087c98
-
engedy@chromium.org authored
The code was originally reviewed in: * https://codereview.chromium.org/62193002 * https://codereview.chromium.org/27030002 Since then, there have been some changes by others, but the bulk of the code is still my original. BUG=298036 Review URL: https://codereview.chromium.org/272763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273873 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://net-internals/#quicrjshade@google.com authored
Improve chrome://net-internals/#quic by linking QUIC connection ID to chrome://net-internals/#events&q=connection_id BUG= Review URL: https://codereview.chromium.org/306903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273872 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
content_browsertests ServiceWorkerVersionBrowserTest.SyncEventHandled TBR=jyasskin@chromium.org BUG=379204 Review URL: https://codereview.chromium.org/305103005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273871 0039d316-1c4b-4281-b951-d872f2087c98
-
perkj@chromium.org authored
This is to ensure that the webrtc::VideoSource is destroyed before the PeerConnectionFactory is destroyed in RenderThreadImpl::ShutDown. COLLABORATOR=tommi@chromium.org BUG=378179 Review URL: https://codereview.chromium.org/299313011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273869 0039d316-1c4b-4281-b951-d872f2087c98
-
eustas@chromium.org authored
BUG=373325 Review URL: https://codereview.chromium.org/305013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273868 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
Prevent extensions with <all_urls> from running content scripts without user consent if the scripts-require-action switch is on. BUG=362353 Review URL: https://codereview.chromium.org/288053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273866 0039d316-1c4b-4281-b951-d872f2087c98
-
dtrainor@chromium.org authored
Build a LoadURLParams object from the OpenURLParams and properly set all parameters on that object when calling into NavigationController. This makes sure we set the correct state for the load. BUG=352083 Review URL: https://codereview.chromium.org/267253007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273865 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
Connect the scattered DLOG(ERROR) to also send an error message to WebRTC Log. Also log the type of API in use: QTKit or AVFoundation. BUG=b/14652504 Review URL: https://codereview.chromium.org/308813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273863 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
We shouldn't include the ppapi_tests dependency when enable_plugins=0 is true. In fact, we should probably get rid of most of the ppapi dependencies in that case, but this change fixes a regression on one of the builders. BUG=379018 R=dmichael@chromium.org Review URL: https://codereview.chromium.org/308703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273862 0039d316-1c4b-4281-b951-d872f2087c98
-
pbos@chromium.org authored
Adds isolate mapping for video_engine_tests and webrtc_perf_tests in build/android/pylib/gtest/setup.py so that they are detected by test_runner.py. BUG=webrtc:2462, webrtc:3423 R=kjellander@chromium.org Review URL: https://codereview.chromium.org/307003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273861 0039d316-1c4b-4281-b951-d872f2087c98
-
dmichael@chromium.org authored
This makes a specialization of base::DefaultDeleter so that scoped_ptr will use Destroy() instead of the destructor. Without this, it seems wrong to hold VideoDecodeAccelerator in a scoped_ptr, given that letting scoped_ptr delete it via the destructor would be an error. Also moves the destructors to protected, to prevent mistakes. BUG= Review URL: https://codereview.chromium.org/292183011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273860 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
We already blow out the command-line length limit on one of the bots. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/304293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273859 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Previously, source sets would be inherited up the dependency chain up to shared library or executable boundaries. But if there is a static library in the middle, it will include the code from the source set and the resulting shared library or executable will get the source set's code twice. This patch stops inheriting of source sets at static library boundaries, since the static library will include the source sets's code. BUG=377890 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/301243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273858 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
BUG=358764 TBR=scottmg Review URL: https://codereview.chromium.org/305653008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273857 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
BUG=372528 Review URL: https://codereview.chromium.org/302893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273856 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
The write_file function should only actually update the file contents if the contents have changed to avoid unnecessary rebuilds of targets that depend on the written file. R=thakis@chromium.org Review URL: https://codereview.chromium.org/301973005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273855 0039d316-1c4b-4281-b951-d872f2087c98
-
wjmaclean@chromium.org authored
In an effort to simplify zoom, this CL removes ViewMsg_SetZoomLevel and plumbs zoom on WebContentsImpl directly through to HostZoomMap. At present calls to WebContents::SetZoomLevel() invoke up to three cross-process IPCs, and introduce a synchronization requirement for any caller that needs to block until the results of the operation are visible via WebContents::GetZoomLevel(). This CL simplifies this down to one IPC and removal of the synchronization requirement. It adds a new IPC message to signal changes in a view's ability to be zoomed, and removes an ViewMsg_SetZoomLevel that was used only by SetZoomLevel(). BUG=none Review URL: https://codereview.chromium.org/287093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273854 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
Doing so caused us to ignore stored content settings for pages accessed via https if a page had been accessed, settings changed and then the page accessed again. BUG=374393 R=xians@chromium.org Review URL: https://codereview.chromium.org/304183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273853 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
Introduce the HistoryClient interface that will abstract the embedder for the history component. The implementation in //chrome ChromeHistoryClient owns the HistoryService and implements the KeyedService interface. BUG=371825 TBR=sky, zea Review URL: https://codereview.chromium.org/305443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273846 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
This fixes the naclports bundled version of libfreetype by removing the bzip2 dependency. R=binji@chromium.org, binji Review URL: https://codereview.chromium.org/308043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273845 0039d316-1c4b-4281-b951-d872f2087c98
-
bengr@chromium.org authored
Update UMA to track bypasses due to 4xx responses that are missing the proxy's via header and bypasses due to network errors. BUG=376148 Review URL: https://codereview.chromium.org/298883011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273839 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
Record word break information for the first 200 characters in a URL or title, not the first 50 characters. This is important because we generally drop URL suggestions that we think do not match at a word break. Tested locally on a longer URL from the bug. TBR=sky (because this change is trivial) BUG=291294 Review URL: https://codereview.chromium.org/306963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273837 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273835 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=302040 R=thakis@chromium.org Review URL: https://codereview.chromium.org/296173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273830 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
alarm, commands, declartive, storage api and extension_gcm_app_handler. Also, removed unwanted extension:: namespace prefix. R=rdevlin.cronin@chromium.org BUG=376293 Review URL: https://codereview.chromium.org/299393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273829 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
Revert due to test failure. See http://crbug.com/303491#c97 for details. > Re-enable PDFExtensionTest.BasicPlugin > > This test was disabled because it was failing. A few changes have been made: > -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. > -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. > -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). > > BUG=303491 > > Review URL: https://codereview.chromium.org/290803007 TBR=raymes@chromium.org Review URL: https://codereview.chromium.org/303163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273828 0039d316-1c4b-4281-b951-d872f2087c98
-
pbos@chromium.org authored
Adding new-API files to libjingle.gyp to prevent linker errors when submitting wiring up the API into libjingle. R=ronghuawu@chromium.org BUG=webrtc:1788 Review URL: https://codereview.chromium.org/301793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273827 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Previously we've abused .volume_id for the purpose, but now we have a dedicated field for the volume name. Now the .volume_id field can be arbitrary human unreadable string, but I'd like to keep it as in the current form since there's also no other reason to make it cryptic. BUG=none Review URL: https://codereview.chromium.org/305053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273826 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
I recently fixed some places which passed empty URLs around (r272182), and these tests might have been failing because of the empty URL behavior (empty URLs were treated as the home page, and maybe the home page is something different on the official Mac builder than other builders). Feel free to revert this commit if the tests fail. R=bartfab@chromium.org TBR=sky@chromium.org BUG=314819 Review URL: https://codereview.chromium.org/308083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273825 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
Reverting due to failing tests. See http://crbug.com/370039#c5 for details. > Added alternative configuration for the data reduction proxy > > Added a second configuration that can support two http proxies and one https proxy. In the process, added a new DataReductionProxyParams object to encapsulate static configuration details and made DataReductionSettingsAndroid a BrowserKeyedContextService. > > BUG=370039 > > Review URL: https://codereview.chromium.org/286013002 TBR=bengr@chromium.org Review URL: https://codereview.chromium.org/307013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273824 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@chromium.org authored
This implements the function which sends certain key events to the PDF plugin. This allows the document to be scrolled even when it isn't focused. BUG=303491 Review URL: https://codereview.chromium.org/282113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273823 0039d316-1c4b-4281-b951-d872f2087c98
-