GitLab

On lower-end devices, given a very long, complex utterance, the first call to
GoogleTtsReadBuffered can take time enough to underflow the SyncReader and cause
an udnerrun.

This manifests itself by the first few chunks of the tts playback being dropped
entirely. No stuttering occurs though as playback is smooth the rest of the way.

Therefore, a reasonable fix that works on-device is to pre-fetch the first
buffer prior to starting audio playback for the utterance.

Within the critical path (TtsService::Render), we can simply use the cached
buffer and only call into read buffered for subsequent chunks, which is fast.

R=dmazzoni@chromium.org

Change-Id: I6bb049d3e8b487af11ca7f34d7ef7b7f82627792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464067
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815828}

In Capture Mode, when a user makes their own capture region the
dimensions label shows always.

This CL makes it so the label only shows when the region is non-empty
and the user is resizing the region, matching the spec.

Test: manual + modified existing test
Bug: 1136324
Change-Id: I56578d7f735f0c09ace6298f5b3172cbeedb5f47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462177
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815827}

This reverts commit 3d00c8a1.

Reason for revert: Likely causes webgl2_conformance_gl_passthrough_tests to fail.
Example builds are:
* https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20Release%20%28NVIDIA%29/19363
* https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20(AMD)/23905

Original change's description:
> Update V8 to version 8.8.64.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/07b0b1dc..e4ed803f
>
> Please follow these instructions for assigning/CC'ing issues:
> https://v8.dev/docs/triage-issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
>
> TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
>
> Change-Id: Ifcadac29a122c1a22c5ab749e372d066e09aceee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463662
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#815717}

TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I15080d2e1e2e1c64ab8e631c4f8998be7fa0f4a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464150Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#815826}

If the service has a matching port with a receive right in userspace,
the task with the receive right owns the lock. If the service is not
assigned, the lock is free.

This implementation polls to attempt to acquire the lock, using a
constant service name and constant polling interval. Further development
could fetch these values from another source of truth (a file of
constants, compiler macros, options loaded at runtime, etc.) or use
bootstrap_look_up and mach_port_request_notification to find the owner
of the lock and wait for the lock to be released.

This change includes two broad changes to preexisting unit tests, due
to issues revealed with those tests while developing this CL:

* app_server_unittest.cc included tests where the AppServer lived
  in the same scope as test code that generates a reference to the
  Global Prefs Object, which requires the prefs lock. This results in
  deadlock with a non-reentrant implementation of a prefs lock, since
  the AppServer owns that lock at that time. This CL introduces scopes
  to deallocate the AppServer instance before the test itself grabs
  the global prefs lock.
* prefs_unittest.cc marked out all the lock tests as Windows-only. Now
  that there is a Mac lock, this limitation does not need to exist.
  However, one of its tests explicitly checked that the lock supports
  reentrancy within a thread (while another verified that it bans
  reentrancy across threads). This test has been deleted, after
  discussion with teammates where we decided that a non-reentrant lock
  is desired.


Change-Id: I513cb67d1c3a12b2b0c01b532a9af10ae2233530
Bug: 1135692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453800Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Adam Norberg <norberg@google.com>
Cr-Commit-Position: refs/heads/master@{#815825}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I85e324ec83076de031b3aa0fed81aa4b7de6b755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463785Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#815824}

This CL adds a data dependency on the //third_party/soda directory
for the Speech On-Device API (SODA) unit and browser tests as they
both require files in the SODA directory.

Change-Id: Ifba311f47c8ecdfdf8e44b82bb2d85220bd2e69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462549Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#815823}

The enum class ash::WindowTypeState is used in the definition
of ash::kWindowStateTypeKey window property. This property is
needed by code in //ash/public/cpp/caption_buttons/frame_size_button.cc.

In order to move the later to //chromeos/ui, the property needs to be
moved. In order to move the property, the enum class needs to be moved too.

This CL moves window_state_type.cc|h to //chromeos/ui.

BUG=1113900
R=jamescook@chromium.org, sky@chromium.org

Change-Id: Id7c1e64fafff0182d4843513e5697bc5c463aeee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456289
Commit-Queue: Antonio Gomes (use @igalia instead) <tonikitoo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815822}

This CL updates the tab strip's UpdateNewTabButtonBorder() method to
apply the vertical border insets to the tab control buttons rather
than the tab controls container.

This is necessary as the NewTabButton will extend its targetable
area to the top of its bounds when the tab strip is in a condensed
state (i.e. the window is maximized). This is done to ensure the
tab strip controls comply with Fitt's law expectations.

Bug: 1136557
Change-Id: I8b312363bdabbef358ec2689321bb30d7680953b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463994
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815821}

A recent change intentionally stopped caching SkImage readbacks.

This benchmark results in a single video frame being requested multiple
times, forcing multiple readbacks into CPU memory. This is not
representative of a real world regression, as applications are expected
to cache any uploaded WebGL textures themselves.

See discussion on bug for more details.

Bug: 1115128
Change-Id: I4de6fc4bfb82f5c6baf1778342f2c4c9bfc0c3cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437470Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonah Chin <jochin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#815820}

For methods called by native it's easier to declare the
function as throwing a RemoteException.

BUG=none
TEST=none

Change-Id: I2a5aa0caa2b683312390ff6d941cfe534a997fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463967Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815819}

Both of these tests are inherently flaky because they rely on events in
the native system that we can neither observe nor wait for completion
of. Specifically:

* OrderFrontAfterMiniaturize relies on being able to figure out when a
  miniaturize is complete, which it attempts to do by sleeping for 2
  seconds; this obviously causes flakes depending on bot load
* VisibleAfterNativeParentShow depends on [NSApp hide:], which has
  different behavior depending on whether other unit tests are running
  in parallel; this makes the test inherently flaky

The latter *could* be rewritten as an interactive UI tests instead, but
I think it does not test anything of value compared to the similar test
at the Widget layer.

Bug: None
Change-Id: Ida502a4ee839fbe764af73eff1df08631e450838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463993
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815818}

On Android 11, setGravity is deprecated. For text toasts is noop.
Therefore, create toast from a custom view, for which setGravity still
works. This is a short term solution.

Bug: 1135597
Change-Id: I8fc9c85df4b5f749b6e0d0781cee4b8963460c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460971
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815817}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99db0de96759..6dc612511e7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC lukasza@google.com,flackr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1122784,chromium:1136968
Tbr: lukasza@google.com,flackr@google.com
Change-Id: Ia0d5adcc90d464420f6498eef7facecf7384faaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463926Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#815816}

This reverts commit 32b6222e.

Reason for revert: Seems responsible for test failures/crashes below:

ShareServiceUnitTest.FileCount (modified by the reverted CL) crashed on 
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/50136


ShareServiceUnitTest.Multimedia (hmm... not modified by the reverted CL) crashed on 
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/50135

Original change's description:
> WebShare: Share implementation for Windows
>
> Finishing the implementation for navigator.share() on Windows.
>
> Updating the existing tests for basic exercising of this functionality
> and adding new tests for the Windows-specific functionality checks.
>
> Bug: 1035527
> Change-Id: Ibc2c50e85109fd1739124c40966b353c5db2c00f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443757
> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815706}

TBR=ericwilligers@chromium.org,ajgo@chromium.org,mhochk@microsoft.com

Change-Id: I9dd866d3c1cc925d20da94974e5ad8fe7018b99e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1035527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463071Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815815}

BUG=1106937,1126208

Change-Id: Ibb9cfbc40f19d45d34082289d1cd999507e36ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461605Reviewed-by: Andre Le <leandre@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815814}

We have different cache status when an attempt is made to fetch a
force installed extension from it during the downloading process.
We want to add download cache status event to the existing events for
the event based reporting for force installed extensions.

Bug: 1048640
Change-Id: Ib12adfcde9052714a15829e9ef1a0462f24383df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460899
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815813}

In r778991 (7203e2f8, https://crrev.com/c/2242233), we added a data
dependency on args.gn to the blink_web_tests, so that we could detect
if the build had dchecks enabled and adjust the test timeout accordingly.

Now that the tests are configured and launched by the generated
bin/run_* wrappers, we can push that logic into the wrapper script from
the build, and not require args.gn to be a data dependency.

This allows builds that differ only by things in args.gn that don't
affect the build (e.g., comments, or goma/no-goma) to share the same
isolate, and helps improve build determinism.

The blinkpy code will still optionally look in args.gn if it is
present to determine a default value; this allows devs to still get
the right value if they invoke run_web_tests.py directly locally,
rather than using the bin/run_ wrapper.

Bug: 1135151
Change-Id: If11ce12fc6bb47e0673d604e96ce130353e83cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462762
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815812}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I06fd1b13f42880bdd701b882ad9cbc4cc64bf29e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463925
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#815811}

https://chromium.googlesource.com/openscreen.git/+log/71f3a45238af..a3f46f23c526

2020-10-09 jophba@chromium.org Add build flag for self-signed certs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I10cfba299303dc622e78e7c45220fb536f7dd48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463748Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#815810}

This reverts commit dda82c9a.

Reason for reland: Fixed by adding missing deps to eu-strip.

Original change's description:
> Revert "[Lacros] Size dashboard: Track stripped size of ELF files."
>
> This reverts commit a4d34d8a.
>
> Reason for revert: This causes chromeos-amd64-generic-lacros-builder-perf to fail, likely due to missing eu-strip.
>
> Original change's description:
> > [Lacros] Size dashboard: Track stripped size of ELF files.
> >
> > This CL modifies lacros_resource_sizes.py to identify ELF files, and
> > also track their stripped sizes (using eu-strip) as well as compressed
> > stripped sizes. These news info are recorded for chrome and the Total.
> >
> > If eu-strip fails for a file then we simply ignore its stripping
> > results and print warning. Known-bad files include .nexe files and
> > libwidevinecdm.so. These are explicitly excluded to denoise the system.
> >
> > Bug: 1106626
> > Change-Id: I9cb47bb41baa2b73996e6662db2fe4bc537338d7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458869
> > Commit-Queue: Samuel Huang <huangs@chromium.org>
> > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#814972}
>
> TBR=huangs@chromium.org,erikchen@chromium.org
>
> Change-Id: I580c4ea4a125fef785cdb0c6de1c31846a7e8180
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1106626
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459794
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#814986}

Bug: 1106626
Change-Id: If0967507192c467bb4efbc7c57d7271628c60ac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463447
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815809}

If the Task Continuation multidevice feature is not enabled, clear
the mutable phone model's browser tab model. Otherwise, use the
cached browser tab model that is updated by the provider.

Bug: 1106937
Change-Id: I671542daa97f4ea4893ec8cc80fb2016d632f574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462553
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815808}

This is in preparation for adding client code in //chromeos which
refactors how the Nearby utility process starts up and shuts down. The
code needs to be moved to this directory due to the fact that //chromeos
cannot depend on //chrome.

Note that Nearby is indeed a Chrome OS-only feature, so this is a valid
location for this code (the old location in //chrome was a vestige of
when feature was in consideration to be implemented on other platforms).

See go/nearby-startup-shutdown-refactor for details.

Bug: 1130069
Change-Id: I2241b05c4d4171534b0e1469407d62e2ae329f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441025
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815807}

Currently it was enabled on Trunk for MV2 extensions.

BUG=896041

Change-Id: Id35c9f3acdbd37739b0079ce04987aaef48ab27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462686Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815806}

In BrowserView::MaybeInitializeWebUITabStrip(), we were previously
checking Browser::SupportsWindowFeature(FEATURE_TABSTRIP) to see if we
should initialize the WebUI tabstrip as well as the tab counter button.

However, this method returns false when in fullscreen mode, so if the
PC was put into tablet mode during fullscreen, the tablet tabstrip would
never get created. This affected tablet-enabled ChromeOS and Windows
devices as it was a BrowserView logic error and not platform-specific.

This CL replaces the call with Browser::CanSupportWindowFeature(...),
which should return the correct value for windows with tabstrips even in
fullscreen or immersive mode.

Bug: 1078612, 1110189
Change-Id: Ied7201dc84bef3c239f4ee9ded1ee97e26d9411e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464023
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815805}

Add a UIView whose background color changes to create a fade-in /
fade-out effect when revealing / hiding the Thumb Strip.

Change-Id: Ia7852dbce9ee152123430f3d79c4baf0d9fbe1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456807
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Reviewed-by: edchin <edchin@chromium.org>
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Cr-Commit-Position: refs/heads/master@{#815804}

https://android.googlesource.com/platform/external/perfetto.git/+log/0ad07c924552..815983783a76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I434dc271ab75801203109d67f10df32b45ba1677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463459Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#815803}

New type of trace event macros use proto fields, for uploading
background traces

TBR=ssid@google.com

Change-Id: I91e4d211ec46bd68eee3c238d8efccbd0f342329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454976Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815802}

For consistency with StructPtr and general developer expectations around
APIs named get(), this changes InlinedStructPtr to return a nullptr when
its internal state is NIL, rather than always returning a valid pointer.

Bug: None
Change-Id: Ia3e59af0374362b3a1e53b418b728336b99149c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461750
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815801}

This CL has no intended behavior change.

This is in preparation for providing a synchronous mechanism to query
interface versions.

Bug: 1136652
Change-Id: I2c9d73887b6cf95c874fbda565cede3256fc237c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462672
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815800}

Bug: b/161610050, 1107162
Change-Id: I3e6ee484b06b0e35a3a5fda55aba12e867f08d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462486Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/master@{#815799}

Bug: skia:10818

Change-Id: Iefc3a686b686da4b1287fa97c7684b541b2cfea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456291Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#815798}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I802199b89a886190bc7eebca5ccb9bf28868bf7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460834
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#815797}

The empty prompt label should be only shown to users who have not
pinned any files.
Also fixed function order in holding_space_tray

Bug: 1134393
Change-Id: I198e8420f27e5e4fe556a461197c29d00d5a9c48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459689
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815796}

This reverts commit f5d2f7eb.

Reason for revert: Suspected cause of crbug.com/1137028

Original change's description:
> Add metrics for thumbnail memory usage
>
> Adds two metrics logged every 5 minutes:
> * Per-thumbnail compressed data memory usage
> * Total compressed data memory usage
>
> The former has a sample for each thumbnail every 5 minutes, while the
> latter has exactly one every 5 minutes.
>
> Bug: 11261624
> Change-Id: I1595c6a6b771f73e3be9a5497d1cf6f6ec3d1af7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462685
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Dana Fried <dfried@chromium.org>
> Commit-Queue: Collin Baker <collinbaker@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815714}

TBR=rkaplow@chromium.org,dfried@chromium.org,collinbaker@chromium.org

Change-Id: I3c0532e5653c3240715a17c00b9aec69bc323e38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 11261624, 1137028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463488Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815795}

This avoids inclusion of existing logs on the system, which is required
when running multiple times during development and for future tests.

Bug: 1136681
Change-Id: Id7acb3d7890f71a5e9c2835bb5d7b6447e65be3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462635
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815794}

This avoids error prone null checks.

BUG=none
TEST=covered by tests

Change-Id: Ie0da15f3469c06d56b2feafa9e64ff74347201fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463806Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815793}

At least hundreds of tests show flakiness on CQ bot. After
some spot check, the CI bot is stable. So disable the whole
test suite on CQ.

Bug: 1131588
Change-Id: Ifa1e064ade0027a0d7f1baf508fc7b22a9acd67d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464022Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815792}

An extension may specify an invalid path in webview accessible resources
(such as a non-relative path or an URLPattern). This would lead to the
URLPattern parsing failing. However, WebviewInfo currently uses a
constructor that always expects this parsing to succeed.

Fix this by handling invalid inputs. Unlike other parsing failures, we
add a warning (rather than throwing a hard error) in this case. This is
because existing apps with non-trivial user counts use this.

Bug: 856948
Change-Id: Ia2087dcf079250d12a1bd6211d6424a03a8a24bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450952Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815791}

As our team size shrinks again, it sounds preferable to have all
of our senior contributors in the OWNERS file.

R=eroman@chromium.org

Change-Id: I8edcc646809c5109b5427b3d952852ddcfd63f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462463
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815790}

Please check the specs in the crbug.

Bug: 1128755
Change-Id: Ic5170b1e632bb54819a2336186dd1c9cc830203d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461177Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815789}