GitLab

This also shortens test length, which is always nice.

Bug: 859660
Change-Id: I83ec61d85b7629ebaa74514adddacc29a767535d
Reviewed-on: https://chromium-review.googlesource.com/c/1341001Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609051}

We need to reset GL_PIXEL_UNPACK_BUFFER in FeatureInfo initialization if it is
non-0. We should always do that regardless of whether or not the current decoder
exposes them, because with shared contexts it is possible that another decoder
uses ES3 whereas the current one doesn't.

Bug: 905519
Change-Id: I2c2f457fcdd76ca4812ac8d71c8f77d694506a57
Reviewed-on: https://chromium-review.googlesource.com/c/1340973
Commit-Queue: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609050}

R=scottchen@chromium.org

Bug: 901210
Change-Id: I04a20fe0b81d2ca599865ae664915d0cac060317
Reviewed-on: https://chromium-review.googlesource.com/c/1340872Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609049}

The previous implementation relied on autofill_agent finding forms, but
it is only interested in address and credit card forms. Instead, we call
the javascript function in CWVAutofillController to obtain all forms we
care about.

Also renamed delegate method from didFind to didScan since the former
implies that at least one was found but in many cases there are 0.

Bug: 905546
Change-Id: Ibb3144e767fe2257c20176d61315568cfde076cb
Reviewed-on: https://chromium-review.googlesource.com/c/1339322
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609048}

TBR=twellington@chromium.org

Bug: 888129
Change-Id: I184b0e86872093b249b1c7f729be75d55e1c355d
Reviewed-on: https://chromium-review.googlesource.com/c/1341023Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609047}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8e9be303b00b..cd22b3155708


git log 8e9be303b00b..cd22b3155708 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 alanbaker@google.com Catch branch condition being a type


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@cd22b3155708

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5c9f01a5e69c2d702434ce8ef6879050dddcf95f
Reviewed-on: https://chromium-review.googlesource.com/c/1340980Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609046}

Bug: 539572
Change-Id: I83ae6f7e74b29be928bd81d50704e59ec864394c
Reviewed-on: https://chromium-review.googlesource.com/c/1340600
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609045}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/721662b8ce13..6ec1a9198bde


Created with:
  gclient setdep -r src-internal@6ec1a9198bde

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibfe5ce71f92e799f8b5321cc6d820a2b5196e053
Reviewed-on: https://chromium-review.googlesource.com/c/1341019Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609044}

This reverts commit 8226b54c.

Reason for revert: The original bug is fixed.

Original change's description:
> Revert "Change Range::expand() to VisiblePosition-free functions for word and sentence"
> 
> This reverts commit 775938b6.
> 
> Reason for revert: need to revert this to revert r608849
> 
> Original change's description:
> > Change Range::expand() to VisiblePosition-free functions for word and sentence
> > 
> > This patch changes Range::expand() to call VP-free version of word and
> > sentence start/end functions, by hoisting the creation of VP from
> > the functions into itself. In this way we reduce the usage of functions
> > relying on VP.
> > 
> > Bug: 657237
> > Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1338719
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Reviewed-by: Kent Tamura <tkent@chromium.org>
> > Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#608855}
> 
> TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org
> 
> Bug: 657237, 906174
> Change-Id: I46b8df3cfd8ed7f7636f9ef1dabfa350168cb820
> Reviewed-on: https://chromium-review.googlesource.com/c/1340906
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608957}

TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org,eirage@chromium.org

Change-Id: Iad61aa1c53fc7225f9795a1aa0e5ff9cc0704bc2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 657237, 906174
Reviewed-on: https://chromium-review.googlesource.com/c/1340837Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609043}

Previously, the Japanese layout was not returned as the highest-prio
ASCII-capable layout because not all of the writing-system-keys produced
printable characters.  Specifically, the Backquote key is used as the
hankaku/zenkaku key to switch between half-width and full-width chars.

This cl fixes that by handling the Japanese/Backquote key as a special
case, and the keyboard map returns a descriptive string.

Bug: 891501
Change-Id: Ic473700866d711a532d3946be73ff5ec38db580a
Reviewed-on: https://chromium-review.googlesource.com/c/1340970
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609042}

Bug: 889029
Change-Id: I6e3fa2029dc9875fd742d84fea65ceb8c071c61f
Reviewed-on: https://chromium-review.googlesource.com/c/1333991
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609041}

Bug: 701684
Change-Id: I668646a89402851ec19acc8b11f0fbd979157eeb
Reviewed-on: https://chromium-review.googlesource.com/c/1334943
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609040}

Create a Finch experiment to turn on FCP++ metrics.

We will monitor the heart beat metrics to guarantee that FCP++ won't
introduce regressions.

Bug: 869924
Change-Id: I68b7e446c4e49bc173dc1eccf6e88a9284f90bcd
Reviewed-on: https://chromium-review.googlesource.com/c/1336555
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609039}

https://webrtc.googlesource.com/src.git/+log/b5bb51306614..179a3923b9e4


git log b5bb51306614..179a3923b9e4 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 Peter) Slatala Implement TargetBitrate, NetworkRoute and overhead features of media transport interface.
2018-11-16 srte@webrtc.org Don't add empty extension list in event log parser.
2018-11-16 Peter) Slatala Fix data race in channel_send.cc


Created with:
  gclient setdep -r src/third_party/webrtc@179a3923b9e4

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6b9048c5bf8d5b011272f5f8ac99ebdc24e32cbf
Reviewed-on: https://chromium-review.googlesource.com/c/1340979Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609038}

WebglConformance_conformance2_context_methods_2 is failing sometimes on Linux Nvidia with
a GPU crash. Mark the test as flaky.

BUG=906212
TBR=kbr@chromium.org

Change-Id: I86bea7e01fde6b26b25d7fa27c8a9f41e5be9df7
Reviewed-on: https://chromium-review.googlesource.com/c/1340948Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609037}

Instantiate Domain Reliability code in NetworkContext so it works with and without the network service.

Bug: 853251
Change-Id: I34a5d73c7fe2e3500fe0d1b345f10c2433a7e202
Reviewed-on: https://chromium-review.googlesource.com/c/1338575
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609036}

This feature has been rolled-out for a while now and it's ready to
make it default.

Bug: 798612
Change-Id: Ib913bd62b6063c5a4d6986fd6125720c35b572a7
Reviewed-on: https://chromium-review.googlesource.com/c/1337438
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609035}

https://skia.googlesource.com/skia.git/+log/19ec80fb37ce..a2187bf7629a


git log 19ec80fb37ce..a2187bf7629a --date=short --no-merges --format='%ad %ae %s'
2018-11-16 mtklein@google.com port S32_alpha_D32_filter_DX to SkOpts
2018-11-16 caryclark@skia.org bookmaker error handling
2018-11-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c30f45d3f9c1..e4634a13a74d (5 commits)
2018-11-16 reed@google.com Reland "remove dead code around SK_SUPPORT_LEGACY_FONT_FLAGS"


Created with:
  gclient setdep -r src/third_party/skia@a2187bf7629a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: I5f9f9701617ce941b3124e96ec892391f18d0983
Reviewed-on: https://chromium-review.googlesource.com/c/1340577Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609034}

To support OOPR, we need switch from SkCanvas to PaintCanvas which is for
OOPR.

Bug: 895568
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286950
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609033}

Bug: none
Change-Id: I3c5f6e3aeea9bfb6b9c00be89b807c2a603cddac
Reviewed-on: https://chromium-review.googlesource.com/c/1340869
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609032}

This change makes a reprioritized SOCKSConnectJob pass down the priority
change to its underlying transport socket handle.

Bug: 166689
Change-Id: I5fdb0d9ea4e14b6ba6ec73925c9b2158791fa57d
Reviewed-on: https://chromium-review.googlesource.com/c/1329347Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609031}

This moves fields relating to:
 - Floats clearance
 - Fragmentation
 - Margin struts
 - Weird percentages

... to a rare data member. This decreases partition alloc usage on
system_health.memory_desktop by approximately 6-7%, at the cost of
0-6% on most benchmarks.

Change-Id: Ifaeaf5d874efcd13ce9eff785d8093d24637de86
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/c/1323803
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609030}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b33404f0931..a64e6d552792


git log 8b33404f0931..a64e6d552792 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 dgarrett@chromium.org Revert "workspace_stages: Create dual sync stage."


Created with:
  gclient setdep -r src/third_party/chromite@a64e6d552792

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib91ca4a8c9cf61de5615bfd5c94222cc50d63676
Reviewed-on: https://chromium-review.googlesource.com/c/1340397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609029}

This reverts commit 29a3a80a.

Reason for revert:
We still need to package asan for i686-android: https://crbug.com/906246

Original change's description:
> Roll clang 346388-1:346388-3
> 
> This picks up package.py changes #607265 and #608413. It does not change
> the version of clang.
> 
> It also includes a crazy workaround for msys binaries (in our case
> find.exe and mv.exe, used by lit tests) crashing during some unknown
> chrome infra problem (see last bug).
> 
> Bug: 870331, 905289
> Change-Id: Ic1d9fa64d6fcd4b590139c9343bed5bbe4d3faa3
> Reviewed-on: https://chromium-review.googlesource.com/c/1337614
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608776}

TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,mmoroz@chromium.org

Change-Id: I225d64bd4e166c0150d63cfa7ab0bad7e0dd92f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870331, 905289, 906246
Reviewed-on: https://chromium-review.googlesource.com/c/1340836Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609028}

Handle the case where the menu is not dismissed due to a drag sequence.
This was not handled gracefully, and resulted in a bad drag state on the
app icon.

finger. Then touch the screen somewhere else.

Example: Show a menu on an app icon via long press, don't release the
Bug: 876440
Change-Id: I8ebde0669aec7b7925fb1c855008cbfbaa8b3683
Reviewed-on: https://chromium-review.googlesource.com/c/1340822Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609027}

https://pdfium.googlesource.com/pdfium.git/+log/75d214c50d2f..a8b6376430de


git log 75d214c50d2f..a8b6376430de --date=short --no-merges --format='%ad %ae %s'
2018-11-16 thestig@chromium.org Use another enum class in CBC_PDF417HighLevelEncoder.
2018-11-16 thestig@chromium.org Use enum class in CBC_PDF417HighLevelEncoder.
2018-11-16 thestig@chromium.org More CBC_PDF417HighLevelEncoder cleanup.
2018-11-16 thestig@chromium.org Simplify fx_opj_stream_create_memory_stream().
2018-11-16 npm@chromium.org Improve JPX fuzzer
2018-11-16 thestig@chromium.org Slightly simplify CPDF_FontEncoding::Realize().


Created with:
  gclient setdep -r src/third_party/pdfium@a8b6376430de

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:903724
TBR=dsinclair@chromium.org

Change-Id: Ic5098a9f104a0caaabf4ebe41d55a048223dda2c
Reviewed-on: https://chromium-review.googlesource.com/c/1340398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609026}

Hopefully should have enough bots:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/linux-chromeos-compile-dbg

R=jbudorick, dpranke

Bug: 902468
Change-Id: I9273d96ede4c056d8bd4b936f5f843176bac087a
Reviewed-on: https://chromium-review.googlesource.com/c/1340536Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609025}

When the P2PQuicTransport's packet writer gets an error from the
underlying P2PTransportChannel, it will signal write blocked to the
QUIC library. In order to resume sending, the P2PTransportChannel
should indicate when it can start sending again.

This CL fixes two problems:
1) Changes the writable signal from SignalWriteState to
   SignalReadyToSend. SignalReadyToSend is signaled by the
   underlying IPC socket when a Send would no longer cause an
   EAGAIN.
2) Changes the IPC socket to fire SignalReadyToSend only at the
   very end of the IPC handler so that the listener can back in to
   the P2PPacketSocket safely.

Bug: 874296
Change-Id: I8276f60165928f77ca62243f3e5865897aa2cf6f
Reviewed-on: https://chromium-review.googlesource.com/c/1330299
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609024}

This reverts commit d8854b56.

Reason for revert: The original use-after-free is caused by storing part
of a temporary object into a reference:

const Position& sentence_end =
      EndOfSentence(range.EndPosition()).GetPosition();

This is fixed after changing the reference into a real instance.

Original change's description:
> Revert "Stop ExpandRange/EndToSentenceBoundary from using VisiblePosition"
>
> This reverts commit 390c941f.
>
> Reason for revert: causing layout test failure crbug.com/906174
>
> Original change's description:
> > Stop ExpandRange/EndToSentenceBoundary from using VisiblePosition
> >
> > This patch stops the two functions from using VisiblePosition by switch
> > to the VP-free versions of Start/EndOfSentence(). Hence, this patch
> > reduces the usage of legacy VisiblePosition.
> >
> > Bug: 657237
> > Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337816
> > Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#608849}
>
> TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org
>
> Bug: 657237, 906174
> Change-Id: I915e9d68f16a11344b0160db4c5702113380273a
> Reviewed-on: https://chromium-review.googlesource.com/c/1340899
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608963}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org,eirage@chromium.org

Change-Id: Ib4832ab51086777c926f4188936f31391a87f019
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 657237, 906174
Reviewed-on: https://chromium-review.googlesource.com/c/1340833
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609023}

We can just get them from the line. This also moves overriding the line's
cross axis extent to a more logical place (and adds it to the NG implementation).

Change-Id: I04da17674645fa55ff1903a15bdd4781ad26ef6e
Reviewed-on: https://chromium-review.googlesource.com/c/1338478Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609022}

This is no longer necessary after https://crrev.com/c/1283482

R=dgrogan@chromium.org, ikilpatrick@chromium.org

Change-Id: I4e0b4d631481f38157072d3f331c11eb05c1f5e7
Reviewed-on: https://chromium-review.googlesource.com/c/1340958Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609021}

https://chromium.googlesource.com/angle/angle.git/+log/e4634a13a74d..778bf09deea4


git log e4634a13a74d..778bf09deea4 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 jmadill@chromium.org Auto-generate validation headers.
2018-11-16 syoussefi@chromium.org Vulkan: Emulate Luminance/Alpha with R8G8B8A8


Created with:
  gclient setdep -r src/third_party/angle@778bf09deea4

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I7e8a4bf7dd083edeaf6e380ff7c9a8d5e05660f5
Reviewed-on: https://chromium-review.googlesource.com/c/1340578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609020}

Using wpt-import in Chromium b55d1dd9.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I8dd402a80346c2d8bae4be57de0af68156343210
Reviewed-on: https://chromium-review.googlesource.com/c/1340874
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609019}

This reverts commit 4391edc0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 608932 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDM5MWVkYzA4MjAzZDY2Zjg3OTUwYTA4MGNiZmJmY2IyZjJiOWQyMgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26490

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: virtual/threaded/animations/composited-filter-animation.html

Original change's description:
> [BlinkGenPropertyTrees] Associate each cc::KeyframeModel with ElementId
> 
> In BGPT, each KeyframeModel on a given Animation may need to animate a different
> ElementId, as the various effects of an element are split into multiple
> different nodes in some of the same node trees. This change sets the ElementId
> on the keyframe model and uses that when applying mutations.
> 
> Since animations currently expect to look for the existence of a single element,
> this patch also modifies PaintPropertyBuilder to construct each node type that
> may be needed for an animation when any property is being animated on an element
> and then uses the kPrimaryEffect id to check whether this has happened.
> 
> This also makes several changes to plumb the proper list of element ids:
> - Register all ancestor ElementIds in PaintArtifactCompositor::Update.
> - Synchronize registered ids during commit.
> - Synchronize registered ids during activation.
> 
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Bug: 896549
> Change-Id: I717822a1ca174658ef792005e76613a5033f4f6a
> Reviewed-on: https://chromium-review.googlesource.com/c/1297305
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608932}

Change-Id: Idaed0e8efd9ea459af64a2201bb53ba2d58d2a28
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896549, 906268
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1341060
Cr-Commit-Position: refs/heads/master@{#609018}

Build on existing naive PosInSet and SetSize implementation to handle
cases such as inconsistent or invalid assignments of kPosInSet and
kSetSize attributes

Change-Id: I966f3ad00e778e0d68bcb48d160f1be5818b587b
Reviewed-on: https://chromium-review.googlesource.com/c/1340523
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609017}

Bug: 904986, 906151
Change-Id: I5aef21b730446234742c2420435aeba8fb81f76e
Reviewed-on: https://chromium-review.googlesource.com/c/1334274
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609016}

Under several circumstances, the network transaction or the
HttpAuthController may invalidate an authentication handler with the
intention of retrying the same transaction. During this process, any
sources of identity that were consumed should be made available for
reuse. Otherwise the behavior of the retry operation could end up being
wildly different from the original transaction.

This is particularly pronounced when dealing with HttpAuthHandler
implementations that support both ambient and explicit credentials. For
those, the retry attempt will switch from ambient to explicit identity.
This CL updates HttpAuthController to restore the identity source such
that the retry correctly attempts the ambient identity again.

Bug: 857228
Change-Id: If4a9cfa30aa0ddb996a4856ae282c7f7358dce7b
Reviewed-on: https://chromium-review.googlesource.com/c/1329902Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609015}

In the presence of an opaque background,
BoxPainterBase::PaintNormalBoxShadow() insets the shadow clip by one
unit (in order to mitigate seaming artifacs), effectively expanding the
shadow inwards, and relies on the opaque background overdrawing this
inset.

But <body> doesn't paint its own background -- it gets transferred to
the view and painted in a different context => the shadow inset remains
visible.

To address this, pass background-skip information to
PaintNormalBoxShadow(), and disable the inset logic when the background
is not being drawn.

Bug: 899342
Change-Id: I5e04a1c17c2be324bf4c6767d2159372f546cc24
Reviewed-on: https://chromium-review.googlesource.com/c/1336495
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#609014}

Aligning with the POSIX impl in preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/1283010

Also adds two trivial ScopedAllowBaseSyncPrimitivesForTesting around
existing thread joins in tests (more advanced changes were extracted
to precursor CLs).

Bug: 707362
Change-Id: If4c4c49b4a20554518ca4a25ae1ea16b84d3a510
Reviewed-on: https://chromium-review.googlesource.com/c/1324370
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609013}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5705acabe03a..6343daaa40fe


git log 5705acabe03a..6343daaa40fe --date=short --no-merges --format='%ad %ae %s'
2018-11-16 iannucci@chromium.org [led] Update led to latest version.


Created with:
  gclient setdep -r src/third_party/depot_tools@6343daaa40fe

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I694e2a34951176ccb92e51f278ebdb3204cc3a36
Reviewed-on: https://chromium-review.googlesource.com/c/1340396Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609012}