GitLab

https://webrtc.googlesource.com/src.git/+log/c8ac35879c9d..2549f174b533

2020-08-17 danilchap@webrtc.org Remove RTPFragmentationHeader creation and propagation through webrtc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ieac912a0f4401836f2118735f0879e2dff7d5dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359286Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798870}

This CL lets RootUiCoordinator create and provide BrowserControlsManager
to other classes. Chrome*Activity still has #getBrowserControlsManager
which now just defers the call to RootUiCoordinator.

This makes |createComponent| and |createRootUiCoordinator| in
ChromeActivity#performPreInflationStartup form dependencies on each other
for CCT/Webapp. This was broken by creating RootUiCoordinator first and
having some components be passed to it as a supplier instead.

Bug: 966272
Change-Id: Ic89fdb77d0886d448033599c9e20128c96f071c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327351
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798869}

Bug: 1045266
Change-Id: Ie8faf5986af1f0564f20cf5aa5b8cc6beea9a135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358597Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#798868}

This reverts commit 065ade05.

Reason for revert: Suspected cause of All/OobeInteractiveUITest.SimpleEndToEnd/9 failure on Builder linux-chromeos-rel Build 40523:

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40523

Original change's description:
> Reland "LoginScreen: Show TPM lock status."
> 
> This is a reland of 67a4df6f
> CL was reverted cause of failing
> chromeos-betty-pi-arc-cfi-thin-lto-chrome due to reaching deadline
> on one of the tests. This is gonna be fixed by increasing time limit.
> See details here: https://crbug.com/1116379
> 
> Original change's description:
> > LoginScreen: Show TPM lock status.
> >
> > If TPM is locked show banner with steps on how to fix this issue.
> >
> > Bug: 1114656
> > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266
> > Reviewed-by: Toni Baržić <tbarzic@chromium.org>
> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
> > Cr-Commit-Position: refs/heads/master@{#797992}
> 
> Bug: 1114656
> Change-Id: Iba50daf1d1b892539e00d9be04fc2b8c0a5a279e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359992
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
> Cr-Commit-Position: refs/heads/master@{#798698}

TBR=tbarzic@chromium.org,antrim@chromium.org,raleksandrov@google.com

Change-Id: I55fca0fb2f7fdbdacf1de9d7122571a888b89d11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1114656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358906
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798867}

This reverts commit 5e960b15.

Reason for revert: Nothing actually wrong with this CL!  But we need to revert a separate CL (https://chromium-review.googlesource.com/c/chromium/src/+/2358906) and this CL introduced merge conflicts.  Sorry for creating extra work for the reland :(

Original change's description:
> CrOS - Login Screen - Minor cleanup
> 
> Rename AnimationState to UiState and use it to determine the
> visibility of elements. Remove multiple variables in favor of
> UiState.
> 
> Bug: 1075994
> Change-Id: I0d7413fb173dadbff22cde0eb3af6f43586bdee2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352883
> Commit-Queue: Renato Silva <rrsilva@google.com>
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798780}

TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com,rrsilva@google.com

Change-Id: Id0637f3c2491612b22a7630194a1377d9e4b7b34
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1075994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360699Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798866}

Add message handler HandleSaveAttachmentMessage() for downloading PDF
attachments.

As the caller of PDFiumEngine::GetAttachmentData(),
HandleSaveAttachmentMessage() validates the attachment's index,
readability and whether the size is non-zero before calling, and checks
whether the returned attachment's size matches the stored attachment
size in |doc_attachment_info_list_|.

After calling GetAttachmentData() to fetch the attachment's data,
HandleSaveAttachmentMessage() posts a reply to save the data to
disk.

Bug: 177188
Change-Id: I34ad386447cdcb4025d0f545e4ff8b9d3b818659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295998
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798865}

Two unit tests were still calling the (removed) set_uri() method
instead of the (new) SetUri() method. Updated the tests.

Bug: 1113983
Test: autoninja -C out_${BOARD}/Release unit_tests builds without errors
Change-Id: Ibd45ff3729d3b5a076913ccd7408402154785d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342424Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Piotr Pawliczek <pawliczek@chromium.org>
Commit-Queue: Josh Simmons <simmonsjosh@google.com>
Cr-Commit-Position: refs/heads/master@{#798864}

Adds a dedicated KaleidoscopeNTPDataProvider that
provides the methods that are needed by the NTP.

BUG=1114862

Change-Id: I29c182f5c032f8dc0553bbe14b405f228942d3eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357521Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798863}

Introduce CriteriaHelper#pollUiThreadNested
This change adds an assertion that pollUiThread is not called from the
UI thread, which is equivalent to calling sleep(), and won't actually
run any UI thread tasks.

In the few cases where polling the UI Thread from the UI thread is
necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests
the looper in order to continue running UI tasks.

Bug: 1115220
Change-Id: I9338a607590e8ee0a22bc32477f02867c6e37271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357289Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798862}

Bug: b/161367720
Change-Id: If21e72031c20b6e5da11fc477cf108145776a5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346970Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: John Williams <jrw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798861}

Attempting to show an error message in payment request dialog view after
PaymentRequestDialogView::OnDialogClosed() call causes a crash. This is
because PaymentRequestDialogView::ShowErrorMessage() creates an error
view and adds it to the view stack[1] while the stack view gets destroyed
upon PaymentRequestDialogView::OnDialogClosed() call.

[1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/payments/payment_request_dialog_view.cc;l=123

This cl fixes the crash by early-returning from
PaymentRequestDialogView::ShowErrorMessage() when the dialog is getting
closed (i.e after PaymentRequestDialogView::OnDialogClosed() has been
called.) The screencast of the fix is already attached to the bug.

Bug: 1114556
Change-Id: I10d9478a83913a167e52ed558a6a09cf18fcd6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359562Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798860}

Add document outline view by porting the bookmarks list to the sidenav
from the viewer toolbar.

Bug: 1116574
Change-Id: I571dc8e6f6f7288debff5a9abcdc4e2f93877366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357673
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798859}

Add about:flags to enable/disable AImageReader. This will help
in debug on production builds.

Bug: 1114874
Change-Id: Ib6216e4b594f59a46890f43640a25154711da351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360113
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798858}

New packages are provided for both Xcode 11.2.1 11B53 and 12b4 12A8179i,
identical to the old packages with the inclusion of atos after
955c73fb.

Bug: 1113466
Change-Id: If8c18cc0881526d006cad35a6f45f2aa2af2d611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360324
Commit-Queue: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798857}

The CommandLinePolicyProvider will be addded on Android device for
Canary, Dev amd trunk channel. Unless the CommandLineOnNonRooted feature
is enabled.

Test locally with following command:
out/Release/bin/chrome_apk run --args='--policy="{\"BrowserSignin\":0}"'

And here is the screenshot of chrome://policy page:
https://drive.google.com/file/d/1wp2nlPpgbMrOWFXigqYjgshjH5E7ZrrT/view?usp=sharing

Bug: 1113792
Change-Id: I11f5d00a68a2f2a852eff1dc02ed6d1e653ff506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357459
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798856}

We had previously found it beneficial to record CPU metrics for a frame
only when it was in the foreground because we were concerned with the
percent of CPU usage by the frame at it's more impactful time (frames
in the background have their task queues slowed/stopped).  However, we
now instead use a metric that measures the peak windowed usage rather
than the percentage of usage overall, so it's no longer critical to
distinguish between foreground/background times.  In addition, not
measuring while in the background leads to us missing potential spiking
CPU usage of frames there.  This CL removes the foreground/background
distinction, ensuring our metrics are recorded for the total time
of the frame independent of its background status.

Note: This change will affect heavy ad intervention behavior.  This is
desirable, as ignoring work that an ad does in the background is a
potential way to circumvent this intervention, and most frames, while
backgrounded, should be doing less anyway.

Bug: 1103699
Change-Id: If34be823bb5501574df0f4142db284e6499151e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310130
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798855}

In order to get interactive_ui_tests run on CI/CQ, we need to disable
failing tests first, then run them.

Bug: 1111979
Change-Id: If90cf564f5647189b2154ebfbdc2ad6ff570e473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360321Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798854}

This reverts commit 30d9990c.

Reason for revert: Suspected cause of build failure on ilder Deterministic Linux (dbg) Build 18293:
https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293?blamelist=1#blamelist-tab

 Checking libblink_common.so difference: (10672 deps)
   obj/third_party/blink/common/common/document_policy_features.o

Original change's description:
> Add bool constructor with type for PolicyValue
> 
> Previously, boolean PolicyValue is missing a constructor with type
> specification on PolicyValue class. It caused some inconvenience
> on code generation and testing. With the introduction of enum
> PolicyValue, this becomes more obvious because enum type's constructor
> also comes with a type parameter.
> 
> In order to simplify the codegen and testing logic, this CL adds a dummy
> constructor for boolean type PolicyValue.
> 
> Note: the constructor with type parameter aims to distinguish policy
> values that have same C++ type representation but different policy value
> type, e.g. IncDouble and DecDouble, Enum and Int.
> 
> Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365
> Commit-Queue: Charlie Hu <chenleihu@google.com>
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798714}

TBR=iclelland@chromium.org,foolip@chromium.org,chenleihu@google.com

Change-Id: I79f53710b14f22a7c81b4c757cbee03160c6addb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360796Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798853}

Since WebContentsImpl::DidStartLoading/DidStopLoading is already sending
NotifyNavigationStateChanged(INVALIDATE_TYPE_LOAD) by way of
LoadingStateChanged, it's no longer necessary to send this out in
WebContentsImpl::LoadStateChanged. This change can reduce the number
of call of TabStripModelObserver.TabChangedAt with TabChangeType.kAll
a lot to increase performance throughout the browser

Bug: 1112496
Change-Id: I96d8942d7e1ebd5ffc8b3f3389497936f62848c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357960
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798852}

These should be the only remaining instances of R.java generated by an
android_resources target instead of the android_library target (in
src/ there are others in other repos).

TBR=What should just be a mechanical change.

Bug: 1073476
Change-Id: Ia61ff2985a7db20f11a546bb76194bd796aec00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357636
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798851}

Create the provider and link it to the PolicyConnector.

Also make few changes in the Loader class:
1) It no longer inherits from ASyncPolicyLoader as the loader process
is sync.
2) Add few debug information in case the JSON input is not valid.

The provider is not disabled globally. There will be one last CL to
enable the provider on Android.

Bug: 1113792
Change-Id: Id32ec74ebfa259777f718bf06b7a4cb307498f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355134Reviewed-by: Yann Dago <ydago@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798850}

https://docs.google.com/document/d/108ekdmEDMwpGDQLRnWGZBcq1cxsyPQLXuFl4oj6OIfw

Bug: 1112872
Change-Id: Ic92d02154f4a01c5f72a65e1585f4558b84436ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360569
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798849}

Eviction.*: kept as lower traffic, and we just fixed a major issue
            with eviction heuristics
                     metrics
DiskOpenStream2TinyLatency, DiskOpenStream2NonTinyLatency:
    removed, not interestng with CodeCache being a thing
other Disk*Latency: kept, important performance metrics.
                    pretty heavy, though.
                 (Why is there a regression in July?)
                             indicates unusual case

HeaderSize: kept as there are deep assumptions on magnitude of this
EntryOpenedAndStream2Removed: removed, not very interesting
EntryCreationTime: kept, really important for performance
EntryCreationResult: removed, can use comparable Disk*Result
CreationToIndex: kept, highly relevant for CacheStorage.
CheckCRCResult: stream reading state is interesting
FileDescriptorLimiterAction: keep, low traffic and
Fixed: 1089899, 1089898, 1089897
Fixed: 1089908, 1089907, 1089906
Fixed: 1089911, 1089910, 1089909
Fixed: 1089920, 1089919, 1089918
Fixed: 1089917, 1089916, 1089915
Fixed: 1089519
Change-Id: I6bf6c3a0d037a85afd8ee7cbc7810f1f4f00b615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359556Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798848}

Using wpt-import in Chromium a866c351.
With Chromium commits locally applied on WPT:
22d98b41 "Make canvas-createImageBitmap-e_srgb.html run cross-browser"
07bc7b3c "[WPT] Refactor WebBluetooth tests to use test-only-api.js"
d2294de0 "Do not create a stacking context for CSS clip"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I9bfd8e8bce32f8a8ab6cec32e9b40e7f8038cfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358588Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798847}

This contains information required for new Java 8 desugaring features.

The reland was fixed in patchset 2: adding a special case not to check
bytecode for this new jar.

Tbr: wnwen@chromium.org, agrieve@chromium.org, yfriedman@chromium.org
Bug: 105675
Change-Id: Idd381efe4fc017944d3be33a01d5ec9c47b72420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359153
Auto-Submit: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798846}

Change-Id: I1286e8e96bd77b27f6d78d36db7e079972e97fce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360120
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798845}

mini_installer.exe requires a temporary directory in which to write
files during processing. Historically, this has been a directory under
%TMP%. While mini_installer does its level best to delete this directory
before terminating, it cannot always do so (e.g., third-party software
may have some files open, or the machine may lose power).
mini_installer.exe scans %TMP% at process startup to delete any stale
directories from previous runs to prevent unbounded accumulation said
directories.

In this CL, mini_installer.exe now creates its work directory in the
directory containing the executable itself. In the case of installations
driven by a variant of Omaha (e.g., Google Chrome), Omaha will
eventually clean any files/directories left behind.

This CL also results in successful runs sending up either 0x10000 or
0x20000 in ExtraCode1 based on whether or not the fallback to %TMP% was
used. This will inform us as to whether or not it's safe to remove that
fallback.

A note to the authors of other Chromium forks: this change in behavior
may impact you. Audit how your variant of mini_installer.exe is run and
ensure that any files or directories left in the same directory as it
are cleaned up.

BUG=516207,1100280

Change-Id: I7a8dd7981b26dbac10553747cfe32a40fb11f37b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351989Reviewed-by: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798844}

We have enabled transformed rasterization for most layers including
composited scrolling contents, which also enables LCD text when
possible, so using composited scrolling for transformed layers won't
lose LCD text in most cases.

Bug: 1095156
Change-Id: I8eef7b7d69edf55aa33e3428a44e5199872af7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360224Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798843}

Bug: 1114160
Change-Id: I8fea8df370aff14aae81f1bb23f2e4f1a4ececbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354600Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798842}

This reverts commit 9183784e.

Reason for revert: Per crbug.com/1116874, there is crash in GetOfferDataRequest::RespondToDelegate. Will revert to unblock branch cut and investigate later.

Original change's description:
> Create AutofillOfferManagerFactory and implement GetOfferDataRequest.
> 
> This change further implements the functionality of AutofillOfferManager. AutofillManager now accesses a singleton AutofillOfferManager via the AutofillOfferManagerFactory. AutofillOfferManager then prepares a request which is sent to the PaymentsClient to retrieve offer data. In further CLs, the data retrieved during these calls will stored and used.
> 
> Change-Id: I384c95f26b9b3094d9b3387d467134ef5998396e
> Bug: 1093057
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258154
> Commit-Queue: Ben Blake <fiorito@google.com>
> Reviewed-by: Anne Lim <annelim@google.com>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Siyu An <siyua@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798344}

TBR=battre@chromium.org,vasilii@chromium.org,jsaul@google.com,siyua@chromium.org,annelim@google.com,fiorito@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1093057
Change-Id: Id441c93ff6b4ac888cfd9e7245e78859448a923b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360334Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798841}

https://android.googlesource.com/platform/external/perfetto.git/+log/f926b0866fe4..d2a9f6661597

2020-08-17 aninditaghosh@google.com Add public docs for TP Python API
2020-08-17 lalitm@google.com Merge "trace_processor: Skipping an android log message is info not error"
2020-08-17 fmayer@google.com Strip in update_[traceconv|trace_processor].

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:163311671
Tbr: perfetto-bugs@google.com
Change-Id: If9e7da732efc8ce7f33d7684e8d33a58e4a29691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360265Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798840}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/78fa1f578a2c..25f6caceffe6

2020-08-17 joselea@microsoft.com Responding to community feedback.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1076112
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I776b39d4612d334f13ba5d3e68a4df4947910d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360434Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798839}

Change-Id: I43e9f2df360a20f4e1a8641114f897053f47bd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358600Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798838}

Bug: None
Change-Id: I063f5d074dac5d7c02d50cdc3e8975f30f80a214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357422
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798837}

For elements with will-change:transform or directly composited images
the raster scale is not updated in response to transform scale
changes. Once the scale gets especially large, the interest rect
computed by blink starts to become less than the layer bounds.
This ends up setting a recorded_viewport_ on RasterSource that is also
less than the layer bounds. If the interest rect gets small enough, it's
possible that tiles that are in view are not completely covered by the
RasterSource. This means that we won't create tiles (much less assign
them GPU memory and schedule them) in PictureLayerTiling::CreateTile. We
did not see this with the previous implementation of directly composited
images, since the content layer never had an interest rect computed.

This change fixes this specifically for directly composited images by
always considering its raster source as covering the entire layer. This
is the definition of directly composited images (has a DrawImageRectOp
that draws into the entire layer). This allows the in view tiles to be
created, then rasterized and activated and the image no longer
disappears.

I looked into fixing the general case (see comments in the bug) but
given the regression for the images scenario and the fact that we'd like
to get a fix merged for 85, I took an approach to just fix directly
composited images.

Bug: 1110141
Change-Id: Ice3cf25508585f116edd7317718292ec9ad8a7ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358888Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798836}

follow up to 8e26d230

Bug: 1097216
Change-Id: Ic65b788010d84c8d2a0282f0bd3a1e2d9680ab3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359746
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798835}

This CL adds Graphics.Smoothness.Jank.* histograms in histograms.xml.

Bug: 1073216
Change-Id: I955cd30c086f0b517be40fd64e830b82ee65271c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359165Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798834}

Add use counter to collect UMA metrics of when postMessage is called
between top-level windows on a same-site and cross-site basis, and
when targetOrigin is not specified. When is called for cross-site,
metrics will be measured in UKM as well.

These metrics will be used to understand how postMessage is used
between sites to come up with future plans for postMessage API changes.

Bug: 1112491
Change-Id: I0b023067c289d0a957c28100cf7c591c97030d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337263
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798833}

This reverts commit f97fae25.

Reason for revert: Fixing the null dereference of Document's loader
which caused the crash in the first place. This crash was similar to
what we saw in crbug.com/931330 and fixed with crrev.com/c/1470543.

Original change's description:
> Revert "Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution"
> 
> This reverts commit 647d93e9.
> 
> Reason for revert: crbug/1116821 - causing crashes
> TBR=ryansturm@chromium.org,falken@chromium.org,rkaplow@chromium.org
> 
> Original change's description:
> > Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution
> >
> > This CL introduces the PerfectHeuristics UKM event, along with a boolean
> > metric for when a blink::ScriptRunner comes across an async script
> > before the script element's node document has finished parsing. The
> > PerfectHeuristics UKM event is logged in the UkmPageLoadMetricsObserver.
> >
> > See the Google-internal UKM privacy review:
> > https://docs.google.com/document/d/1UqkpGXc4LEh5jzzVR8fCVVTuCuG2mwvhQTuCy36zT3g/edit#
> >
> > See the Perfect Heuristics [1] project document (currently
> > Google-internal).
> >
> > [1]: https://docs.google.com/document/d/1Y7uF76Gq0VlJZky2j7x-lbD1_awH64eW0WRg1bNLuFs/edit
> >
> > R=​falken@chromium.org, nhiroki@chromium.org, ryansturm@chromium.org, sophiechang@chromium.org
> >
> > Bug: 1086227
> > Change-Id: I71954491a1a559c2e1244a543092f1b8f38b8136
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340845
> > Commit-Queue: Dominic Farolino <dom@chromium.org>
> > Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#798393}
> 
> TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1086227,1116821
> Change-Id: I0131884d123e2122fa674097381293174795fecf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359573
> Commit-Queue: Sophie Chang <sophiechang@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798738}

TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1086227
Bug: 1116821
Change-Id: I7722da2c17dc34952ea9155d72840708b4eaa5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359742Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798832}

This change updates the headers' aria role to be 'heading' instead of
'group', which is a more appropriate role given the definitions from w3.
This also improves screen readers' understanding of these text blocks.

Bug: 1116623
Change-Id: Iac4fa60c72da8a130bd28841889a3826a755c8e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357461Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798831}