GitLab

It's used for poking at InputDeviceClient. As Chrome/Ash use
DeviceDataManager in classic mode InputDeviceClientTestApi handles
both. That is, if DeviceDataManager exists it pokes at it, otherwise
InputDeviceClient.

BUG=776514
TEST=test only changes

Change-Id: I4e46dbe74dbce4a37d2b4e054b8fec88d4b5a048
Reviewed-on: https://chromium-review.googlesource.com/829713Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524447}

Change-Id: Ida79579f16af6c2d0dcd97a7d972b2444f2280c3
Reviewed-on: https://chromium-review.googlesource.com/827541Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524446}

Record partner bookmark count as zero when skipped, so that
the distribution is not skewed.

Bug: 787132
Change-Id: Ie5c0c49120ff47a0fce984de823928997a1652f8
Reviewed-on: https://chromium-review.googlesource.com/826465Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524445}

This previously existed, but was mistakenly removed in
crrev.com/c/648076.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I09759933d8717d55de1343852827ab3289a4bee0
Reviewed-on: https://chromium-review.googlesource.com/830136
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524444}

Because Blink depends on the WebUSB interfaces directly they shouldn't
be part of chrome_content_browser_manifest_overlay.json and should
instead be part of content_browser_manifest.json. Since these are still
implemented by Chrome and not //content the factory methods are moved
into ContentBrowserClient.

Change-Id: Ic34008eccca45dd24bace5afee8fff478bb9ba6d
Reviewed-on: https://chromium-review.googlesource.com/828025Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524443}

Remove an unused (and deprecated) overload of
ExtensionTabUtil::GetBrowserFromWindowID.

Bug: None

Change-Id: Ia5580dc63e39d0b9c01784abf69ef31383ff79ce
Reviewed-on: https://chromium-review.googlesource.com/829693Reviewed-by: catmullings <catmullings@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524442}

(a) device info should be in the batch summary of the request for PLM
(b) I'd like separate Device Info messages in case they diverge, which seems like a distinct possibility.

Patchset 1 is what landed yesterday.

This is a reland of 1e920b32
Original change's description:
> Adding device memory in kb to the client config request
>
> pingback will also have this information
>
> Bug: 793373
> Change-Id: I0c999c35b5e968f6b2e19696a08a722b3399d0d9
> Reviewed-on: https://chromium-review.googlesource.com/823176
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524203}

Bug: 793373
Change-Id: I4d3f6854b3b28c5c412388e27b0851e767e5f8b4
Reviewed-on: https://chromium-review.googlesource.com/830133Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524441}

Disabled this feature for unit test which tests old code.

Bug: 787943
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2aba8bcca42197bc18b390181099ba664f171646
Reviewed-on: https://chromium-review.googlesource.com/828284Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524440}

It appears using external process to write to a file we hold an open handle for
isn't 100% reliable (I suspect we need an fsync somewhere or maybe gsutil is
doing 'mv' somewhere and writes to another inode, or something like that).

Reopening the file before reading from it fixes the bug, at least locally for
me.

R=scottmg@chromium.org, kbr@chromium.org
BUG=795330

Change-Id: I498540ec62439c02243b84a5577c4b225ba5e1f3
Reviewed-on: https://chromium-review.googlesource.com/830257
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524439}

This patch adds the following dumps in v8 memory dump provider:
- v8/isolate/contexts/detached_context
- v8/isolate/contexts/native_context
Both dumps contain an "object_count" scalar value.

The value of detached_context is the number of contexts that were
detached (due to iframe navigation or removal) and not yet garbage
collected. This number being non-zero indicates potential memory leak.

The value of native_context is the number of the top-level contexts
created for the main window and iframes. Increase of this number
over time indicates a memory leak.

Bug: 793789
Change-Id: I4753454747c398fac4fc153fcccb1288d28f2a2d
Reviewed-on: https://chromium-review.googlesource.com/822336
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524438}

This CL decreases the bottom padding of the In-Product Help bubbles for
Contextual Search, to overlap the panel, as per UI Review's comment.

Bug: 794013
Change-Id: I607f5ea31f3cea0cbd370b9a3b19fddd6b8db385
Reviewed-on: https://chromium-review.googlesource.com/829879
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524437}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eaa72a5e..7be4ef7e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I54a79e84fd83c9641d6de2b957832bf8b6b739dd
Reviewed-on: https://chromium-review.googlesource.com/830113Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524436}

Bug: 
Change-Id: Iec0429a3149ee17ca53b60224684e4dc3e6bbf26
Reviewed-on: https://chromium-review.googlesource.com/828442
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524435}

21ece16c added support for using
the frame duration metadata in the muxed stream, but if the frame
timestamp is already int64_t::max(), computing the end timestamp
based on frame time + duration yields int64_t::max() so we can
end up with a duration of zero.

This updates the conditional to skip frame duration metadata when
we don't have a valid frame duration after the calculation.

BUG=793550
TEST=new unittest

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5bb728f18fbfba7df326b44f7b6159f2395a3fb5
Reviewed-on: https://chromium-review.googlesource.com/828287Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524434}

This CL enables the sharing of non-HTTPS canonical URLs if the
display URL is HTTPS, due to a requirements change. It also
updates the logging to treat HTTP canonical URLs as a success
case.

Bug: 794768
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I741949980f2d6d804a673ac82d950cdf735021df
Reviewed-on: https://chromium-review.googlesource.com/826051Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524433}

Because some intercepts run before the main binary is bound and
initialized, they cannot be instrumented on X64. This is because
the shadow memory is dynamically allocated, and so won't be available
until some time during or after binding.

Bug: 783296
Change-Id: I93b0bd81d325a452205351059bc6ba013618bb99
Reviewed-on: https://chromium-review.googlesource.com/825782
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524432}

This reverts commit 73722a14.

Reason for revert: Breaking the Linux x64 build
https://ci.chromium.org/buildbot/chromium/Linux%20x64/55031

Original change's description:
> Remove navigation start observing from DataUseAscriber
> 
> There's no reason to PostTask a bunch of data to the IO thread to do a
> no-op method.
> 
> This CL should change no behavior.
> 
> Bug: 792524
> Change-Id: Ia0f88da99c72fa3369b164a2fd25352f77d13544
> Reviewed-on: https://chromium-review.googlesource.com/827980
> Reviewed-by: rajendrant <rajendrant@chromium.org>
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524424}

TBR=csharrison@chromium.org,rajendrant@chromium.org

Change-Id: I00a16f8e2ee77b767f4289ad01ca4a05c711fdc9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792524
Reviewed-on: https://chromium-review.googlesource.com/830473Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524431}

In VR, we change the dip scale of the WebContents, but cannot properly
change the dip scale of Java UI because doing so would require
reinflating said java UI.

This leads to problems when determining the offset applied by the
top/bottom controls. RenderWidgetHostViewAndroid previously converted
the shown ratio of the controls to pixel values using the dip scale
of the WebContents, while ChromeFullscreenManager converted the control
height to pixels using the Java UI dpr. It then treated a mismatch
between these two values as the control container being visible, even
if the shown ratio was 0.

This CL changes the FullscreenManager to always apply fully-hidden
control offsets while in VR since the controls will be hidden anyways.

Bug: 793430
Change-Id: If18aa601ed51ea91cef6b83060972d216a8cd6a9
Reviewed-on: https://chromium-review.googlesource.com/818116
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524430}

Bug: 795089
Change-Id: I7772621479504e5797c579f6d45315f836d5bceb
Reviewed-on: https://chromium-review.googlesource.com/827809Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524429}

This reverts commit 12dca865.

Reason for revert: crbug.com/795223

Original change's description:
> Fix Windows touchpad lagging in first tab
>
> Currently the receiving of WM_MOUSEWHEEL messages lags when we open a
> URL on a new window until we resize. The issue was introduced by
> r384698. That CL change wait for MOUSE_EVENT to wait for SENDMESSAGE
> in MessagePumpForUI::WaitForWork to optimize the GPU thread. But the
> GPU thread does not use MessagePumpForUI anymore so it should be OK to
> just remove that code.
>
> The updated version of Chrome was tested to make sure that the hangs
> that were occasionally seen when using chrome://tracing are still gone.
>
> After this CL chaopeng@ need to monitor to make sure that the crash
> rate not increase.
>
> Bug: 713907, 596190
> Change-Id: I7545a867de4851acd4e57c9b8c7a3dd05def1dd8
> Reviewed-on: https://chromium-review.googlesource.com/809829
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523689}

TBR=thestig@chromium.org,brucedawson@chromium.org,chaopeng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 713907, 596190, 795223
Change-Id: I3f53fd77e7a6545cd214444cac46709cff0142c9
Reviewed-on: https://chromium-review.googlesource.com/830174
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524428}

In order to experiment with different deadlines on different machines,
this CL introduces a command line flag to set the default deadline to
synchronize.

Bug: 672962
TBR: sky@chromium.org for services/ui.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I58e8fd8431c439bca35ca0a3cb400046bf0dc2b6
Reviewed-on: https://chromium-review.googlesource.com/828123
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524427}

Ranker also takes care of logging and deals with field trials internally.

Bug: 786472, 778468
Change-Id: Ie583616643ab8ad169df4739a4a18b81a950553f
Reviewed-on: https://chromium-review.googlesource.com/788331
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524426}

P2PSocketDispatcherHost is supposed to update network list even
when the system is offline (i.e. after last NIC is brought down).

Bug: 789125
Change-Id: Id732ca2e35f7ea435bc960fd37a2656b152fac32
Reviewed-on: https://chromium-review.googlesource.com/802237Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524425}

There's no reason to PostTask a bunch of data to the IO thread to do a
no-op method.

This CL should change no behavior.

Bug: 792524
Change-Id: Ia0f88da99c72fa3369b164a2fd25352f77d13544
Reviewed-on: https://chromium-review.googlesource.com/827980Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524424}

This reverts commit a8a1b79e.

Reason for revert: Failures on Linux MSan Tests buildbot:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests

Original change's description:
> Network Error Logging: Ignore Reporting API upload requests
> 
> Right now, the ReportingUploader cancels requests once the headers are
> received, which causes the requests to fail with ERR_ABORTED, which
> triggers a NEL report.
> 
> This CL breaks that loop by attaching user data to upload requests and
> ignoring ERR_ABORTED errors stemming from them.
> 
> TBR=mkwst@chromium.org
> 
> Bug: 793392
> Change-Id: Id26516533ec0e7531797717526b015c56a742c1b
> Reviewed-on: https://chromium-review.googlesource.com/817553
> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
> Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524390}

TBR=mgersh@chromium.org,juliatuttle@chromium.org

Change-Id: I3e86f06bed769481a2ec6bdec109bdd590493ddc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793392
Reviewed-on: https://chromium-review.googlesource.com/830353Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524423}

Increases usage of const where appropriate in
SourceBufferRange{,ByDts,ByPts} classes. I found and am fixing this while
working on patches to fix bug 791095.

BUG=791095

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If8d70f80e36462fce62451a3a189485bb9774eef
Reviewed-on: https://chromium-review.googlesource.com/825965Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524422}

This change modifies the U2F BLE UUIDs to have extern linkage and
renames them to comply with the style guide naming conventions for
constants.

Bug: 763303
Change-Id: Ica2cb8f62c83d3a2fdcb4cdfc265735675e9e6af
Reviewed-on: https://chromium-review.googlesource.com/829175Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524421}

https://skia.googlesource.com/skia.git/+log/67a86d50f38d..29c14a760682

$ git log 67a86d50f..29c14a760 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 caryclark fix very large clipped path limit
2017-12-15 reed hide SkImageDeserializer
2017-12-15 caryclark working on image docs
2017-12-13 caryclark fix zero length dashed lines

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I568feeb43b109d9141e9e7a9c245bad28c1f136e
Reviewed-on: https://chromium-review.googlesource.com/829973Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524420}

This reverts commit a8a1b79e.

Reason for revert: Caused MSan failures. (Thanks Findit!) https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/6611

Original change's description:
> Network Error Logging: Ignore Reporting API upload requests
> 
> Right now, the ReportingUploader cancels requests once the headers are
> received, which causes the requests to fail with ERR_ABORTED, which
> triggers a NEL report.
> 
> This CL breaks that loop by attaching user data to upload requests and
> ignoring ERR_ABORTED errors stemming from them.
> 
> TBR=mkwst@chromium.org
> 
> Bug: 793392
> Change-Id: Id26516533ec0e7531797717526b015c56a742c1b
> Reviewed-on: https://chromium-review.googlesource.com/817553
> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
> Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524390}

TBR=mgersh@chromium.org,juliatuttle@chromium.org

Change-Id: I8aae7138cb616fb86e038463c80560f9e916f0c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793392
Reviewed-on: https://chromium-review.googlesource.com/830313Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524419}

This CL handles two cases:
1) When restore_session.html is first loaded, set virtual URL to the
   item that will be displayed when session is fully restored.
2) If a restore_session.html is loaded in the webview, set the virtual
   URL to the encoded URL, as that will be the page that will eventually
   be displayed.

Moved session restore logic into a separate util file so it's easier to
test.

Bug: 789993
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1547f792f1e3de0bf97d11dced09383b82c507fc
Reviewed-on: https://chromium-review.googlesource.com/817713
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524418}

Fixes for reland:
- "Win8 Tester" browser_tests_functional failure
- "Win8 Tester" capture_unittests failure

Original description:
- Full rewrite of the MediaFoundation implementation video part to use
IMFCaptureEngine
- Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities
- takePhoto triggers a still image capture with the highest available
resolution without stopping the video stream thanks to IMFCaptureEngine

TEST=adapted video_capture_device_unittest.cc and
webrtc_image_capture_browsertest.cc; launch Chrome with
--force-mediafoundation on Win8+ and capture video using
e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/

R=mcasas@chromium.org

Bug: 730068
Change-Id: I3835a48ca8516fc66a6a8394b3709d4dea862f89
Reviewed-on: https://chromium-review.googlesource.com/734042
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521435}
Reviewed-on: https://chromium-review.googlesource.com/810766
Cr-Commit-Position: refs/heads/master@{#524417}

This CL corrects the provider ID attribute name, which was causing data to not get converted to Mojo properly.

Bug: 
Change-Id: I476e17eeb82387090fe6a5f6003fa60d04d40df5
Reviewed-on: https://chromium-review.googlesource.com/828288Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524416}

This works around a race condition between loading the page and the IPC
message that contains the MV items.
Before this CL, if the page load won the race, then it would assume there
are no tiles and load incorrect metrics. This CL exposes "did we ever
receive MV tiles" to the page, so it can delay loading them while they're
not available anyway.

This is very much working around the symptoms rather than fixing the root
cause. Unfortunately I have no idea how to really fix the issue.

Bug: 794942, 793818
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I091b71d17d36e28b3f53ceebef6829ef23d82b3b
Reviewed-on: https://chromium-review.googlesource.com/829254Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524415}

R=skyostil@chromium.org
BUG=789901

Change-Id: I39e845e80772571c9bac3c0d5f53fb04c3c53be5
Reviewed-on: https://chromium-review.googlesource.com/823031
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524414}

This hardens the macOS sandbox by specifying an explicit vnode type for
all writeable files, reducing the risk that an attacker can symlink a
file Chrome has write access to, and modify the filesystem at will.

Bug: 793402
Change-Id: I53bbcc84345e432756eff0d2dc18a505719fd521
Reviewed-on: https://chromium-review.googlesource.com/829877Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524413}

Recent changes removed dial_device_description_parser_impl* from
chrome/utility/media_router and introduces a new SafeXmlParser.
(https://chromium-review.googlesource.com/c/chromium/src/+/770920)

Abandoned previous DialAppInfoParser patch
(https://chromium-review.googlesource.com/c/chromium/src/+/745538),
resolved most comments in the new patch and added a SafeDialAppInfoParser
class which uses SafeXmlParser.

Bug: 779892
Change-Id: I1c0d141381e1a8c992888476e8643385a96db06f
Reviewed-on: https://chromium-review.googlesource.com/826126Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524412}

This reverts commit a71b54d8.

Reason for revert: Breaking the Linux Debug NVidia bot. See crbug.com/795332 for more details.

Original change's description:
> [cfi-icall] Refactor GL g_driver_* to be CFI-safe
> 
> Control Flow Integrity [1] indirect call (cfi-icall) checking can not
> verify that dynamically resolved function pointers call their intended
> function. To account for this, we place the function pointers in the
> various g_driver_* structs in ProtectedMemory, a wrapper for keeping
> variables in read-only memory except for when they are initialized.
> Once they are set they can not be tampered with since the memory is set
> back to read-only.
> 
> The generated bindings in gl_bindings_autogen_*.cc are not aware of the
> fact that their implementation is held in protected memory, so instead
> of using base::UnsanitizedCfiCall() we mark the individual function
> stubs with __attribute__((no_sanitize("cfi-icall"))) to disable icall
> checks on the generated bindings since their function pointer calls
> are routed through protected memory.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I6bbf1b9a4122e1d00f6d2a365ae3730b4bb95a73
> Reviewed-on: https://chromium-review.googlesource.com/770252
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524318}

TBR=dcheng@chromium.org,dalecurtis@chromium.org,kbr@chromium.org,sandersd@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: Ib4a1eae5e9f01f5e9ddbb1fcc5c66fc0b91f1015
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365, 795332
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/830173Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524411}

https://chromium.googlesource.com/breakpad/breakpad.git/+log/a61afe7a3e86..c283630201ac

$ git log a61afe7a3..c28363020 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 rsesek Reconcile -[BreakpadController withBreakpadRef:] with its documentation.
2017-12-11 wittman Update binaries with dump_syms changes to write new field
2017-12-11 wittman Write field indicating multiple symbols at an address in dump_syms
2017-12-05 adamharrison Remove duplicate import.

Created with:
  roll-dep src/third_party/breakpad/breakpad

Change-Id: I75b9d3a240b9818e2f527a591c6be2a61974088c
Reviewed-on: https://chromium-review.googlesource.com/829674Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524410}

R=jbudorick@chromium.org

Change-Id: I480364ec2aa241cdfc9b0f016cdb008f5226ecac
Reviewed-on: https://chromium-review.googlesource.com/821558
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524409}

Renaming WebVR 2 code to WebXR as per community group desision.

Bug: 670510
Change-Id: Ia85cfe584afa3e21d4634414748e11f3c9b9bfc3
Reviewed-on: https://chromium-review.googlesource.com/823424Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524408}