- 11 May, 2018 40 commits
-
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e7273d25017a..fafa09dbe1d3 $ git log e7273d250..fafa09dbe --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I72458bd599df30fc1687649075a58a745d1e5d9d Reviewed-on: https://chromium-review.googlesource.com/1055481 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557893}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Tbr: fukino Bug: 836254 Change-Id: I9aa41ba37f9510979cd72f0d91de0705214dfbe4 Reviewed-on: https://chromium-review.googlesource.com/1055035Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557892}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: Ifd6e5047d3d82c28ac56e83d7bc87e6cfd68a9fc Reviewed-on: https://chromium-review.googlesource.com/1044500Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#557891}
-
Justin Novosad authored
This change is a component of a larger refactor that transitions OffscreenCanvas to using CanvasResource. BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id58bca5a71ec4eaad2513a099571e073a34ec866 Reviewed-on: https://chromium-review.googlesource.com/1053999 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557890}
-
Stephen McGruer authored
This is a reland of 48f503a8 Original change's description: > Composite ScrollTimeline scrollSource when appropriate. > > This CL makes being the scrollSource of an active (i.e. the scrollSource is > scrollable) and attached (i.e. it is being used by at least one WorkletAnimation > as a timeline) ScrollTimeline a compositing reason. It does not change the > requirement that the scrollSource must be composited for the WorkletAnimation to > be sent to the compositor, nor does it change the case where a scrollSource stops > being composited whilst a WorkletAnimation is running. Those will be addressed in > follow-up CLs. > > Bug: 776533 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Icae43e1c9cfe2720cc739401c4766b592571f231 > Reviewed-on: https://chromium-review.googlesource.com/1036934 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556541} Bug: 776533 Change-Id: Ideda71c9dcb54dc94dd7ebf837a84890861030b9 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1054252 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557889}
-
Gabriel Charette authored
Deprecating was a bit too strong as this is still useful in few browser tests (which don't have TestBrowserThreadBundle since it's a unit test construct). R=jam@chromium.org Bug: 824431 Change-Id: Id1b44632aca4f02cbf579fe3fb2b0a91c2ac0ba4 Reviewed-on: https://chromium-review.googlesource.com/1054632Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557888}
-
Noel Gordon authored
Enabled in RELEASE, re-enable these tests (listed below) on all bots: MultiProfileFileManagerBrowserTest/PRE_BasicDownloads MultiProfileFileManagerBrowserTest/BasicDownloads MultiProfileFileManagerBrowserTest/PRE_BasicDrive MultiProfileFileManagerBrowserTest/BasicDrive is all bots. Remove old comments about that test. Trim the "normal operations" comments. Tbr: fukino Bug: 836254 Change-Id: Ia283400c34cd902514c2caf6e767dd30b0c8743e Reviewed-on: https://chromium-review.googlesource.com/1055231Reviewed-by:
-
Charlie Andrews authored
The test has been very flaky for some time. NOTRY=true TBR=perezju@chromium.org Bug: 842180 Change-Id: I86b81726d9e6c0c5f1cbe7956f102738f6cba823 Reviewed-on: https://chromium-review.googlesource.com/1055594 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#557886}
-
Peng Huang authored
Bug: 841616 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6e7d47e3e127ab9f634ea658c25466e2c53bd07e Reviewed-on: https://chromium-review.googlesource.com/1054472Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557885}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. No-Presubmit: true Tbr: fukino Bug: 836254 Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252 Reviewed-on: https://chromium-review.googlesource.com/1055252 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
Missed from previous CL: https://chromium-review.googlesource.com/1047986 Bug: 768439 Change-Id: Icc7cdcdd5084b9203abeec34e0244c43312ff4b6 Reviewed-on: https://chromium-review.googlesource.com/1054173 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#557883}
-
Charlie Andrews authored
The test has been flaky for some time now. NOTRY=true TBR=nednguyen@chromium.org CC=wkorman@chromium.org,vmpstr@chromium.org Bug: 842175 Change-Id: I857bbc9e9077d1378d59cdc14d7a03a7e1a67057 Reviewed-on: https://chromium-review.googlesource.com/1055593Reviewed-by:
-
Charlie Andrews authored
NOTRY=true TBR=perezju@chromium.org Bug: 842163 Change-Id: I148198aaa2e8f6dc4eb7ebeba01ef945f5ad6d4f Reviewed-on: https://chromium-review.googlesource.com/1054166Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Tbr: fukino Bug: 836254 Change-Id: Ib1ac9ed1fcd0b920134460f1d9fe3e9e65103ae5 Reviewed-on: https://chromium-review.googlesource.com/1053934Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 840511, 838937 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4b688d12e0f08ce265c5796df2d96d473b4591c8 Reviewed-on: https://chromium-review.googlesource.com/1048831 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557879}
-
Mathieu Perreault authored
Bug: 842156 Change-Id: I9867d575ed580e10e9d082514afc00550fb5337c Reviewed-on: https://chromium-review.googlesource.com/1055475 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#557878}
-
Josh Karlin authored
What: Changes the ContentSettingFramebustBlockBubbleModel to behave more like ContentSettingPopupBubbleModel. It now uses the same content type but differs in title and what it observes. Why: Popups and Framebusting behavior is merging. They'll use many of the same strings and they will share content setting storage. A screenshot of the new bubble is here: https://crbug.com/840356#c9 Bug: 840356 Change-Id: I098b0c3c7d94dcad58b2f01ebb02493503ecd835 Reviewed-on: https://chromium-review.googlesource.com/1050198 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#557877}
-
Helen Li authored
Use capturing lambda to make test logic more concise. Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic48af0c91ddc9574fa793540df4059247df005d9 Reviewed-on: https://chromium-review.googlesource.com/1048207 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557876}
-
sebsg authored
If the name of the form is empty, use the NameForAutofill of the first field, if present, as the identifier to decide whether to trigger a dynamic refill. Bug: 841759 Change-Id: I50b024fad4cfea71bc56d97587e76d1ab09dbd4e Reviewed-on: https://chromium-review.googlesource.com/1048634Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557875}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 220bb374. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17288 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: Ifd77538fd900e182aeaf88dd568274788efb9b39 Reviewed-on: https://chromium-review.googlesource.com/1054471 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557874}
-
Max Morin authored
Revert failed, so I'm disabling the test. Tbr: mmenke No-Try: true Bug: 837776, 842088 Change-Id: I5cd22fb63cb53ae85c99cb4b903c4c1143767c42 Reviewed-on: https://chromium-review.googlesource.com/1055508Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557873}
-
Kush Sinha authored
Chrome OS AccountManager has not been fully turned on yet and error logging missing tokens file is creating noise in error logs. This error log will be re-introduced once AccountManager is the default Identity provider on Chrome OS and failure to read tokens file is an actual error for all users. Bug: 841524 Change-Id: I608306317f1aa6edc6f44ec3338df8a63b1bba5c Reviewed-on: https://chromium-review.googlesource.com/1054673Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#557872}
-
Helen Li authored
This CL fixes the case where network::TCPServerSocket::Listen() fails to catch the error from net::ServerSocket::GetLocalAddress(). Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I16916e1ddfd717715ab08ad56c06d1b38e220471 Reviewed-on: https://chromium-review.googlesource.com/1054588Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557871}
-
Vadym Doroshenko authored
IsBlacklistMatch method can be simplified and removed by replacing it with lambda function. Bug: 831123 Change-Id: I80c838629c65270f022683d1d18b64fbba3c9f67 Reviewed-on: https://chromium-review.googlesource.com/1054874Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#557870}
-
Brian Osman authored
This reverts commit e6ae8f4c. Reason for revert: Perf regression Bug: chromium:841807 Original change's description: > Switch to using skcms for ICC profile parsing > > Change-Id: I8bafe64117d7247b7806e1d64d6e7e793078877c > Reviewed-on: https://chromium-review.googlesource.com/1028452 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556861} TBR=ccameron@chromium.org,bcwhite@chromium.org,mtklein@google.com,brianosman@google.com,mtklein@chromium.org,bcwhite@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2cc981f9fcce42e94a0cc74240d51fc7dbb0f1db Reviewed-on: https://chromium-review.googlesource.com/1054509 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#557869}
-
Peter K. Lee authored
Without specifying "fetch" in Info.plist, runtime generates spurious warning messages. Bug: 795802 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie9e73e52d626a170645a98db8e7ae90b61755ce1 Reviewed-on: https://chromium-review.googlesource.com/1050687Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#557868}
-
Sadrul Habib Chowdhury authored
Remove use of ToString(), and replace that with explicit width and height checks instead. ToString() shows up in sampling profiles as being rather expensive. BUG=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I928962767f8078a9c50aef485000e31d52c2869b Reviewed-on: https://chromium-review.googlesource.com/1054158Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#557867}
-
Tommy Martino authored
This conditionally replaces "Autofill settings" with "Manage cards" or "Manage addresses" when using the new Autofill UI. Bug: 768881 Change-Id: I9257385a0af87d8208e54db5f56daf78f54b770f Reviewed-on: https://chromium-review.googlesource.com/1054102Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557866}
-
Noel Gordon authored
Enabled in RELEASE/MSAN, now re-enable this test in DEBUG/ASAN because crrev.com/557831 improved our browser test speed. Tbr: fukino Bug: 836254,837106 Change-Id: I8f0e803901926f37438125174c16b173bbb83f89 Reviewed-on: https://chromium-review.googlesource.com/1055527 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
This uses the actual size of the native views dropdown to decide if it will be drawn upwards or downwards, to the left or to the right. Screenshots can be found at: https://drive.google.com/open?id=1F43ccvwErhPS7hEmdKWl90i0yHmd3-7J Bug: 768881 Change-Id: Iedc166b7c7edbdfe324c7657f7f319dc4032487f Reviewed-on: https://chromium-review.googlesource.com/1036286 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557864}
-
Gauthier Ambard authored
Followup for the image of the activity service. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71a5c8679d2734fbc0ca942105d7478eef1dbc8d Reviewed-on: https://chromium-review.googlesource.com/1055492Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557863}
-
Ryan Hamilton authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I50de51120163cf0244b22c6e7cfca45327618cb3 Reviewed-on: https://chromium-review.googlesource.com/1045614 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557862}
-
Marc Treib authored
Before this CL, TryStart and TryStartImmediately returned a bool. However, nobody actually consumed it, and IMO its meaning was unclear and more confusing than helpful. This CL removes the return values. Bug: none Change-Id: Ib9ff4786bd888d0fbefad7d89fc26be1e681238f Reviewed-on: https://chromium-review.googlesource.com/1054876Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#557861}
-
Eric Seckler authored
thread_time was previously overriding the wall time, but should actually be reported in a separate UKM field. Bug: 842112 Change-Id: If772b5276c0629a4184006bb5382939d9281d3d7 Reviewed-on: https://chromium-review.googlesource.com/1054011Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557860}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98ce1809..e5661887 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I41375018f5acb805ae540ffed10ad1dc44e94c6d Reviewed-on: https://chromium-review.googlesource.com/1054512Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#557859}
-
vitaliii authored
1) Exclude deprecated model types (e.g. DEPRECATED_SUPERVISED_USERS and DEPRECATED_SUPERVISED_USER_SHARED_SETTINGS) from kModelTypeInfoMap presubmit check. 2) Improve a couple of comments in model_type.cc. Change-Id: I68fd166396804c69ca567686b671ee9d19c624ac Reviewed-on: https://chromium-review.googlesource.com/1054875Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557858}
-
Leonard Grey authored
This reverts commit e3d54350. Reason for revert: Broke detached bookmark bar Original change's description: > Implement |GetChildrenInZOrder| in browser and top container views > > Currently, we ensure that the bookmark bar view is always the first > child view of its parent to ensure that toolbar inkdrops are drawn on > top of it. Unfortunately, this breaks keyboard traversal order. > > This change implements |GetChildrenInZOrder| on the two views that > host the bookmark bar: browser view and top container view. This > ensures that the bookmark bar is painted first, removing the need > to manipulate child view order. > > Bug: 712347 > Change-Id: If8f2aabe816a86b7ec29ff41779783c0f05a6393 > Reviewed-on: https://chromium-review.googlesource.com/1052854 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557537} TBR=ellyjones@chromium.org,lgrey@chromium.org Change-Id: I43286f3f1a771a8835f72d28c2333f67c9ef6b7b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 712347 Reviewed-on: https://chromium-review.googlesource.com/1054594Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557857}
-
https://webrtc.googlesource.com/src.git/+log/73b36b582fcf..e72ea24d884b $ git log 73b36b582..e72ea24d8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8aa19aef3d7aede779021c77968de738a57ee254 Reviewed-on: https://chromium-review.googlesource.com/1055467Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557856}
-
Charlie Harrison authored
This allows telemetry to have access to an indexed ruleset, without having to specify one in the source tree (which would need to be updated every time the format version changes). Follow-ups will copy this into telemetry's user-data-dir. Bug: 823982 Change-Id: Iba551b1cd6137d73bed8dfbb0bc69d00f32be7ab Reviewed-on: https://chromium-review.googlesource.com/1052860Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#557855}
-
Gauthier Ambard authored
This CL changes the style of the PopupMenu associated with the tab grid button. If the action is destructive (closing the/all tabs), the action is tinted in red. Also it adds the same icon for closing all incognito tabs as the one for opening a new incognito tab. Bug: 831152 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84617985d0811d431e38ee58391dd22df1cfb8f0 Reviewed-on: https://chromium-review.googlesource.com/1051709Reviewed-by:
-
