GitLab

Bug: None
Change-Id: Iea33829fefcc53f868d0021e1e9b3786b2285329
Reviewed-on: https://chromium-review.googlesource.com/c/1332416Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607382}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6521150ae99..6374fa323c0e


Created with:
  gclient setdep -r src-internal@6374fa323c0e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1c86d93caa52dbf400a7a27114312cd83c0e8cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1332348Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607381}

Chrome iOS stopped supporting ios10.

Bug: 904393
Change-Id: I89e9cfe5cc27e8ef94feb5e8b404e1fc8d8264d7
Reviewed-on: https://chromium-review.googlesource.com/c/1329968
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607380}

There was way too much nesting in ContentSettingBlockedImageModel.
This CL tries to tease apart some of the logic, and reduce nesting
via early-return pattern.

Bug: None
Change-Id: Ida0acf144bf4b6d1217541feb7b7e304e89fc12c
Reviewed-on: https://chromium-review.googlesource.com/c/1330346
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607379}

This test is getting close to 30 minutes.  There are 6 test cases, so sharding
it to 2 tests cases per will use 3 machines, and bring test runs closer to ten minutes.

This also renames the test cases to end in TestCase, which is how sharding does it's
math.

Change-Id: I7c4f58e89534b1d526fbfc026cbecb76c61a745e
Reviewed-on: https://chromium-review.googlesource.com/c/1331130Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607378}

The histogram GPU.GPUProcessSoftwareRendering recorded in
GpuProcessHost::LaunchGpuProcess() does not have a correct software rendering
status. GpuInit::InitializeAndStartSandbox() is where we check if we are doing
software rendering.

A new histogram GPU.GLImplementation is added to record all GL modes. If the
GPU.GLImplementation mode is kGLImplementationSwiftShaderGL, the GPU process is
running with software rendering.

Bug:899361

Change-Id: Ie2ef9b84c4055a2407128c3f4f27fbd802445485
Reviewed-on: https://chromium-review.googlesource.com/c/1317923Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607377}

No-Try: true
Tbr: nednguyen@google.com,sergeyberezin@chromium.org
Bug: 903849
Change-Id: Ib6ca07f44fcb27a9f2b6cb665fbc856539d91698
Reviewed-on: https://chromium-review.googlesource.com/c/1331875
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607376}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowBaseSyncPrimitives in non-test files
 * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=jkarlin@chromium.org

Bug: 766678
Change-Id: I51f5ca1c02138ff83229148f833f53bf1c0a1c8e
Reviewed-on: https://chromium-review.googlesource.com/c/1325208Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607375}

With NoScript and OptimizationHints launch, the ALLOWED_WITHOUT_OPTIMIZATION_HINTS
case is no longer needed so this CL cleans up the bloat for it.

Bug: 895581
Change-Id: Id32bd5f462f646275029021238b3ea291d6eccb1
Reviewed-on: https://chromium-review.googlesource.com/c/1323707
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607374}

This change adds a message bubble to the login screen and
generates a system notification on login for Supervised
Users, both of which indicate that the Supervised User
feature is to be deprecated.

Bug: 899017
Change-Id: I05b684f183a47b6275442caf8e7a4820bda0374e
Reviewed-on: https://chromium-review.googlesource.com/c/1324310
Commit-Queue: Danan S <danan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607373}

This reverts commit 87db0e76.

Reason for revert: The original CL was reverted as a culprit of a flaky crash. But it turned out to be innocent per discussion in https://crrev.com/c/1329972.

Original change's description:
> Revert "Add more information to |error| of -didFailFavigationWithSSLError:."
> 
> This reverts commit af760c91.
> 
> Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland.
> 
> Original change's description:
> > Add more information to |error| of -didFailFavigationWithSSLError:.
> > 
> > Add error.localizedDescription and error.userInfo[CWVCertStatusKey].
> > 
> > Bug: 898037
> > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29
> > Reviewed-on: https://chromium-review.googlesource.com/c/1325578
> > Reviewed-by: Carlos IL <carlosil@chromium.org>
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#607127}
> 
> TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org
> 
> Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 898037, 904345
> Reviewed-on: https://chromium-review.googlesource.com/c/1329972
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607205}

TBR=phoglund@chromium.org,eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org

Change-Id: I4ac81df8f2c1386acc0683c0a03e5d022a826b95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898037, 904345
Reviewed-on: https://chromium-review.googlesource.com/c/1332967Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607372}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1e9fc1aac107..f343a1576406


git log 1e9fc1aac107..f343a1576406 --date=short --no-merges --format='%ad %ae %s'
2018-11-12 dj2@everburning.com Add missing overrides (#2041)
2018-11-12 dj2@everburning.com Remove asserts around environment determination. (#2040)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@f343a1576406

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I09c5ee6001663cac53d06954a0d726d8d5641d11
Reviewed-on: https://chromium-review.googlesource.com/c/1332087Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607371}

ServiceFilter will replace usage of Identity in APIs which take or
require only a partial Identity.

This CL adds the mojom and C++ type (with type-mapping) and updates
Connector's mojom to use ServiceFilter instead of Identity where
appropriate. Implementations of Connector are updated accordingly.

Follow-up CLs will transition callers to explicit use of ServiceFilter
and then finally change Identity to no longer have optional fields so
that all uses refer to concrete service instance identities.

Bug: 902590
Change-Id: I8587f2c7ba15a68d5d873f207ec8fa99dc0e7312
Reviewed-on: https://chromium-review.googlesource.com/c/1330895
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607370}

An incomplete implementation of the fullscreen shell protocol,
separated from server.cc to allow selective compilation for
different platforms that support EXO. The rest of the protocols within
server.cc will be refactored in future CLs.

Bug: 896710
Test: Compiled on ChromeOS, works with fullscreen client
Change-Id: Idda3b73c97c72e5efd16dfe1f7c79831587c8066
Reviewed-on: https://chromium-review.googlesource.com/c/1299838
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607369}

Adds a RandomTree that splits on features by decreasing entropy
improvement.  It does not select a random subset of features when
deciding on each split.  It also does not stop growing the tree
when no improvement is found, including pure leaves.

Bug: 902857
Change-Id: I742f64c71fd535bd7acc20b02b6478b20d9dae24
Reviewed-on: https://chromium-review.googlesource.com/c/1324130
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607368}

Many of these are leftover failure expectations from fixed bugs.
Some were fixed on some platforms but not others. There are some
new failures that were hidden by previous broad suppressions. Also
some tests are only failing because we haven't updated the drivers
on the bots (http://crbug.com/887241).

Bug: 757097, 838133, 672380, 625738, angleproject:2325
Bug: 534697, 849572, 625738, 703779, angleproject:2142
Bug: 757098, 644740, 705865, 602688, angleproject:2103
Bug: 903903, 740769, 662644, 680720, angleproject:1932
Bug: 709874, 887241, 625365, angleproject:2952
Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00
Reviewed-on: https://chromium-review.googlesource.com/c/1325197
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607367}

It doesn't appear to flake on desktop Linux or Chrome OS (ash or mash).

Bug: 69475
Change-Id: I6bebb08d7dd1bca61cc952eb58105eab0d67a1c4
Reviewed-on: https://chromium-review.googlesource.com/c/1327148
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607366}

Rather than sending (Instance, TargetValue), just bundle it up
into TrainingExample.

Change-Id: I145dd136af2fec8e2d1177ad8c9fc42dd2e79cf9
Reviewed-on: https://chromium-review.googlesource.com/c/1318389Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607365}

R=proberge@chromium.org

Bug: 830892
Change-Id: Ib22499d88a2fdb160a083eeb904e17e24a96edfc
Reviewed-on: https://chromium-review.googlesource.com/c/1331876Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#607364}

The image model for the popup setting is currently a
ContentSettingBlockedImageModel. This CL makes it inherit from
ContentSettingSimpleImageModel in order to make policy changes easier
to make moving forward, including making the image visible in non-blocked
cases (e.g. an ambient UX).

This CL has no intended behavior change.

Bug: 82362
Change-Id: Ib49c5c0d428017ef566b465cb4cb1fb8a0ab79e1
Reviewed-on: https://chromium-review.googlesource.com/c/1331908Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607363}

On each LE advertisement event, we forward the event along with the EIR
such that it's closer to the behavior in Android.

Please review along with ag/5453291

Bug: chromium:887029,b:118334521
Test: CtsVerifier
Change-Id: I4f56ef5e30087768acb7e897c5345380ffb7a633
Reviewed-on: https://chromium-review.googlesource.com/c/1321581Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#607362}

Bug: 903265
Change-Id: Id36168aa8b5db879e2ea63a7e22bc4b1492053da
Reviewed-on: https://chromium-review.googlesource.com/c/1331581Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607361}

IElevator is registered with unique IIDs for the various flavors of Chrome and Chromium. This allows the different flavors of Chrome/Chromium to co-exist without side effects.

Bug: 833687
Change-Id: Icbba17012165cc9e3c04a47590a78b54bec761e7
Reviewed-on: https://chromium-review.googlesource.com/c/1327352
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607360}

This reverts commit 4cde6da1.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 607282 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGNkZTZkYTFiNmM4NTM0YjEyZGJlOGNlZDc2NTY1MTE2NWYyYmNlMgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/72883

Sample Failed Step: sync_integration_tests

Sample Flaky Test: USS/TwoClientWalletSyncTest.UpdateCreditCardMetadata/1

Original change's description:
> [AF] Add integration tests for wallet metadata
> 
> This CL creates the first integration tests for the autofill wallet
> metadata model type.
> 
> Bug: 894001
> Change-Id: Ie756264fe6b22d863a6965456ec0d7b627774c23
> Reviewed-on: https://chromium-review.googlesource.com/c/1306357
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607282}

Change-Id: I6021aa4d092acfeb62f635bc04c76b7c11738101
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894001, 904577
Reviewed-on: https://chromium-review.googlesource.com/c/1332393
Cr-Commit-Position: refs/heads/master@{#607359}

Using wpt-import in Chromium f4b94156.
With Chromium commits locally applied on WPT:
270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets"
687313c5 "Add action_sequence in testdriver"
395cf32d "Preparation of moving LayoutTests to web_tests."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Idd4c64b8b5158fac5d75aa0c13783bde42017fe5
Reviewed-on: https://chromium-review.googlesource.com/c/1331616
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607358}

Change-Id: I5aaebd553669d9b6594105edd4ba18f6b4701d20
Reviewed-on: https://chromium-review.googlesource.com/c/1331037
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607357}

Pedal suggestions are styled like new answers and entities
with this CL. The logic for deciding layout is also clarified.

Bug: 893183
Change-Id: Id7f4ad9e8a0d6aeffcbe623db65f29107aa79b52
Reviewed-on: https://chromium-review.googlesource.com/c/1330709Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607356}

The Feed can be disabled and destroyed without warning, meaning
calls to FeedProcessScopeFactory#getFoo() can return null. This CL
guards against that for FeedLifecycleBridge

Bug: 902123
Change-Id: Iff4fb6eb1c1e19358637159558d1983e774a42a2
Reviewed-on: https://chromium-review.googlesource.com/c/1327550
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607355}

Update the code to match https://w3c.github.io/encrypted-media/#close.
Most noticeable change is that other requests will be rejected once
close() has been called. Previously this only happened after the CDM
actually closed the session (as acknowledged by the close event).

BUG=901372
TEST=new layout tests pass

Change-Id: I59c2ad2705f1928d74e6f41a853c0f25c8975189
Reviewed-on: https://chromium-review.googlesource.com/c/1330349Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607354}

This is needed because the WebRTC change is moving the files and the
lack of the new entry in the blacklist will cause a crash in
content_unittests's DesktopCaptureDeviceTest.Capture. See
https://bugs.chromium.org/p/chromium/issues/detail?id=901319#c14.

Bug: 901319
Change-Id: I547c663c42a315841415032a6d53141a051ad402
Reviewed-on: https://chromium-review.googlesource.com/c/1325801Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
Cr-Commit-Position: refs/heads/master@{#607353}

While a navigation is pending, show the original URL if the browser is
navigating to the previews server.

Reworks the GetOriginal APIs in the Previews bridge to support a plain-
string impl since checking for a committed preview won't work while the
navigation is pending.

Bug: 894881
Change-Id: Ic8ffd3e16b270dd69efb7a62128265629a5b9de2
Reviewed-on: https://chromium-review.googlesource.com/c/1330761Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607352}

This reverts commit 0d2550b1.

Reason for revert: Fixed NetworkContextConfigurationFilePacBrowserTest

Original change's description:
> Revert "Get NetworkChangeNotifier working on ChromeOS with network service."
>
> This reverts commit 7b0677dd.
>
> Reason for revert: findit says this broke something. I'll revert and see if it's right tomorrow.
>
> Original change's description:
> > Get NetworkChangeNotifier working on ChromeOS with network service.
> >
> > The current NetworkChangeNotifierChromeOS implementation won't work
> > with the network service enabled because it listens for network changes
> > from Shill, which only supports a single client. The browser process
> > has other dependencies on Shill, so it has to be the client for the time
> > being, meaning the network service can't directly listen for network
> > changes and has to be notified of them from the browser process.
> >
> > This CL splits the NetworkChangeNotifierChromeOS into two parts;
> > the first will live in the browser process and listen to Shill, while
> > the second is the actual NetworkChangeNotifierChromeOS implementation
> > which will have an instance in both the browser and network processes.
> > Since NetworkChangeNotifierChromeOS can't actually listen for network
> > changes itself, it just gets notified of changes from part 1 via a new
> > method in NetworkChangeManager. When the thing listening to Shill sees
> > a network change, it notifies its local NetworkChangeNotifierChromeOS
> > instance, and calls the new NetworkChangeManager method, the
> > implementation of which then notifies the network service's
> > NetworkChangeNotifierChromeOS instance.
> >
> > Bug: 882610
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414
> > Reviewed-on: https://chromium-review.googlesource.com/c/1274445
> > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#606665}
>
> TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org
>
> Change-Id: I1fa2bcabe73082e02e59f7c613d08aec4ac94e57
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 882610
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/c/1328701
> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606745}

TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org

Change-Id: Ied0722203a1fa29aa3420bb84c70dee15d47fbb6
Bug: 882610
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1329897Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607351}

Previously it uses strip_k_prefix = False in update script but
strip_k_prefix = True in the presubmit checker. This CL fixes
this bug.

Change-Id: Ibd710b55c1f21ee944840a7dec2996cd20ef87a2
Reviewed-on: https://chromium-review.googlesource.com/c/1331634
Commit-Queue: Luna Lu <loonybear@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607350}

This feature is guarded by --chromium_flag_http2_varint_decode_64_bits.

Before this change, HpackVarintDecoder only decoded integers up to 2^28
+ 2^prefix_length - 2, where prefix_length is between 3 and 7.  Trying
to decode larger integers resulted in an error.  After this change,
HpackVarintDecoder decodes any integer that can be represented on 64
bits (unsigned).  Any input that HpackVarintDecoder decoded before this
change is still decoded.

Decoded integers are used to address entries in the static and dynamic
tables, to specify string lengths, and to update the size limit of the
dynamic table, both in HTTP/2 and in QUIC.  For all of these values
there is already a limit in place that is much lower than 2^28
(otherwise a malicious client could waste hundreds of megabytes of
server memory; and if there is no such limit in place, then we already
have a problem), so making the decoder decode larger values should not
change behavior at higher levels.

To merge this feature, this change also adds an HTTP/2 platform API for
flags,  maintaining parity with SPDY and QUIC (and keeping the
separation between SPDY and HTTP/2 for ease of merging to Chromium).
This change then uses this platform API in the related files referencing
the feature flag and adds a presubmit check.

This change borrows heavily from the pre-existing SPDY and QUIC platform
API for flags.

This CL lands server changes 216463549 and 221087569 by bnc, and
218390247 by diannahu.

BUG=488484

Change-Id: Ie0788f117aba9c6d41fc31148e28c9b49e122602
Reviewed-on: https://chromium-review.googlesource.com/c/1310613Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607349}

Ctrl+Shift+K to toggle. Exists behind --enable-viz-hit-test-debug flag.
Debug quads are drawn around every hit-test region (in HitTestAggregator), cycling through cyan,
green, and magenta depending on depth. Quads will tinted if kHitTestAsk flag is set.

LayerTreeDebugState is used to store hit-test debug information, which is then added as a
HitTestRegionFlags.

Example: https://screenshot.googleplex.com/rO5xGuTYdHf

R=riajiang@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I13efbb7f6d520f85c2b00711bb708a7f9338baea
Reviewed-on: https://chromium-review.googlesource.com/c/1240508Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Alexander Shah <zandershah@google.com>
Cr-Commit-Position: refs/heads/master@{#607348}

As part of this change, also update the IndexedDBKey
constructors to support std::move().

Bug: 902498
Bug: 717812
Change-Id: Ifd94d01a525850c6293fbfaf28624d3614a419a6
Reviewed-on: https://chromium-review.googlesource.com/c/1321164
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607347}

R=cmasso@chromium.org

Change-Id: I8c49b9e68258ae2b9a21b1f17b4fbc9717180be8
Reviewed-on: https://chromium-review.googlesource.com/c/1332251Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607346}

This CL adds logging for the following histograms at tab switcher open
time:
  - Tabs.Tasks.TabCreated.Count.FromManuallyCreated
  - Tabs.Tasks.TabCreated.Count.FromTargetBlank
  - Tabs.Tasks.TabCreated.Count.FromExternalApp
  - Tabs.Tasks.TabCreated.Count.FromOthers

  - Tabs.Tasks.TabCreated.Percent.FromManuallyCreated
  - Tabs.Tasks.TabCreated.Percent.FromTargetBlank
  - Tabs.Tasks.TabCreated.Percent.FromExternalApp
  - Tabs.Tasks.TabCreated.Percent.FromOthers

Bug: 890502
Change-Id: I2fa8d8e20596c43057f172a65683ba1b1860a63c
Reviewed-on: https://chromium-review.googlesource.com/c/1313550
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607345}

With servicification, NQE (Network Quality Estimator) prefs manager
can be used on a single thread. This CL makes NQE prefs manager
a single threaded class by combining methods that were previously
executed over separate threads.

Change-Id: Ic332bfeecc77f7d3401cd63ce1126f954fbbefc8
Bug: 878844
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1331178
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607344}

Race condition is caused by RenderProcessHost::Shutdown recreating the
sync IPC channel and asynchronously causing SyncContext::OnChannelOpened
to be called on the IO thread.

In the interim the RPH has been deleted, causing the WaitableEvent that
was passed to the SyncContext to be destroyed before it is used.

Because we never intend to use the WaitableEvent to signal shutdown in
WebView, it's simplest to just pass null for the shutdown_event,
indicating that the caller never intends to signal shutdown.

Bug: 904043,865062
Change-Id: I69a51adc78a0f1c0d6f84fbb7206fc9d58e69ed2
Reviewed-on: https://chromium-review.googlesource.com/c/1329670
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607343}