- 14 Jun, 2018 40 commits
-
-
crystallambert@chromium.org authored
This adds documentation that explains users must allow file:// urls through extension management page Bug: 850693 Change-Id: I214bd285c076babb4ba6a7769db4d4a9c54c1916 Reviewed-on: https://chromium-review.googlesource.com/1093257Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#567384}
-
Steve Kobes authored
This prevents spurious trace events from the empty document created before navigation begins. Also annotate trace events with the frame they correspond to, combine score and max distance into a single TracedValue, and change trace category to "loading". Bug: 581518 Change-Id: I9ee8005596245ad31c78a8556ec837e2ef999d24 Reviewed-on: https://chromium-review.googlesource.com/1101245Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567383}
-
Wez authored
- Add the ScopedZxHandle APIs to the base zx::handle. - Add missing includes. This allows ScopedZxHandle to be removed incrementally from call-sites. Bug: 852541 Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97 Reviewed-on: https://chromium-review.googlesource.com/1100132 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#567382}
-
Ted Choc authored
ScrollingBottomViewSceneLayer extends from SceneLayer and that does a native call in its constructor, which can cause a crash if native isn't loaded. This moves the scene layer to the model and into initializeWithNative. This might be a better short term fix than long term design practice though. BUG=850804, 852468 Change-Id: I5cda1e24787ea6558d7ac07b3ef49f6503c32243 Reviewed-on: https://chromium-review.googlesource.com/1100130 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567381}
-
Fan Yang authored
R=zhongyi@chromium.org Change-Id: I4c556473f320dc4e0857457ef4e9843bc86d1c10 Reviewed-on: https://chromium-review.googlesource.com/1101248Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567380}
-
Steven Bennetts authored
iron-a11y-keys is not scoped, i.e. it is global within a component, so it is not a good choice for complex components. Bug: 827953 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65ce312f3476a85d75b2f806ecd5fac7ec70fe12 Reviewed-on: https://chromium-review.googlesource.com/1100311Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567379}
-
Jialiu Lin authored
Enterprise password reuses are handled differently from sync password reuses in 3 ways: 1. enterprise password reuses don't require sign-in 2. "Change Password" button on modal warning and page info bubble takes user to enterprise change password page ( instead of chrome://settings) 3. unhandled enterprise password reuses are not persisted across sessions (since we're not showing them on chrome://settings). They are only tracked in their own web_contents. A follow-up CL will add more UMA metrics. Another follow-up CL will further propagate the ReusedPasswordType enum to dialog and page info UI to assist choosing the warning text. Bug: 852138 Change-Id: Iefa9a176206715a74f5d569629ca1699b6c176a8 Reviewed-on: https://chromium-review.googlesource.com/1086152 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567378}
-
Xiaochu Liu authored
We add temporary logs so it shows up in feedback report. Detailed reasons can be found in the issue. This has to be removed immediately after the issue is fixed. BUG=chromium:851151 TEST=None Change-Id: I5be8e7532e2694d85710b58543c677949b206ecc Reviewed-on: https://chromium-review.googlesource.com/1100238 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#567377}
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia was using media_client library, which is deprecated now. Update //media to use AudioRenderer2 FIDL interface directly. Bug: 851733 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I356a0ae08798c2eb62d4cb42355aff4c47fbb360 Reviewed-on: https://chromium-review.googlesource.com/1096414 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567376}
-
Ken Rockot authored
Moves cloud print proxy and service process code off of Mojo EDK APIs and onto new equivalent public Mojo APIs. No functional changes. Bug: 844763 Change-Id: I8e0fe9cb0bf9a5daff1b63d7c7256e0929a5f540 Test: Build Chrome-branded official mini_installer on Windows and verify that when installed, the cloud print service can log in and manage cloud printers via the proxy. Reviewed-on: https://chromium-review.googlesource.com/1100166 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567375}
-
Helen Li authored
GCM and WebRTC depend on the ability to create proxied TCP and TLS sockets. This CL adds a mojo socket interface for this type of sockets. This CL adds: - network::mojom::ProxyResolvingSocketFactory This represents an interface that can create proxied sockets. Each instance has separate socket pools hanging off an HttpNetworkSession that is built using NetworkContext's params. - network::mojom::ProxyResolvingSocket This represents a socket interface that establish socket connection that respects system's proxy settings. There are functionalities missing. I am planning to add them in follow-up CLs. Bug: 844187 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5698e02d79708c0e07e57b1f4ac0f82cf484916d Reviewed-on: https://chromium-review.googlesource.com/1080948Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#567374}
-
Dominic Battre authored
Record UKMs for instances when the user generates a password and instances when the user modifies a generated password. Bug: 846694 Change-Id: I032a5f45823b4aa68b6b190ef24e7472b6ad44bf Reviewed-on: https://chromium-review.googlesource.com/1099242Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#567373}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/17b4574e14a3..de5f8a610a0a git log 17b4574e14a3..de5f8a610a0a --date=short --no-merges --format='%ad %ae %s' 2018-06-14 nya@chromium.org sync_stage: Correct early-crash notification message. Created with: gclient setdep -r src/third_party/chromite@de5f8a610a0a The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851198 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic8c84ce4d2e9aae868422788a137d75575e71b7c Reviewed-on: https://chromium-review.googlesource.com/1101042Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567372}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f6e160fa9ca5..75359664993b git log f6e160fa9ca5..75359664993b --date=short --no-merges --format='%ad %ae %s' 2018-06-14 geofflang@chromium.org Implement EGL_KHR_debug. 2018-06-14 lucferron@chromium.org Vulkan Intel: Flaky test suppression 2018-06-14 lucferron@chromium.org Vulkan: Support the indices offset in drawElements calls Created with: gclient setdep -r src/third_party/angle@75359664993b The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id801488319c892c26f6756f3c79260c21a6068de Reviewed-on: https://chromium-review.googlesource.com/1101359Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567371}
-
Eric Stevenson authored
This is a reland of eb3da872 Original change's description: > Android: Remove BuildHooksAndroidImpl from the main dex. > > Removing the reference to BuildHooksAndroidImpl from BuildHooksAndroid > shrinks the main dex by ~2000 methods for downstream targets. > > Bug: 820570 > Change-Id: If4051f7a85e387129c65a7a5b927183b5b36bf65 > Reviewed-on: https://chromium-review.googlesource.com/1089625 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565305} Bug: 820570 Change-Id: I8fbaf650ac1ed444ccc6d2cbd3d6d45ab045451f Reviewed-on: https://chromium-review.googlesource.com/1093111Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#567370}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/724a97d08d35..9eb38866cd65 git log 724a97d08d35..9eb38866cd65 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 srte@webrtc.org Adds field trial parser. 2018-06-14 peterhanspers@webrtc.org Metal view: Update drawable size when rotating. Created with: gclient setdep -r src/third_party/webrtc@9eb38866cd65 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idc3c6ce6eab39853faa9d1ca7d64d0c99c69fc41 Reviewed-on: https://chromium-review.googlesource.com/1101357Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567369}
-
Morten Stenshorne authored
Which object type to create depends on whether we are to use LayoutNG or not. This was already working correctly for block flow, but not for flexbox. Since we can no longer assume that a flexbox is of type LayoutFlexibleBox (LayoutNGFlexibleBox inherits directly from LayoutBlock), it would be impossible to call the protected method SetDocumentForAnonymous() on a LayoutBlock from LayoutFlexibleBox::CreateAnonymous(). So just move everything into LayoutBlock::CreateAnonymousWithParentAndDisplay(). No behavior changes intended for block flows. For flexbox, on the other hand, we're now able to create anonymous LayoutNGFlexibleBox objects, This doesn't seem to affect any enabled tests, though. Support for LayoutNGFlexibleBox is behind the LayoutNGFlexBox runtime flag, which normally isn't enabled. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If0d1b0607c65ac46253e9d91a77faafa1de6486d Reviewed-on: https://chromium-review.googlesource.com/1100817Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#567368}
-
Yi Gu authored
Currently the sync mechanism between cc and worklet is stateless meaning that it sends a new copy of the world every sync cycle. This has the benefit of keeping things very simple initially but it is not necessarily very efficient. This patch makes worklet animation stateful and adds the ability to mutate only a subset of animations. Bug: 843255 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I18e5d64d0145394fad739a70fa7d0e91bb0e4588 Reviewed-on: https://chromium-review.googlesource.com/1092413 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567367}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7124db04..900b6b8c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7ee6db0d8bcb489edfd4d261917426f803444599 Reviewed-on: https://chromium-review.googlesource.com/1101309Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567366}
-
Francois Doray authored
TBR=noel@chromium.org Bug: 852788 Change-Id: I4743b9a85680d07492c92324a24f29225b415279 Reviewed-on: https://chromium-review.googlesource.com/1101251Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567365}
-
Victor Costan authored
Change-Id: Ib37c918d0e96be88c51e5ce3a06f2d1e39ba3f75 Reviewed-on: https://chromium-review.googlesource.com/1100678Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#567364}
-
Ryan Sturm authored
These histograms haven't been viewed, and don't provide much value. Bug: 852621 Change-Id: Id3c859b9ec7fe0118010c1c92e787df8773f2090 Reviewed-on: https://chromium-review.googlesource.com/1100176Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#567363}
-
John Z Wu authored
//ios/web_view will delete all locally saved data after logging out. Change-Id: Ief9ea2ead7d49d9900575ce1c7784333baa99ea6 Bug: 852436 Reviewed-on: https://chromium-review.googlesource.com/1089796 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567362}
-
dpapad authored
Bug: 714021 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c96ce501e1d5ff65b8c27f7d04dab83694acc2e Reviewed-on: https://chromium-review.googlesource.com/1090000Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#567361}
-
chrome://safe-browsingVarun Khaneja authored
Bug: 750327 Screenshot: http://screen/Uww4i7zS0iQ Change-Id: If3d63958f9cb5d0bd97555dade30a3071e79f69a Reviewed-on: https://chromium-review.googlesource.com/1096898 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#567360}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ie3f5e71a10f9ea0b8e3eec260fbd3f95703021e8 Reviewed-on: https://chromium-review.googlesource.com/1101249Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567359}
-
Ryan Daum authored
* Add testing for GestureCancel and GestureProgress. * Fix missing CanHandleGesture before dispatching TAP gesture. * Fix missing CanHandleGesture before cancel & progress. Bug: internal b/75979846 and b/109888887 Test: unit tests Change-Id: I716c13376cd3d8d6e5ae6cf3d3b4ce085914a6bd Reviewed-on: https://chromium-review.googlesource.com/1101165 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#567358}
-
Hiroshige Hayashizaki authored
This CL merges ModulatorImplBase::CompileModule() into ModuleScript::Create() and removes Modulator::CompileModule(), - Because ModuleScript will need more closer interaction with ScriptModule and V8CodeCache in bindings. - Also this is a part of removing indirect layers around Modulator. Bug: 845285, 841466 Change-Id: I4a2be4a816c4cc89a9ad57f8b0ec5a206000343c Reviewed-on: https://chromium-review.googlesource.com/1065061 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#567357}
-
jonross authored
Currently MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated is disabled on Android, Windows and Linux due to flakes. When running on Mac with --enable-features=VizDisplayCompositor I have also seen this test flake. I'm disabling the test on all platforms until it can be redesigned. TEST: MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated Bug: 801629 Change-Id: I9c98d3e8ab90f24f23f50d1657d49cf0c1c95c29 Reviewed-on: https://chromium-review.googlesource.com/1101299Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#567356}
-
John Rummell authored
The maximum frame size in VP8 is 16,384 x 16,384, which uses most of the default 2048 Mb allowed. Bumping up the size to 4096 Mb to handle the larger frame size. BUG=808775 TEST=fuzzer test case passes Change-Id: I8e1e56bbd0936e745792f34106c7e638ff5a1c2b Reviewed-on: https://chromium-review.googlesource.com/1100004Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#567355}
-
Ryan Hansberry authored
ProximityAuthWebUiHandler now uses either ProximityAuthClient or DeviceSyncClient to get remote device info or perform Cryptauth calls, depending on whether the chromeos::features::kMultiDeviceApi is enabled. Once the migration to DeviceSyncClient has been completed across all of Smart Lock, code that references ProximityAuthClient will be removed. This is one of many future CLs which are migrating Smart Lock to use DeviceSync Mojo API instead of directly using the CryptAuth API. I have manually verified the correctness of this change by verifying the output on chrome://proximity-auth. Bug: 824568, 752273, 848956 Change-Id: Ia6bf1666f631a79c2873df3745232b8a8152bc8e Reviewed-on: https://chromium-review.googlesource.com/1099050 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567354}
-
Nico Weber authored
Undoes the split added in https://chromium-review.googlesource.com/1081627 The motivation for that split was that we don't have capacity to run the test on both the win7 and win10 default cq bots. Use test_suite_exceptions.pyl to not run the tests on the win7 cq bot. This adds the test to the clang tot bots and some more main waterfall win bots. Bug: 818832,839419,843511 Change-Id: I550d01b33695bf07dea3b97a4bf6a0d8b3f404f4 Reviewed-on: https://chromium-review.googlesource.com/1099135 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567353}
-
Xiyuan Xia authored
This CL wires up the drop code path for remote window. That is, dragging from a local window and drop it on a remote window. Bug: 837716 Test: services_unittests DragDropDelegateTest.* Change-Id: I3490864b169ca0873ee3def4dce74d855913643c Reviewed-on: https://chromium-review.googlesource.com/1099176Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567352}
-
Becca Hughes authored
This is a reland of 326c044a This is unchanged except for a test fix to web_contents_impl_browsertest.cc. TBR=mlamouri@chromium.org,sky@chromium.org,kinuko@chromium.org,foolip@chromium.org Original change's description: > Display Cutout: Notify the browser process on fullscreen frame change > > Notify the browser process when the frame owning the current > fullscreen element is changed. > > Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 > > BUG=838400 > > Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 > Reviewed-on: https://chromium-review.googlesource.com/1054441 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567162} Bug: 838400 Change-Id: I72c8dff2b4b1d9df5410c3fa14ea32eb5d606ca9 Reviewed-on: https://chromium-review.googlesource.com/1101140Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567351}
-
Eugene But authored
Updated the code to wait until Open in.. button shows up. Bug: 852532 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6f40e5fa401d8dc600cef4b43ab12b471ac1ae75 Reviewed-on: https://chromium-review.googlesource.com/1101305 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567350}
-
Martin Kreichgauer authored
This moves the definition of the concrete keychain-access-group value into AuthenticatorRequestClientDelegate, rather than hard-coding it in the TouchIdAuthenticator. In the process, TouchIdAuthenticator creation is moved out of //device/fido and into AuthenticatorImpl because of the dependency on values from //content/browser. For Chrome specifically, also update the keychain-access-group value to match what we're setting it to in official builds since crrev.com/c/1079833. Bug: 837392, 848052 Change-Id: I97ef8972fed7ee29c597b9ab510d4a642b5a165a Reviewed-on: https://chromium-review.googlesource.com/1083712 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567349}
-
Hiroshige Hayashizaki authored
Previously, classic inline script's source_text to be evaluated is taken from the element's child text content at the time of evaluation. However, according to the spec, this should be the element's child text content at the time of #prepare-a-script. This CL fixes this by taking the element's child text content in ClassicPendingScript's constructor, which is called inside PrepareScript(). This affects the behavior if parser-inserted classic inline <script>'s innerText is modified by JavaScript after <script> is inserted into DOM before its evaluation, and I expect this is extremely rare and doesn't have legitimate use cases. Bug: 686281 Change-Id: I0ef67dd8b71403a7862f24d02394f89c6e916bfd Reviewed-on: https://chromium-review.googlesource.com/1091912Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#567348}
-
Christian Fremerey authored
Added all video pixel formats from media::VideoPixelFormat to media::mojom::VideoCapturePixelFormat. Updated Mojo typemapping to have a 1:1 mapping between the two. A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1026795 caused a regression by introducing a new mojo enum VideoCapturePixelType and typemapping it to media::VideoPixelFormat, see crbug/839742. A quick mitigation fix was landed and merged into M68. However, the fix is specific to a particular single format. The current state still has the danger of having produced similar regressions occurring for other formats, which may simply not yet have surfaced. Using TBR since this has been reviewed previously at https://chromium-review.googlesource.com/c/chromium/src/+/1050489 TBR=xhwang@chromium.org,rockot@chromium.org,sandersd@chromium.org,rsesek@chromium.org,chfremer@chromium.org,lasoren@chromium.org Bug: 852096 Change-Id: I6f6d3add996d3557f33fbd42084ad2a9844b5957 Reviewed-on: https://chromium-review.googlesource.com/1098143 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567347}
-
Allen Vicencio authored
Uses SmbUrl to parse the path passed to Mount and resolve the URL using SmbShareFinder Bug: 757625 Change-Id: I4d5ca6aa0fbc6c59728c650804b189b275faaf30 Reviewed-on: https://chromium-review.googlesource.com/1097710 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#567346}
-
wutao authored
We need to update device_settings_update's device id and type. We update them when the assistant service starts. Bug: b/110094434 Test: manual. Can see updated id and type in log. Change-Id: I1c85828482be49fb0e879cb233160236d0a676e1 Reviewed-on: https://chromium-review.googlesource.com/1099965Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567345}
-