- 24 Jan, 2020 40 commits
-
-
Natalie Chouinard authored
Following the naming conventions decided in go/clank-preferences-refactor, this change replaces the "Preferences" suffix with "Settings". Bug: 1030446 Change-Id: Icc4f86b119194cc92716b5452711ea8dfafd8883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014623Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#735132}
-
Francois Doray authored
TBR=ajgo@chromium.org R=ajgo@chromium.org Bug: 1045564 Change-Id: Ibd82b6b2635f773df74467d45dfd390d3a9a0e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020802Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/829bdae45d24..955353d9a221 Created with: gclient setdep -r src-internal@955353d9a221 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1023913,chromium:1028270,chromium:927262 Tbr: jbudorick@google.com Change-Id: I0b60e8756d3bbbb4784ca793b9cb01abeff0c31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020507Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735130}
-
Dana Fried authored
This might be the root cause of the tagged issue, though it is no longer reproducible. Note that layout is already invalidated when the title changes, for ostensibly the same reason. Bug: 1038448 Change-Id: I3f4e40d8450fc1a96da1d0c1b1e6e9b2c9ac661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018487Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#735129}
-
Ryan Sturm authored
This replaces app state observing with tabbed activity observing. One key difference is that tabbed activity does not include CCT. We only want to preconnect DSE for non-CCT chrome foreground. Bug: 1041118 Change-Id: I9e88e15c11cdfd7d13078a71c680be31c9b05932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006478 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#735128}
-
Karan Bhatia authored
$document exception rules can be implemented using allowAllRequests action type. BUG=1038831 Change-Id: Iab90eff5923ad76b3091f54479c1cafe33e92a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005113 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735127}
-
Lukasz Anforowicz authored
Overview ======== Before this CL, opaque origins would be allowed without any further checks in the following callers of CanAccessDataForOrigin: 1. VerifyInitiatorOrigin 2. GetOriginForURLLoaderFactory 3. AppCacheSubresourceURLFactory::CreateLoaderAndStart 4. RenderFrameMessageFilter::OnOpenChannelToPepperPlugin This CL adds a comment with more details on why special casing of opaque origins in VerifyInitiatorOrigin is needed. This CL removes such special casing in GetOriginForURLLoaderFactory, CreateLoaderAndStart and OnOpenChannelToPepperPlugin. This is accomplished by moving the special-casing into CanAccessDataForOrigin itself. Special-casing opaque origins without a precursor origin ======================================================== A browser-initiated navigation to a data: URL will commit an opaque origin without a precursor origin. Such commit may happen in a renderer process locked to a http site URL. See also PDFExtensionTest.EnsureInternalPluginDisabled. To account for the scenario above, before this CL, opaque/no-precursor origins would be allowed to commit via ChildProcessSecurityPolicyImpl::CanCommitOriginAndUrl. After this CL, opaque/no-precursor origins are allowed in ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin instead. Before this CL, an origin might be allowed to commit (via CanCommitOriginAndUrl) but fail to pass post-commit IPC checks later (i.e. fail CanAccessDataForOrigin checks) leading to a renderer kill. After this CL, this inconsistency is mitigated, avoiding such renderer kills (at least in the scenarios special-cased by this CL). Bug: 1029092 Change-Id: I552668478a2b27b13e956b13d333393fa844ef28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007983 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735126}
-
W. James MacLean authored
This CL is a first step towards implementing origin isolation opt-in via OriginPolicy. At present, this CL just looks for the existence of any top-level "isolation" key (true or a dict) in the OriginPolicy manifest. The opt-in status is stored in ChildProcessSecurityPolicyImpl in two ways: * a master opt-in list that reflects the opt-in status for a given origin as of the most recently received OriginPolicy, and * a per-BrowsingInstance map that tracks all origins that have been loaded into that BrowsingInstance and have isolation enabled. The first navigation to an origin in a BrowsingInstance will respect the current opt-in status in the master opt-in list, and if the origin opts in to isolation the opt-in status with respect to the BrowsingInstance is set at that time. However, if an origin does not opt in, then this CL does not track that (this will be in a near-future CL). This CL should be a functional implementation of origin-isolation opt-in and only requires --enable-features=OriginPolicy to enable it. Of course, one also needs an origin's server to send an appropriate OriginPolicy manifest. Bug: 1042415 Change-Id: I1d7ecb4c77a52048bd2ebe780d763e47270ea5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956014 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#735125}
-
Hans Wennborg authored
This reverts commit 0aa05cca. Reason for revert: This broke arm64-builder-rel and some other builders, see bug. Original change's description: > Roll clang n333938-3a6da112-1 : n340158-efb130fc-2. > > Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. > > This increases the clang version from 10 to 11. > > It also disables the use of vector instructions in zlib to work around > new false positives in msan (see crbug.com/1045291). > > Bug: 1030664 > Change-Id: I5417d3063f0d67a61cdf31141b05a51a56e84482 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014904 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735080} TBR=thakis@chromium.org,hans@chromium.org Change-Id: I48754484c26ebf6b1f0b4a47c82fe3c74ee39837 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664,1045592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020785Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#735124}
-
Sergey Ulanov authored
Previously LayerTreeHostImpl was return 8 or 4 depending on device scale factor. This makes it more likely that the devices runs out of memory usable for textures. Updated RequestedMSAASampleCount() to always return 4 on "low-end" devices to save memory. Bug: fuchsia:43693 Change-Id: I98bbe794614fa73a4cecbf13c1fcd3c0f0e55a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018332 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735123}
-
Henrique Nakashima authored
Bug: 1041468 Change-Id: I5514ebc9668acfb965a6393921a13837c5d05f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013462 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Fritz Koenig authored
Bug: None Change-Id: I78a846cbcf0408a1704f214214fe4afc189d8d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019938 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735121}
-
Sergio Collazos authored
This reverts commit 75044a52. Reason for revert: After this CL Landed in 7603: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/7603?blamelist=1#blamelist-tab All subsequent runs of iphone-simulator ui_eg2tests have failed: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator I tried repro locally but other than some DCHECKs I could make the test fail, but after I ran this revert using twosided.py the ui_eg2tests were completed successfully: https://ci.chromium.org/p/chrome/builders/try/iphone-simulator/229 Original change's description: > [iOS] Add a new option to non-managed account Sign-Out. > > Adds a new option for users in non-managed accounts to clear synced > data from their local device when signing out. > > Bug: 1005509 > Change-Id: Iae3b599b3ca3698b2a176bd56b470c6787c74367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007695 > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734681} TBR=sdefresne@chromium.org,jlebel@chromium.org,fernandex@chromium.org Change-Id: I0d0742663b7b27cfefde24380b3a2c331aafb4e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020323 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735120}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I1721c8cea3e035192a9dfa05539a86342450d3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735119}
-
Joe Downing authored
This reverts commit bb8e99d0. Reason for revert: Suspected of causing ozone_unittest failures on ChromeOS MSAN builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17456 Original change's description: > Replace drmModeSetCrtc by Atomic APIs > > If the device supports atomic APIs, use drmModeAtomicCommit to modeset > and disable instead of drmModeSetCrtc. > Abstracted Modeset and Disabled code to HDPM to handle both atomic and > legacy call. > Updated tests to support Connector and CRTC props. > > BUG=987274 > TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, > HardwareDisplayPlaneManagerLegacyTest.Modeset, > HardwareDisplayPlaneManagerLegacyTest.DisableModeset, > HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on > Nautilus(Intel), Grunt(AMD) and Cave(Legacy). > > Change-Id: Ic307c04df4e22d1696abb31ebcd820f6bdcb542a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715751 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735013} TBR=dnicoara@chromium.org,dcastagna@chromium.org,markyacoub@google.com Change-Id: I05afd1f0419d53814889c4968ecbace723829ff5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020865Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735118}
-
Joe Downing authored
This reverts commit 8d695b07. Reason for revert: Suspected of causing multiple webkit_layout_test failures involving scrolling on the Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16924 Original change's description: > [Reland] Make programmatic scrolls respect smooth scroll flag > > Programmatic smooth scrolls should also be instant if the smooth scroll > flag is explicitly disabled. > > Previously landed in https://crrev.com/c/1536759 > > To reland, this CL force enables the scroll animator in Blink web > tests. Without this, the usual flow for determining if the animator is > enabled is followed, which leads to inconsistencies. On Mac, the > animator is enabled in Chrome but not in content shell. This leads to > inconsistencies with other platforms (Mac tests ran without smooth > scroll while Linux/Windows ran with) and ensuring we test what we ship. > > This change required some minor fixes to tests that assumed instant > scroll on Mac (and uncovered one real bug). > > Bug: 944583 > Change-Id: I114d8b882d9855fbe0c43645575a1cdd7c3b6e61 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009842 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735006} TBR=flackr@chromium.org,nasko@chromium.org,bokan@chromium.org Change-Id: Ifa361e963dbc536830ad245ef31bfae542954c33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020555Reviewed-by:
-
Kai Ninomiya authored
This reverts commit fd03e16d. Reason for revert: crbug.com/1045444 Original change's description: > Metal: Test offline-compiled shader link time > > Change metal_util::TestShader to test either compile or link, and > change the default behavior to link. > > Add inline data for a trivial test shader. Add code to modify the > bitcode, to defeat caching. > > Ensure that the Metal calls for the test are invoked on a thread > that has base::TaskPriority::HIGHEST. > > TBR=jvanverth > > Bug: 974219 > Change-Id: I35e688c3758af2e03f893a1ccbef7aef6b778b23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015486 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734645} TBR=ccameron@chromium.org,jvanverth@chromium.org Change-Id: I872bad72bfd2bbb4318e032db4b14bf43e14d6e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974219 Bug: 1045444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020567Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735116}
-
rbpotter authored
Autogenerate Polymer 3 versions of CrProfileAvatarSelector and its tests. This will be used by the chrome://settings page in future. Bug: 1042558 Change-Id: Ic0ccfae7768f5b06ec16e23ae434318e649a764a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016191Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735115}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I4481691a7e492da4e311805c3b3bf76884c5bd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020506Reviewed-by:
-
Jimmy Gong authored
- Print server printers are presumbably configured correctly and are IPP printers. - This prevents users from edit a good state printer into a bad state. - Adds browser test to reflect this change. Bug: 1015628 Test: browser tests Change-Id: I23878c588655b9325c1a8527df4779a59e493d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015579 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#735113}
-
David Black authored
This browser client will be responsible for downloading conversation starters from the server when the new V2 feature flag is enabled at the discretion of the AssistantSuggestionsController. Note that this CL only adds the bare bones interface/implementation and follow up CLs will add/make use of new APIs. Bug: b:148239201 Change-Id: Ifb97461f1eee61c7420f5f2ee652a4092b0d3787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018382 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735112}
-
Hazem Ashmawy authored
Perform copying when a list item is long clicked on instead of just clicking. Long click sounds more intuitive for copying behaviour. Short clicks also looked spamy, since it can be an accidental touch while scrolling, opening or closing a menu. Also access item data using the recommended API parent.getItemAtPosition rather than from the data array itself for cleaner code and better managed variable scope. Bug: 948923 Test: Manually long press item lists. Change-Id: Ib54c3c5a1778d9c9d38814f9861f1b6b61b6ba83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020702Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#735111}
-
Ahmed Mehfooz authored
Bug: 1009523 Change-Id: Ie52edb90f65e4a90007c18be2a3051fc351fb040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018184 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735110}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a793e97ab5e1..09dbeace089e git log a793e97ab5e1..09dbeace089e --date=short --first-parent --format='%ad %ae %s' 2020-01-24 dhoss@chromium.org Add --disable-xfa flag to test_runner.py 2020-01-24 tsepez@chromium.org Avoid redundant EnumFontList() invocations. 2020-01-24 thestig@chromium.org Replace str[str.GetLength() - 1] with str.Last(). 2020-01-24 thestig@chromium.org Remove #defines in cpdf_textpage.h. 2020-01-24 thestig@chromium.org Give a couple CPDF_TextPage members better names. 2020-01-24 maawas@microsoft.com Adding APIs to get name, type and value of form fields Created with: gclient setdep -r src/third_party/pdfium@09dbeace089e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ibd7cfede35d0af8d5f7af23e2af6a95eea0f953d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020322Reviewed-by:
-
Austin Eng authored
This makes it possible to use WebGPU on Linux NVIDIA without disabling the GPU sandbox. It still requires --use-vulkan so that Chrome loads the Vulkan driver before creating the GPU sandbox. Bug: 852089 Change-Id: I80ea898af221e48c5dd6a471a468628b47cc1992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013474 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#735108}
-
Avi Drissman authored
This is preparation for cleaning out sdk_forward_declarations. BUG=1044828 Change-Id: I3b86f376cf489be3f3c2fc3a8ce663043725504e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019766 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735107}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3ac3f8c4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: andruud@chromium.org: external/wpt/css/css-properties-values-api dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/resources jsbell@chromium.org, mek@chromium.org: external/wpt/webstorage kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc meade@chromium.org: external/wpt/web-animations mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org: external/wpt/trusted-types msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I23a133edf73978ec2a359d12847c8ec4d102ecb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019825Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735106}
-
rajendrant authored
This CL uses optimization guide to fetch the public image URLs as hints and sends to renderer where URL loader throttles allow redirect only for the subresource URLs in the list. Change-Id: Id654d041c376420a6e4d2a4daf3fdb51b24056f9 Bug: 1042869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996944 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735105}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/214a08493a82..0dace75a3e64 git log 214a08493a82..0dace75a3e64 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 treehugger-gerrit@google.com Merge "Remove FrameBuffer name and handle from RenderStage slice name" 2020-01-24 hjd@google.com Merge "ui: Open .trace systrace files directly in legacy UI" Created with: gclient setdep -r src/third_party/perfetto@0dace75a3e64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib803985d13474c0efc93cc5be6f81c7ba2bf8e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020326Reviewed-by:
-
Lukasz Anforowicz authored
This CL explicitly allows blob:null/... and data:... lock URLs when using CanAccessDataForOrigin to validate precursor of an opaque origin. This CL has been extracted from a slightly bigger refactoring at https://crrev.com/c/2007983/11. This CL helps avoid renderer kills reported in https://crbug.com/1041880 Bug: 1041880, 1029092 Change-Id: I923512c8fc03491b4f95547240b3b7f8a88f7104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020327 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Avi Drissman authored
We build with the 10.14 SDK, so this is not needed. BUG=1044838 Change-Id: I81ac8d37ee65d78d4b5a062b251c9fcfec840b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020422 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
-
Wez authored
These tests all make use of either base::test::TaskEnvironment or content::BrowserTestBase (via the WebEngineBrowserTest helper), which already set default ScopedRunTimeouts. Bug: 1021777 Change-Id: Ifbc5c29fb7dc1380c1d97bf6a49ff71c02b7e7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020642 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735101}
-
François Doray authored
This reverts commit b4d501e3. Reason for revert: This CL is on the blame list of the first failures observed for PortalBrowserTest.FocusTransfersAcrossActivation on Mac, and it is related to focus. Original change's description: > Focus tab contents in BeginNavigation case of NTP-initiated navigations. > > Tab contents may get focused during some renderer-initiated navigations > (e.g. navigations from an NTP-replacement extension - see the regression > test added in r723022). This CL ensures that the focus decision is > applied not only to navigations that go through OpenURL, but also to > navigations that go through (more freqeuent, usual) BeginNavigation. > This change helps ensure that we retain the right focus behavior after > more navigations switch to the BeginNavigation code path (e.g. after > relanding ShouldFork removal in https://crrev.com/c/1949448). > > The CL covers both the OpenURL and BeginNavigation code paths by > handling the focus decisions in a newly added TabContentFocusingHelper > class (replicating/moving the focus decisions from OpenURL-only > Browser::UpdateUIForNavigationInTab). Adding a new tab-helper class is > useful, because the existing, OpenURL/BeginNavigation-shared navigation > notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot > distinguish between replaceState and new navigations (see also new steps > in the OmniboxFocusInteractiveTest.NtpReplacementExtension test). > > While this CL changes how focus behavior is implemented, it should have > no effect on end-to-end/high-level expectations of focus behavior (as > observed by end users or browser tests). > > browser_tests do not guarantee window activation and/or focus, but before this > CL navigation in browser_tests would focus WebContents. This is not happening > after this CL, and requires moving a handful of focus-dependent tests from > browser_tests to interactive_ui_tests. > > Bug: 1029161 > Change-Id: Ib57c260b2f85f276ff1dad3aabedd59d1d864c8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970834 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735048} TBR=pkasting@chromium.org,bbudge@chromium.org,creis@chromium.org,rouslan@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,bsheedy@chromium.org Change-Id: I43362d7689548761154b80b72a0734ca02569794 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029161, 1045594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020862Reviewed-by:
-
Maksym Onufriienko authored
Current update prevent creating/deleting simulators if test runs on real devices. Some bots don't have preinstalled sim-runtimes that match version of connected real devices, it was a reason of failure like https://chrome-swarming.appspot.com/task?id=49c31b4eab008710 To determine whether device with UDID is simulator used `xcrun simctl` command because `idevice_id` is not installed properly on some bots without real devices, e.g. https://chromium-swarm.appspot.com/task?id=49c9a229b161d210 Bug: 1042380 Change-Id: I3771af295dadf32068343bdc2691bedf0a5f72a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002895Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#735099}
-
Matthew Mourgos authored
This is a reland which has fixed msan failures by initializing |target_color_| in hotseat_widget.cc. In this change, the hotseat background will change color for different shelf states and will animate between colors when changing. When in-app shelf is shown the hotseat color should have an alpha value of 90%. When the home shelf is shown the hotseat color should have an alpha value of 60%. Bug: 1041132 Change-Id: I74c1fc9de07d7db1e39400a963d6a5c7c8149320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017913Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735098}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfca5c67f1a7..a7e557f3e353 git log cfca5c67f1a7..a7e557f3e353 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 michaelludwig@google.com Reland "Increase precision of some quad AA calculations" Created with: gclient setdep -r src/third_party/skia@a7e557f3e353 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10141204 Tbr: benjaminwagner@google.com Change-Id: I012f8db2f3ffbb1c57356940b328a47404e3ab9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019859Reviewed-by:
-
Samuel Huang authored
Previously DevUI DFM Java files have locations that are inconsistent with convention: * Java files under .../modules/dev_ui/ should be in package org.chromium.chrome.features.dev_ui, but were instead placed in org.chromium.chrome.modules.dev_ui. * /chrome/android/features/dev_ui/java should be /chrome/android/features/dev_ui/internal/java. This CL fixes the above. Change-Id: I523d040b0e1a2a041c2faa589d7606a04491ab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018248Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735096}
-
Richard Knoll authored
This adds the host implementation of the WebRtc service in the browser process. It implements a new SendMessageDelegate that can send Unido messages via the WebRtc service running in a sandboxed process. - The service is launched in SharingServiceHost::BindService with SandboxType::kUtility - SharingWebRtcConnectionHost handles sending / receiving data in plaintext as of now, with a follow-up CL adding encryption: https://crrev.com/c/2011925 - Signaling of WebRTC is done via FCM messages and passed through WebRtcSignallingHostFCM to and from the service Bug: 1031144 Change-Id: I44884b5debdf3001b82c32e467b07bc0de87c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995660 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#735095}
-
Tomasz Wiszkowski authored
This change replaces inheritance with generics and, in turn, flips relation between Base- and Specialized ViewBinder classes. While more verbose, this gives us a better control and protection over how views and view binders are created and used. With this change we get: - better control over what individual viewbinders see, - better compile-time diagnostics for accidental typos and copy-paste errors, - better support for selective view substitution (enabling us to further optimize suggestions mechanism while staying safe). For the most part this ensures Compiler will catch and report an error early. In the extreme case where an error is repeated everywhere the error will be caught and thrown at runtime upon view creation. This change aligns with the original design proposal for suggestions refactor. More details: https://crrev.com/c/2007943 Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8 Bug: 982818 Change-Id: Ic8425512f3904cc29ea410723a9b7a717492e191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017980 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735094}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/300b9ced..516ed977 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32fcf61627f8cc1f3584efcf397a10f45948a1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019824Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735093}
-
