- 19 Dec, 2019 40 commits
-
-
Oksana Zhuravlova authored
This change adds trace entries under content::Start. Also moves the call to TraceEvent.setATraceEnabled to the very beginning of startChromiumLocked(). Bug: 1019793 Change-Id: I06d3a9d4cb20075f2dc2ce999ffe5efe3d1dd0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962858Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726458}
-
Abigail Klein authored
Using the accessibility recorder on native chrome ui crashes Chrome, causing the bug below. This CL only shows the button to start recording events for web pages in the chrome:accessibility page. There is also a TODO to add support for native chrome UI later. Bug: 1035760,785493 Change-Id: I416e00f4b8e577c5f497074243bd5eadc68ab6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976017Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726457}
-
Jimmy Gong authored
- This is the fixed approached to retrieving the EULA URL for printer preview. - Previously, it was under the assumption that the EULA URL would be available in the Printer object. - EULA URLs are now fetched through a server call. Subsequent calls are cached, reducing the needs for more repetitive server fetching. - Fetching for the EULA URL does not block fetching capabilities. - We attempt to fetch the URL only after the user selects a destination, which may start a fetch for capabilities. So the calls may be in parallel. Feature: 1020586 Test: End to end manual, browserTest Change-Id: I8ce7592100de763710fae2a1f2b1b0edcf2b5d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967031 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#726456}
-
Andreas Haas authored
As the size ByteLength field of ArrayBuffers is now size_t, I changed the implementation of AudioBuffer::copyFromChannel and AudioBuffer::copyToChannel to be able to handle size_t buffer offsets. R=rtoy@chromium.org Bug: chromium:1008840 Change-Id: Iaf3a336a6fdc9c4af44708335a91b50de9d43783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975718Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726455}
-
John Abd-El-Malek authored
This matches Chrome & WebView, which fixes websites that use cache storage. This cl is meant to be small and self-contained so that it can be merged safely. I'll work on making this more generic in a followup. Bug: 1035420 Change-Id: I692f685569427e0d5277c97d5fca658cd2b56897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976550 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#726454}
-
Xiang Ji authored
Validation: https://ci.chromium.org/p/chromium/builders/try/win-celab-try-rel/102 Change-Id: I8b797a034515d71ad40be739b6b96199e29563d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970910Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#726453}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 36607112. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I39f5af0d6d86a759b715de7e5a7d01febc51b94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726452}
-
John Budorick authored
Encountered while running tests on the emulator bots, but liable to affect device tests as well. Bug: 922145 Change-Id: I80b78627975c248b9146e76d6ecbc65d89624376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976004 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#726451}
-
Andreas Haas authored
This CL replaces calls to deprecatedLengthAsUnsigned by calls to lengthAsSizeT. Unfortunately the current implementation cannot deal with huge ArrayBuffers yet. Therefore I reject the incoming ArrayBuffers with a RangeError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=rtoy@chromium.org Bug: chromium:1008840 Change-Id: If2518d9ea341212b9024f2b2f9e0f8d07db9899b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975883 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
Bug: 1035930 Change-Id: I95c63e80eb1c64a366a2d14018808ec2e6cc6712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976432 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726449}
-
Robert Ferrese authored
Bug: b/140491587 Change-Id: I0bb446e8740c058526c3899b4ec3ec47171d3d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956012 Commit-Queue: Robert Ferrese <rferrese@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726448}
-
yilkal authored
This CL default enables supervised user iframe filters. Bug: 850328 Change-Id: Iab050a660967d10a254e2a09896363279b1b487d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967756 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#726447}
-
Marijn Kruisselbrink authored
Since all this runs on the same thread these days, there is no longer any reason for FileSystemDispatcher::DidCreateSnapshotFile to create a BlobDataHandle. The callbacks called by it already do the same synchronously anyway. Bug: none Change-Id: I86cbc0f0c4feeb20b6495f6741493d9a11ec98b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975088Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726446}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/451c28a14b36..04d5ba90fb16 git log 451c28a14b36..04d5ba90fb16 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 brgoddar@microsoft.com Audits: give focus to New Audit button after completing a report. Created with: gclient setdep -r src/third_party/devtools-frontend/src@04d5ba90fb16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5ba94a66ee71a5051cdeb1a67c1a2ac1c15ef78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726445}
-
Bo Liu authored
Enable zygote in chromium code in chrome and content shell. Requires crrev.com/i/2340835 for private code to build. Change-Id: I99a3f550a81b0c877389ccb839b59afba8a7d447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976015 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#726444}
-
Rakib M. Hasan authored
Test expectations for directories need to have globs at the end of the pattern in the new expectations format. If they do not have a glob then the expectation will not apply to tests within the directory. Bug: 986447 Change-Id: Ia44254b7d79d26647463000a6c13cb6610f10101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974318 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#726443}
-
Jan Wilken Dörrie authored
This change adds branding strings for Touch To Fill and includes logic that selects the right string via a Finch parameter. It also modifies the padding computations to take the new string into account. Bug: 1034499 Change-Id: Ib262c12dd1fa4db6e5f0788feb46526ecd99a15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971835 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726442}
-
Sebastien Marchand authored
This CL does several things: - It removes the legacy IPC OnPageImportanceSignalChanged IPC. - It makes third_party/blink/renderer/core/page/chrome_client_impl.cc send a message to PerformanceManager in the browser process via Mojo when a frame is interacted with. - It removes a lot of unnecessary complex code from Blink. - It adds this this information to the FrameNode class. - It removes the property from the WebContents(Impl) class and move this to a WCUserData. One side effect of this CL is that the bit that indicates if a form on a page has been interacted with is now more accurate, as it gets cleared on navigation events. See crbug.com/1031661 for more details on this. Bug: 1031661, 793806 Change-Id: Iab62fabfe0e33cb1e6a9896153d8942008a35103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954606 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#726441}
-
Kurt Horimoto authored
This will allow this functionality to be shared between overlay-based and legacy infobar presentation. Bug: 1030357 Change-Id: I3f3182cf41880ba03b5f4257936230238c72f8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975016 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baf7a8617f37..2627d4d90fac Created with: gclient setdep -r src-internal@2627d4d90fac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: Ia1f46d7fe65dfcc88773ba73d84776565d891a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976450Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726439}
-
Zhongyi Shi authored
Those experimental APIs are consumed by some customers, and needs to be supported indefinitely. Add those APIs to presubmit checklist will help ensure those APIs are never modified or removed. Change-Id: I057fff4cfe30f08f020717f263f7050be399a000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974701Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#726438}
-
Stephen Nusko authored
This reverts commit 42d682b8. Reason for revert: Breaks perf tests crbug/1035865 Original change's description: > Create MemoryManagedPaintCanvas class > > With deferral enabled a canvas rendering context can create an > unlimited amount of GPU resources between frames. This class allows us > to track how much memory is being pinned and to flush the recording > after we pass a certain threshold. > > Bug: 1016727, 1015729 > Change-Id: I3a64dc07cc0239447aa721ea2a7cc808541a0a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960469 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Yi Xu <yiyix@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726085} TBR=jbroman@chromium.org,fserb@chromium.org,khushalsagar@chromium.org,yiyix@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org Bug: 1016727, 1015729,1035865 Change-Id: Ia0e7899b4381ae264ed67ae618d245d6a462067b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976003Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726437}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d04ddcd6c518..4ef1ca1d089e git log d04ddcd6c518..4ef1ca1d089e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 michaelludwig@google.com Fix int/uint comparison in TextureOp asserts 2019-12-19 robertphillips@google.com Add glue to link the GrContext createCompressedBackendTexture API to the GL and Vulkan backends 2019-12-19 jvanverth@google.com Clean up GenDistanceFieldFromPath. 2019-12-19 halcanary@google.com public.bzl: add SKOTTIE_IOS_LIB_{SRCS,HDRS} Created with: gclient setdep -r src/third_party/skia@4ef1ca1d089e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia709854bc94447f47a54ebbc58abe10e254ec567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976106Reviewed-by:
-
Ian Kilpatrick authored
In https://chromium-review.googlesource.com/1954925 we added a DCHECK to ensure that a LayoutDeprecatedFlexibleBox was only having layout performed when it had "-webkit-box-orient: vertical". This failed external/wpt/css/css-overflow/webkit-line-clamp-026.html as we weren't reattaching the layout tree when we had a "-webkit-box" with "-webkit-line-clamp", which then had its "-webkit-orient" set to "horizontal". This patch ensures that we reattach the layout-tree in this case. Bug: 993813 Change-Id: Ifa176010ce53804fc3d055983564eb126355d4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975307Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79994d4369cf..7a9153faa00d git log 79994d4369cf..7a9153faa00d --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com perfetto: expose the tracing header properly 2019-12-19 lalitm@google.com perfetto: allow usage of tracing.h in bazel Created with: gclient setdep -r src/third_party/perfetto@7a9153faa00d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icef6b56dcdb9ae681beecfdaee2f15e03ec398a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976102Reviewed-by:
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ia1d357d29c09a1c0f102c5dbb99dfc0c8e296a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975728 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726433}
-
David Benjamin authored
The default was changed in https://chromium-review.googlesource.com/c/chromium/src/+/1965952, but I forgot the admin policy documentation also needs updating. Bug: 996894 Change-Id: Ib6ddd9a91e0812662a46125c377ab7486180c447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974578 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726432}
-
Wenyu Fu authored
With recently introduced API SharedPreferenceManager. Migrate HomepageManager to use SharePreferencesManager rather than checking SharedPreferences directly; also move the private preference keys into ChromePreferenceKeys.java Bug: 1022108 Change-Id: Id1be4b4f70ec6c070d8ded81a5e98512f995da15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974320 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726431}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f321db9a8ea2..9dec123fec99 git log f321db9a8ea2..9dec123fec99 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 syoussefi@chromium.org Ignore nameless vim swap files Created with: gclient setdep -r src/third_party/angle@9dec123fec99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I17af6a691de1999a0e6ff260206b22161ce99f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976104Reviewed-by:
-
arthursonzogni authored
This patch is the revert of the diff in between patchset 4 and 5 of: https://chromium-review.googlesource.com/c/chromium/src/+/1947741/4..5 This caused a 4.2% regression in the octane benchmark. The real reasons is still unknown. It must be investigated. This revert can be seen as a temporary bandage until we figure out the cause of the performance regression. Bug: 1031311 Change-Id: Ib22008a4557b6f05cc170e80cf71762b0b45b4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974092Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726429}
-
Mikel Astiz authored
TrustedVaultClient::FetchKeys() has an asynchronous signature, but the Android implementation (and the JNI bridge) adopted a synchronous implementation prior to this patch. In this proposal, the operation becomes non-blocking, based on: 1. The introduction of a dedicated Java->C++ API call, invoked when the operation completes. 2. The adoption of base.Promise in TrustedVaultClient.Backend, which is an idiomatic way to express that keys will eventually be read. Bug: 1012659 Change-Id: I04b9b32549e5a880d8cbe3da1fffb60ddaa1ae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968991Reviewed-by:
-
Leonard Grey authored
In this CL, it's exposed through the Mac tab menu. A follow-up change will also add it to the tab context menu. Bug: 1021551 Change-Id: I3ca1e67fa5a2215a869016c2a2eeb9a946d79ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954178 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Michael Spang authored
This broke the build of some Nest devices that don't have libdrm in the build environment. Partially revert enabling this on Linux to fix the build. BUG=1031269 TBR=thomasanderson Change-Id: I596f30849da48d44c246983a08a5cd08f2fbff08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976194Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726426}
-
Jérôme Lebel authored
Moving accessibility string constants into fake_chrome_identity_interaction_manager_constants target. This is to prepare: crrev.com/c/1958118 Bug: 987646 Change-Id: I963103862ae31cb1bd1006eeb2aecbacfa2482a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973818 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#726425}
-
Andrew Grieve authored
Notice this in SuperSize reports. UI>Browser is probably a better catch-all categorization of the code in //chrome than "Build" is. Change-Id: Id57f0eb0bf69c97381ea5ecde39c039ef8fcdba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976131Reviewed-by:
Dana Fried <dfried@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#726424}
-
Alex Ilin authored
This reverts commit ed56d990. Reason for revert: causes test failures on Android https://crbug.com/1035856. Original change's description: > [Autofill Assistant] Split profiles into usage cases. > > Previously the source for contacts and shipping addresses was the same > sorted list of profiles. There may be cases where we want to sort them > differently, which is enabled by splitting the list in two. > On view we transform the profiles into either Contacts or Addresses. > > Note: This change breaks the default selection based on the account's > address. This is moved to native in crrev/c/1954393 and has not been > recreated here. > > Bug: b/144005336 > Change-Id: I1e8e085f1de2fc7710969e778078495b3b54704b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961197 > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Cr-Commit-Position: refs/heads/master@{#726331} TBR=arbesser@google.com,marianfe@google.com,sandromaggi@google.com Change-Id: I56c7b11c9e2e100a39c5350529a8e2afce268bc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/144005336, 1035856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976699Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726423}
-
Nicolás Peña Moreno authored
This CL does the following fixes to crossiframe.html test: * Remove slow-image and onload, which are obsolete assumptions. Instead, rely solely on PerformanceObserver. * Use awaits where needed to make the test logic more sequential. * Use coordinates and test_driver.Actions() to target the iframe. Using the test_driver.click directly won't work for elements in iframes. * Updates the test to check reasonable values for the frame and iframe entries and check that they don't receive each other's entries. This CL also: * Removes unneeded variables from the clickAndBlockMain(). * Removes manual test, which is no longer needed. Bug: 831729 Change-Id: Iff50035a216b21f67cd71796023af4f934573086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972249 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#726422}
-
Aya ElAttar authored
Moved the browsertests of media stream policies out of policy_browsertest.cc & added TODO comment to refactor base::RunLoop::QuitCurrentWhenIdleDeprecated() Bug: 1002483 Change-Id: Ia007dfd0a6b30ed4be0e1eb708899b3f47e1376d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930831Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#726421}
-
Andrew Grieve authored
Change-Id: I7fe91b126afdf7b6db18476579002c1ea03774c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976192 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726420}
-
Marc Treib authored
This CL adds suffixes Sync, Drive, and Policy to the existing histogram FCMInvalidations.FCMMessageStatus. Having all the different senders in a single histogram made analysis tricky. Since the sender_id constants aren't accessible at the place where the histogram is recorded, they're duplicated. This should be okay since existing sender_ids are not expected to change, and new ones are added infrequently. While I'm here, also add myself as an owner of other FCMInvalidations histograms, since the original owner is OOO. Bug: 1023813 Change-Id: I41d24f4d61c22641eb0e599176fcfff45f2740c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972841 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726419}
-
