- 02 Dec, 2018 12 commits
-
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icbb5afb6b21e64e5717717b68182e4480f45be5e Reviewed-on: https://chromium-review.googlesource.com/c/1357880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612966}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bc9893eed87..248876f7b6b1 Created with: gclient setdep -r src-internal@248876f7b6b1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d0cd5441f42a6df4e3f136594cf29a2000e29b4 Reviewed-on: https://chromium-review.googlesource.com/c/1357881Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612965}
-
Victor Costan authored
This CL aligns the process for changing SQLite with the new process for upgrading SQLite. Change-Id: I0bfd95855606642de569844145b1d4b0117341c4 Reviewed-on: https://chromium-review.googlesource.com/c/1349458 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#612964}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Id31f83702db71aece936782e49233448184a486a Reviewed-on: https://chromium-review.googlesource.com/c/1357899Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#612963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62c2383b006d..4bc9893eed87 Created with: gclient setdep -r src-internal@4bc9893eed87 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I03ea70135d7783831b51d552de1bea3b8c0dd422 Reviewed-on: https://chromium-review.googlesource.com/c/1357879Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/480454475db7..62c2383b006d Created with: gclient setdep -r src-internal@62c2383b006d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9dac876007d538d04e65a967ef80e1093e5aabb2 Reviewed-on: https://chromium-review.googlesource.com/c/1357738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612961}
-
Victor Costan authored
Bug: 892852 Change-Id: I6c43809d5a74ffd4648442fe30f3c505999e219b Reviewed-on: https://chromium-review.googlesource.com/c/1354315Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612960}
-
Joshua Peraza authored
Both the browser and child processes determine whether they will produce crash dumps at initialization. When crash dumping is disabled for the browser, no signal handler is installed. Child processes with crash dumping disabled will still install a signal handler so the browser and any observers can be notified of the crash, but the child process will send a byte along with its message to the CrashHandlerHost noting whether a dump should be produced. Change-Id: I7acde16b604ecdcad124cb95677e127fc099e0e8 Reviewed-on: https://chromium-review.googlesource.com/c/1298651 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c2434aa5b5b..480454475db7 Created with: gclient setdep -r src-internal@480454475db7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I688074ec0e7222741b9cc4594f90ab922f30aa96 Reviewed-on: https://chromium-review.googlesource.com/c/1357735Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac9b0ff799ae..d5cded1697ed git log ac9b0ff799ae..d5cded1697ed --date=short --no-merges --format='%ad %ae %s' 2018-12-01 dburger@chromium.org Stop generating URLs per their "waterfall" Created with: gclient setdep -r src/third_party/chromite@d5cded1697ed The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6359f71ce3227c39d931cc1df614cc734b0d3372 Reviewed-on: https://chromium-review.googlesource.com/c/1357736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612957}
-
Mitsuru Oshima authored
The task posed in the complete callback can be executed under load if it waits for idle. Explicitly exit upon animation complete instead. Bug: None Test: Test no longer fails under load Change-Id: Ibef010506fd7a888615b7d2d304d0a04c826d00d Reviewed-on: https://chromium-review.googlesource.com/c/1357668Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612956}
-
Joshua Peraza authored
Adds DumpWithoutCrashingForClient() which enables generating a dump on behalf of the embedding app (represented by AwDebugCrashReporterClient) This also includes refactoring of native code in minidump_uploader to expose MimeifyReport() and WriteBodyToFile(), to be used by AwDebug::DumpWithoutCrashing() in the followup CL. Change-Id: If528bf060b6acaa51d0facaf1f1adf784c1852e6 Reviewed-on: https://chromium-review.googlesource.com/c/1269099 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#612955}
-
- 01 Dec, 2018 28 commits
-
-
Matthew Mourgos authored
Fixes browser crash after search result answer card search Bug: 910388 Change-Id: I7ab881d2cf4da2920439be73da2977a7c436b6af Reviewed-on: https://chromium-review.googlesource.com/c/1356715Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612954}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b296c5011167..6c2434aa5b5b Created with: gclient setdep -r src-internal@6c2434aa5b5b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8806fa299af37a0e55d3b0c0ec2169c783a26354 Reviewed-on: https://chromium-review.googlesource.com/c/1357839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9cee82d2dd3b..b296c5011167 Created with: gclient setdep -r src-internal@b296c5011167 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia5686062e709bd637fa0ac87efbfa76f54fff6ea Reviewed-on: https://chromium-review.googlesource.com/c/1357734Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612952}
-
Philip Rogers authored
This patch plumbs a flag and settings for a BlinkGenPropertyTrees finch trial. Because we have dependencies on the existing command line flag (--enable-blink-gen-property-trees), the command line flag has not been removed in this patch but will be removed in a followup. Bug: 836884 Change-Id: I73d4c01964b953397d1857a9ee130502792b3d4a Reviewed-on: https://chromium-review.googlesource.com/c/1355852Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612951}
-
Joshua Peraza authored
This is a reland of dbca191e Original change's description: > Package Crashpad's handler into various APKs > > For Chromecast, Content Shell, and non-monochrome Clank/Webview: > > The Crashpad handler is a standalone executable, packaged like a > loadable module and named libcrashpad_handler.so in order to not be > ignored by Android's APK installer. > > For Monochrome: > > The Crashpad handler is linked into libmonochrome.so. At crash-time > /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java > which loads libmonochrome.so and runs the native HandlerMain(). > > This strategy is not used for non-monochrome APKs (i.e. pre-N) because > on L, Android's loader is not yet capable of loading native libraries > from the APK. This is normally performed by the Chromium linker which > can't be used by CrashpadMain.java because /system/bin/app_process > doesn't initialize the process like a normal Android application > (specifically, no ContextImpl has been created, so any calls to e.g. > appContext.getApplicationInfo() will segfault). > > Binary-Size: MonochromePublic.apk increases in size by 100 KB. > ChromeModernPublic.apk increases in size by 203KB (587 KB > increase in install size because libcrashpad_handler.so is extracted > from the APK). Possible mitigations for this increase are TODO: > > For J, K: We could link the handler directly into libchrome.so and let > that be our handler executable. This would de-dup portions of libbase > that are currently linked into both libchrome.so and > libcrashpad_handler.so. > > For L, M: It might be possible to get the chromium linker (or Bionic's > linker on M) to dlopen libchrome.so from the APK for a trampoline > libcrashpad_handler.so to de-dup libbase. > > Bug: crashpad:30 > Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65 > Reviewed-on: https://chromium-review.googlesource.com/1150774 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594853} TBR=agieve@chromium.org,torne@chromium.org Binary-Size: See above. Bug: crashpad:30 Change-Id: I2b866be642670188d9e8b674fac940b05497b806 Reviewed-on: https://chromium-review.googlesource.com/c/1252007 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#612950}
-
Ken Rockot authored
This is a reland of e13e5485 with a fix for official Chrome OS compile, which was broken by this and doesn't have CQ coverage. :} Original change's description: > Migrate chrome services to ServiceBinding > > Migrates most remaining chrome & chrome OS services from ServiceContext > to ServiceBinding. > > Bug: 891780 > Change-Id: Ib67772b549a58a4b2549840e90f719daa3370215 > Reviewed-on: https://chromium-review.googlesource.com/c/1356312 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612911} TBR=jam@chromium.org Bug: 891780 Change-Id: Ibde6312ca6710a981ebbd43473e8289dae479781 Reviewed-on: https://chromium-review.googlesource.com/c/1357670Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#612949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7246cb4fac87..9cee82d2dd3b Created with: gclient setdep -r src-internal@9cee82d2dd3b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I372f028df3ef1f84cd57270e05d306666605edbb Reviewed-on: https://chromium-review.googlesource.com/c/1357733Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612948}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b05d24c8ae07..ac9b0ff799ae git log b05d24c8ae07..ac9b0ff799ae --date=short --no-merges --format='%ad %ae %s' 2018-12-01 achuith@chromium.org device: Move Device to separate lib. 2018-12-01 lamontjones@chromium.org Drop unit parameter from osutils.GetImageDiskPartitionInfo 2018-12-01 lamontjones@chromium.org Allow partition name in MountImagePartition. 2018-12-01 chrome-bot@chromium.org Update config settings by config-updater. 2018-12-01 derat@chromium.org chromeos_config: Remove chrome-informational from ASan/UBSan Created with: gclient setdep -r src/third_party/chromite@ac9b0ff799ae The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8cb20460a312dabe20cd37dae915cf261ad85e64 Reviewed-on: https://chromium-review.googlesource.com/c/1357731Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612947}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae97faeec26e..7246cb4fac87 Created with: gclient setdep -r src-internal@7246cb4fac87 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia30a104ca5de576a589d6ae35ae4bac463a3b8f2 Reviewed-on: https://chromium-review.googlesource.com/c/1357732Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612946}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 404d04e5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5b6656cb4aa14b58b1510c6168e53207b73717f7 Reviewed-on: https://chromium-review.googlesource.com/c/1357669 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612945}
-
Mitsuru Oshima authored
There is still a few cases it prints the warning when it shouldn't. (in mirroring display scenario) I'll address it in next CL. Bug: None Change-Id: Id254aab0788ab19f6ff970f495be98c7a0ee6e32 Reviewed-on: https://chromium-review.googlesource.com/c/1352032Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612944}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f8fc4984231..ae97faeec26e Created with: gclient setdep -r src-internal@ae97faeec26e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If99965050b06cc64ace3d127ffe54b5f9f029799 Reviewed-on: https://chromium-review.googlesource.com/c/1357741Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612943}
-
Jazz Xu authored
Bug: 910382 Change-Id: Icf32ada34f569567deaa7917d82f79b35df9a8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1357651Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612942}
-
Max Moroz authored
Bug: 756596, 904877 Change-Id: If1f5dbefa165a3d4c50ff59c62a47e8eff5eb3c2 Reviewed-on: https://chromium-review.googlesource.com/c/1357611 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612941}
-
Shakti Sahu authored
Currently to determine whether a download was paused by user, we look at DownloadJob. This doesn't take into account whether the download has been restarted. This CL consults with the in-progress DB to determine this correctly. Change-Id: I00212fd995f2810ddbb68f97d5b8d1594bc2cd69 Bug: 909014 Reviewed-on: https://chromium-review.googlesource.com/c/1352615Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612940}
-
Max Moroz authored
TBR=cmumford@chromium.org,pwnall@chromium.org Bug: 900476 Change-Id: Ib126694fe3a60a9c6447a93b05a5bafe1f95fe09 Reviewed-on: https://chromium-review.googlesource.com/c/1356225 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612939}
-
Christopher Cameron authored
This has been a longstanding TODO. Pending work will require adding more methods to route to AppShimHost, so just delete this rather than adding more methods to it. TBR=mgiuca Bug: 896917 Change-Id: Idd8f55c7b6f549354441e28832e292ce693b9363 Reviewed-on: https://chromium-review.googlesource.com/c/1357574Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#612938}
-
chrome://Dan Beam authored
The Size column of Network panel shows "0 B" for every request when no bytes are actually transferred over the network. Enabling "large rows" is great as it shows the resource size as well, but sorting doesn't take the resource size into account as a secondary factor. This CL fixes that. I also added a summary view of the resource sizes (very similar to the network bytes transferred summary) to the bottom start end of network tab. Screenshot: https://imgur.com/XQRYtWj R=alph@chromium.org BUG=907289 Change-Id: I35d69cb617113b0094f6cc2a368b6180c90c2772 Reviewed-on: https://chromium-review.googlesource.com/c/1345232Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#612937}
-
Jazz Xu authored
Add "pip-presented" CSS class to menu list and track list when picture in picture is enabled. Remove the CSS class when pip is disabled. So that we can have different menu width depending on whether we have pip button in menu. Bug: 901738 Change-Id: I08c0c480fef221f19917637fc9538e66f99f79ca Reviewed-on: https://chromium-review.googlesource.com/c/1357601Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612936}
-
Adrienne Walker authored
This has turned up some bugs, but is being incredibly noisy on the bots. Remove the crash report until this is solved. Bug: 910772 Change-Id: I9f2a7f7a1a758abe20a2304ad10da4a12fb4b9db Reviewed-on: https://chromium-review.googlesource.com/c/1357619Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612935}
-
Ben Kelly authored
When a simple disk_cache is in APP_CACHE mode eviction is disabled and access times do not need to be tracked. This means that it should be possible to perform read-only operations without triggering any index disk writes. This CL implements this optimization by making the following changes: * Avoid updating access times in APP_CACHE mode. * Avoid writing a clean index to disk when closing the backend. * Avoid dirtying the index when a size update does not make a change. * Avoid dirtying the index when opening an entry that is in the index. * Avoid dirtying the index when dooming an entry not in the index. With these changes its possible to use simple disk_cache to perform read-only operations in cache_storage without any index writes. Bug: 905351 Change-Id: I8eed0a72ed166e7b1b3623a7f4c17f7cec7f96d4 Reviewed-on: https://chromium-review.googlesource.com/c/1351539 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#612934}
-
Ben Wagner authored
This is a minimal change to cover most cases. In particular this does not take @font-face font-feature-settings into account, but does make letter-spacing with a non-default value disable optional ligatures for all cases except when enabled directly by font-feature-settings. It also makes optimizeSpeed force the default setting for optional ligatures to off. This avoids using or changing TypesettingFeatures, leaving blink::kLigatures to only affect the use of the word shaper. The use of the word shaper can be modified independently and will involve rebaselines and consideration of the performance impact (since common fonts like Arial, Times New Roman, and DejaVu Sans use spaces in GPOS or GSUB). Bug: chromium:896033 Change-Id: I764b1a7eed6d9f06ff8df31c4225dee2ea860684 Reviewed-on: https://chromium-review.googlesource.com/c/1292436 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#612933}
-
Eugene But authored
Change-Id: Ife2616f947a3251d88ee156af9780d9df2690177 Reviewed-on: https://chromium-review.googlesource.com/c/1355198 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612932}
-
Victor Costan authored
Disable two SQLite features that aren't used in Chrome, saving 9KB of binary size. Change-Id: I87ff8c454eed8fe554a6ba93f3cc28d10b91258e Reviewed-on: https://chromium-review.googlesource.com/c/1341492 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612931}
-
Parastoo Geranmayeh authored
The secondary members should not be considered while comparing profiles. Change-Id: I767ea18ab39ed7c5ad6771338aedf39f620bd477 Reviewed-on: https://chromium-review.googlesource.com/c/1357576Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#612930}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d007d7c4f11..0cc11b4b947e git log 0d007d7c4f11..0cc11b4b947e --date=short --no-merges --format='%ad %ae %s' 2018-11-28 magjed@webrtc.org Android: Bump stack trace logging severity from debug to warning 2018-11-28 yura.yaroshevich@gmail.com Added user-defined predicate to filter video codec implementations. 2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82a8b043..28d61688 (611537:611644) 2018-11-28 gustaf@webrtc.org AEC3: Fix ENR in the dominant nearend detection 2018-11-28 devicentepena@webrtc.org AEC3: Optimizing the Update method of the FilterAnalyzer class. 2018-11-28 aegolden@google.com Don't clear self.videoFrame when setting up OpenGL in the EAGL video view. 2018-11-28 artit@webrtc.org Fix webrtc-internal ios json config 2018-11-28 robin@opticaltone.com Adding WinUWP compilation support to WebRTC. 2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b04e513f..82a8b043 (611432:611537) 2018-11-28 zstein@webrtc.org Reland "Delay call to Destroy until after SignalDone has finished firing." Created with: gclient setdep -r src/third_party/webrtc@0cc11b4b947e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:909007,chromium:None,chromium:905542 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I98fcd8196b69f3530655fee12d869c96a26c618e Reviewed-on: https://chromium-review.googlesource.com/c/1357744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612929}
-
siyua authored
Currently the credit card icon is visible when flow step is PROMO_BUBBLE or CREDIT_CARD_ICON. When user navigates away when bubble or credit card icon is shown, the flow step is not correctly set so the icon will always show even if the bubble is gone. Bug: 897998 Change-Id: I8a966cbb76775aaedc8b766306ec6d5c9602c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/1352358Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#612928}
-
Clark DuVall authored
This flag is necessary to enable DRP with network service. Adding the flag to DRP tests allows them to pass when run with network service on the Android mojo bot. Also updates the changed files to use @EnableFeatures/@DisableFeatures. Bug: 721403 Change-Id: Ibf75db48c4ab64ac47bd493e1a5e04f899ac19e9 Reviewed-on: https://chromium-review.googlesource.com/c/1352476Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612927}
-