- 16 Nov, 2018 40 commits
-
-
Justin Cohen authored
This happens when clearing browser data, and forces the NTP to be recreated (and not show previous NTP tiles). Bug: 905735 Change-Id: If818e02703c7324f0a660bf6b115603db3682b74 Reviewed-on: https://chromium-review.googlesource.com/c/1339340Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608947}
-
Ella Ge authored
TBR=kbr@chromium.org BUG=906092 Change-Id: I11105b926d35b5bcb16c2930c04f98db20e5f4b4 Reviewed-on: https://chromium-review.googlesource.com/c/1340788Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608946}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09299cdfd973..4d0fac4a2c9e git log 09299cdfd973..4d0fac4a2c9e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 tsepez@chromium.org Remove some unused strings from CFX_CSSData tables. Created with: gclient setdep -r src/third_party/pdfium@4d0fac4a2c9e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7108ae0af76028e59a5cc51eeedcf69a9094f9fc Reviewed-on: https://chromium-review.googlesource.com/c/1340572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608945}
-
Toni Barzic authored
The larger goal is to stop using sign-in profile after a user session starts (with hopes that it will eventually be possible to shut the profile down after sign-in completes). BUG=901768 Change-Id: Ic019113cad1284cffb50581d3e52b891cd509ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1338866Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#608944}
-
Nico Weber authored
Bug: none Change-Id: I4cd719751f4962bd80c7f9b6531535e15a1d3d99 Reviewed-on: https://chromium-review.googlesource.com/c/1340520 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608943}
-
Jesse McKenna authored
TaskScheduler: Make method ordering consistent between SchedulerWorkerPoolImpl:: and SchedulerSingleThreadTaskRunnerManager::JoinForTesting This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1338140 Bug: 889029 Change-Id: I1c179f6617bac417fb54c55e9328e2391d2d7b5b Reviewed-on: https://chromium-review.googlesource.com/c/1340360 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608942}
-
Joe Downing authored
This change adds a DataChannelHandler for Action messages and ties it into ClientSession. When a new handler is created, it will receive an ActionExecutor (added in a previous CL) which is used to invoke the requested action. BUG: 892434 Change-Id: I56b60fdc56b89900297943eafe78f50982b7681f Reviewed-on: https://chromium-review.googlesource.com/c/1294715Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608941}
-
Johannes Henkel authored
This directory is rolled manually and thus far does not contain anything that's synced in by gclient or similar. So it's confusing to have it in .gitignore because it makes it easy to forget updating things in it this way. an automatic deps mechanism, but for now this should be it. PS: We may later add this back, if we end up going with Change-Id: I74441dd50055efa860dd793789786b42c6c0fa2b Reviewed-on: https://chromium-review.googlesource.com/c/1338720 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608940}
-
Tarun Bansal authored
Enable DataReductionProxyMainMenu by default. This has been enabled for 99% of population for over a year. Also, remove the variation param "persistent_menu_item_enabled" since we decided not to launch with that setting. See the bug for more details. Change-Id: I551f90132e3a5daaedd544cd7847c0949400f09f Bug: 905911 Reviewed-on: https://chromium-review.googlesource.com/c/1338883Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608939}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/417ac91cdb06..e4634a13a74d git log 417ac91cdb06..e4634a13a74d --date=short --no-merges --format='%ad %ae %s' 2018-11-16 jmadill@chromium.org Apply code formatting. 2018-11-16 ynovikov@chromium.org Vulkan: Handle VK_ERROR_DEVICE_LOST 2018-11-16 jmadill@chromium.org Use angle::Result in front-end (Part 9) Created with: gclient setdep -r src/third_party/angle@e4634a13a74d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I54172fc246c9772b6b184cdd9e131f366c31e228 Reviewed-on: https://chromium-review.googlesource.com/c/1340390Reviewed-by:
-
Bettina authored
We created another uninstall reason when uninstall functionality was made available in Chrome Web Store but didn't update the condition for showing the uninstall URL. I've re-enabled the browser test for EnsureExtensionUninstallURLIsActiveTabAfterUninstall since I've run the test 100 times in one run and 600 times in another run and it did not fail. Bug: 900554 Change-Id: I805840717709606a8e98d1c82cbea2b611efdfd6 Reviewed-on: https://chromium-review.googlesource.com/c/1336522 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608937}
-
Vlad Tsyrklevich authored
This change is preparing for an upcoming refactor. kFreePagesNumBits and kGpaMaxPages are equivalent. Get rid of the latter with a static_assert() that kGpaMaxPages is always equal to the size of the BitMap. Bug: 896019 Change-Id: I7e99766d2e6fffa0e3d3eb3a47a2e76038b522ab Reviewed-on: https://chromium-review.googlesource.com/c/1340526Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608936}
-
Vlad Tsyrklevich authored
Get rid of the SlotMetadata constructor/destructor and replace the destructor with a Destroy() method. Also change alloc_ptr to be a uintptr_t. This refactor makes SlotMetadata safer to initialize with out-of-process memory in an upcoming crash handler change, because the SlotMetadata we read should not be automatically destructed (the members will be from another memory space). Since alloc_ptr is only used in the crash handler there's no reason to not make it a uintptr_t to make it appear less like a pointer in crash handler's memory space. Bug: 896019 Change-Id: I3f1f22eac6277722de9594a3331b8daef618d29d Reviewed-on: https://chromium-review.googlesource.com/c/1340868 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
Aaron Krajeski authored
Provide a pointer to SecurityOrigin within SVGFEImageElement so that it can test if its content actually taints the origin. Previously all filters with feImages tainted the canvas. When the filter is set (during CanvasRenderingContext2DState::SetFilter) the SecurityOrigin is stored. During CanvasRenderingContext2DState::GetFilter is it determined whether the compiled filter should taint the canvas. Next step is to make this work for other svg_fe elements. Change the test expectations for SVGFEDisplacment tests as FEImages no longer necessarily taint the origin. Reverting changes here: https://chromium-review.googlesource.com/c/chromium/src/+/782649/ Bug: 618871 Change-Id: I506c443f842068f08eab0e3d6b214f2b10878a86 Reviewed-on: https://chromium-review.googlesource.com/c/1258968 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608934}
-
Shawn Gallea authored
Move wl_seat interface out of server.cc, removed usage of keyboard and pointer for cast shell. Bug: 896710 Test: Built on ChromeOS Change-Id: I3e91381883ff028e684b5c4bfbb1dd744cf31ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1324099 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608933}
-
Robert Flack authored
In BGPT, each KeyframeModel on a given Animation may need to animate a different ElementId, as the various effects of an element are split into multiple different nodes in some of the same node trees. This change sets the ElementId on the keyframe model and uses that when applying mutations. Since animations currently expect to look for the existence of a single element, this patch also modifies PaintPropertyBuilder to construct each node type that may be needed for an animation when any property is being animated on an element and then uses the kPrimaryEffect id to check whether this has happened. This also makes several changes to plumb the proper list of element ids: - Register all ancestor ElementIds in PaintArtifactCompositor::Update. - Synchronize registered ids during commit. - Synchronize registered ids during activation. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 896549 Change-Id: I717822a1ca174658ef792005e76613a5033f4f6a Reviewed-on: https://chromium-review.googlesource.com/c/1297305Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608932}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a3d34a0f7ad..c1d08bca895a Created with: gclient setdep -r src-internal@c1d08bca895a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38e460f59dfdedb9f0f088a77c85e8f60468ee76 Reviewed-on: https://chromium-review.googlesource.com/c/1340391Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608931}
-
Mitsuru Oshima authored
* WindowSelectorObserver listens the activation change first so that it can cancel the overview before resuming minimized window. * This also fixes a crash that happens if you click the overview button while activating a window in overview. * This also fixes the bug in WindowSelectorController was calling wrong "Starting/EndingAnimation". This happens to work fine because the end results are the same. Bug: 905813 Test: covered by unit test. WindowSelectorControllerTest::AnimationCallbacks Change-Id: I2b3d3fdc2e68bb41c0d037d46552cf6cfda98746 Reviewed-on: https://chromium-review.googlesource.com/c/1338175 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#608930}
-
kylechar authored
Bug: 874797 Change-Id: Iced662e0de18687740b1ad374f5743ae01916ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1340361Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608929}
-
Jun Cai authored
Network Service: Update comments about the callback parameter for NetworkConnectionTracker::GetConnectionType() This CL updates the comments about the callback parameter for NetworkConnectionTracker::GetConnectionType() to make it clear that the |callback| will not be called when connection type can be retrieved synchronously. Bug: None Change-Id: I39eefe13311d9e594dc3f2518fb543014ccf5487 Reviewed-on: https://chromium-review.googlesource.com/c/1336078Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#608928}
-
about://newtabJustin Cohen authored
Bug: 905721 Change-Id: I6218a61cdd74b93257cb44580351c9c666092c0c Reviewed-on: https://chromium-review.googlesource.com/c/1338964 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
-
Shawn Gallea authored
Fix bounds unittest to make sure an offset from fullscreen_surface will be detected. Bug: 896710 Test: FullscreenShellSurfaceTest.Bounds Change-Id: Ia8e3213b5c854f423537a9d0e58455f3d497bea7 Reviewed-on: https://chromium-review.googlesource.com/c/1340863Reviewed-by:
-
Mohamed Amir Yosef authored
When a message arrives for a lazy GCM subscription and Chrome isn't in the foreground, it is persisted on disk until next time Chrome is in the foreground. This CL adds two histograms 1- Record the time spent to check if a subscription lazy upon receiving a GCM message while Chrome is in the background. 2- Record the time spent in reading and replaying persisted messages when Chrome goes to the foreground. Bug: 882887 Change-Id: I2ea8e5a5c5242b573e842b56f08d7f1070d48856 Reviewed-on: https://chromium-review.googlesource.com/c/1333656Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#608925}
-
Lindsay Pasricha authored
Migrate from using our custom utility and helpers to a similar util developed and maintained by the EG team. Doc at go/bling-axe Bug: 856622 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib86b171447eac2961ec2591c8a08764d06b7a953 Reviewed-on: https://chromium-review.googlesource.com/c/1291570 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608924}
-
Sunny Sachanandani authored
This is a reland of 56f3274d Fix uninitialized |rotation_| in VideoFrameSubmitter. Original change's description: > Reland "Fix video quad rect and surface output rect" > > This is a reland of 1dfd4418 > > Original change's description: > > Fix video quad rect and surface output rect > > > > Video surface output rect didn't take rotation into account so when > > SurfaceAggregator would stretch content to fill bounds, it would end up > > with the wrong scaling factors (squash in one dimension and expand in > > another) since the surface quad's bounds (in the embedder) were rotated. > > > > To work around this (or by accident), VideoFrameResourceProvider was > > passing the rotated size as the quad's rect which doesn't make sense > > intuitively. This also worked by accident with DirectComposition > > overlays because of applying another scaling which would fix the aspect > > ratio again. > > > > This change makes it possible to use the |quad_to_target_transform| as > > is, without having to apply an aspect ratio correcting scaling, and to > > assume that the quad's rect is in the pre-transform space. > > > > Bug: 904035 > > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 > > Reviewed-on: https://chromium-review.googlesource.com/c/1334971 > > Reviewed-by: enne <enne@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608495} > > TBR=enne@chromium.org,kbr@chromium.org,liberato@chromium.org > > Bug: 904035 > Change-Id: I278a0ea2c5507f01ea13b31d2090b5f99537c7c3 > Reviewed-on: https://chromium-review.googlesource.com/c/1338418 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608596} TBR=enne@chromium.org Bug: 904035 Change-Id: I0f94cd8d71c7c9af60d3d57ac593d2f509e566b0 Reviewed-on: https://chromium-review.googlesource.com/c/1339200Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#608923}
-
Katie D authored
This logs image minimum dimension and dimension ratio for all images loaded when a screen reader is enabled. For more info see go/gchro. Bug: 905419 Change-Id: I75402356c4cf5e64211e37d928634b7b4754fc2b Reviewed-on: https://chromium-review.googlesource.com/c/1336001 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608922}
-
Steve Anton authored
Bug: 874296 Tbr: hbos@chromium.org Change-Id: I1d76f979d9ff4cfcec0b5d5a34663dc48bb94056 Reviewed-on: https://chromium-review.googlesource.com/c/1289698 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#608921}
-
Jeremy Roman authored
This is required for correct heap tracing, since RTCQuicStream derives ContextClient, which is a GC mixin. Bug: 869498 Change-Id: I124c3a23e4a6e670fc3af195fa43498c3f9a857e Reviewed-on: https://chromium-review.googlesource.com/c/1340790Reviewed-by:
-
John Budorick authored
Tbr: justincohen@chromium.org No-Try: true Change-Id: Ie1eaf6202192b20bbbc42ca272f44e2c36921d06 Reviewed-on: https://chromium-review.googlesource.com/c/1340909Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608919}
-
Brad Hall authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/f78187ab7712..7f463e66e1c4 $ git log f78187ab7..7f463e66e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 bradhall Only allow repeated dimensions for 'caches' 2018-11-06 tikuta [client] Add --filepath-filter option to choose download files from isolate 2018-11-02 tikuta Revert "[client] Increase worker to download isolate files faster" 2018-11-01 tikuta [client] Increase worker to download isolate files faster 2018-11-01 vadimsh [isolate] Don't unexpectedly raise KeyError if the cache state file was lost. Created with: roll-dep src/tools/swarming_client Bug: 871453 Change-Id: If2148a3a89af930dcf8ec0a6a5f71684cf974c9b Reviewed-on: https://chromium-review.googlesource.com/c/1340332 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
-
Casey Piper authored
When a request is originated from cryptotoken, bypass the checks of the origin as cryptotoken already validates the origin. Change-Id: I9105a8e5881c901322a417845d2976636205a05c Bug: 902567 Reviewed-on: https://chromium-review.googlesource.com/c/1318064 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#608917}
-
Xiaocheng Hu authored
This patch parameterizes CharacterIteratorTest for LayoutNG to prevent regressions when LayoutNG is enabled. Bug: 810579 Change-Id: I160081c9389aed9ee8cb326be6e022d7b6fd375f Reviewed-on: https://chromium-review.googlesource.com/c/1340271Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608916}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=jennyz@chromium.org Bug: 903957 Change-Id: Idc81701192f6879ee7e11e2f15e89292d9406f9e Reviewed-on: https://chromium-review.googlesource.com/c/1338414 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608915}
-
Ella Ge authored
This reverts commit e2923c55. Reason for revert: <revert the test expectations since original CL that cause failure is reverted> Original change's description: > Disable video-poster.html on Mac bots > > TBR=chrishtr@chromium.org > > Bug: 905860, 900602 > Change-Id: I5d2a01010b4424ffa4312dfaf01e3ca0af24d182 > Reviewed-on: https://chromium-review.googlesource.com/c/1338570 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608606} TBR=chrishtr@chromium.org,eirage@chromium.org Change-Id: Ibb383335e781e792898fdbce2f3eeb70639ad7a3 Bug: 905860, 900602 Reviewed-on: https://chromium-review.googlesource.com/c/1340763Reviewed-by:
-
Wei Li authored
Recent commit 13fc02ff broke Windows build because the compiler on Windows uses different ABIs than those on Linux. The change caused the UI devtools server failed to be created so no connection could be made. This CL fixes the calling, and added a unit test to prevent future brokerage. BUG=903987 Change-Id: Ie8c0201ab817482b9e7d6eaf305ff0620dff3540 Reviewed-on: https://chromium-review.googlesource.com/c/1336446Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#608913}
-
Reilly Grant authored
In r604906 this method was updated to return the device list from cache if available. By running the passed callback synchronously however this violated the assumptions of other code, such as the USB device chooser on Android. Methods that execute a callback either synchronously or asynchronously tend to trigger errors in other code and so rather than work around this change in behavior this patch forces the callback to always be run asynchronously. Bug: 904321 Change-Id: Ib6a71bee3c578e42e2812bc762db40ebc2bd6994 Reviewed-on: https://chromium-review.googlesource.com/c/1338941 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#608912}
-
Peter Kasting authored
This allows enabling some disabled tests on Mac. Bug: none Change-Id: I3b5bce542d91f40842d9ab68bac60c1b11ef9014 Reviewed-on: https://chromium-review.googlesource.com/c/1338211Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4d46091. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Icdc3a568d2dfd89d63f768213bdc54a67e757982 Reviewed-on: https://chromium-review.googlesource.com/c/1340580 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608910}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/645a3afceae0..eee39206a2f6 git log 645a3afceae0..eee39206a2f6 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 sprang@webrtc.org Don't poll EncoderInfo from encoder twice per frame Created with: gclient setdep -r src/third_party/webrtc@eee39206a2f6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7a23f4ddc9d9ce993b25ebf093d7b5d10187286 Reviewed-on: https://chromium-review.googlesource.com/c/1340388Reviewed-by:
-
Vlad Tsyrklevich authored
After a refactor I noticed that this unit test was broken. _aligned_malloc() does not go through the allocator shims on windows, but because we used EXPECT_TRUE() we didn't catch this failure. Delete the _aligned_malloc() test and refactor allocationCheck() to return failure count so that we can track failures across calls and return the proper exit code. Bug: 896019 Change-Id: Ibef719eb14980575cc52796167735f5a0ba177fc Reviewed-on: https://chromium-review.googlesource.com/c/1339319 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
-
