- 07 Nov, 2016 40 commits
-
-
sadrul authored
The gfx::GpuMemoryBuffer implementations in the mus client lib do not do the right thing, and are not really necessary. Remove the code, and instead use the same implementation in gpu-client that content uses. The code is still not right: instead of getting memory buffer from the host, the code allocates shared memory on the client side. When returning memory, the code ignores the sync token. These issues will be fixed in future CLs. BUG=643746 Review-Url: https://codereview.chromium.org/2480023002 Cr-Commit-Position: refs/heads/master@{#430335}
-
kraush authored
Every method in DualControlLayoutTest is already tagged with TargetAPI JellyBean MR1. This change disabled one of the tests accordingly to not run on any devices prior to JellyBean MR 1. The other DualControlLayoutTest works fine. BUG=658263 Review-Url: https://codereview.chromium.org/2439083002 Cr-Commit-Position: refs/heads/master@{#430334}
-
sorin authored
This allows conveying more error information from the component installers to other layers of the component updater. Before this change, the component install execution path could only return one error. We are trying to understand the reasons why the component installers fail. BUG=615669 Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630 Review-Url: https://codereview.chromium.org/2479633003 Cr-Original-Commit-Position: refs/heads/master@{#429995} Cr-Commit-Position: refs/heads/master@{#430333}
-
tedchoc authored
This was preventing bookmarks from appearing on the NTP. BUG= Review-Url: https://codereview.chromium.org/2485683002 Cr-Commit-Position: refs/heads/master@{#430332}
-
asvitkine authored
With this change, all files required to build chrome target on Mac have been migrated. This CL does not yet remove the include in base/metrics/histogram.h since files for other targets & platforms still need migration. BUG=416479 TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2479093002 Cr-Commit-Position: refs/heads/master@{#430331}
-
rbyers authored
The only type of touch which now takes a user gesture is touchend/pointerup when it doesn't correspond to a touch scroll. Conceptually scrolling consume's the user's intent - no sensitive action should be triggered for the same gesture that does a scroll. For details see: https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nvOg/edit Intent to remove: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/gesture%7Csort:relevance/blink-dev/TO_x7FRkdmw/uCrOwufTCAAJ BUG=611981 Review-Url: https://codereview.chromium.org/2414273003 Cr-Commit-Position: refs/heads/master@{#430330}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/1c2ed9963fb8..67b39de70fb5 $ git log 1c2ed9963..67b39de70 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 halcanary s/SkAutoTUnref/sk_sp/ in src/ part 1 2016-11-07 sylvestre.ledru Remove dead code in SkBitmapProcLegacyShader::ContextSize 2016-11-07 borenet Fix zero-padding in gerrit ref 2016-11-07 jvanverth Fix Vulkan command buffer assert on device lost 2016-11-07 halcanary fix android dm compile Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2477373003 Cr-Commit-Position: refs/heads/master@{#430329}
-
scheib authored
Revert of Roll src/third_party/catapult/ 8ac279fd8..0adb6ef9b (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2477243003/ ) Reason for revert: Failed compile on official.desktop.continuous for win trunk https://bugs.chromium.org/p/chromium/issues/detail?id=662998 Link to Build: ------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/49769 Link to Log Path: ------------------ https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/49769/steps/compile/logs/stdio Error log : FAILED: net_unittests.exe net_unittests.exe.pdb C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./net_unittests.exe /PDB:./net_unittests.exe.pdb @./net_unittests.exe.rsp c:\b\build\slave\win_trunk\build\src\v8\src\heap\mark-compact.cc(1278) : fatal error C1001: An internal error has occurred in the compiler. (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255) To work around this problem, try simplifying or changing the program near the locations listed above. Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information scheib@ could you please look into this. thank you Original issue's description: > Roll src/third_party/catapult/ 8ac279fd8..0adb6ef9b (1 commit). > > https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ac279fd8db3..0adb6ef9b5dd > > $ git log 8ac279fd8..0adb6ef9b --date=short --no-merges --format='%ad %ae %s' > 2016-11-07 nednguyen [Telemetry] Remove the logic of killing stray adb processes > > BUG=656224 > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, see: > http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=catapult-sheriff@chromium.org > > Committed: https://crrev.com/4711d631a805e410531fbba09e9c69278b2d17c0 > Cr-Commit-Position: refs/heads/master@{#430279} TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=656224 Review-Url: https://codereview.chromium.org/2484833002 Cr-Commit-Position: refs/heads/master@{#430328}
-
sky authored
Here's the specific case, and this only applies to the window manager: . Client other than WM creates window A. . Client adds A to the root At this point the WM knows about A via an OnWindowHierarchyChanged(). . Client removes A. . Client creates new window B. The WM doesn't know about B. . Client adds A to B. The WM still doesn't know about B, further the WM think's A's parent is null. . Client adds B to the root. This triggers an OnWindowHierarchyChanged() for the window manager with B and a parent of the root. Before the fix OnWindowHierarchyChanged() didn't contain A, so that the WM thought A still had no parent and would get confused later on if a OnWindowHierarchyChanged() was sent for A with a different parent. The fix is to make the last OnWindowHierarchyChanged() include A in the data parameter. This was uncovered in getting views to work with aura-mus. I've included test coverage of the case. BUG=660994 TEST=covered by test R=ben@chromium.org Review-Url: https://codereview.chromium.org/2472983004 Cr-Commit-Position: refs/heads/master@{#430327}
-
rsesek authored
BUG=606408 TEST=With WiFi turned on, go to https://maps.google.com, update current location, verify Net.WiFi histograms and AccessPointData. Review-Url: https://codereview.chromium.org/2472463002 Cr-Commit-Position: refs/heads/master@{#430326}
-
martijn authored
BUG= Review-Url: https://codereview.chromium.org/2483733003 Cr-Commit-Position: refs/heads/master@{#430325}
-
ellyjones authored
This was removed some weeks ago in an update to the Harmony spec, but the code was never updated to match. BUG=635176 Review-Url: https://codereview.chromium.org/2477333002 Cr-Commit-Position: refs/heads/master@{#430324}
-
wangxianzhu authored
TBR=pdr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2477413002 Cr-Commit-Position: refs/heads/master@{#430323}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#430322} -
Matt Sarett authored
BUG=642462 R=scroggo@chromium.org Review URL: https://codereview.chromium.org/2482883002 . Cr-Commit-Position: refs/heads/master@{#430321}
-
skyostil authored
BUG=662959 TBR=perezju@chromium.org Review-Url: https://codereview.chromium.org/2484783002 Cr-Commit-Position: refs/heads/master@{#430320}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/470b5fa8f8db..9adabf886724 $ git log 470b5fa8f..9adabf886 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 npm Revert of Compile fuzzer sources in standalone builds. (patchset #3 id:40001 of https://codereview.chromium.org/2480043002/ ) Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2477403002 Cr-Commit-Position: refs/heads/master@{#430319}
-
guidou authored
BUG=648183 Review-Url: https://codereview.chromium.org/2476153002 Cr-Commit-Position: refs/heads/master@{#430318}
-
boliu authored
The flake is probably due to the test server re-using the same url for different test pages. Changed so that each test page gets a new url. Then found out the test is still flaky because apparently onPageFinished doesn't mean blink has committed the new page so it's hit-testable. So also wait for the page commit signal. This replaces polling for title in the test. BUG=662078 Review-Url: https://codereview.chromium.org/2475163003 Cr-Commit-Position: refs/heads/master@{#430317}
-
estade authored
NativeScrollBar used to wrap NativeScrollBarViews, but it was almost entirely a pass-through shim. Thus, now we just have one layer of views scrollbars called ScrollBarViews. BUG=662605 Review-Url: https://codereview.chromium.org/2480763005 Cr-Commit-Position: refs/heads/master@{#430316}
-
sl.ostapenko authored
BUG=662534 Review-Url: https://codereview.chromium.org/2480763003 Cr-Commit-Position: refs/heads/master@{#430315}
-
sky authored
Revert of Don't apply maximized window bounds workaround if bounds aren't changed (patchset #1 id:1 of https://codereview.chromium.org/2454053004/ ) Reason for revert: This resulted in a shortcut to move between monitors not working. See 656001. Original issue's description: > Don't apply maximized window bounds workaround if bounds aren't changed > > In HWNDMessageHandler::OnWindowPosChanging() was added code that > restores correct maximized window's bounds after attaching or detaching > additional display (see crrev.com/6bb7f819). But this workaround also > applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE > flags that leads to bugs such as crbug.com/659525 and crbug.com/655984. > > This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before > applying workaround and fixes this bugs. > > BUG=659525,655984 > > Committed: https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065 > Cr-Commit-Position: refs/heads/master@{#428368} TBR=atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659525,655984 Review-Url: https://codereview.chromium.org/2482933002 Cr-Commit-Position: refs/heads/master@{#430314}
-
rouslan authored
BUG=648051 Review-Url: https://codereview.chromium.org/2473053003 Cr-Commit-Position: refs/heads/master@{#430313}
-
riajiang authored
Reduce similar code in single-display screens. 1. ScreenBase doesn't set itself as the screen instance in display::Screen anymore, rather its subclass needs to decide if it wants to be the screen instance. 2. Moved Displays::iterator FindDisplayById(int64_t id); to private in DisplayList. 3. Fixed BlimpScreenTest since Display::SetScaleAndBounds also updates the work area of a display. 4. Fixed RenderWidgetHostViewAuraTest.PhysicalBackingSizeWithScale since added UpdateDisplay call in aura::TestScreen::SetDeviceScaleFactor. BUG=none, related to https://codereview.chromium.org/2361283002 TEST=covered by blimp_unittests, app_shell_unittests, content_unittests, unit_tests, mash_unittests, extensions_browsertests Review-Url: https://codereview.chromium.org/2431473002 Cr-Commit-Position: refs/heads/master@{#430312}
-
oshima authored
* If the raw device scale factor is lower than 1.0, shrink the font size further. BUG=646254 TEST=manual Review-Url: https://codereview.chromium.org/2441043002 Cr-Commit-Position: refs/heads/master@{#430311}
-
guidou authored
Users of device-change notifications are not yet using this. An upcoming CL will include wiring of the Blink devicechange event and PepperMediaDeviceManager to this and removal of the corresponding code in MediaStreamDispatcher and MediaStreamDispatcherHost. BUG=648183 Review-Url: https://codereview.chromium.org/2471543003 Cr-Commit-Position: refs/heads/master@{#430310}
-
boliu authored
Instead of have the parallel FrameFuture be held in RenderThreadManager and have the logic for waiting on the frame split between different places. BUG=662096 Review-Url: https://codereview.chromium.org/2481573002 Cr-Commit-Position: refs/heads/master@{#430309}
-
slan authored
The Cast Linux build will use this interface to provision devices from the "media" service. Move these classes into general subdirs and update BUILD.gn files so that these build on Linux. The only non-mechanical change in this CL is that content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter* instead of a RenderFrameHost*. This will allow more flexibility for content embedders like Chromecast to use this class. BUG=660736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2469863010 Cr-Commit-Position: refs/heads/master@{#430308}
-
yusukes authored
BUG=None TEST=try Review-Url: https://codereview.chromium.org/2473003005 Cr-Commit-Position: refs/heads/master@{#430307}
-
yusukes authored
BUG=b:31959560 TEST=click a link with a custom scheme, then press ESC Review-Url: https://codereview.chromium.org/2455733004 Cr-Commit-Position: refs/heads/master@{#430306}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/43513543de10..1c2ed9963fb8 $ git log 43513543d..1c2ed9963 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 reed remove xfermode legacy build flag for android 2016-11-07 mtklein update Vulkan docs for GN. 2016-11-07 halcanary fix svg compile 2016-11-07 liyuqian Combine analytic edges with tolerance 2016-11-07 msarett Finish color space support for SkCodec 2016-11-04 robertphillips Add GrTextureRenderTargetProxy and support switching between RT & Tex Proxies 2016-11-07 bsalomon Revert "Revert "Limit GL_TEXTURE_RECTANGLE filtering to bilinear."" 2016-11-07 borenet Fix iOS isolate 2016-11-04 halcanary gm: s/SkAutoTUnref/sk_sp/ 2016-11-04 halcanary bench, samples, etc: s/SkAutoTUnref/sk_sp/ 2016-11-07 brianosman Add/promote gamma helpers to SkColorSpace_Base Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2480313002 Cr-Commit-Position: refs/heads/master@{#430305}
-
stkhapugin authored
Notable changes: * crw_web_controller.mm used to have a dictionary storing selectors just for keeping the KVO code clean. ARC cannot call a selector from a string like this, because it cannot guarantee correct memory management in this case. So it was replaced with an array of observed key paths to keep some of the code cleanness, while the KVO callback has a huge switch. BUG=624365 TEST=None Review-Url: https://codereview.chromium.org/2434853002 Cr-Commit-Position: refs/heads/master@{#430304}
-
debugwang authored
0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org Review-Url: https://codereview.chromium.org/2471623005 Cr-Commit-Position: refs/heads/master@{#430303}
-
nasko authored
BUG=575230 Review-Url: https://codereview.chromium.org/2477063003 Cr-Commit-Position: refs/heads/master@{#430302}
-
mmenke authored
This is a relic of a bygone era, when URLRequestJob was refcounted, and could outlive its URLRequest. Now we can just delete the URLRequestJob. Also remove a couple checks in URLRequestHttpJob and ServiceWorkerURLRequestJob that their request is not NULL, as the checks are no longer needed, for the same reason. BUG=NONE Review-Url: https://codereview.chromium.org/2480563002 Cr-Commit-Position: refs/heads/master@{#430301}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2478843003 Cr-Commit-Position: refs/heads/master@{#430300}
-
sprang authored
Second take. Previous attempt (https://codereview.chromium.org/2440143002) caused quality regressions. sSpatialLayers[0].sSliceArgument.uiSliceNum = 1 is the workaround for now. BUG=chromium:614970 Review-Url: https://codereview.chromium.org/2475623002 Cr-Commit-Position: refs/heads/master@{#430299}
-
michaeldo authored
Remove the restriction that only a single state can be active at a time. This is to allow incognito and normal mode WKWebViews live side by side where they can be two active states at any given time. BUG=579264 Review-Url: https://codereview.chromium.org/2251023003 Cr-Commit-Position: refs/heads/master@{#430298}
-
tbansal authored
Separate out observation sources as either HTTP layer or transport layer. Majority of the current observation sources (e.g., cached estimate, external estimate) are not broken down by which networking layer they were computed at. This CL breaks down the observation sources by the layer (either HTTP or transport layer). e.g., this will be useful for observers to distinguish between a cached HTTP RTT estimate vs. a cached transport RTT estimate. when NQE caches both HTTP RTT, and transport RTT. As a side-effect, this CL will prevent the observers from distinguishing between the RTT from a TCP source vs. a QUIC source since both of them will now be bundled into NETWORK_QUALITY_OBSERVATION_SOURCE_TRANSPORT. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=490870 Review-Url: https://codereview.chromium.org/2453653002 Cr-Commit-Position: refs/heads/master@{#430297}
-
fsamuel authored
BUG=none Review-Url: https://codereview.chromium.org/2484483002 Cr-Commit-Position: refs/heads/master@{#430296}
-