- 23 May, 2019 40 commits
-
-
Tsuyoshi Horo authored
This reverts commit 6d9fb7a5. Reason for revert: Fixed test Initial CL: https://crrev.com/c/1616937 Revert CL: https://crrev.com/c/1624588 The original CL was reverted due to the data race bug in test. Change-Id: I7280e271f4739da54b9fcf5e022b3a57256b05ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625026 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Lowell Manners <lowell@google.com> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662520}
-
May Lippert authored
This will only be shown on relevant devices. BUG=965657 TEST=ran on all relevant devices and verified the link is correct. Ran on other devices and verified the link does not appear. Change-Id: I204c64fbb8ccf8633bff9631c2c4b0928f88aa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622617 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#662519}
-
Dominik Röttsches authored
The last remaining user of this method was removed in 95e51a93, removing this static method. Change-Id: I12865334448ef07ebb2c1b8c82ef3b1c60464e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622167Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#662518}
-
François Degros authored
Change-Id: I3e22e420bd7281dae51cbc7432712a60d6b608ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626057 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#662517}
-
Takashi Toyoshima authored
Since origin_access_entry.* are files just to forward Blink calls to equivalent services/network functions, let me add myself to the OWNERS file as the network service side implementation author. NOTRY: true Change-Id: I9150caedc53e67ef9c18c37407fdbd85466bba43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616829Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#662516}
-
Igor Kobylin authored
R=dbeam@chromium.org Bug: None Change-Id: Ifb305d275749627cf9a4da47eb951f5dc589819a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623091Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Igor Kobylin <ikobylin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#662515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5093ba67643c..8224a58b4749 git log 5093ba67643c..8224a58b4749 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 aleino@nvidia.com Normalize fragment color in Texture2DIntegerTestES3 Created with: gclient setdep -r src/third_party/angle@8224a58b4749 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:963595 TBR=ynovikov@google.com Change-Id: I0d99daefb194b56ba85dc721c9353e20e74852b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662514}
-
Peter Kotwicz authored
This CL hooks up the SplashscreenObserver#onTranslucencyRemoved() callback (which runs the delayed screen orientation lock requests) BUG=957835 Change-Id: Ifc23d1cdbe37606c5bed3191b3b4534b586ec684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622641 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#662513}
-
Timothy Loh authored
This CL adds a 'Shut Down' option to the shelf and launcher context menus for the Plugin VM app. These will only show while the app is open. For now we simply dispatch a StopVm message, but we may want to expand this to also close the UI window once the shut down is complete. Bug: 940319 Change-Id: I3acbbaf540384fad1dbb68e6226420b47d586793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621987 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662512}
-
Ehsan Karamad authored
Mojo calls from browser to renderer are currently on a non-associated channel. Essentially, the SetInternalId API on MimeHandlerViewContianerManager must be received before the document is loaded. Right now this is not guaranteed and there is room for race bugs. Right now SetInternalId seems to be the only IPC which requires to be on an associated channel. Eventually this IPC could be singled out into its own interface and have a separate binding in MHCVCM for it. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: I2b337c4876f3eb3e4bc6b1e6f72033ccd4edda03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617016Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662511}
-
Ting Shao authored
When taking update check, request's validate cache flag should be set depending on the conditions like update via cache option, time elapsed since last update, etc. Bug: 648295 Change-Id: Id2de38a65d8eccc393c1c7c40b8f82894ec52093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560905 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662510}
-
François Degros authored
This convenience method allows usage patterns that are easier to read and maintain, and promotes better error propagation by discouraging exception swallowing. Used it in VolumeManagerImpl. Change-Id: Idfb1832d7262a37245fc818a063d3d36575d11b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621480 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84137d6f7099..cbb4f6b5b7c6 Created with: gclient setdep -r src-internal@cbb4f6b5b7c6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ife89aa412e41a5d443f7ac9ce434f16d18c2866b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627012Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662508}
-
Yutaka Hirano authored
platform/probe has only one tracing event: "PlatformResourceSendRequest" which is called in ResourceFetcher::StartLoad. This is very similar to what we are doing for "ResourceSendRequest" in InspectorTraceEvent::WillSendRequest also called in ResourceFetcher::StartLoad through ResourceLoadObserver::WillSendRequest. As the event has never been actually used, let's remove it. This CL will allow us to remove PlatformProbeSink. Bug: 914739 Change-Id: I0f93e363214ac6da071ee480ee155d3492fb3e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616839 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#662507}
-
Hitoshi Yoshida authored
Historically, we run IDL code generator in modules/ component, but it's actually independent from all components. This CL moves the task to bindings/ to make it clear. Bug: 953125, 839389 Change-Id: I89cd99fb05717f287a3573cf86690280b88036c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573303Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#662506}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 874385 Change-Id: I7bbc1d28c59529b9dbc13acbb87d9a9f3ecf5517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626197Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#662505}
-
Matt Siembor authored
Adds more usages of content and chrome URL constants and content::GetWebUIURL* utility functions throughout various test code. Bug: 955562 Change-Id: I31319391d0b5ff55d5414266a51c2104fe0329a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616970 Commit-Queue: Matt Siembor <msiembor@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#662504}
-
Leon Han authored
This is a reland of b7b4d8b4 Original change's description: > Organize typemaps in //mojo/ shared for Blink variant > > BUG= > > Change-Id: Ie397047eb79a8639d5e14718f076c17376f9a252 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619204 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Leon Han <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#661602} Change-Id: Ibabdc03be43e10e0a626f960c34321aa19a76c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621709Reviewed-by:
-
Kent Tamura authored
Use blink::mojom::DateTimeSuggestion instead. Because mojo structs are not copyable, this CL makes DateTimeChooserParameters non-copyable too. DateTimeChooserImpl constructor copied DateTimeChooserParameters. Now DateTimeChooserImpl stores a raw pointer to DateTimeChooserParameters to avoid copying it. It's safe because DateTimeChooserImpl::WriteDocument() is called back in the constructor. Explicitly define DateTimeChooserParameters constructor and destructor in order to generate DateTimeSuggestionPtr constructor/destructor code in date_time_chooser.cc. Bug: 950157 Change-Id: I4a8da56aa085e69fa234e8cf7886e59e6f4430e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619589 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#662502}
-
Asanka Herath authored
For some reason the authentication stack still has NULLs instead of the hip and stylish nullptr. This CL does the conversion so that subsequent refactoring CLs can use nullptr while retaining local consistency. Bug: 927182 Change-Id: I73bbcda8b6c6988cd013b5920bc739b080d2b9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579269 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#662501}
-
Maksym Onufriienko authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Bug: 922813 Change-Id: I4704c5dc6bccd3eebbb5a5e939737ddbb030cbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599825 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662500}
-
Austin Tankiang authored
Transient issues may cause formatting to fail, so remount the device to let the user see what happened to the device, and also try format it again. Bug: 965806 Change-Id: I4e95f050dd4d48fbe11527be000cfa4c34b22d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624005Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#662499}
-
Wei-Yin Chen (陳威尹) authored
The GridTabSwitcher RecyclerView would be rendered to a Bitmap as the background in TabListSceneLayer, so that the shrinking Tab can be animated on top of the (Bitmap version of) GTS RecyclerView. Bug: 964406 Change-Id: I9962cbcce42ad7787e170a2fd855375a318cf324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617892 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662498}
-
Regan Hsu authored
This is a reland of 690cf93a Original change's description: > [CrOS SplitSettings] Fork OS reset settings into new files > > Remove all browser reset settings. > Hide OS specific settings in Browser settings. > > Bug: 950007 > Change-Id: Ic8ab799a8c96dd5fd6612f2aab06eec957cfc51e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599514 > Commit-Queue: Regan Hsu <hsuregan@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657897} Bug: 950007 Change-Id: I8a8f3d95c83f61adfe8dc458d37139161240c9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604362 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662497}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0ed21231. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" 8e9cad0d "Cookies WPTs: Add test coverage for SameSite=None" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-contain NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I577850ea0261fa78158bfb4586ccdaa2df5b2e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626046Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662496}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I14f87e980321ee696cec225b93027e292886ef26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625834Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#662495}
-
siyua authored
save card bubble controller. This is required in my other CL 1610308 as adding string variations experiment logic all to views should be avoided. Separate the refactor from the other CL to keep them small. Following Upstream String related CL will be based on this one Bug: 961082 Change-Id: I44ccdb387405685789871ad8d758988237f2194a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626025 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#662494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2441fff8d6ff..84137d6f7099 Created with: gclient setdep -r src-internal@84137d6f7099 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I4c0229a34debe1cd4acb763f49840b2e703d2653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626951Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/47f6fc90c9f3..e85b6a54b641 git log 47f6fc90c9f3..e85b6a54b641 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 brianosman@google.com Interpreter: Tweak tracing output 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-23 csmartdalton@google.com Revert "remove unused functions in sksl.inc" 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e85b6a54b641 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I5e261dd8cdba5123bffec836c95132ae262d026a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626950Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/50ca6f2b940b..7cb7b0fac7f4 git log 50ca6f2b940b..7cb7b0fac7f4 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 pwang@chromium.org cbuildbot: Refactor the logic for non-unibuild lab_board_name Created with: gclient setdep -r src/third_party/chromite@7cb7b0fac7f4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I735b14184ed8db86e3f6eada9e78bf532a3b4fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626952Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68bef44c309d..181e44c23185 git log 68bef44c309d..181e44c23185 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@181e44c23185 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id9072d4318994a251665655dc8fe81a583a6decf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626143Reviewed-by:
-
Lambros Lambrou authored
This adds support for requesting offline access for the new token (via the 'offline' field in the gRPC request). This also suppports providing the new OAuth refresh token (as well as the access token) to the callback. This functionality will be used for updating the host's config, in case the stored refresh token has insufficient scopes. This will be provided by a separate class in an upcoming CL. The OAuthTokenGetter is not affected - it will always use "online" mode to transparently deliver access-tokens with required scopes. Bug: 954427 Change-Id: I6a09677b3a8cc0e9a61e98dc4bb084031c77cc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625955 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#662489}
-
Yuwei Huang authored
This CL makes FtlMessagingClient ignore broadcasted message that doesn't have a sender registration ID. This can happen when the user registers a new device, which will broadcast a USERDATA message to all of the user's devices. If this happens with a CHROMOTING_MESSAGE then it means the sender has bug. Currently we still ack messages with no sender registration ID, since normally we don't expect Chromoting hosts/clients to broadcast. And if someone (might be FTL backend) does broadcast, we want to make sure the message won't just sit in the inbox forever. Change-Id: Ib99796675918aae8ddcaf572c032d3fb8b929771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626653 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
siyua authored
Added button labels in a separate CL (from CL 1610308) to merge in asap if we want to land the separate button label implementation on M76, since it already passes the string freeze. Will make sure these are translated. Bug: 961082 Change-Id: I1e927a9e19b43ac07bbc80ee880116f3b1ce231b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625922 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
-
iOS Autoroller authored
TBR=smut Change-Id: I7a5aec9475404019a1ffe91941f53d2190c7477d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626932Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#662486}
-
Erik Jensen authored
As part of the migration from Talk to FTL, we need to fetch new OAuth tokens with additonal scopes. This fetching will happen in the network process, which has no filesystem access. This new message will allow the network process to inform the daemon process of the new token, so the daemon process can update the on-disk config file accordingly. Bug: 954427 Change-Id: I59d0498abe9d31c4789a95ff1371d700728eabca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625925Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dad31e0cc1e9..4d346fbec70e git log dad31e0cc1e9..4d346fbec70e --date=short --no-merges --format='%ad %ae %s' 2019-05-23 benjhayden@chromium.org Add butterbars to /report and /group_report Created with: gclient setdep -r src/third_party/catapult@4d346fbec70e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=eyaich@google.com Change-Id: Iedfe94cbbe7a5b2dcfb27558e3c1e4a91a1fe50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626694Reviewed-by:
-
Yuwei Huang authored
* Change the redirect URI to the new non-talk one. * Remove the ME2ME OAuth scope check in OAuthTokenExchanger since it breaks IT2ME and test binaries. Change-Id: I36e7778a9ee7a42ea77719277784bab2eb294a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626400 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The fix at r662120 https://chromium-review.googlesource.com/c/chromium/src/+/1624074 was insufficient to stop the bot failures. Convert more PostTaskWithTraits to using a TaskRunner instead. Bug: 963702 Change-Id: I57768cc53e9c6069acba19590a1dcbae19eda4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626195Reviewed-by:
-
sangwoo.ko authored
Replace gfx::AnimationDelegate with views::AnimationDelegateViews. This will help gfx::AnimationContainer be driven by ui::Compositor. TODO: * files under ash/ * other files which can't use AnimationDelegateViews. Bug: 953585 Change-Id: I39279bcc779c72bedb26f8c1e43661f0a0a9691d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616921Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#662481}
-
