- 29 May, 2019 40 commits
-
-
Yutaka Hirano authored
This is a followup of [1]. It turns out FrameUseCounter is confusing given that it is not a subclass of UseCounter, so this CL renames it to UseCounterHelper. This CL also renames DocumentLoader::GetUseCounter to DocumentLoader::GetUseCounterHelper, which was another TODO in [1]. 1: https://crrev.com/7d455c057de0e1ccb28b2eb574b855ae118786dc Bug: 963306 Change-Id: Id83e39bcdb0c6957384d9dbe269deee2de203b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664135}
-
tby authored
This CL adds the most recently launched app to the info included in a hashed logging event. Note: there are now a couple of string manipulation functions in search_controller.cc that probably don't belong there, and are also duplicated elsewhere. I'll refactor them out into the utilities class in a separate CL. Bug: 951287 Change-Id: I0ea7379339aa1ae25788a6c0cc6af73f38a0f004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634029Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#664134}
-
Sara Kato authored
Ensure that filter type is correctly set when S2S is enabled. Test: Manual (follow steps to reproduce on bug) Bug: b/109637169 Change-Id: I34a6358a8aa27e5571e70f1b71866c46dd79fcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631809Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#664133}
-
Sam McNally authored
BackgroundTrigger never ended up being used so remove it. Change-Id: I96ae083bfe60c893b7ddd97921d6432a69d207ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634129 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#664132}
-
Ramin Halavati authored
Profile::IsGuestProfile() returned true for the off the record profile of a guest session profile, and Profile::IsGuestSession() returns true for both off the record and regular profiles of the guest sessions. To prevent usage confusions, the former is removed. Bug: 947933 Change-Id: Iedf55f05d386bd190d8cb00228bfc104b5b763cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628728Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#664131}
-
Koji Ishii authored
This patch changes `ShapeResult` and `ShapeResultView` to set `StartIndex` from the original given argument. Before this change, it was computed from the start index of the first run. This was problematic when the first run is missing, such as when all glyphs in the first run are missing. LayoutNG and `ShapingLineBreaker` fails to compute when `StartIndex` and `EndIndex` are shifted due to missing runs. The way to compute `NumCharacters()` is also changed because `EndIndex` depends on it. Before it's the sum of characters in all runs, but for the same reason, this excludes missing runs. With this change, it is computed and set from the given arguments on creation. The start index of runs is also affected when copying ranges or creating `ShapeResultView`, because the old way was accumulating the number of characters in runs, which results in incorrect index after a missing run. Bug: 963521, 967167, 967439 Change-Id: Ie522285fce6468d70334cd7cca5c3ac7b358f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632134Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664130}
-
Jay Harris authored
When window.open is called, the created app window doesn't know what url it will be opening, so we can't determine if the toolbar will be shown. Thus, once the web contents starts a navigation, the window bounds must be checked for correctness. This CL adds a property 'initial_url' function to AppBrowserController. This will be used in a future CL to determine whether or not to show the 'X' button on the custom tab bar (popups opened out of scope should not show it). Before and after screenshots for an in and out of scope popup. The popups should both have their web contents sized at 480x300 Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394814&signed_aid=zqCH2pYzkhISnPQRiPjzuQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394815&signed_aid=owOrcmaGQWpKcub8E8orNw==&inline=1 Bug: 777854 Change-Id: I893c21d0c13a12b079eb578e68f1167bf335be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626058 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664129}
-
Takuto Ikuta authored
This is step 2 written in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1337417 Bug: 954450 Change-Id: I12f57ceca31ab35933ea70549b77b54a3e6275ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629896Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4870b6af055..9b4620d4523a Created with: gclient setdep -r src-internal@9b4620d4523a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I429dced93cb545f5180d8750cd9f4feb8f4e5053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664127}
-
Armando Miraglia authored
Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] https://github.com/w3c/mediacapture-main/issues/585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126}
-
Lambros Lambrou authored
This updates the installer, and the launchd agent (whenever it is run as root) to run the upgrade tool. Bug: 954427 Change-Id: I7f4a4b89c95ec76f706f4906a207af2236c29871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633970Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664125}
-
Erik Jensen authored
On Windows, this is used to rewrite the configuration file. Bug: 954427 Change-Id: I8bca99c6cf553004936417d626b4b3e47830103e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633630 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Paul Dyson authored
Instead of only logging PWAs that are on a white list, use from_bookmark() to determine whether an extension is a PWA. from_bookmark() returns true for both PWAs and bookmark apps, so this is used to log bookmark apps as well. Bug: 899123 Change-Id: Ia6cc4f11fff13ff249786f229d21c6d15d1d8e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599811Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#664123}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c573ec8ab233..25b63f91b3b4 git log c573ec8ab233..25b63f91b3b4 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 herb@google.com Remove getGlyphIDAdvance() from SkStrike's API Created with: gclient setdep -r src/third_party/skia@25b63f91b3b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I6fb58c610a7d604ad31ca906de8dca9f317db18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664122}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/686be20b4556..e4470cd8b405 git log 686be20b4556..e4470cd8b405 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9b60f86c..99181c0b (663961:664078) Created with: gclient setdep -r src/third_party/webrtc@e4470cd8b405 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1cd89606a31b2646f9d3b3f925822c7219cd136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633535Reviewed-by:
-
Matt Mueller authored
CRLs use the same concept of thisUpdate & nextUpdate, split the date checking function out so that it can be used by both OCSP and CRL checking. Bug: 749276 Change-Id: I641db6f92062422ff70697353bd4d435016dc2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628167 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664120}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5db62d36c9b5..a63e7596c1e6 git log 5db62d36c9b5..a63e7596c1e6 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 dberris@chromium.org Dashboard: Add dberris@ to OWNERS Created with: gclient setdep -r src/third_party/catapult@a63e7596c1e6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Change-Id: I4afec78d00ade914cc2fa68e6ab06c6d24892de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633734Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664119}
-
Erik Jensen authored
Previously, we were passing the pseudo handle returned by GetCurrentThreadToken(). While this worked fine on Windows 10, but failed on Windows 7. This commit instead uses OpenThreadToken, which returns a real handle to the user token. Bug: 967928 Change-Id: Ic1f58aa03d07fb68748aff2b5c08a3aaf7b1005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632601Reviewed-by:
-
Ramin Halavati authored
HostContentSettingsMap::is_incognito() covers both incognito and guest sessions, hence it is renamed to IsOffTheRecord(). Bug: 947933 Change-Id: I70e29b8f27dbbcfcec8fad97cbb6a9962fcc8603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631280 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2cb25737..15de9f2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f5b520b35b8e7944a5d24b25aabc02d3798177a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633595Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664116}
-
Kevin Bailey authored
This CL adds a feature and companion parameter that respectively enable and select the preferred maximum number of URL suggestions to be shown in the Omnibox. The limit can be exceeded if there are no other types to replace them with. Bug: 966462 Change-Id: Id4a5e9cf5b5ef778f79de7f085e8bd5c7bfa779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628640Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664115}
-
Yutaka Hirano authored
The origin header manipulation was introduced at https://codereview.chromium.org/343273005. As we are moving CORS to services/network, let's stop manipulation origin header in renderer. This fixes origin header for GET-nor-HEAD request from extensions. Bug: 967630, 595993 Change-Id: I5bb5342ebceb133aa726ebc9125f6c1a5f71a0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633869 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664114}
-
Koji Ishii authored
This patch moves caret utility functions off from NGPaintFragment, to minimize dependencies to NGPaintFragment in NGBoxFragmentPainter. Bug: 714962 Change-Id: I1c23baf5805239149deca155af141c59134eb6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631233 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#664113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83b12e46399c..e4870b6af055 Created with: gclient setdep -r src-internal@e4870b6af055 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I682c18367510493c3cc352370c8ab793aa2f6ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633455Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a758c5cf. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" abf2ac5e "webrtc wpt: avoid race conditions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I02acc49ce7634baee0aec0d884ba3b5aa52a49bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633592Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664111}
-
Maksim Sisov authored
Change the log to present more meaningful information about what buffer format and usage were used to create a gbm buffer. Also, remove the size from the TRACE as it is not really needed. Bug: 939794 Change-Id: I04fbbfa17b5eedd0fd9f5de0a9088b3e7f79fc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511461Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#664110}
-
David Dorwin authored
This affects metrics in one case for WebVR: WebVR presentation sessions started by headset activation will be counted as requestPresent. This seems like a reasonable tradeoff for this simplification since WebVR is deprecated and such scenarios are likely rare. The use in VRDisplay's constructor was not actually necessary since this is a non-immersive session. Bug: 842025 Change-Id: I08d4712967c1ce2720e93f85d7679a2f915a6b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629178Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664109}
-
Erik Jensen authored
Bug: 954427 Change-Id: I8427f0bf330bc6a1cba5a37a5ebd17aa640ab568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626547Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If1447dca9ad54734cf93ff64168acfe364149956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633735Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f88b2da05d5..c573ec8ab233 git log 8f88b2da05d5..c573ec8ab233 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c573ec8ab233 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I72c15ca410930959c0049ba1c96e2e5034cc6232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633737Reviewed-by:
-
Leon Han authored
This is a reland of a4545bae Based on the original CL, this CL changed to add the blob handle for network::mojom::DataElement --> blink::FormDataElement conversion in encoded_form_data_mojom_traits.cc for Network Service disabled cases. Original change's description: > [OnionSoup] Move binding of blink.mojom.ServiceWorker into Blink > > This CL moves blink.mojom.ServiceWorker interface implementation from > content::ServiceWorkerContextClient into > blink::ServiceWorkerGlobalScope, at the same time moves another two > tightly coupled classes into Blink as well: > content::{ServiceWorkerTimeoutTimer,ControllerServiceWorkerImpl}. > > Previously, > content::YYY -(Mojo call DispatchXXXEvent)-> > content::ServiceWorkerContextClient -(WebServiceWorkerContextProxy)-> > ServiceWorkerGlobalScopeProxy --> ServiceWorkerGlobalScope. > Now, > content::YYY -(Mojo call DispatchXXXEvent)-> ServiceWorkerGlobalScope. > > Previously, > blink::ZZZ -(DidHandleXXXEvent/ResponseToXXXEvent)-> > ServiceWorkerGlobalScopeClient -(WebServiceWorkerContextClient)-> > content::ServiceWorkerContextClient. > Now, > blink::ZZZ -(DidHandleXXXEvent/ResponseToXXXEvent)-> > ServiceWorkerGlobalScope. > > As a result of the above changes, we removed a bunch of member functions > from WebServiceWorkerContext{Client,Proxy}, together with a bunch of > public Web types which have been replaced with corresponding mojom > types, like WebServiceWorker{Request,Response} replaced by > blink.mojom.FetchAPI{Request,Response}, also removed those corresponding > type converters as well. > > BUG=922376 > > Change-Id: If9cc7f190f6056a2c4440f3e5e1eaa6823ed79e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1297740 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Leon Han <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#663648} TBR=falken,shimazu,peter,haraken,yhirano,tkent as they've already given OWNER approval on the original CL. Bug: 922376 Change-Id: Ie20bd86142aeb3d23561540246e22a87ed667697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631124Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ib5e3666facd8d2eb4ccf4c74b3c8cbb68f4598b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633974Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#664104}
-
Jamie Walch authored
Change-Id: I25172eeb7f589d1dea3480d322d4ed73f2213fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633969Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8b5fc36191d7..26d3cf08c209 git log 8b5fc36191d7..26d3cf08c209 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 enga@chromium.org Fix dawn_end2end_tests with the wire 2019-05-29 jiawei.shao@intel.com Support force enabling multiple toggles in Dawn end2end tests Created with: gclient setdep -r src/third_party/dawn@26d3cf08c209 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Id5e3edfa6b1eaaa3c6068a01897876b48b3b4549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633671Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a730bef0e754..dc0353f46e1f git log a730bef0e754..dc0353f46e1f --date=short --no-merges --format='%ad %ae %s' 2019-05-29 gbiv@google.com chromeos_config: use llvm-next in the pgo_generate toolchain builder 2019-05-29 achuith@chromium.org lib/cros_test: Unittests Created with: gclient setdep -r src/third_party/chromite@dc0353f46e1f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I30a6524193ff010778f0457c4b0f855df89b2f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633733Reviewed-by:
-
Jordan Bayles authored
This patch rolls the third_party/openscreen dependency to include build fixes for compiling in Chromium. Change-Id: I451ef45155da341cf94fdf20e93f2e0dd31ddb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632910 Auto-Submit: Jordan Bayles <jophba@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#664100}
-
Austin Orion authored
This change adds the ability to take metadata provided by websites via the MediaSession API and give it to the System Media Transport Controls (SMTC), giving users more information about the active media session on Windows. Bug: 954009 Change-Id: I637fce4208a5a78138cbdc1bcb93a954b698b7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606900 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#664099}
-
Ehsan Karamad authored
The test PDFExtensionInternalLinkClickTest.ShiftLeft exposed a race where the embedder RenderFrameHost is nullptr by the time the IPC ReadyToCreateMimeHandlerView arrives. This CL checks |rfh| to ensure it is not nullptr. TBR=wjmaclean@chromium.org Bug: 967045 Change-Id: Ib80499c8d9e758c8ef07b7d06f69429062d8c6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633991Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#664098}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ce909c11c06..b97d193baafa git log 4ce909c11c06..b97d193baafa --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 maruel@chromium.org cipd: Update lucicfg to 1.7.7. Created with: gclient setdep -r src/third_party/depot_tools@b97d193baafa The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:808836 TBR=agable@chromium.org Change-Id: I3b4830379ab5adbbc95b0de154005d4959bfe61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633732Reviewed-by:
-
Vikas Soni authored
Move the files to from gpu/vulkan/ to gpu/ipc/common/. This is to avoid vulkan dependency and ifdefs at every place this struct is used. Bug: 948722 Change-Id: I065948a99b1ed0de92229173747711855e5ca63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601642Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#664096}
-
