- 30 Jan, 2020 40 commits
-
-
Adam Rice authored
Implement the SendStream interface and OutgoingStream mixin from the WebTransport specification. Implement the QuicTransport createSendStream() method to create a SendStream() object. SendStream is trivial as all interfaces are inherited from OutgoingStream. A new interface, WebTransportCloseProxy acts a bridge between QuicTransport and OutgoingStream. It abstracts away that a single stream_id can be shared between an IncomingStream and OutgoingStream in the case of a bidirectional stream. Also add a browser test for the new API. Bug: 1011392 Change-Id: I68731e606527d5dd94d54f9bfed05a22fde4d59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024393Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#736817}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1cf15bfe55a3..cf0595234cf2 git log 1cf15bfe55a3..cf0595234cf2 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 eshr@google.com Move quality scaler into adaptation module Created with: gclient setdep -r src/third_party/webrtc@cf0595234cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I52f3482096e2ff2fd279df1a036c5f6415b9ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736816}
-
Adam Rice authored
According to the Fetch Standard, attempting to create a Request object with a body that is a ReadableStream and the keepalive flag set should throw a TypeError exception. Make it do that. Since we don't yet support upload streaming, this doesn't make much functional difference, but it lets us pass the external/wpt/fetch/api/request/request-keepalive.html test. BUG=973659 Change-Id: Ib3919d28a99691cfdde640b2dfb9e695b9e0c8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030349 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
python client is being deprecated. Bug: 984869 Change-Id: I94a7445b903d8806fe520788998e1e0e4b96326c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029566 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736814}
-
David Roger authored
Before this change, any account added during the extension consent flow was not going through Dice, and thus was not properly added to Chrome. This prevented the account to be properly managed, and in particular it was not possible to refresh the access tokens. This CL attaches Dice headers to requests coming from the extension consent flow, and the account is now added to Chrome. Other guest web views (such as the InlineLoginUI) are still ignored by Dice. It is unclear whether they really need to be ignored, but to minimize the change, this CL doesn't modify this behavior. Change-Id: I869ab5e699b7ee6cb556c17555be502893e3ea67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954387 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736813}
-
Wenbin Zhang authored
From Pinpoint, end user can launch a job by selecting a benchmark together with a story or a story tag. Though, there's no way to run all stories of a benchmark. The reason behind this is that Pinpoint does not have enough devices so it wants to limit the duration of each job. However, some benchmarks are small and it won't be a big load even running all of their stories. Per Blink team's request, this CL adds "all" tag to two of its benchmarks: blink_perf.dom Bug: chromium:1023451 Change-Id: I334e3d3157b3c29c94e3de342d4d5e060948f712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028120Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#736812}
-
Alice Wang authored
This CL added some checks before the personalized bookmark signin promo is shown and refactored some related code. Bug: 1045480 Change-Id: I408e3e9a90c1c188fd77ab8ddd94158d259313ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022786 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#736811}
-
Colin Blundell authored
When Chrome's captive portal detection service is enabled (as it is on Linux), its SSLErrorHandler requires that CaptivePortalTabHelper be available off of WebContents. This CL makes CaptivePortalTabHelper in this context in WebLayer as preparation for sharing //chrome's SSLErrorHandler in //weblayer. Bug: 1030692 Change-Id: Ib5c2fb5ed2fee54204f32c18a146dfad3a45b428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024851 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#736810}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60fd8cd3. With Chromium commits locally applied on WPT: b292a7b8 "Separated willValidate check in HTMLInputElement::validationMessage" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib5246995770bf8d84f21b559e9362736d0bbefd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028475Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736809}
-
arthursonzogni authored
This correspond to step 1.b from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao This merges: - content::CSPSourceList - network::mojom::CSPSourceList Only the mojo one remains. Future follow-up will apply do the same CSPDirective and ContentSecurityPolicy. The goal at the end is to have an unique mojo data structure for representing Content-Security-Policy. Bug: 1021462 Change-Id: Ie9f826dec8f6e0f3ec9e8fd38bc606250bd6fc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022948Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
The sole test in this suite exercises dragging an extension into the app menu, which is not a supported feature when the flag is enabled. Bug: 984654 Change-Id: I9d59ea27b80cef4529b6201b8f1be0face7ed7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027847Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#736807}
-
Ioana Pandele authored
This reverts commit 6d035d3a. Reason for revert: Broke multiple test targets on Linux CFI Bug:1047150 Original change's description: > Roll src/third_party/swiftshader 6c3dc3581eaf..430def835f9f (7 commits) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/6c3dc3581eaf..430def835f9f > > git log 6c3dc3581eaf..430def835f9f --date=short --first-parent --format='%ad %ae %s' > 2020-01-29 capn@google.com Regres: aways use build output path for ICD json > 2020-01-29 capn@google.com Associate bug IDs with unimplemented functionality > 2020-01-29 amaiorano@google.com Fix memory leak in rr::Optimizer > 2020-01-29 bclayton@google.com Regres: Make it work on windows. > 2020-01-29 amaiorano@google.com Subzero: implement coroutines for Win32 > 2020-01-29 bclayton@google.com SpirvShaderDebugger: Expose builtins in HLSL / GLSL. > 2020-01-29 bclayton@google.com Vulkan/Debug: Add VariableContainer::extend() > > Created with: > gclient setdep -r src/third_party/swiftshader@430def835f9f > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I02f8c532b33dc934d1f4da0da6eb43dd0b7e174b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029219 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#736686} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I6721bde098fb6ed88cdaa210ec1168fb1f01712d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030174Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#736806}
-
Robbie Gibson authored
With the new dark mode design, the icons no longer change color when they are highlighted. This means that the extra masking is all no longer needed and can be cleaned up. Fixed: 986804 Change-Id: I796a6fa6d4db5f478361823c5e216527bd875f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023658Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#736805}
-
Rushan Suleymanov authored
This CL adds UMA for commit error codes (including NONE) of sharing message data type. Bug: 1044609 Change-Id: I683be2597167a180653f8ad2d29b6da30b47eeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025110Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#736804}
-
Rune Lillesveen authored
Bitwise operation between enums of different types. Bug: 1035171 Change-Id: Ie82131a9c6d2f0797947893735b5fb193ea54eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030166Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#736803}
-
Ioana Pandele authored
The flags removal CL did not contain updates to flag-metadata.json. The removal CL was reverted at https://chromium-review.googlesource.com/q/I6473fb68d3aac1e937da9ded8138befdd857e762 and merged into release branches. The revert did not include changes to flag-metadata.json causing AboutFlagsTest.EveryFlagHasMetadata to fail on multiple bots. This CL adds metadata for the removed flags, in order to fix the tests. This approach is likely to cause less disruption than a revert of the breaking change. TBR=mcasas@chromium.org Bug: 1047089 Change-Id: Ifb40c3ca8ec826b509c588efb37cf65cf69ef863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030484Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:10165 Change-Id: I2788219581bbbc328c276916aafa2475a51f0a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028087Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736801}
-
Ioana Pandele authored
TBR=jsbell@chromium.org Bug: 1047126 Change-Id: Ie21b6031591425cf4fa1b80ec14f35836734f5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030465Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b12649462ca2..df2dbba832ad git log b12649462ca2..df2dbba832ad --date=short --first-parent --format='%ad %ae %s' 2020-01-30 leese@chromium.org Check for wasm disassembly before inline script 2020-01-30 szuend@chromium.org Add 'skipFirstWait' argument to breakpoint decoration test helper 2020-01-30 kayce@google.com Update the What's New UI for Chrome 81 Created with: gclient setdep -r src/third_party/devtools-frontend/src@df2dbba832ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1045573,chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If8ee0f39ec0c67488c8f9686e1b68f452beffa78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030041Reviewed-by:
-
tby authored
This is a reland of cbe25387 Original change's description: > [Structured metrics] Rearrange build files > > Currently, the generated classes for each event are created under the > //tools/metrics/structured target. I don't think this is the intended > use of the tools directory, because chrome targets explicitely can't > depend on it, and so can't access the generated events. > > This CL moves the codegen targets to //components/metrics/structured, > which is accessible from chrome (and just makes more sense). > > Bug: 1016655 > Change-Id: I6a295486a3dad094b44db67d70408c8629728bcc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029531 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Auto-Submit: Tony Yeoman <tby@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736753} Bug: 1016655 Change-Id: I16f5ddd85b46d0b3420d7a40421a5cba60063f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030385Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736798}
-
Fabian Sommer authored
This is in preparation to use the UI for smart cards. Bug: 1001288 Change-Id: I6a2890eaf476a79db68e8bc6898c7e4fb89199c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022770 Commit-Queue: Fabian Sommer <fabiansommer@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736797}
-
Stephen Nusko authored
There was a lot of different uses of getting the SharedMemoryArbiter this unifies them all and makes it consistent. Bug: 1007310 Change-Id: I0a6aba5f739723b46261cb6e0ec174d07ddc2897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026569Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I996de028a1b2f135003a12bea40d62d24d57f83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030040Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29e5a1af6c1d..305542ea70b1 git log 29e5a1af6c1d..305542ea70b1 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@305542ea70b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib29b230275804310d09dd921017d7287c534f531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030035Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ebcde89ed38..a66ca23b9f26 git log 6ebcde89ed38..a66ca23b9f26 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fancl@chromium.org Add /subscriptions/list endpoint Created with: gclient setdep -r src/third_party/catapult@a66ca23b9f26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: Ic4d526e4674eac67db1d8a4df75ce426321fab08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030039Reviewed-by:
-
Rune Lillesveen authored
Resolved in https://github.com/w3c/csswg-drafts/issues/4608 Pull request: https://github.com/w3c/csswg-drafts/pull/4714 Change-Id: Id902a8f7b920872a3dede346c98c87092a6147e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027418Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#736792}
-
Yutaka Hirano authored
Using default implemnetation breaks WrappedResourceRequest semantics. Bug: 787704 Change-Id: Ic80403d884df5ca04460614c8fbc94fa27b417ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029535Reviewed-by:
-
Arthur Hemery authored
Test flakes because of an already identified problem. Bug: 1040059 Change-Id: Id18c4111664a9c8adc186a8034085d7f84a265fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027792 Auto-Submit: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736790}
-
Edward Jung authored
Experiment period has not seen any statistically differences in proceed or action rates on the security interstitials. Removing all experiment code. This will also fix the refresh flicker from the JS classname switching. Bug: 978002 Change-Id: Ida9649772ff6e5e0ddbcc10f779c3545884e42ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010947 Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#736789}
-
Maria Kazinova authored
calls. PasswordForm is a result of parsing and is a part of the browser process. The renderer process doesn't need it, as all necessary renderer process information is contained in FormData. Bug: 949519 Change-Id: Ifd7b96945206d895bd77e5aaeb18d31420646fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013055Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#736788}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1c330bde24f..8f44c3504ca6 git log f1c330bde24f..8f44c3504ca6 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8f44c3504ca6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I77bb0d0b7b2d8ed4389f763bb1afdbef853909d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030037Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/97f1d485b763..dd3f8d4922eb git log 97f1d485b763..dd3f8d4922eb --date=short --first-parent --format='%ad %ae %s' 2020-01-29 afdx@google.com spirv-fuzz: Add outlining test (#3164) 2020-01-29 afdx@google.com spirv-fuzz: Make functions "livesafe" during donation (#3146) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@dd3f8d4922eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I8a87ff85d4de4e8e58597c6c5c01862aae94d306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030034Reviewed-by:
-
Isabella Scalzi authored
Addresses post-facto review comments of CL:2026548. Bug: 1038799 Change-Id: Id22e54a6824d7d28028145f5ef5eef3efb8ff846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029560 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736785}
-
sandromaggi authored
The action is no longer used. Bug: b/148194528 Change-Id: Ia7b6cb5c5f6dd4ebdad059f35a15e35da469d159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027329Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#736784}
-
Simon Zünd authored
This CL removes a race in a breakpoint web test. The CL does a similar things an existing test helper, but in a safe way. {waitUntilPausedAndDumpStackAndResume} also prints the reason why we are paused. Since we pause at a breakpoint and we get a status message for that (plus a stack trace), we removed the reason from the test expectation in favor of a non-flaking test. R=petermarshall@chromium.org Change-Id: I20aa786d370e64eb16ed3a9036b5599a6be02651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028888Reviewed-by:Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#736783}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9a80305c0897..5e86b28ffb81 git log 9a80305c0897..5e86b28ffb81 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 johnkslang@users.noreply.github.com Merge pull request #2071 from jeffbolznv/version_less Created with: gclient setdep -r src/third_party/glslang/src@5e86b28ffb81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I2852784f0a72494ab3d00a5aa0bc936f4d3e04ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029285Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1026818 Change-Id: Ia27a49cc27a09ba8288eb013cd522a5eea26ab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027850Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736781}
-
Maksim Ivanov authored
Add VLOG statements for the certificate, signature and PIN requests into the chrome.certificateProvider API implementation. These logs will help in investigating testing and customer issues for the Chrome OS smart card login feature. The logs will have to be removed later, once the feature gets stabilized. Bug: 1046860 Change-Id: Id3aaa57118f9134f15dee0e861c606ebb3e03252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029508Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736780}
-
Anatoliy Potapchuk authored
This CL contains a cleanup of redundant command line flags -- kForceAndroidAppMode, kForceWebAppMode, leaving only kForceAppMode for all kiosks. Also, it sends this flag to the renderer so the net_error page doesn't display suggestions which may redirect outside. Bug: 1034137 Change-Id: I3ecdc1916d6a33364b13624a8dcffc2c835df554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027907 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#736779}
-
Kei Nakashima authored
This change is for following the spec of validationMessage. It affects the situation where willValidate is false and actual validation message exists. It enables validationMessage to return empty string in this situation. Bug: 1046211 Change-Id: Ie501535464b61366c81ee08d6b234fb52cc076f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024132 Auto-Submit: Kei Nakashima <keinakashima@google.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736778}
-
