GitLab

The manifest spec doc was missing the extra dictionary for "portable".
Spotted by Brad. Thanks!

BUG=none
NOTRY=true
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/394283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305852

Review URL: https://codereview.chromium.org/396933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283575 0039d316-1c4b-4281-b951-d872f2087c98

When an extension is updated, the imported module of the extension could be changed in the new version. If the imported modules are removed in the new version, we need check and remove the shared modules if necessary.

BUG=393232

Review URL: https://codereview.chromium.org/386033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283574 0039d316-1c4b-4281-b951-d872f2087c98

Most of the WindowTreeHost functionality is actually implemented by the
platform window, so there's not much in WindowTreeHostOzone aside from
forwarding calls to and from the platform part.
    
Should be no functional change for in-tree platforms. To accomplish
that, this adds a transitional class PlatformWindowCompat that
implements PlatformWindow functions as WindowTreeHostOzone did before.
As a followup, we'll convert each platform to use the new PlatformWindow
natively & then remove PlatformWindowCompat.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran all platforms.
NOTRY=true
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/375053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283573 0039d316-1c4b-4281-b951-d872f2087c98

- Add accessors: web_frame(), routing_id(), render_view().
- Remove accessor: render_frame(). Where we do need to touch the
  RenderFrame, we'll look it up by its routing ID.
- Small change to the CompositingHelper to use the new getters.
- Add a map to allow finding a RenderFrameProxy by its associated
  blink::WebFrame.
- Introduce a second factory function and differentiate the two
  factory functions according to the two ways RenderFrameProxies will
  be created. The first is for when an extant local RenderFrame is
  being swapped out and replaced with a new RenderFrameProxy. The
  second is for when a RenderFrameProxy needs to be created without
  displacing an existing RenderFrame, as shall occur once we mirror
  the frame tree.
- This second factory function, which is uncalled at the moment, will
  create WebRemoteFrames. Also there is stubbed out code in the first
  factory function to create WebRemoteFrames. This code is in
  preparation for eliminating the RenderFrame (and its attendant
  WebLocalFrame) and having instead just a RenderFrameProxy.
- Add some defensive checks to prepare for when the render frame may
  not exist, as will happen once the second factory function
  enters use.
- Add an Init function so that code can be shared between the two
  factory functions.

As an adminstrative note, this patch is a chunk of nasko's 
larger "use RenderFrameProxyHost" effor (issue 241223002)

BUG=357747
TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process

Review URL: https://codereview.chromium.org/357043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283572 0039d316-1c4b-4281-b951-d872f2087c98

I've gone through the enterprise UMA enums and compared them to their C++
counterparts.  There was a mismatch for EnterpriseDeviceManagementStatus which
is corrected by this CL.  To prevent this kind of error in the future, this CL
adds comments and numeric ids to the C++ enums.

BUG=none

Review URL: https://codereview.chromium.org/375903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283571 0039d316-1c4b-4281-b951-d872f2087c98

member so we can free channel_id_key_ after we're finished with it.

This fixes a TODO in https://codereview.chromium.org/355293003/.

R=rch@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/397803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283569 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283568 0039d316-1c4b-4281-b951-d872f2087c98

The android-chrome-shell browser is an upstream browser, so should
be using a target platform of 'android' not 'android-chrome'.

BUG=394324
NOTRY=true

Review URL: https://codereview.chromium.org/392323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283567 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178278:178288&mode=html
TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/398083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283566 0039d316-1c4b-4281-b951-d872f2087c98

Revert of athena: Add a minimized state for the home-card. (https://codereview.chromium.org/394043002/)

Reason for revert:
it broke "athena_unittests,steps" on "Linux ChromiumOS Tests (1)":
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45720.

Original issue's description:
> athena: Add a minimized state for the home-card.
> 
> The home-card can be in a minimized state. In this state, only a narrow line
> is displayed at the bottom of the screen, and dragging it up shows the overview
> mode. When a window is selected in the overview mode, the home-card is minimized
> again.
> 
> BUG=381224
> R=mukai@chromium.org, oshima@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283539

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381224

Review URL: https://codereview.chromium.org/391383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283564 0039d316-1c4b-4281-b951-d872f2087c98

Revert of mac: Fix tab dragging visual bug in Yosemite. (reland) (https://codereview.chromium.org/393933003/)

Reason for revert:
Broke TestActivate and TestFullscreen on Mac 10.6 Tests (http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/builds/53658)

Original issue's description:
> mac: Fix tab dragging visual bug in Yosemite. (reland)
> 
> -----------------Reland Description------------------
> Core animation was turned on in M35. The fullscreen window was not layer
> backed, but should have been. This original CL exposed this bug.
> 
> -----------------Original Description------------------
> In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
> views (like the tab strip and the profile icon) are placed on top of the title
> bar and require special treatment. All other views are added as subviews of
> 'chromeContentView' in TabWindowController. This allows tab dragging and
> fullscreen logic to easily move the views that don't need special treatment.
> 
> This CL also removes the instances where a VersionIndependentWindow's
> contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
> gets passed around as a subview. This allows VersionIndependentWindow to remove
> another of its internal hacks.
> 
> Original CL link: https://codereview.chromium.org/379293003/
> BUG=392239
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283456

TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392239

Review URL: https://codereview.chromium.org/398903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283563 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/398023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283562 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/392253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283561 0039d316-1c4b-4281-b951-d872f2087c98

Add flags from debian/rules, and disable assembly modules.

BUG=344505, 313751, 389216
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/393023010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283560 0039d316-1c4b-4281-b951-d872f2087c98

In particular on the Swarming bots.

R=dbeam@chromium.org
BUG=376299
NOTRY=true

Review URL: https://codereview.chromium.org/398113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283559 0039d316-1c4b-4281-b951-d872f2087c98

Added combined shadow assets used by the class ui::wm::Shadow and remove the unneeded
assets for individual shadow patches.

BUG=377319
TEST=run 1.0x, 1.25x and 2.0x scale factor and verify all shadows are rendered correctly.
R=ccameron@chromium.org, oshima@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/385123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283558 0039d316-1c4b-4281-b951-d872f2087c98

gpu: Update CHROMIUM_copy_texture.txt to reflect that GL_TEXTURE_RECTANGLE_ARB is a supported source target.

BUG=366710
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/395213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283557 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/388053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283556 0039d316-1c4b-4281-b951-d872f2087c98

Also sorted css rules for dots.

BUG=375191
NOTRY=true

Review URL: https://codereview.chromium.org/397543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/383263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283554 0039d316-1c4b-4281-b951-d872f2087c98

This allows to remove weak pointers between different WebContents,
and pointer from DevToolsController to WebContents of DevToolsWindow.
The latter one proved to be stale sometimes and caused crashes.

Once bug 392031 is resolved, AllowOtherViews can be removed.

BUG=392914,392917,392971,392031

Review URL: https://codereview.chromium.org/388803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283553 0039d316-1c4b-4281-b951-d872f2087c98

First phase of extending the relocation packer for arm64.

Upgrade logging to be streams-based.  Add new unit tests to cover logging
and checking features.  Mechanical changes to logging call sites.

Also correct a type promotion issue that causes incorrect DT_RELCOUNT
adjustments when the packer is compiled as a 32-bit Linux binary.

BUG=385553

Review URL: https://codereview.chromium.org/392653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283552 0039d316-1c4b-4281-b951-d872f2087c98

This will help ASan reports appear on stderr when content_shell is run from CMD.exe console or on ClusterFuzz

See also http://crrev.com/275067 where the same was applied to chrome.exe

BUG=345874

Review URL: https://codereview.chromium.org/394853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239
TBR=toyoshim

Review URL: https://codereview.chromium.org/397623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283550 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up to https://codereview.chromium.org/337053005.

BUG=224596

Review URL: https://codereview.chromium.org/392233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283549 0039d316-1c4b-4281-b951-d872f2087c98

This is the duplicate of https://codereview.chromium.org/373043003. The bubble turned to be unresponsive on Windows. This CL has a workaround. The original problem is in infrastructure. It's to be fixed in  BubbleDelegateView.
set_use_focusless(true) has adverse effect on Windows.
1) The bubble can't be the active window (which is not desired behavior).
2) The bubble doesn't get WM_LBUTTONDOWN event. Therefore, all the buttons get stuck.
We call set_use_focusless(false) after the bubble is shown. Thus, it can get focus and mouse events properly.

BUG=383821

Review URL: https://codereview.chromium.org/396973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283548 0039d316-1c4b-4281-b951-d872f2087c98

SymbolizationLoop.process_line() has been factored out and can now be used to symbolize the reports line by line.

BUG=235466
NOTRY=true

Review URL: https://codereview.chromium.org/397983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283547 0039d316-1c4b-4281-b951-d872f2087c98

In order to track UMA accurately we only need to track it when there is an actual prompt for permission, not when the permission was saved for the domain. I have re-purposed the PermissionDecided method for this which was essentially doing nothing before.

BUG=392145
TBR=fgorski,tommi

Review URL: https://codereview.chromium.org/371933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283546 0039d316-1c4b-4281-b951-d872f2087c98

The previous code writes the parsed metadata to |metadata| dictionary
remembered in |this.rootParser_|, but this is wrong.

The parser class is shared among multiple parses, so to correctly
distinguish concurrent parsing activity, it cannot store states
in the member fields.

BUG=172989

Review URL: https://codereview.chromium.org/391313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283545 0039d316-1c4b-4281-b951-d872f2087c98

|willRequestAfterPreconnect| was removed from blink::WebFrameClient at
blink r178134, thus this override is never called.

BUG=386888

Review URL: https://codereview.chromium.org/395093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283543 0039d316-1c4b-4281-b951-d872f2087c98

(This is a much larger change than its diff suggests. If it breaks something, please revert first and ask questions later.)

R=davidben@chromium.org, eroman@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/345063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283542 0039d316-1c4b-4281-b951-d872f2087c98

video_decoder_shim.cc uses libyuv, and the build fails if we're not
building in component=shared_library mode and enable_webrtc=0:

In file included from ../../third_party/libyuv/include/libyuv.h:15:0,
                 from ../../content/renderer/pepper/video_decoder_shim.cc:25:
../../third_party/libyuv/include/libyuv/compare.h:14:32: fatal error: libyuv/basic_types.h: No such file or directory
 #include "libyuv/basic_types.h"
                                ^

R=dmichael@chromium.org, bbudge@chromium.org

Review URL: https://codereview.chromium.org/393813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283541 0039d316-1c4b-4281-b951-d872f2087c98

Doing some sorting and splitting of data to make large amounts
of changes easier to study.

BUG=

Review URL: https://codereview.chromium.org/375063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283540 0039d316-1c4b-4281-b951-d872f2087c98

The home-card can be in a minimized state. In this state, only a narrow line
is displayed at the bottom of the screen, and dragging it up shows the overview
mode. When a window is selected in the overview mode, the home-card is minimized
again.

BUG=381224
R=mukai@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/394043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283539 0039d316-1c4b-4281-b951-d872f2087c98

Before, the FakeProvidedFileSystem had some hardcoded responses. However, since
FileStreamWriter is coming soon, we will need to verify if the file on the
file system is changed correctly.

For that, FakeProvidedFileSystem has been refactored, so it is possible to add
and get fake files and verify their values.

TEST=unit_tests: *FileSystemProvider*
BUG=391362

Review URL: https://codereview.chromium.org/393233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283538 0039d316-1c4b-4281-b951-d872f2087c98

split off from https://codereview.chromium.org/388963002/

BUG=160586

Review URL: https://codereview.chromium.org/390183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283537 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/385553002/ uses BackoffEntry, but it requires a lot of changes, so it probably won't be merged to M37. I suggest to merge this small fix.

BUG=377725
TEST=manual

Review URL: https://codereview.chromium.org/383183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283536 0039d316-1c4b-4281-b951-d872f2087c98

Enables most of compiler warning on ASan build.

BUG=162783

Review URL: https://codereview.chromium.org/391743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283535 0039d316-1c4b-4281-b951-d872f2087c98