GitLab

Removing the TextTrackClient interface because it was obscuring calls
made to the HTMLMediaElement and wasn't really providing much value.
Calls made to the HTMLMediaElement are much clearer now and it is
easier to follow what happens when tracks are removed from the
TextTrackList.

BUG=249427
TEST=All existing LayoutTests still pass
R=adamk@chromium.org

Review URL: https://codereview.chromium.org/177003025

git-svn-id: svn://svn.chromium.org/blink/trunk@168534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch keeps m_blocksForFingerprint in sync with m_fingerprints when
adding a new entry to m_fingerprints. Here's a quick summary about
these maps:
m_blocksForFingerprint maps Fingerprint -> list of RenderBlocks
m_fingerprints maps RenderObject -> Fingerprint

Previously, when adding a block to m_fingerprints we could neglect to
update m_blocksForFingerprint. By removing entries from
m_blocksForFingerprint before registering a new block fingerprint, we
prevent a crash on [1].

[1] http://www.chicagotribune.com/news/sns-wp-blm-news-bc-inventor01-20140301,0,255272.story

TEST=Added an assert that crashes all over our layouttests without this fix. Manually verified [1] no longer crashes.
BUG=348463
NOTRY=true

Review URL: https://codereview.chromium.org/186453002

git-svn-id: svn://svn.chromium.org/blink/trunk@168533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A few more WebSocket layout tests now pass with the new
implementation. Remove them from the TestExpectations.

BUG=339373
TEST=run_webkit_tests --debug http/tests/websocket

Review URL: https://codereview.chromium.org/162923002

git-svn-id: svn://svn.chromium.org/blink/trunk@168532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When XMLHttpRequest.responseType is specified to "blob", we
download the resource into a file and on XMLHttpRequest.response
call, we create a Blob object from m_response.downloadedFilePath()
and m_downloadedBlobLength. m_downloadedBlobLength is accumulated on
WebCore::XMLHttpRequest::didDownloadData() handler call but not
reset on clearResponse() call. So, if you use the XHR instance again
after calling open(), uncleared invalid size will be used.

We should just reset it to 0 on clearResponse() call.

BUG=349321

Review URL: https://codereview.chromium.org/183333005

git-svn-id: svn://svn.chromium.org/blink/trunk@168531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move HTMLContentElement & HTMLShadowElement out of shadow/ and
into html/.

Reference CL: https://codereview.chromium.org/27009005/

Review URL: https://codereview.chromium.org/183893019

git-svn-id: svn://svn.chromium.org/blink/trunk@168530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=317931
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/181233010

git-svn-id: svn://svn.chromium.org/blink/trunk@168529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related to this w3c mailing list thread:
http://lists.w3.org/Archives/Public/www-style/2014Mar/0013.html

BUG=231754

Review URL: https://codereview.chromium.org/186943003

git-svn-id: svn://svn.chromium.org/blink/trunk@168528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert "Consider text alignment and direction when computing the left offset for horizontal writing modes."

This caused layout to fail in the filmstrip for Google Hangouts.
This reverts r167732 and r168295.
Landing with NOTRY=true because bots167732 seem busted.

BUG=347889,157539
NOTRY=true

Review URL: https://codereview.chromium.org/176763011

git-svn-id: svn://svn.chromium.org/blink/trunk@168527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes scaling (including z-scaling) caused by page zoom and high dpi settings (pinch zoom still todo).

This also fixes the light position, since the light origin was misplaced when a non 0 filter effect region x and y parameters were used (which is the case by default). The origin was affected by these values, which shouldn't be the case, as these provide extra space to render an effect, like a blur, for example, but should not changed the effect's coordinate system.

BUG=

Review URL: https://codereview.chromium.org/181943003

git-svn-id: svn://svn.chromium.org/blink/trunk@168526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add various performance tests for CSS Shapes taken from
https://bugs.webkit.org/show_bug.cgi?id=128188.

BUG=349093
NOTRY=true

Review URL: https://codereview.chromium.org/186783003

git-svn-id: svn://svn.chromium.org/blink/trunk@168525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trying to add this first before https://codereview.chromium.org/186783003/

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168517

Review URL: https://codereview.chromium.org/187673007

git-svn-id: svn://svn.chromium.org/blink/trunk@168524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dstockwell@chromium.org, steveblock@chromium.org
BUG=349552

Review URL: https://codereview.chromium.org/183023015

git-svn-id: svn://svn.chromium.org/blink/trunk@168523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a bit more smarts to StyleBuilder jinja machinery to make
it understand how fonts are made. Custom is bad. Generated is good.

R=ksakamoto@chromium.org,eae
BUG=

Review URL: https://codereview.chromium.org/186403002

git-svn-id: svn://svn.chromium.org/blink/trunk@168522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Range::didSplitTextNode() fails to update RangeBoundaryPoint's
m_childBeforeBoundary correctly, if either boundary point is located
immediately after the split text node. This change fixes this bug and adds
a couple of unit tests that make sure text splits are handled correctly.

This is a bug I found while I was investigating on a ClusterFuzz crash. The bug
above was the root cause of the crash. The crash happens in the following way:
  1. Range::surroundContents() removes some nodes during its operation,
     which causes DOMNodeRemoved event to fire *before* surroundContents()
     completes.
  2. A user-supplied event handler does something causing text to split.
  3. Due to the bug above, Range's boundary points may get into an inconsistent
     state; i.e. m_start may be located *after* m_end.
  4. If certain conditions are met, an invalid Range object created during
     Range::surroundContents() causes a crash within checkDeleteExtract().
  5. Sad face.

This change adds a new layout test that reproduces this crash.

BUG=343798

Review URL: https://codereview.chromium.org/178543013

git-svn-id: svn://svn.chromium.org/blink/trunk@168521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is now agreed in blink that 'nullptr' is used
to represent a null value for smart pointers.
This patch makes HashTraits<RawPtr> use 'nullptr_t'
as 'EmptyValueType' making it consistent with
HashTraits<RefPtr> and HashTraits<OwnPtr>.

Review URL: https://codereview.chromium.org/185903002

git-svn-id: svn://svn.chromium.org/blink/trunk@168520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r168130 updated -webkit-appearance:menulist-button implementation. We should
update the CSS ruleset for input[type=color][list] too because it uses
menulist-button when it is styled.

BUG=345609
TEST=automated

Review URL: https://codereview.chromium.org/180163012

git-svn-id: svn://svn.chromium.org/blink/trunk@168519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trying to add this first before https://codereview.chromium.org/186783003/

NOTRY=true

Review URL: https://codereview.chromium.org/187673007

git-svn-id: svn://svn.chromium.org/blink/trunk@168517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168491

BUG=313447
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/181233009

git-svn-id: svn://svn.chromium.org/blink/trunk@168516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=kinuko@chromium.org, tyoshino@chromium.org
BUG=349537

Review URL: https://codereview.chromium.org/186723006

git-svn-id: svn://svn.chromium.org/blink/trunk@168515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tommyw@chromium.org
BUG=349528

Review URL: https://codereview.chromium.org/187413005

git-svn-id: svn://svn.chromium.org/blink/trunk@168514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Number input type maximum value increased from float to double. Float allowed only max value of 3.402823466e38, it has now been increased to 1.7976931348623158e+308, by using double.

InvalidStateError exception is removed from NumberInputType::setValueAsDouble and NumberInputType::setValueAsDecimal, as HTMLInputType::setValueAsNumber checks if value is infinite.
As NumberInputType functions will not be called, they have been removed.

HTMLParserIdioms has also been updated as the functions are triggered in NumberInputType functions and has check for max values, thus updated.

R=tkent, ch.dumez@samsung.com
BUG=336020
TEST=Max value number can hold and exception thrown in case higher value than double is set

Review URL: https://codereview.chromium.org/172223003

git-svn-id: svn://svn.chromium.org/blink/trunk@168513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Which are:

- webaudio/dynamicscompressor-simple.html
- webaudio/realtimeanalyser-fft-scaling.html

BUG=349523
TBR=rtoy@chromium.org

Review URL: https://codereview.chromium.org/183063009

git-svn-id: svn://svn.chromium.org/blink/trunk@168512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderReplaced::computeReplacedLogicalWidth walks up to it's
containingBlock in some cases and asks for the containingBlock's
width. If the containingBlock's width itself depends on the
RenderReplaced's width, then we infinite loop. Avoid the
infinite loop by making sure that width/min-width/max-width
are all specified on the containingBlock, which will keep
the width from depending on it's children.

Added FIXMEs. I think we should delete all this containingBlock
walking code, but it needs to be done carefully to make sure
percentage widths on <svg> keep working. The spec actually
considered this undefined behavior, but suggests doing the
crazy that we do here.

BUG=344647

Review URL: https://codereview.chromium.org/186913003

git-svn-id: svn://svn.chromium.org/blink/trunk@168511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=349518
TBR=rtoy@chromium.org

Review URL: https://codereview.chromium.org/187383005

git-svn-id: svn://svn.chromium.org/blink/trunk@168510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reattach which means everything will work fine for ::first-letter changes.

However, if there is a change in ::first-letter style, but the element had
::first-letter style both before and after the change, we would not try to
recalc any ::first-letter pseudo for LocalStyleChange.

The introduction of LocalStyleChange for :hover/:active/:focus caused a
regression for the combination of ::first-letter and e.g. :hover.

This fix does a SubtreeStyleChange for :hover/:active/:focus updates when
the existing renderStyle is marked as having ::first-letter pseudo.

::first-line is working fine. Added a layout test to make sure it will
continue to do so.

R=esprehn
BUG=344322

Review URL: https://codereview.chromium.org/169643002

git-svn-id: svn://svn.chromium.org/blink/trunk@168509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this change it was not possible to easily distinguish when RuleData represented a single item and when it represented an array.

This change is prerequisite for moving RuleSet/RuleData into the GC managed heap because tracing routines are largely type driven.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/181403005

git-svn-id: svn://svn.chromium.org/blink/trunk@168508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/184293003

git-svn-id: svn://svn.chromium.org/blink/trunk@168507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

icudtl.dat is not copied to an Android device for webkit_unit_tests
leading to the failure of tests depending on ICU.

Add icu.isolate explicitly to get icudtl.dat copied.

TBR=jamesr@chromium.org
BUG=72633
TEST=build/android/test_runner.py gtest -s webkit_unit_tests --verbose
--gtest_filter=WebFrameTest.SelectRange*

Review URL: https://codereview.chromium.org/183013006

git-svn-id: svn://svn.chromium.org/blink/trunk@168506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/186863002

git-svn-id: svn://svn.chromium.org/blink/trunk@168505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/183833011

git-svn-id: svn://svn.chromium.org/blink/trunk@168504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/177653004

git-svn-id: svn://svn.chromium.org/blink/trunk@168503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash is on L1125, calling insertNodeAt with the Null VisualPosition, startOfInsertedContent.
It inserts a <br> element to the selected position but the replacing might change visual position so we should check.

BUG=348283

Review URL: https://codereview.chromium.org/183893018

git-svn-id: svn://svn.chromium.org/blink/trunk@168502 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Creates RemoteFrame, which will represent in WebCore frames
that are rendered outside of Blink, and Frame, a base class
for both LocalFrame and RemoteFrame. The current division of
members and methods between Frame and LocalFrame is not
final, but provides a starting point for us to start
converting LocalFrame to Frame in some parts of Blink.

BUG=346764
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/183713002

git-svn-id: svn://svn.chromium.org/blink/trunk@168501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

step-middle and steps(x, middle) need to work in the Web Animations API but not in CSS. To achieve that we check for step-middle and steps(x, middle) in CSSToStyleMap::mapAnimationTimingFunction, where CSS-land timing functions are set. Step middle functions won’t behave like other invalid inputs; when an animation is made with timing-function: step-middle, or the timing function is set to step-middle after creating the animation, the timing-function value is set to “ease”.

In AbstractPropertySetCSSStyleDeclaration::setPropertyInternal (in PropertySetCSSStyleDeclaration.cpp) there is no good way to check the value of the property to be set, so we just don’t. This means that if you do

    element.style.animationTimingFunction = 'step-middle';

then element.style.animationTimingFunciton will return “step-middle”, but “ease” is used as the actual timing function. This issue is partially mitigated by the fact that we also check RuntimeEnabledFeatures::webAnimationsAPIEnabled at the parsing layer, and don’t parse step middle functions if it’s false.


This CL also removes TimingFunctionTestHelper and TimingFunctionTestHelperTest and  adds TimingFunctionTest.

BUG=327564

Review URL: https://codereview.chromium.org/149363002

git-svn-id: svn://svn.chromium.org/blink/trunk@168500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the last step in factoring compute_interfaces_info:
EventInterfaces.in is a simple auxiliary file that's largely unrelated to
bindings.
Splitting it out means compute_interfaces_info now purely computes interfaces
info!
This means we can reuse it without needing dummy files (e.g., in r-b-t and in
gyp), and also simplifies its code.

We can actually simplify both scripts (and r-b-t) further,
but this is a conservative CL, just splitting it out.

BUG=341748
R=haraken

Review URL: https://codereview.chromium.org/185303008

git-svn-id: svn://svn.chromium.org/blink/trunk@168499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Move testRunner.startSpeechInput/setValueForUser to internals (https://codereview.chromium.org/176953009/)

Reason for revert:
Broke the Android compile:
  http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/25493/steps/compile/logs/stdio

Android does not enable speech input, and the methods called are guarded behind the ENABLE_INPUT_SPEECH compile-time flag. The testing code in Internals.cpp should also be guarded with the same flag.

Original issue's description:
> Move testRunner.startSpeechInput/setValueForUser to internals
> 
> Now TestRunner is being moved from CppBoundClass to gin::Wrappable,
> where it is not appropriate to use WebElements directly. This CL moves
> some functions which treats WebElement* from testRunner to internals.
> (To be exact, this CL only copies some functions, but I'll remove those ones
> in testRunner later.)
> 
> BUG=331301
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168495

TBR=haraken@chromium.org,hajimehoshi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331301

Review URL: https://codereview.chromium.org/187903004

git-svn-id: svn://svn.chromium.org/blink/trunk@168498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This follows the spec change on https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
where the fetch origin is given by the master document, not the referring document.
This matches what CSP in imports is doing: Using master's CSP directive to regulate
all the imports.

In implemntation, it just set ResourceLoaderOptions::m_securityOrigin in
FetchRequest::setCrossOriginAccessControl() because HTMLImportsController
happened to pass the master' origin already.
(That was wrong but wasn't covered by the test.)

This change doesn't affect other FetchRequest client because in other callsite,
m_securityOrigin is same as one that is used when it is absent.

TEST=cors-same-origin.html
BUG=348671
R=abarth@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/186803005

git-svn-id: svn://svn.chromium.org/blink/trunk@168497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=loislo

Review URL: https://codereview.chromium.org/180783018

git-svn-id: svn://svn.chromium.org/blink/trunk@168496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now TestRunner is being moved from CppBoundClass to gin::Wrappable,
where it is not appropriate to use WebElements directly. This CL moves
some functions which treats WebElement* from testRunner to internals.
(To be exact, this CL only copies some functions, but I'll remove those ones
in testRunner later.)

BUG=331301

Review URL: https://codereview.chromium.org/176953009

git-svn-id: svn://svn.chromium.org/blink/trunk@168495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransfer-interface

The spec uses DataTransfer and both Firefox and IE agrees.

BUG=348580
R=ch.dumez@samsung.com, tkent@chromium.org

Review URL: https://codereview.chromium.org/183743013

git-svn-id: svn://svn.chromium.org/blink/trunk@168494 bbb929c8-8fbe-4397-9dbb-9b2b20218538