- 08 Jul, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594219033-e737395f4059a2d181f502d2cd1e2e733e308ff9.profdata to chrome-mac-master-1594231179-c7594468dab38d8e431c4fcba79f22d1baa4fc31.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I45ed3e29e540cc170c4e3ca0588ece4c4fba650c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786452}
-
Dominique Fauteux-Chapleau authored
This dialog can appear during a long scan, or if the user waits for too long to close the scan dialog indicating the scanning verdict. It is misleading as the page seems unresponsive because of the scanning, so this CL prevents that dialog from appearing at the same time as the scanning dialog. The dialog is prevented from being shown by having ShouldIgnoreUnresponsiveRenderer return true until the paste callback has been ran. Bug: 1028750 Change-Id: If34f8184f254074c9ce30b49337a14531e24a8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283397Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786451}
-
Curt Clemens authored
This is a reland of 341bb752 Original change's description: > [Nearby Share] Add ToDictionary, FromDictionary to PrivateCertificate > > ToDictionary and FromDictionary methods convert to/from a Value > dictionary to facilitate storing PrivateCertificates in Prefs. > > Change-Id: I92117836af94cd224eeea34edc7dd55dd3eb7484 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284043 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#786027} Change-Id: I223a97fa67c1ecc821971ce89302f0064fd4abb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287989Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#786450}
-
Sreeja Kamishetty authored
- RenderDocumentHostUserDataTest.CheckWithFrameCrashDuringNavigation - All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoreferrer/2 - All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoreferrer/0 - All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoreferrer/1 Bug: 1102629 Change-Id: Ibf928450dd7affeca9a78842460c364210308de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287810Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#786449}
-
Henrique Nakashima authored
Old wording implies only one JAR is analyzed. Bug: 1081840 Change-Id: Id98d2ce6e59d6b0d9e9dde863932f47d14920a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288629 Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786448}
-
Stephen Sigwart authored
Fixes visible selection change when you left click or hold down the left mouse button. Bug: 1101679 Change-Id: Id08534eeabfc9a9a58744d7fa6cb4e7a2ba1a372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285873Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786447}
-
Matt Reynolds authored
WebMediaPlayerImpl uses a base::CancelableCallback to hold the callback that will receive a routing token for the Android overlay. The callback is canceled if DisableOverlay is called before the token is received. The type of this callback should be media::RoutingTokenCallback which is a base::OnceCallback, so we'll switch to base::CancelableOnceCallback. BUG=1102651 Change-Id: I50845dba9be97f30b86f8ebb71a152457ff3df7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284208Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786446}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594216727-af10bce0f9b1296f4a0f692869feeccf20c7185e.profdata to chrome-win32-master-1594220267-9b42ec61f1a87a14500dff1ab9da4a37b8c79053.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib0fcd2365e0e5232a08da3e5c9b356607f10ef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288469Reviewed-by:
-
Edward Lesmes authored
Bug: 1098927 Change-Id: Ibc9b2571750e5ac9dbb7fbb737790c7584af88f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284370Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#786444}
-
Natalie Chouinard authored
This reverts commit 53f0457f. Reason for revert: Suspected cause of multiple weblayer_instrumentation_test_apk failures on Lollipop Phone Tester https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester Original change's description: > [WebLayer] InstrumentationShellActivity uses UrlBarController. > > This change gets rid of the EditText we were using in > InstrumentationTestActivity for weblayer instrumentation tests and > replaces it with a UrlBarView returned by UrlBarViewController. > > All relevant methods have been updated, and a small UrlBarControllerTest > added to verify expected behavior. > > Bug: None > Test: ./out/<build_dir>/bin/run_weblayer_instrumentation_test_apk > Change-Id: I7b8a54cec34f4b53df2e410ebb9526c943f4edf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270442 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Mugdha Lakhani <nator@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785731} TBR=jam@chromium.org,boliu@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103342 Change-Id: I46ff0442bebc4ff50b6ae6ed8a7708ced5678568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288103 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786443}
-
Steve Kobes authored
Bug: 1007815 Change-Id: I858d9d2cd1b28d213d028350d39c064d2972bdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285519 Auto-Submit: Steve Kobes <skobes@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#786442}
-
Steve Kobes authored
Bug: 1007815 Change-Id: Idfa01b46b4ada3e968843277124841e70932bc7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285512 Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
If we already know the inline-size of the float before placing it, we don't need to make a guess at its position before laying it out. We can just set it right away. This is just an optimization. No behavior changes intended. Bug: 915929 Change-Id: I72ce406ef6b32ff5755522e3375dd93c407ee834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278050Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#786440}
-
Yuheng Huang authored
- Create enable_tab_search build flag - Setup WebUIDataSource for TabSearchUI - Setup resource grid file Bug: 1099917 Change-Id: Ifef42c65d2e485a9f9cb24f6634af41cd7afb48c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268199 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786439}
-
Henrique Nakashima authored
Use multiprocess.Pool to spawn CPU# / 2 processes and accelerate generate_json_dependency_graph.py when possible. Based on a single run: Before: real 5m38.769s user 29m9.770s sys 1m38.073s After: real 1m11.504s user 23m35.792s sys 1m5.959s Bug: 1081840 Change-Id: Ib5d1e24c37d1fadeae5df0536c7fd1b20e7a1b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285379 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Allen Bauer authored
Change-Id: Ic5381f3d316ff944dbde13abb234d2873359bd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278627 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
With VizForWebView enabled webview now supports embedding of the surfaces. Unfortunately because of the order how we apply features it's not possible to override DisableSurfaceLayerForVideo from the finch config. This CL modifies the check for disabling surface layer to take into account VizForWebView experiment. Bug: 1103197 Change-Id: Ied5f9e85680e0fa151c79020a5b8de7ed92f2812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287809Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#786436}
-
Alex Turner authored
This method allows callers to chain tokens in the builder, just like other primitive types and byte spans. Bug: 1102935 Change-Id: I2020be507a4d65819230a4c67d32ac96170a3d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285252 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786435}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I567afd7824ff7c10d442ae576d694eb0af4d7259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285468 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#786434}
-
danakj authored
Now that renderer local dumps are all synchronous operations (thanks to https://chromium-review.googlesource.com/c/chromium/src/+/2284373) we can compute all the renderer-side dump results and pass them to the WebTestControlHost in the browser immediately in InitiateCaptureDump() ipc. Once we do this, we no longer need to call a separate CaptureDump() ipc to the renderer, store a callback there, and reply asynchronously. The browser already has everything it needs once it finishes doing text (aka layout) and pixel dumps. We also can combine the InitiateLayoutDump() ipc with the InitiateCaptureDump() so that we only have one ipc to the browser when the renderer's main frame wants to signal that the test is done. To do this we just need to move some code around in the renderer side in order to land on a single InitiateCaptureDump() call. This greatly simplifies the end of the test, and removes a bunch of async states from both the browser and the renderer. We change expectations for 2 web tests that do weird things with the main window's WebContents. The portal test activates and destroys the WebContents out from under WebTestControlHost, which it doesn't like. Now it should end the test gracefully. The web platform test does a window.close() which closes the Shell in the middle of the test, which again the WebTestControlHost is not a fan of. But it should also now print a FAIL indicating this happened and end the test instead of timing out. R=avi@chromium.org Bug: 866140, 1069111, 1039247 Change-Id: I051a18f875dff758232cc1ba3f573f0ab4bcde2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285169Reviewed-by:
-
Michael Crouse authored
This is a reland of 6ea86d08 The issue was the network condition checks which are now override by a switch for these tests (see cl/2284978). Original change's description: > [LiteVideo] Do not attempt LiteVideos on Reloads/Forward-Back. > > This change prevents LiteVideos from being attempted when the > navigation is a reload or forward-back page transition. It also > adds an entry for host of the navigation to the user blocklist to > allow users to soft opt-out of the optimization if they reload > frequently on a host. > > A future change will clear the blocklist when the browser history > is wiped. > > Bug: 1096796 > Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786127} TBR=tbansal@chromium.org Bug: 1096796 Change-Id: I5164e510bfb06fc97e45ab9c82c482dc25529e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287380Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#786432}
-
Xida Chen authored
With this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2234063 We changed how the aggregated throughput is computed, but I forgot to delete the old old which is the ComputeAggregatedThroughput(). This CL deletes the dead code. This is a code health CL, no behavior change. Change-Id: I946e215f10270827065b667893c8782a9482f30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285932Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786431}
-
Erik Chen authored
The first time the GetLinuxDistro() is called, it reads from a file. This means that it can block so it should not be invoked from non-blocking sequences. Change-Id: I33230eeeba931d1d8cf4780b10f00754cb3569f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283936 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786430}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I8ac7626e4795bca5be0cddb900e49577780c5b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288079Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#786429}
-
ckitagawa authored
This CL replaces the viewport state in PlayerFrameMediator with a new PlayerFrameViewport class for managing state. This causes a chain reaction requiring 1. A number of new method calls. 2. Removal of scale updates from moveViewport 3. Removal of scale maps for storing bitmaps Bug: 1099722 Change-Id: Ia666485b59b0808af20055a1c023eb9e5176ecf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285257Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#786428}
-
Annie Sullivan authored
Change-Id: Iba711bbf8384847bb14064604399c0748681ddf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288197Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786427}
-
Kramer Ge authored
Rename to enable adding a WaylandSubsurface that wraps a wl_subsurface for overlay forwarding. Proposal doc: https://docs.google.com/document/d/1qdioeaZmfv8df0qbVTVoVQ8qSaHBZ0T3cjF4eEpARi8/edit?usp=sharing Change-Id: I17a07e86f98fdf15b2892b31694743aa262dd020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288072 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#786426}
-
Andrew Grieve authored
This reverts commit 0763bc96. Reason for reland: No longer removing target_sdk_version from webapk shell Original change's description: > Revert "Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile"" > > This reverts commit e0f5a1c0. > > Reason for revert: Breaking downstream builder: > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8875332406729172240/+/steps/compile/0/logs/raw_io.output_failure_summary_/0 > > Original change's description: > > Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > > > This reverts commit fb07fcff. > > > > Reason for reland: Not changing target_sdk_version for angle tests > > > > Original change's description: > > > Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > > > > > This reverts commit b7fb15b1. > > > > > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849 > > > > > > Original change's description: > > > > Android: Bump default target_sdk_version 24 -> SDK used to compile > > > > > > > > Why do this? > > > > * It's best practice to target the latest sdk, so this makes for a > > > > better default. > > > > * Many targets were neglecting to ever update this value > > > > TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org > > > > Bug: 1099849 > > Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981 > > Reviewed-by: Bo <boliu@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786275} > > TBR=boliu@chromium.org,agrieve@chromium.org,behdadb@chromium.org > > Change-Id: If60966b54d37bfa2c5326bcad0f36819f1c47023 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1099849 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288092 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786357} TBR=boliu@chromium.org,agrieve@chromium.org,behdadb@chromium.org Bug: 1103295 Change-Id: Ia7cdeb9dc309d4bea7e0863b709b29ebc49ee6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288097 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#786425}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e62496bafc47..c49c88ac82fb 2020-07-08 thakis@chromium.org gclient: Force "git clone" to run arm git on arm macs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103236 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I98b1577fd964d76781743e558e46a5f6eb8b08af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288132Reviewed-by:
-
Katie D authored
This fixes a bug where the active node could be scrolled offscreen causing a bad state. Now Switch Access just finds the next node when the active node is missing, after the menu is closed, and refreshes node state on scroll. Also fixes a bug where setNode could be called on an invalid node. AX-Relnotes: n/a Bug: 1095220 Change-Id: I29563cd34e76cc694ddd5a75ac4608cef9ed1fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276613Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#786423}
-
Lukasz Anforowicz authored
Before the current CL, the nonce in the crash key is unique in each crash report, making it more difficult to aggregate the data. Additionally, after r783795 landed, we started seeing new values of request_initiator_site_lock crash key associated with https://crbug.com/1056949, but unfortunately the interesting part of the crash key was truncated, making it impossible to distinguish between mhtml.subframe.invalid VS browser.initiated.invalid VS error.page.invalid. For example, before the current CL, the crash key values might look like the following (truncated to 64 characters): null [internally: (646094991C8C225E35D3FEE319396B15) derived fro After the current CL, the crash key value omits the nonce: null [internally: derived from https://error.page.invalid] Bug: 1056949 Change-Id: Ib676e4484f1814a494b5359db13cfc9160233b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284044 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Annie Sullivan authored
This ensures that it does not get called when not actually painting, which enables a failing paint-timing test to pass. The test is here: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/external/wpt/paint-timing/fcp-only/fcp-svg.html In JavaScript, the circle with id "circle" is changed from display:none to display:block, and the test asserts that First Contentful Paint only occurs after the change to display:block. Before this CL, the test fails because SVGRootPainter calls MarkFirstContentfulPaint while the circle, which is the only thing to actually be painted, is still display:none. Moving the MarkFirstContentfulPaint calls into the individual types (image, text, shape, foreign object) fixes this bug and aligns the first contentful paint implementation more with largest contentful paint. Bug: 1071450 Change-Id: I3d2a4549e00501057b4a6cf14cd04bd8f20d9d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285532Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786421}
-
Tim Volodine authored
The tests started failing on Tablet Tester bots (L and M) recently. BookmarkPersonalizedSigninPromoTest#testSigninButtonDefaultAccount BookmarkPersonalizedSigninPromoTest#testSigninButtonNewAccount BookmarkPersonalizedSigninPromoTest#testSigninButtonNotDefaultAccount BUG=1103210 NOTRY=true TBR=twellington@chromium.org,aliceywang@chromium.org Change-Id: I6c1be6beca24985eaa4c018fb4d65eef59a01c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288357Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#786420}
-
Tim Volodine authored
The tests started failing on Tablet Tester bots (L and M) recently. BookmarkPersonalizedSigninPromoDismissTest#testPromoImpressionCountIncrementAfterDisplayingSigninPromo BookmarkPersonalizedSigninPromoDismissTest#testPromoNotShownAfterBeingDismissed BUG=1103210 NOTRY=true TBR=twellington@chromium.org,aliceywang@chromium.org Change-Id: Ib9cf49b2e0b8c98fd01f01e55139cbdec6d1d3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288272Reviewed-by:
-
Erik Staab authored
TBR=dpranke@google.com NOTRY=true Bug: 896680 Change-Id: Id4a14d384bdff3dde45ce293a875733d7d97608f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288383 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786418}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5a58435c586b416629a876bce4990d2ef0f4973b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288080Reviewed-by:
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/c41d2fe865c9..4581908bee97 $ git log c41d2fe86..4581908be --date=short --no-merges --format='%ad %ae %s' 2020-07-08 vasilvv Make QuicFrame a standard-layout struct. 2020-07-07 renjietang Rename QuicConnection::RetransmitZeroRttPackets() to MarkZeroRttPacketsForRetransmission() because the method doesn't actually retransmit the data. 2020-07-07 fayang Enable gfe2_reloadable_flag_quic_fix_undecryptable_packets and gfe2_reloadable_flag_quic_fix_packet_number_length in //third_party/quic/core/http:end_to_end_test. 2020-07-07 quiche-dev Don’t assume `QuicheStringPiece::const_iterator` is a `const char*` 2020-07-07 dschinazi Deprecate quic_google_transport_param_send_new 2020-07-07 quiche-dev Remove SSL methods from non-SSL base class 2020-07-06 dschinazi Fix packet number length computation 2020-07-06 renjietang Deprecate gfe2_reloadable_flag_quic_do_not_retransmit_immediately_on_zero_rtt_reject 2020-07-06 wub For quic loss detection tuning, add a new reward function using average http latency and run it side by side with the existing reward function. protected by --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_fix_write_pending_crypto_retransmission. 2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_fix_willing_and_able_to_write. 2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_move_amplification_limit. 2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_bundle_crypto_data_with_initial_ack. 2020-07-06 wub Deprecate --gfe2_reloadable_flag_quic_update_ack_alarm_in_send_all_pending_acks. 2020-07-06 haoyuewang Remove max_ack_delay_ in rttstats. this field is unused and should be removed when deprecating quic_sent_packet_manager_cleanup flag, and hence not flag protected. 2020-07-01 dschinazi Prevent infinite loops in QUIC e2e test Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: Ib7aab5e79c77db6abaaca6beb70c0fbfb2424b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287892 Auto-Submit: Bin Wu <wub@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786416}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f0288101b5fc..414418d55f49 2020-07-08 egdaniel@google.com Add option for client to own semaphores after telling to skia to wait. 2020-07-08 herb@google.com use clip as invariant instead of skipClip 2020-07-08 robertphillips@google.com Remove all internal uses of (and deprecate) SkSurface::getContext 2020-07-08 herb@google.com remove unused clipRect for distance field 2020-07-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1004772 Tbr: mtklein@google.com Change-Id: I337f232bc5759fd884addc27e433ed6a5521bc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288412Reviewed-by:
-
Brian Geffon authored
This adds a simple helper which can be used instead of mincore for determining which pages are in core. BUG=chromium:1067833 Change-Id: Ie6f001b0c08f9fc40b35d8f18d7a2008bf9aee82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288432Reviewed-by:
-
Maksim Ivanov authored
Add a new CheckedGet() method that is equivalent to base::PathService::Get(), but returns the result as a return value (and CHECKs that the operation succeeded). This is a pure convenience addition that allows to simplify the code that anyway cannot correctly handle the path service being unavailable. (In the existing codebase, there are already >100 callsites that do CHECK(PathService::Get(...)), and also many callsites in tests that just take the path returned by PathService::Get() without checking its return value.) Bug: none Change-Id: I38535138ea08f0fd71e0eaf1979a1bdc99c504ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279813Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#786413}
-
