GitLab

BUG=455694

Review URL: https://codereview.chromium.org/1056213003

Cr-Commit-Position: refs/heads/master@{#325488}

The previous usage of Log required layers and components to
redefine Log classes and have them declare log instances. This was
not convenient and made base packages needlessly aware of specialized
layers.

This approach has the callers specify the group tag at every call, removing the need to get any sort if logger instance.

BUG=472152

Review URL: https://codereview.chromium.org/1080543002

Cr-Commit-Position: refs/heads/master@{#325487}

It makes it possible to tell if the GPU process is stuck waiting
for a DRM device to authenticate.

BUG=476728

Review URL: https://codereview.chromium.org/1086353003

Cr-Commit-Position: refs/heads/master@{#325486}

Review URL: https://codereview.chromium.org/1061433003

Cr-Commit-Position: refs/heads/master@{#325485}

This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc.
It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc.

Original CL (reverted for unrelated failure):
https://codereview.chromium.org/1043343002/

BUG=430115
TBR=michaelpg, pneubeck, mpearson@chromium.org

Review URL: https://codereview.chromium.org/1091043002

Cr-Commit-Position: refs/heads/master@{#325484}

Revert of Fix errors found in Mac gn component builds (patchset #10 id:180001 of https://codereview.chromium.org/1087873003/)

Reason for revert:
Suspected of breaking Mac GN, see https://codereview.chromium.org/1087873003

Original issue's description:
> Fix errors found in Mac gn component builds
>
> Mac gn component build fail because of missing frameworks and missing some other
> dependencies, and occasionally file list out of sync with the gyp counterpart:
> http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio
>
> For instance, the frameworks linked in the components that sync depends on is not
> automatically linked into sync, thus revealing the issue.
>
> Committed: https://crrev.com/ae8297db22a6ca96652d42bd0cdc3deff17aba4a
> Cr-Commit-Position: refs/heads/master@{#325479}

TBR=dpranke@google.com,dpranke@chromium.org,brettw@chromium.org,avi@chromium.org,toyoshim@chromium.org,piman@chromium.org,pavely@chromium.org,dalecurtis@chromium.org,jiangj@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1089773003

Cr-Commit-Position: refs/heads/master@{#325483}

The [data_]deps of source_set dependencies aren't built.
The group target type works as I'd expect; see bug for details.

This is still a GN bug(?) workaround, but a cleaner one.

BUG=477104
TEST=Building mojo/services/html_viewer:apptest builds mojo_shell
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1053493003

Cr-Commit-Position: refs/heads/master@{#325482}

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1095433005

Cr-Commit-Position: refs/heads/master@{#325481}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d352e4a..3cf1422

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089393003

Cr-Commit-Position: refs/heads/master@{#325480}

Mac gn component build fail because of missing frameworks and missing some other
dependencies, and occasionally file list out of sync with the gyp counterpart:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio

For instance, the frameworks linked in the components that sync depends on is not
automatically linked into sync, thus revealing the issue.

Review URL: https://codereview.chromium.org/1087873003

Cr-Commit-Position: refs/heads/master@{#325479}

BUG=none

Review URL: https://codereview.chromium.org/1088013002

Cr-Commit-Position: refs/heads/master@{#325478}

Changes the parameter default_zoom_factor to appear as defaultZoomFactor
to javascript.

BUG=477559

Review URL: https://codereview.chromium.org/1093603002

Cr-Commit-Position: refs/heads/master@{#325477}

BUG=465418

Review URL: https://codereview.chromium.org/1057613006

Cr-Commit-Position: refs/heads/master@{#325476}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f7aaadb..bdb0bf5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1089993002

Cr-Commit-Position: refs/heads/master@{#325475}

This fixes the compilation failures associated with _ChromeEnableBits caused by https://codereview.chromium.org/1038453002/.

BUG=477476
TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1096493004

Cr-Commit-Position: refs/heads/master@{#325474}

It does not seem necessary to have this variable, just to create another
down below called 'buf'.

BUG=None
TEST=base_unittests --gtest_filter=MD5*
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1087333004

Cr-Commit-Position: refs/heads/master@{#325473}

that return the MockRenderProcessHost.

Preamble to a fix for bug 474231, where I'll add a new method to
MockRenderProcessHost.

BUG=474231

Review URL: https://codereview.chromium.org/1051343005

Cr-Commit-Position: refs/heads/master@{#325472}

Previously all dependencies would stop propagating for link purposes when a shared library or executable boundary is reached.

This patch makes public shared library dependencies propagate through shared libraries. Since the ability to use header files is propagated through these boundaries, so do the link dependencies. See the comment in target.cc for more details.

BUG=475091

Review URL: https://codereview.chromium.org/1083663007

Cr-Commit-Position: refs/heads/master@{#325471}

This is a minor refactoring change.  See linked bug for related work.

In order to make db_ private we needed to:
  - Add accessors for common operations (IsOpen, etc.)
  - Make TestDirectoryBackingStore a friend so it can db_.release().

BUG=475557

Review URL: https://codereview.chromium.org/1082423002

Cr-Commit-Position: refs/heads/master@{#325470}

This changes the renderer side of Chromium to only denote persistent
notification ids as int64_ts rather than as strings.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1078783002/
  [2] This CL.
  [3] https://codereview.chromium.org/1072873002/

BUG=

Review URL: https://codereview.chromium.org/1071203002

Cr-Commit-Position: refs/heads/master@{#325469}

This CL removes the "override" keyword from all Blink API implementations.
We don't use the keyword for the Blink API since it's in a different
repository, and it makes changes to the API much harder.

Additionally, clean up some minor camelCase -> under_score variables.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1090953002

Cr-Commit-Position: refs/heads/master@{#325468}

BUG=476187

Review URL: https://codereview.chromium.org/1092463003

Cr-Commit-Position: refs/heads/master@{#325467}

These tests are for RemoteMediaVideoInfo and MediaUrlResolver. Many more
unit tests are needed, but these are a start. While these tests do not
replace the downstream instrumentation tests, a complete set of Cast unit
tests may reduce the need for them, and allow us to use those simply as
integration tests.

This CL also fixes one bug in MediaUrlResolver and removes getting the
already known browser user agent.

BUG=472067

Review URL: https://codereview.chromium.org/1079153002

Cr-Commit-Position: refs/heads/master@{#325466}

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1082503002

Cr-Commit-Position: refs/heads/master@{#325465}

The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.

Also, secure proxy check is now done on IO thread.

BUG=437080

Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
Cr-Commit-Position: refs/heads/master@{#325302}

Review URL: https://codereview.chromium.org/981633002

Cr-Commit-Position: refs/heads/master@{#325464}

Change ScopedSuspendBookmarkUndo to take the BookmarkUndoService
instead of the Profile in its constructor and change client code
accordingly.

Add a GetProfileIfExists() method to BookmarkUndoServiceFactory
to avoid service creation when suspending the undo/redo mechanism
as if the service is initialized at BookmarkModel creation time.

BUG=477679

Review URL: https://codereview.chromium.org/1059523005

Cr-Commit-Position: refs/heads/master@{#325463}

BUG=410824

Review URL: https://codereview.chromium.org/1086393002

Cr-Commit-Position: refs/heads/master@{#325462}

BUG=473071

Review URL: https://codereview.chromium.org/1090783002

Cr-Commit-Position: refs/heads/master@{#325461}

The effects functionality has been migrated to NaCl - the code to
manually register a Pepper plugin for Effects is no longer needed.

BUG=392002
TEST=trybots, unit_tests

Review URL: https://codereview.chromium.org/1085393003

Cr-Commit-Position: refs/heads/master@{#325460}

Although the network stack is single-threaded, it *should* be legal to spin up
a parallel instance of everything on another thread. Until
https://crbug.com/458365 is resolved, the session cache is one of the few
global mutable objects in the network stack, apart from test code. Thus it
needs to be locked.

BUG=476713

Review URL: https://codereview.chromium.org/1079943006

Cr-Commit-Position: refs/heads/master@{#325459}

BUG=472073

Review URL: https://codereview.chromium.org/1089643002

Cr-Commit-Position: refs/heads/master@{#325458}

BUG=

Review URL: https://codereview.chromium.org/1079613003

Cr-Commit-Position: refs/heads/master@{#325457}

BUG=

Review URL: https://codereview.chromium.org/1086213004

Cr-Commit-Position: refs/heads/master@{#325456}

BUG=

Review URL: https://codereview.chromium.org/1051253006

Cr-Commit-Position: refs/heads/master@{#325455}

BUG=477148
TEST=Load webview browser sample (https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa), use the browser sample app to navigate to a website that embeds a plugin (flash or pdf). Verify that the browser doesn't crash.

Review URL: https://codereview.chromium.org/1088323002

Cr-Commit-Position: refs/heads/master@{#325454}

Add original author of the code and original reviewer as OWNERS and
sdefresne@ for componentization work of //chrome/browser/undo.

BUG=476919
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1088513005

Cr-Commit-Position: refs/heads/master@{#325453}

Required in order to reland CL 1056763002. The only difference in the test output is that on the Mac the textual contents of the contenteditable are also present in the AXValue property on the AXGroup representing the contenteditable. I prefer to reland the contenteditable CL in order to investigate this more easily on my Mac.
BUG=347859
R=dmazzoni

Review URL: https://codereview.chromium.org/1080533004

Cr-Commit-Position: refs/heads/master@{#325452}

In the process of investigation of empty username occurences in the password manager, we suspect re-authentication forms to be a frequent cause. This metric will show us in how many cases this is not the cause.

We interpret occurences of an empty and nonempty username pair on the same signon realm as a presence of both a first-time authentication and re-authentication form.

We report the number of password forms with an empty username in the login database, for which there isn't another password form with a nonempty username on the same signon realm.

Out of several possible approaches:
a) SELECT ... WHERE NOT EXISTS
b) SELECT DISTINCT ... FROM ... JOIN ... ON a.signon_realm=b.signon_realm
c) SELECT DISTINCT ... FROM ... WHERE ... AND a.signon_realm=b.signon_realm
d) SELECT, put into std::set<>, SELECT, iterate and search the set

we implemented a), as manual testing on 1000 random samples seemed to be the fastest.

BUG=456728

Review URL: https://codereview.chromium.org/1087233002

Cr-Commit-Position: refs/heads/master@{#325451}

Now that all blink threads have schedulers it makes sense to get
hold the corresponding WebScheduler via WebThread.  This patch
is the chromium side of doing that.

Patch 2: https://codereview.chromium.org/1087203002
Patch 3: https://codereview.chromium.org/1084173002

BUG=463143

Review URL: https://codereview.chromium.org/1088053003

Cr-Commit-Position: refs/heads/master@{#325450}

Fix KeychainItemForForm so that it understands not to specify a path when looking for Keychain items corresponding to Android credentials.

While other code in PasswordStoreMac omitted the path before storing the Keychain item, KeychainItemForForm derived an erroneous path for an Android credential as well, and insisted to retrieve only Keychain items having that path -- yielding no matches. This has led to deleting and updating existing passwords not working.

BUG=476851

Review URL: https://codereview.chromium.org/1089233002

Cr-Commit-Position: refs/heads/master@{#325449}