- 16 Dec, 2020 40 commits
-
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I9ecee3fa64eb3192adcf62b8ce5e43324d04edf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594449Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837718}
-
Leonid Baraz authored
For all parameterized Storage tests added a new dimension: encryption enabled/disabled - now the same opening/writing/reading/reopending is tested with and without encryption. Fixed few minor mistakes, found with the test. Bug:b:170054326 Change-Id: I72df7e96b7163a5b1f7a3f43553b11ac73c15472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587505 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#837717}
-
Maggie Chen authored
The new range is between 5ms to 5s. The old range can't give us a good picture of the time it takes to finish the GPU initialization on each platform. Bug: 1153866 Change-Id: If52c1c50a9da7746d2a0ffa36b38bac1d72a9fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590696Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837716}
-
Ali Juma authored
This removes safe-browsing-real-time from about:flags since the feature is enabled by default and has shipped to 100% of Stable. This also removes safe-browsing-available from flag-metadata.json. This flag was removed from about:flags in a previous CL, but the flag-metadata.json entry was left behind. Bug: 1028755 Change-Id: I62b90e18594f906d3bc7e87392fe2afcd35f8f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595609 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#837715}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4dbefed1b355..958f1e8ca769 2020-12-16 jophba@chromium.org Port/Rewrite of Chrome's RPCBroker 2020-12-16 miu@chromium.org Fix some places that became microseconds but are supposed to be millis. 2020-12-15 jophba@chromium.org Fix Android senders by accepting 0 sequence number. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1659995c0ff1579158784a01826cddac765ee3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837714}
-
Morten Stenshorne authored
This used to crash, because we ignored layout abortions on floats, and would attempt to use the fragment (which is nullptr). Bug: 829028 Change-Id: I04c44030d33182fd3020e8091228668d7f8a7190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592805Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837713}
-
Xida Chen authored
As a result of this convert, the PendingTaskInfo::task is converted to a base::OnceClosure. This is a code health CL, no behaviour change is expected. Bug: 1152278 Change-Id: I1bb1434f01b35818336a37bed6687ab71b1dfaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593480 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#837712}
-
Nick Diego Yamane authored
Early calls to Widget::SetBounds() for native windows with the same size (but changing origin location, for example) may lead to "host resized" event being propagated to widget's views tree when it shouldn't. Which leads to tricky side effects, such as crbug.com/1151092 under Wayland, for example. This avoids it by making sure initial bounding rectangle is cached at WTHPlatform when creating the PlatformWindow instance. R=sky@chromium.org Bug: 1151092 Change-Id: I476dc11ef336e8443c83dfa874d160a1a6a9581f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593547Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#837711}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608119279-b562d5ec97263b932edf0a2d650ba22af7f72930.profdata to chrome-mac-master-1608141458-a5500324610cca8317ad489f360bbb6633944839.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6083dfb96f2875792893845a53625214fd4ba300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595493Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608119279-7581a2bc471fb45383c585f2e908653a380f92f3.profdata to chrome-linux-master-1608141458-ce789808658cedde2d9d2bce7c84c9a07b9d1c0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87ce43caf28befb9cc0cc9508767b39be28ab6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595494Reviewed-by:
-
Vidhan authored
PersonalDataManagerCleaner is responsible for applying address and credit card fixes and cleanups once on browser startup provided that the sync is enabled or when the sync starts. This CL factors out everything related to fixes and cleanups of address and credit card from the PersonalDataManager and moves them to the newly created PersonalDataManagerCleaner class. Change-Id: Ib6ed35b1237576c04dc6fe3fce8d8792cc07f3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584811Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#837708}
-
Xinghui Lu authored
Cache duration may be misconfigured. We should evict these caches to prevent false positive. Bug: 1156896 Change-Id: I4bc464113dc460319d7256919fb377f5d89bedf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583467Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837707}
-
Gavin Williams authored
Scanning: http://screen/BtSb3TZ6LzDiU7A Single image scanned: http://screen/BjGPJ8kxDBW2maR Multiple images scanned: http://screen/4NVszFMDFdS8FWr Bug: 1059779 Change-Id: I60f80431690e7d2c4d8732c95c01762587c200bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594325Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837706}
-
Joe Downing authored
During a recent service outage, most of our hosts came back online but some did not. Looking at the logs, the hosts which failed to come online were treating HTTP 500 errors as 'UNAUTHENTICATED' which is a permanent error that caused the hosts to go offline. Instead of returning UNAUTHENTICATED in this case, UNAVAILABLE should be returned. This is a retryable error and is handled as such in the various classes which use the ProtobufHttpClient class. Change-Id: Idcfe98082f382b4053dfd6dbb2b4570621375f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595521Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837705}
-
Bailey Berro authored
This change adds the RegisterReceiveSurfaceResult enum which is used to provide more granular result information to RegisterReceiveSurface callers. Bug: 1156391 Change-Id: I6c308e71b85eab1eb52d74a9b8415a0d9231baee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594177 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#837704}
-
Josh Simmons authored
I'm unable to log in to Gerrit with my @chromium.org account as it's linked to my @google.com account. I believe this should fix my inability to +1 CLs in directories I have OWNERS in. Change-Id: I796f5e99600c61d56c620c8a6aaf0233cab7fd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594213Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#837703}
-
Xiaocheng Hu authored
This patch modifies CounterStyle to handle extreme int values more carefully to avoid integer overflows during the calculation and ensure the correct result. More importantly, now 'decimal' style handles -2147483648 correctly without integer overflow, which would otherwise cause an infinite fallback cycle or DCHECK on 'decimal'. Bug: 687225 Change-Id: I2ed786aa91b7cbb950c3f6aae8762bdf48b6947f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594241Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837702}
-
Xiaocheng Hu authored
This patch refactors implementation of counter() and counters() that: - The parsed value (CSSCounterValue) now uses a custom identifier to represent the counter style name, instead of an enum - The computed value (CounterContentData) now uses an AtomicString and a TreeScope reference to represent the counter style reference, instead of an enum This allows counter() and counters() to handle custom counter style names. A follow-up patch will make LayoutCounter actually look for custom counter styles instead of relying on the ElistStyleType enum. Note: After refactoring, the separation between CounterContent and CounterContentData no longer makes much sense. So they are merged. Bug: 687225 Change-Id: I4f16a73122d8b0abcc8d1dc8e2c4eb40974461d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587955Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Gavin Williams authored
Check to see if the scan job still exists before processing the next image response. Bug: 1059779 Change-Id: I918787bfa84f8b26e785eed4be735ccc5a3a1674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594447Reviewed-by:
-
Christian Biesinger authored
The block size may be a percentage, in which case we would think the extent is definite on the final pass through this function, even if it is an indefinite percentage. Fix this by using BlockLengthUnresolvable. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1154572 Change-Id: Ia70dc730d4fee2005904942afa4020f9074f4eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595248 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Jonathan Backer authored
Change-Id: Id0dd733f9f3022a6b0b75b92d4db97d9417ade84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595690Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837698}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 409c6e41. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I377944047776df753c153ce0cf0591e8d1eb578f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595727Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837697}
-
Mario Sanchez Prada authored
This reverts commit d89f4b46. Reason for revert: These tests keep being flaky even after the patch from crrev.com/c/2587045 has landed see this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=1157241#c6 Let's disable them again for now while investigating further. Original change's description: > Enable MediaSessionBrowserTest.{MultiplePlayers,Simple}PlayPause tests > > These tests were disabled due to flakiness introduced by some recent > migrations from legacy IPC to mojo that landed past week, which I think > should be fixed by crrev.com/c/2587045, which has been just merged. > > Let's re-enable them now to double-check if the fix actually worked > as expected, keeping an eye in case they are still flaky after this. > > Bug: 1157263, 1157241, 1157239, 1157319 > Change-Id: I2b1daffebbb157eca5f8cce3f7692dbfabe75bf8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593367 > Auto-Submit: Mario Sanchez Prada <mario@igalia.com> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837643} TBR=mlamouri@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iccb8b670506aaaae9aff76e70b40d6b4a3c957db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157263, 1157241, 1157239, 1157319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595375Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#837696}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608087498-2f929d29b1a1e70fb6742374bfad7f4f226a61c8.profdata to chrome-win64-master-1608119279-c2227cc33d0350f20f44d9be3f390190e6aa297e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifce0ba62bce4b1b61eddb5d5f28e4c83c0b1ba42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595207Reviewed-by:
-
Yi Gu authored
Bug: 1152282 Change-Id: I9394d301b39b1c20410d462149aede16618f89d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595347Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837694}
-
Anthony Cui authored
Bug: 1158626 Change-Id: Ie84c58fcda662822f77e7a21f42bf2a5dbe7a580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592128Reviewed-by:
-
Morten Stenshorne authored
The offsets stored in NGLink are "paint offsets", which include any offsets caused by relative positioning. The fragment builder, on the other hand, expects "layout offsets", which shouldn't include that. The fragment builder adds the relative offset on its own at the right time. I struggled with coming up with a very sensible test, since fragmentation of out-of-flow descendants is incorrectly affected by the inset specified on their relatively positioned containing block (see crbug.com/1158387 and crbug.com/1158756 ). Bug: 1079031 Change-Id: I803dd89a11be2ba9179e20ea06d0b709d08ab534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593005Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837692}
-
Jesse Schettler authored
Update all fonts in the Scan app to conform to the spec. Spec: https://carbon.googleplex.com/cros-ux/pages/scanning Before and after: http://shortn/_w86cpakDzE Bug: 1059779 Change-Id: I8c9018bc7978a176e0de5846ed8753b21395b15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594210 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#837691}
-
Illia Klimov authored
Flash has been deprecated since M87. User-visible code was removed in M88. In this CL, I remove the last ContentSettingsType::PLUGINS non-critical call sites. Bug: 1149393 Change-Id: I6436e9d3c34f6dfd578538e6a1e7df06ae3bbffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584163 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837690}
-
Becca Hughes authored
This reverts commit a4ee82d6. Reason for revert: Kaleidoscope has been turned down Original change's description: > Add metric for Kaleidoscope derived watchtime > > This adds a UKM metric to BasicPlayback that contains > whether the playback has come from a page that was > opened by Kaleidoscope. This is so we can track watchtime > that is attributable to Kaleidoscope. > > Ukm-Privacy-Review: https://docs.google.com/document/d/1XOeGNU34FlSv_rrs5TTovpc9gTyT4IQ3Rdy2T7oyLGQ/edit?usp=sharing > > BUG=1152935 > > Change-Id: Icc6047abddf1f4f1389c09a639e9a8c49c8f24ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558691 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835001} TBR=sky@chromium.org,dalecurtis@chromium.org,jwd@chromium.org,beccahughes@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152935 Change-Id: Ie518f3b240341b75f867e2528aa6037731fb0bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595492Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837689}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0c031adc5339 2020-12-16 treehugger-gerrit@google.com Merge "tp: Fix span_left_join for empty RHS tables" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I749f9187f6c1732b2306085d6585c75230789b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595990Reviewed-by:
-
Xianzhu Wang authored
Bug: 1152869 Change-Id: Ie68a761a3cd2a81dcdd3de6d2469d64146c3f596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591907 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837687}
-
Thomas Lukaszewicz authored
This CL limits the height of the Feedback dialog to the maximum available height of the user's screen. This CL also fixes the cancel / show buttons to the bottom of the window so that they remain visible in the overflow state. Also fixes a mismatch in feedback height constants. Dialog with overflow: https://drive.google.com/file/d/1tPJumvN2NmlSj5pI5htr18QHBJKCi6W9/view?usp=sharing Dialog with no overflow: https://drive.google.com/file/d/1OB1arIhF4t0cWfKZdTYGrmuk2vCWcczR/view?usp=sharing Bug: 1065889 Change-Id: If49afa489445df770063d3b7feda889900bcfdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586759Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#837686}
-
Jonathan Wright authored
Reload the generate_build_files module after checking out the new BoringSSL hash to pick up assembly files generated for newly supported platforms. Without this change, the assembly files generated for newly supported platforms will not be committed as part of the roll. Change-Id: I7dbeefc650b3dfc52b73bd9a98fecf7f55e1910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593639Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#837685}
-
Matt Menke authored
Currently, the test fails when all ExpectCT partitioning options is enabled, because its call to AddExpectCT() uses an empty NetworkIsolationKey, while its other calls use a specific transient key. This CL fixes the test to pass in the same transient key. This CL doesn't modify the test to enable ExpectCT partitioning, since that has to be done before the TransportSecurityState is constructed. Bug: 969893 Change-Id: Ie36e8d0fc8c10028f57925d393309dd3e1658faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595628Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837684}
-
Anne Lim authored
AutofillCacheServerCardInfo is fully rolled out, so removing flag. Fixed: 1077617 Change-Id: I850f8f4cda663dcfb8303742df1a9abe7ee58d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593154Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#837683}
-
Christopher Cameron authored
Change "p3" color space to "display-p3". This is the name used in the specification and in the CSS color level 4 specification (which is shipping on Safari). Of note is that is that the color gamut media queries use "p3" instead of "display-p3". This could be intentional (reflecting the P3 *primaries* common to DCI P3 and Display P3 *color spaces*), or may be accidental. Change ImageDataColorSettings to ImageDataSettings. Right now all of the settings are for color, but the spec doesn't put color in the name because of future plans to add other settings (like premultiplied alpha). The largest remaining inconsistency is that "pixelFormat" versus "storageFormat" and "uint8" versus "unorm8". R=yiyix TBR=fserb Bug: 1083693 Change-Id: I8e6d476a17fd2fca8da6b7901bb1098253a61559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594269 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#837682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df1712b41e9f..6bf9e131d05a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I37d3b0c2a214ae804a86edfaf14f0e64b304b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595517Reviewed-by:
-
David Tseng authored
On official builds, the unified status tray appears to be inactive; test always fails. Re-enable for non-officila builds, which still exercises views UI + STS reading. R=akihiroota@chromium.org Fixed: 1158879 Change-Id: I2fc7b4e6bb922c6d60aa819a73ce3a41b3afc003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595491 Auto-Submit: David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#837680}
-
Sergei Glazunov authored
Move the problematic include under the ENABLE_BACKUP_REF_PTR_IMPL flag. Change-Id: I15340b867bb51fda4894ea260bdd8ac59f666e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595369 Auto-Submit: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837679}
-
