- 13 Nov, 2019 40 commits
-
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I07ec25a8d87cbfc446155825c501469da6624003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912202Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714895}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I5df7c3d600bd39afb6b7d478d4b75a42193f3c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912203Reviewed-by:
-
Gauthier Ambard authored
This scoped swizzler swap the implementation of two instance methods of a class. Bug: 901082 Change-Id: I90d4009189b2206c453f9f3847c5fc9e58e94ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911743Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#714893}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I9b4bbcc58754f84ebda30cb171c49c638bd261c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912300Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c7351898. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jfernandez@igalia.com: external/wpt/css/css-align NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2c9d1314f00f2fc26b5da0d181671fbe63ad15c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914182Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714891}
-
Maks Orlovich authored
Sadly wanting a DCHECK for asan_canary coverage gets in the way of testability here. (This is done for metrics only, as a prep step before switching over). Change-Id: Ia8c272a90459c885ec3fdae7d9879a1b5413c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913063Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#714890}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0db01f0fabd1..088977a7a7fb git log 0db01f0fabd1..088977a7a7fb --date=short --no-merges --format='%ad %ae %s' 2019-11-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@088977a7a7fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I478f02de5b6cfc1182a595547eb11a082b15d4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714889}
-
Marc Treib authored
Nothing in InvalidatorRegistrarWithMemory requires thread affinity, so no reason for using ThreadChecker instead of the preferred SequenceChecker. Bug: none Change-Id: Iead32eb4176913df32c11364cf90c5263782d3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910087Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#714888}
-
Eric Seckler authored
This is a reland of 0d929861. Reland after fixes for crbug.com/1022770, crbug.com/1022386, and crbug.com/1022818 landed. Original change's description: > perfetto: Use TraceProcessor for proto2json conversion > > TraceProcessor replaces the existing (unmaintainable) proto2json > converter and adds features like combining of BEGIN/END events > and support for heap profiles. > > Also updates a devtools test that was expecting separate begin/end > events where TraceProcessor now combines them into a complete event. > > We have reduced the trace procesor's binary size overhead > by selectively excluding features Chrome doesn't need from >400kB to > ~50kB. We could probably save a couple more kB if we invest even more > eng time and accept the maintenance burden for this in trace processor, > however, we feel that we've reached an acceptable state that balances > binary size & code health. > > Binary-Size: see paragraph above. > Bug: 1006770 > Change-Id: Ia7f6b3a784c1a9c40574e1dcd80eca1ca2dfb03f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746258 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713593} Binary-Size: see paragraph above. Bug: 1006770, 1022770, 1022386, 1022818 Change-Id: I7297721eb67834905262081282936013b34a0184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913602Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#714887}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d4002a733dc6..1242d9cc48ca git log d4002a733dc6..1242d9cc48ca --date=short --no-merges --format='%ad %ae %s' 2019-11-13 danilchap@webrtc.org Reland Cleanup MultiStreamTester Created with: gclient setdep -r src/third_party/webrtc@1242d9cc48ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic920df481986e944f50d126785350e5e491c4229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913558Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/88632cac30e1..359bc80a7ee4 git log 88632cac30e1..359bc80a7ee4 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 digit@google.com [vulkan] Implement VK_KHR_external_memory_fd for Linux and Android. Created with: gclient setdep -r src/third_party/swiftshader@359bc80a7ee4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140419396 Change-Id: If5b2a35c08e238cd052f89993f7a290c2e0be482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913997Reviewed-by:
-
Alex Ilin authored
ashmem_create_region() returns -error_code on failure. ScopedFD treats only -1 as invalid handle meaning that ScopedFD will try to close a file descriptor with a negative value other than -1. ScopedFD crashes when close() fails. This CL adds a check that the result of ashmem_create_region() is non-negative before wrapping it into a ScopedFD. This CL also adds a check that the rounding operation doesn't overflow which was the reason of the failure in the first place. Bug: 1022582 Change-Id: Id2dcec613e87c8eda97bf18cbd70f13b105b1e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913239 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#714884}
-
Mike West authored
[1] shows that `SitePerProcessBrowserTest.OOPIFDetachDuringAnimation` is somewhat flaky in general, and it just flaked twice in a row this morning on `linux-chromeos-rel`: [2], [3] [1]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXQsSBUZsYWtlIlJjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BTaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0Lk9PUElGRGV0YWNoRHVyaW5nQW5pbWF0aW9uDA&show_all_occurrences=1 [2]: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/31228 [3]: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/31229 TBR=kenrb@chromium.org Bug: 809580 Change-Id: I866bfc20a69e706aee34addd32a5e8e8fc40792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912710Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714883}
-
Mikel Astiz authored
Tests often have indirect dependencies to code that requires a FieldTrialList instantiated. To work that around, many existing tests manually instantiate a FieldTrialList, but this is cumbersome, distracting and hard to clean up once it no longer is necessary. Instead, this patch adopts base::test::ScopedFeatureList as part of the test suite for all tests. Follow-up patches will simplify tests. Bug: 1018667 Change-Id: I15b1f1097357f0fc3a30d4ac337d77b1ef607098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883567 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714882}
-
Mike West authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EnrollmentRecoveryTest.DifferentDomain shows a pretty unhappy story for `EnrollmentRecoveryTest.DifferentDomain` on linux-chromeos-dbg in both `browser_tests` and `non_viz_browser_tests`. TBR=antrim@chromium.org Bug: 1024176 Change-Id: I92a8605359f6db3e22d9733aa8d2ec263d685e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912709 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
Andreas Haas authored
This is a first step of getting rid of blink::ArrayBuffer. blink::ArrayBuffer serves two purposes by now: 1) Managing a list of ArrayBufferViews; 2) Managing the detached flag; With this CL I encapsulate the list of ArrayBufferViews. In follow-up CLs I then want to pass the list and an ArrayBufferContents object to the ArrayBufferView instead of the ArrayBuffer object. This will bring us one step closer to removing blink::ArrayBuffer. Update: ArrayBuffer seems to be very involved. It is the connecting data structure between DOMArrayBuffer, ArrayBufferContents, and ArrayBufferView. Even though it is not used anymore outside these classes, it is not obvious if we can replace it within these classes. I still think that refactoring the organization of views here is good. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I533f5496b7c51312e77a0138ac8249f9f0e55ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911207Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#714880}
-
Ioana Pandele authored
This change adds a pref that is set to true when the first eligibility check passes and is not reset on subsequent checks. This helps ensure that the feature is checked for all past and present eligible cases. Bug: 1021033 Change-Id: Ie0f48e07ed5e28b8ee6fec0400d7d5fac41f1a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893204 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#714879}
-
Marc Treib authored
Before this CL, when we failed to extract a topic name from the response to a per-user-topic subscription request, we'd record *both* kSuccess and kParsingFailure in the FCMInvalidations.SubscriptionRequestStatus histogram. This CL fixes this by recording kSuccess only on actual success. This probably makes little or no difference in practice, but let's be consistent. Bug: 1023813 Change-Id: I16ea38e4df5783455450e250ee0fd732ed0aa4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911751Reviewed-by:
-
Vasilii Sukhanov authored
The class uses interprocess communication and doesn't have to survive the parsing result. Bug: 1023606 Change-Id: I3828b9da3395eee73fd371450349bd062647642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911793Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714877}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12e54dae167c..ab3cdcaef56e git log 12e54dae167c..ab3cdcaef56e --date=short --no-merges --format='%ad %ae %s' 2019-11-12 alanbaker@google.com Fix operand access of composite in upgrade memory model (#3021) 2019-11-12 alanbaker@google.com Validate array stride does not cause overlap (#3028) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ab3cdcaef56e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I354bef01a53322746c84e099ea1299d209f74ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913991Reviewed-by:
-
Mike West authored
The following tests pretty consistently fail on linux-chromeos-dbg: BrowserNavigatorTest.CloseSingletonTab BrowserNavigatorTest.NavigateFromBlankToOptionsInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsPageInSameTab https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15245 is a recent example run. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserNavigatorTest.NavigateFrom is a broader view. TBR=ellyjones@chromium.org Bug: 1024166 Change-Id: Ia05dc43c8948fb0ba26615f3f9f5c791705d876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912707Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f023f565a61..9ec5c78a9256 git log 4f023f565a61..9ec5c78a9256 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 9da287fd0264..88632cac30e1 (6 commits) Created with: gclient setdep -r src/third_party/angle@9ec5c78a9256 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I1bb5f12e2a9f93e2b3f80cc2dcfe8fe1ab0bf7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913989Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15f6f95cdc3e..c062acf6a20a git log 15f6f95cdc3e..c062acf6a20a --date=short --no-merges --format='%ad %ae %s' 2019-11-13 vapier@chromium.org dev_server_wrapper: get unittests passing under python 3 2019-11-13 kdgwill@google.com licensing: remove sys-apps/escalator 2019-11-13 vapier@chromium.org cros lint: use --ignore-patterns to filter protobuf files Created with: gclient setdep -r src/third_party/chromite@c062acf6a20a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie2c532c4158c05099da28f1bb1ce816f397c2267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913990Reviewed-by:
-
A Olsen authored
JS tests don't work on ASAN, which is a known bug: https://crbug.com/1010561 Use the existing "include_js_tests" flag to exclude password_change_authenticator_test as it is intended, instead of an ad-hoc solution. Reland: Last time I moved the wrong target into the include_js_tests block, so it didn't work. Bug: 1022385 Change-Id: I9eac120f3abef3c7b6856804f3894d2a2742f92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910220Reviewed-by:
A Olsen <olsen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Mike West authored
It looks like https://chromium-review.googlesource.com/c/chromium/src/+/1895922 causes consistent failures in `ShelfLayoutManagerWindowDraggingTest.NoOpForHiddenShelf` with the following stack: ``` Received signal 11 <unknown> 000000000000 r8: 00002040963d13a8 r9: 00007ffdd58dcf50 r10: 0000000000000000 r11: 00007f6d6e486f90 r12: 000055ac8516d870 r13: 00007ffdd58e0a70 r14: 0000000000000000 r15: 0000000000000000 di: 00002040982e9db8 si: cdcdcdcdcdcdcded bp: 00007ffdd58dd5a0 bx: 0000000000000000 dx: 00007ffdd58dd800 ax: cdcdcdcdcdcdcded cx: cdcdcdcdcdcdcded sp: 00007ffdd58dd5a0 ip: 00007f6d818945a4 efl: 0000000000010286 cgf: 002b000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 ``` (See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896938459425026880/+/steps/ash_unittests/0/logs/Deterministic_failure:_ShelfLayoutManagerWindowDraggingTest.NoOpForHiddenShelf__status_CRASH_/0) TBR=newcomer@chromium.org Bug: 1024163 Change-Id: I83d55f2c1cfadcd1752b2be91d0c3d1dde1278b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913402Reviewed-by:
-
Mike West authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MediaEngagementPrerenderBrowserTest.Ignored shows a sad story for `MediaEngagementPrerenderBrowserTest.Ignored` on `win-asan`. https://ci.chromium.org/p/chromium/builders/ci/win-asan/8440 is a recent build in which it failed. TBR=mlamouri@chromium.org Bug: 1024158 Change-Id: I0a769262b2d513d0e7a6ea965c914c791da96061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913247Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/604072bc2ed0..cfdbaaa37664 git log 604072bc2ed0..cfdbaaa37664 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 jiawei.shao@intel.com Implement querying WGPUDeviceProperties from dawn_native::Adapter Created with: gclient setdep -r src/third_party/dawn@cfdbaaa37664 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:996713 Change-Id: If0dabcd9db0aba62b0d5095a7098b0e70561ef28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912636Reviewed-by:
-
Alex Keng authored
This change updates the rendering of range/meter/checkbox so their border widths are 1px regardless of the zoom level (same behavior progress and radio currently have) To prevent the borders from growing on zoom, the ThemePainterDefault are updated for checkbox and range so the painting context is not modified when zoom level is not 1. The zoom info are then embedded in ButtonExtraParams and SliderExtraParams and passed to NativeThemeAura so PaintCheckbox can render border-radius correctly and PaintSliderTrack can render track height correctly. For meter the border-width is changed from 1px on thin. Tests: meter: meter-extreme-values.html range: range-appearance-basic.html checkbox: checkbox-appearance-basic.html Bug: 1021319 Change-Id: Icee5d83a859556909bdf930c314d70ddd17d7784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910864 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Mike West authored
The test has flaked thrice this morning on Win10, and looks flaky generally: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Ftracing%2Ftimeline-style%2Ftimeline-style-recalc-all-invalidator-types.js TBR=bmeurer@chromium.org Bug: 1024151 Change-Id: I4b5e37604bd0aaf5d6fce253ceee9d22dd44c7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912703Reviewed-by:
-
Saurabh Nijhara authored
Updated API in update_required_screen to fetch the Eol status of the device. GetEolStatus has been deprecated and hence, now using GetEolInfo. Also, added a browser test for the same. Bug: 1020616 Change-Id: I3e5ba906fb9c2fa88e75536b4a1017ae2f7bee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910085 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714866}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e94ac7ab5553..89ab0576bf88 git log e94ac7ab5553..89ab0576bf88 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e33c1582b4bc..4f023f565a61 (4 commits) Created with: gclient setdep -r src/third_party/skia@89ab0576bf88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None Change-Id: I4c1c91f99339f5865a9f9c6fd67662ca1388031e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914037Reviewed-by:
-
Rahul Arakeri authored
Mac uses Option + click instead of Shift + click (on Windows/Linux). Bug: 1016955 Change-Id: I49c54fb8773c68d37d4bc0b7fc677f259767967b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885975 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714864}
-
Mike West authored
See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/6852 is a recent build in which it fails with: ``` ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,19],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) ``` TBR=snianu@microsoft.com Bug: 1024161 Change-Id: Ifa8923ce4e71d3fb097e788f9f1ce613d2ce98da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912705 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/362f46250e2d..33ddd5f9c3ce git log 362f46250e2d..33ddd5f9c3ce --date=short --no-merges --format='%ad %ae %s' 2019-11-13 skyostil@google.com Merge "TrackEvent: Add support for instant events" Created with: gclient setdep -r src/third_party/perfetto@33ddd5f9c3ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6cf8b9ef2bef07df434b9a529a46e497293854ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914159Reviewed-by:
-
Kent Tamura authored
* Rename FindActualFocusTarget() to GetFocusableArea() to match to the specification. * FlushAutofocusCandidates() applies GetFocusableArea() instead of focusing delegatesFocus hosts unconditionally. Bug: 1024056 Change-Id: I954e306d9fec20bbe26b46060aefa0d9925ad14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913222 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#714861}
-
Kuo Jen Wei authored
Bug: b/117810572 Test: Pass presubmit check. Pass tast run <DUT> 'camera.CCAUI*' Change-Id: I7ad44a0d3d78ddd2c4f0d052d0bb6402e2406d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886270Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714860}
-
Stefan Zager authored
The methods MapToVisualRectInTopFrameSpace and ApplyTransformForTopFrameSpace in LocalFrameView give the impression that they are mapping into the coordinate system of the main frame, but that is not the case. In fact, an OOPIF has never before known its position WRT its parent or the main frame. Fortunately, up to now nothing has relied on having coordinates mapped to the space of a remote main frame. This patch plumbs to each render process the offset of the local frame root from the main frame's viewport, so that it's possible to map to the coordinate space of the main frame. This capability is required for upcoming features. It also renames those two methods in LocalFrameView, to be more explicit about what they do: s/MapToVisualRectInTopFrameSpace/MapToVisualRectInRemoteRootFrame/ s/ApplyTransformForTopFrameSpace/MapLocalToRemoteRootFrame/ Change-Id: I3e6e3fc0f7c8edd78e2a30dd9051b8d03b3d8a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899386 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714859}
-
Mike West authored
This reverts commit 06b27c6f. Reason for revert: This consistently fails under MSan with: ``` [ RUN ] StackTraceTest.OutputToStream ../../base/debug/stack_trace_unittest.cc:82: Failure Value of: backtrace_message.find("testing::Test::Run") != std::string::npos Actual: false Expected: true Expected a demangled symbol in backtrace: #0 0x5608768c4adb in backtrace /b/swarming/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4101:13 #1 0x56087a80709b in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x56087a45d4da in StackTrace ./../../base/debug/stack_trace.cc:206:12 #3 0x56087a45d4da in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #4 0x5608770e0c0f in base::debug::StackTraceTest_OutputToStream_Test::TestBody() ./../../base/debug/stack_trace_unittest.cc:39:14 #5 0x56087a2470c5 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x56087a2470c5 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2508:5 #7 0x56087a24abde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:11 #8 0x56087a24c81a in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28 #9 0x56087a28aa4a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5338:44 #10 0x56087a288cae in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x56087a288cae in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4925:10 #12 0x56087a9047a5 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2473:46 #13 0x56087a9047a5 in base::TestSuite::Run() ./../../base/test/test_suite.cc:394:16 #14 0x56087a98ce2a in Run ./../../base/callback.h:98:12 #15 0x56087a98ce2a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:158:38 #16 0x56087a98c8bf in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:228:10 #17 0x56087a8b39a0 in main ./../../base/test/run_all_base_unittests.cc:12:10 #18 0x7f4d99e7d830 in __libc_start_main ??:0:0 #19 0x56087688a67a in _start ??:0:0 Stack trace: #0 0x56087a45d4da in StackTrace ./../../base/debug/stack_trace.cc:206:12 #1 0x56087a45d4da in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #2 0x56087a1f22de in StackTraceGetter::CurrentStackTrace(int, int) ./../../third_party/googletest/custom/gtest/internal/custom/stack_trace_getter.cc:22:27 #3 0x56087a226149 in testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) ./../../third_party/googletest/src/googletest/src/gtest.cc:820:35 ``` (see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896945774609420288/+/steps/base_unittests/0/logs/Deterministic_failure:_StackTraceTest.OutputToStream__status_FAILURE_/0) Original change's description: > Reland "[base] Cleanup StackTraceTest.OutputToStream #ifdef soup." > > This was most recently reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1906545 > due to failures on some ChromeOS platforms, which lack the necessary > tables to allow stack-trace unwinding. > > Bug: 999737, 706728 > Change-Id: I7889416cd2ae9b6a09caf9eebb68a5ccf8bf4ca3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911680 > Auto-Submit: Wez <wez@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714735} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I94bb1c35c8a8b205b72f4a7705996276453f9c2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999737, 706728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912704Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6bfc3bbb7a58..15f6f95cdc3e git log 6bfc3bbb7a58..15f6f95cdc3e --date=short --no-merges --format='%ad %ae %s' 2019-11-13 vapier@chromium.org paygen: add some debug logic around storelog Created with: gclient setdep -r src/third_party/chromite@15f6f95cdc3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib69fb25b3037a5f9e66873776d3881b5604738d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913590Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::EmbeddedSearchClient using AssociatedReceiver, AssociatedRemote, and PendingAssociatedRemote. Bug: 955171 Change-Id: I1fe1d2cf2fda69ebc8f88f49771171741754b457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897399Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714856}
-
