- 02 Oct, 2018 14 commits
-
-
chrome://safe-browsingDaniel Rubery authored
Change-Id: Iade20c998ceed292eb16595ef23ae30d3bf03202 Reviewed-on: https://chromium-review.googlesource.com/1256013Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595663}
-
Xiaohan Wang authored
Now Widevine support is controlled by "enable_widevine" gn arg and this header is not used on Android at all. These were missed from previous CLs. Bug: 349182 Test: No functionality change. Change-Id: I651ec23a394d566c78a6c43e6cc9e06ff18d17fc Reviewed-on: https://chromium-review.googlesource.com/1256005 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595662}
-
Zhenyao Mo authored
The previous code is hardwired to youtube site. Now it's more generic, although it still doesn't work anywhere. BUG=867155 TEST=manual R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ief21731f484bbe2d0b2500483d304abdd27511de Reviewed-on: https://chromium-review.googlesource.com/1242453 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595661}
-
John Rummell authored
(Also updates one ffmpeg_regression_tests that now works properly.) https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/bbe6b81a6c31..458e9fd3f8e8 $ git log bbe6b81a6..458e9fd3f --date=short --no-merges --format='%ad %ae %s' 2018-10-01 liberato Don't rebuild ffmpeg configs / patches / etc. if already committed. 2018-09-28 jrummell Improve handling of .gclient file in script 2018-10-01 liberato Run handy regex to summarize gn file differences. 2018-09-28 liberato Push merge commit and set tracking branch. 2018-09-28 jrummell Chromium patches file 2018-09-28 jrummell GN Configuration 2018-09-14 michael avcodec/diracdec: check that GetBitContext has not ended in codeblock() 2018-09-14 michael avcodec/diracdec: Propagate errors from codeblock() 2018-09-12 michael avcodec/bintext: Use ff_get_buffer instead of ff_reget_buffer and simplify 2018-09-12 michael avcodec/bintext: Check input size before allocating the input image (...) Created with: roll-dep src/third_party/ffmpeg BUG=890005 Change-Id: I62781916144e5f9b919e985a0a182efb2e7eb159 Reviewed-on: https://chromium-review.googlesource.com/1255887Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595660}
-
Malay Keshav authored
This patch changes the accessor name from sk_bitmap() to GetBitmap. This is done to prepare for the addition of Paint records which will require a non inline function. Bug: 882507 Change-Id: I3e05ec775d8978461b7e68e585a5eb9d8e2fbb16 Component: ImageSkiaRep, Bitmap, ui Reviewed-on: https://chromium-review.googlesource.com/1255901Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#595659}
-
Wez authored
Change-Id: I3e7af0dcb90af2d8f8fe325291a9c31c1cfccd36 Reviewed-on: https://chromium-review.googlesource.com/1256202 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595658}
-
Bill Orr authored
Currently VR APIs on desktop are hosted in an unsandboxed process when enabled. After this change, VR Apis may be hosted in an AppContainer low-integrity process when a flag is enabled. This allows debugging sandbox issues before enabling VR by default. BUG=795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie16dd86cfa23171b0025359cd7e2d4db7997a9e7 Reviewed-on: https://chromium-review.googlesource.com/1162763Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595657}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ef78eae9311..a7a52b9de36c git log 8ef78eae9311..a7a52b9de36c --date=short --no-merges --format='%ad %ae %s' 2018-10-01 stani@google.com Fix error at run time to load skottie_android.so 2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 810f3db8264a..f1d777c71f03 (1 commits) 2018-10-01 herb@google.com Move remote glyph cache DFT handling to painter Created with: gclient setdep -r src/third_party/skia@a7a52b9de36c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I7913e9fab90ef5484670cb40d2e360bdfcbe67cb Reviewed-on: https://chromium-review.googlesource.com/1255511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b448050d611..2a44a65dc4a9 Created with: gclient setdep -r src-internal@2a44a65dc4a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I850898e28b36553e9a4f625f5a6117517c724fad Reviewed-on: https://chromium-review.googlesource.com/1255566Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595655}
-
Chris Palmer authored
It is breaking macOS GPU tests. Bug: 890752 TBR: ajwong Change-Id: I3f686473483cab053fc43e3d4b719a2900bdd71b Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1255592Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595654}
-
Andrey Kosyakov authored
Originally regressed by https://chromium-review.googlesource.com/c/chromium/src/+/876657 Bug: 878524 Change-Id: I3526eea2063a795b6f9049008cc564ca65c1ba04 Reviewed-on: https://chromium-review.googlesource.com/1255606Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595653}
-
Amos Lim authored
Add DocumentAndElementEventHandlers as per the spec[1] and remove oncopy, oncut, and onpaste from Document and Element. [1]: https://w3c.github.io/html/single-page.html#documentandelementeventhandlers Make Document, HTMLElement, and SVGElement include DocumentAndElementEventHandlers. Bug: 835570 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie81d7995dbe0824ad3a66ccbfabcdbe5e3864fa4 Reviewed-on: https://chromium-review.googlesource.com/1253169Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#595652}
-
Marcin Wiacek authored
According to various sources lambdas can provide profits in some scenarios. According to the https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Lambdas-and-Method-References lambdas are allowed also in Chrome, patch is migrating AnimatorUpdateListener usage to them. BUG=889613 Change-Id: I7d4af5f34e83abe03bd998359e4c0b3cc149e3f0 Reviewed-on: https://chromium-review.googlesource.com/1244440 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595651}
-
Thomas Anderson authored
This reverts commit a8d13c1d. Reason for revert: Suspected causing build failure on win32-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/3631 Original change's description: > Headless: remove devtools protocol network handler > > Network conditions management is now done in content, so support for > this in headless is redundant. > > Change-Id: I559de2c65e659c026b7e8e9d9021340e6271af92 > Reviewed-on: https://chromium-review.googlesource.com/1255610 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595637} TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org Change-Id: I0601d25a065e06cff731df50e1dae614ee194dc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1256166Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595650}
-
- 01 Oct, 2018 26 commits
-
-
David Tseng authored
Bug: 888152 Change-Id: I5584ab2c808b26f7363d214bedae38d080ba9735 Reviewed-on: https://chromium-review.googlesource.com/1246168 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595649}
-
Tatiana Buldina authored
Bug: chromedriver:2079 Change-Id: I5395a899686cb8b5f4d2a48f8ea6d7cfa9939e51 Reviewed-on: https://chromium-review.googlesource.com/1256109Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595648}
-
Kevin Marshall authored
content::NavigationEntry contains more useful data about the page load state compared to |validated_url|, which obscures the URLs that caused page load errors. Add an |is_error| field to indicate if an error occurred during navigation. BUG=890533 Change-Id: If7407cec236ddd5b1474f52ac2538b3a3657a366 Reviewed-on: https://chromium-review.googlesource.com/1252637 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595647}
-
Sophie Chang authored
Bug: 889621 Change-Id: Ibb038ec8ea75a75129dd9ccbfb20c86da750a901 Reviewed-on: https://chromium-review.googlesource.com/1255262Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595646}
-
Bailey Berro authored
- Marks username and password as optional in the add share dialog. Bug: chromium:891020 Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb Reviewed-on: https://chromium-review.googlesource.com/1255900Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#595645}
-
Jinho Bang authored
In the current implementation, memory leaks occur becuase the internal view_stack_ for payment sheet grows incrementally whenver calling retry(). So, this patch uses GoBackToPaymentSheet() instead of ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to reduce stack's size internally. Bug: 861704 Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc Reviewed-on: https://chromium-review.googlesource.com/1255082Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595644}
-
chrome://flagsMoe Ahmadi authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7303af44d7ada834b3d22e1cfdf5245976d7defc Reviewed-on: https://chromium-review.googlesource.com/1249910 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595643}
-
Nate Fischer authored
This implements the Quiet Billing interstitial and adds the approved strings from http://crbug.com/887186 and adds the interstitial to the debug WebUI page (chrome://interstitials). WebView support will come in a follow-up CL. Bug: 887186 Test: browser_tests --gtest_filter=InterstitialUITest.BillingInterstitialQuiet Test: Manual - observe chrome://interstitials page Change-Id: I4ff9811d925bdde81bf1349ac714c2533ad563bb Reviewed-on: https://chromium-review.googlesource.com/1256021Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595642}
-
Matt Menke authored
A recent change (https://chromium-review.googlesource.com/1161479) accidentally resulted in treating 304 responses as downloads. This CL treats them as ERR_ABORTED instead. This doesn't exactly match old behavior, which passed them on to the renderer, which then aborted them. The new code results in correctly restoring the original URL in the omnibox, and has a shiny new test to prevent future regressions. Bug: 882270 Change-Id: Ic73dcce9e9596d43327b13acde03b4ed9bd0c82e Reviewed-on: https://chromium-review.googlesource.com/1252684 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595641}
-
David Black authored
Already we are handling interactions that end in error if they contain TTS. As it turns out, these interactions do not always include TTS so we need to handle this case as well to show a message to the user. Bug: b:116786185 Change-Id: Ic1b281c5d84f4cc2d955e01e31ffe3218cc82503 Reviewed-on: https://chromium-review.googlesource.com/1249077 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595640}
-
Thomas Tangl authored
Record user action for signout button in user menu when the user is signed into Chrome (not syncing) and Dice is enabled. Bug: 891070 Change-Id: I3990093b7a59d047eff3ad07310c5c686c90e3ea Reviewed-on: https://chromium-review.googlesource.com/1255626Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#595639}
-
Gabriel Marin authored
Original CL: - https://codereview.chromium.org/11823061 GTTF: cherry-pick memalign/realloc mismatch debug code Especially ffmpeg may be prone to errors in this area. Googlers: see b/1397952 for reference. BUG=30715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177171 BUG=724399,b:70905156 Change-Id: Iac78c1c49014a0454eacb651f549001e76c0cf93 Reviewed-on: https://chromium-review.googlesource.com/1130799Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#595638}
-
Andrey Kosyakov authored
Network conditions management is now done in content, so support for this in headless is redundant. Change-Id: I559de2c65e659c026b7e8e9d9021340e6271af92 Reviewed-on: https://chromium-review.googlesource.com/1255610Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595637}
-
Marijn Kruisselbrink authored
Bug: 714018 Change-Id: I02bc49853ff630a0422ba0ddc8f08b7412046327 Reviewed-on: https://chromium-review.googlesource.com/1255148Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#595636}
-
Lukasz Anforowicz authored
We've decided to not ship this feature and focus on other isolation modes instead. Bug: 884842 Change-Id: I5895e12f4c80fa22e9fef8ea7045a1bb6a7913bb Reviewed-on: https://chromium-review.googlesource.com/1228944Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595635}
-
Scott Violet authored
During the conversion to ws2 a handful of aura unittests got an early out. This adds comments as to why these tests fail with MUS, and updates one to work with MUS. For the ones I didn't update I didn't feel fixing the test was worth it, given we get coverage in the LOCAL case. BUG=866502 TEST=test only changes Change-Id: If6d1d0bd50c79b727fd9f38c3662312a76ca7d53 Reviewed-on: https://chromium-review.googlesource.com/1256011 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#595634}
-
David Black authored
Previously a voice interaction was only started if in tablet mode. Now, we'll also factor in user preference to start a voice interaction on Assistant entry. This CL is reliant on and cannot be submitted before: https://chromium-review.googlesource.com/c/chromium/src/+/1244441 Bug: b:115843337 Change-Id: Ia50b992843e542027e26faa2b522f3d4d48aa58e Reviewed-on: https://chromium-review.googlesource.com/1252631 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595633}
-
Xiaohan Wang authored
The word "should" here is odd to read in some context. For example, in tests, when we "should bundle widevine CDM", we run tests that requires the CDM. This CL simply drops the word "should" so the gn/build flag becomes "bundle_widevine_cdm", which is more definitive. This CL also refactors widevine.gni to better support common variations. Bug: 349182,843649 Test: No functionality change. Rename only. Change-Id: Iaa8c6c29a33409bb1b31be86cb6202ff3f4b7cd9 Reviewed-on: https://chromium-review.googlesource.com/1249736 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595632}
-
Bence Béky authored
StrCat is 2-4x faster, so use that instead of Printf/Appendf. This CL lands server changes 211484351 by dzetkulic and 215218657 by bnc. BUG=488484 Change-Id: I5b6cab6db94c1cb5f75106832d45858a92924875 Reviewed-on: https://chromium-review.googlesource.com/1252161 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595631}
-
Thomas Tangl authored
The Clear Browsing Data dialog is updated: - A footer is added to display the sync account information. - The string descriptions for the data items depend on the sync state. - Information on how to resolve sync errors is added. Screenshots: https://drive.google.com/drive/folders/1AFV0ttCuS5g4IEOypktqeH3MGk8d_ac1?usp=sharing Bug: 889137 Change-Id: Ie79e9ff4bb68ec3f0a9b5a0231aaee707875618c Reviewed-on: https://chromium-review.googlesource.com/1251627 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595630}
-
Yuichiro Hanada authored
According to the reference doc of InputConnection.commitText(), we should clear the current composition text when commitText() is called instead of commiting the current composition text. Bug: 845079 Test: Typing text wiht Google Japanse Input app and it works well. Change-Id: Ie2d9cd73d64f5728dc82f3f441d73af7a2740836 Reviewed-on: https://chromium-review.googlesource.com/1252226 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595629}
-
Mike Wasserman authored
PointerWatcher is no longer needed with Ash hosting the Window Service. Add StylusEventHandler to notify PaletteTray on stylus events. Fix odd logic for showing the bubble; remove event handler when done. Convert PaletteWelcomeBubble to EventHandler and simplify show/close. Update tests and perform some minor cleanup. Bug: 872450 Test: No (bad) behavior changes in palette tray / stylus welcome bubble. Change-Id: If8d6da88d6a70979978f227f10ebb8357fb0d34e Reviewed-on: https://chromium-review.googlesource.com/1252910 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#595628}
-
Mike Reed authored
Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd Reviewed-on: https://chromium-review.googlesource.com/1254341 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#595627}
-
Jun Choi authored
Currently, the only identifier for showing Bluetooth authenticators on WebAuthN UI modals is the authenticator ID which represents the MAC id of the device. As this is not user friendly, add human-readable authenticator_display_name to AuthenticatorReference. Bug: 877344 Change-Id: I2d3b35db669d8f8f61e9989870122a211d80e80f Reviewed-on: https://chromium-review.googlesource.com/1247681 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595626}
-
Kevin Marshall authored
This reverts commit af3f31af. Reason for revert: Breaks Android buildbot runs with errors like: ```../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/IncognitoToggleTabLayout.java:18: error: cannot find symbol import org.chromium.chrome.browser.widget.TintedImageView;``` Full run here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933828868736954944/+/steps/compile__with_patch_/0/stdout Original change's description: > [Android] Replace TintedImageView and TintedImageButton > > This CL replaces Chrome-specific tinting view classes with their > AppCompat equivalents: TintedImageView -> AppCompatImageView and > TintedImageButton -> AppCompatImageButton. > 1. Entries in XML layouts have fully qualified names because some > layouts are inflated outside AppCompatActivity, so AppCompat magic > doesn't work for them. > 2. AppCompatImageView doesn't have setTint, so > ImageViewCompat.setImageTintList is used instead. > 3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint', > so these are replaced, too. > > Bug: 727723 > Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1 > Reviewed-on: https://chromium-review.googlesource.com/1245786 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595500} TBR=tedchoc@chromium.org,twellington@chromium.org,bsazonov@chromium.org,huayinz@chromium.org Change-Id: I83efa81fce074f24f330281460b2685f1765f0e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 727723 Reviewed-on: https://chromium-review.googlesource.com/1255456Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595625}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I353b0b183df8242b9a799face70be560f186e56c Reviewed-on: https://chromium-review.googlesource.com/1252386Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595624}
-