- 29 Jan, 2020 40 commits
-
-
matterchen authored
Port forwarding in Cros will allow users to add, activate, remove and deactivate ports. This CL includes the implementation of the remove and deactivate port utilities and unit tests. The tracking of the port forwarding preferences in the user's profile preferences has not been implemented yet. Bug: chromium:848127 Test: crostini_port_forwarder_unittest.cc and everything builds Change-Id: Ie7b5358813ca9cf454e0e216467c6d1ec8344c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015868Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#736249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e5460f07009..4d88bb065eda Created with: gclient setdep -r src-internal@4d88bb065eda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ieb5736b217a87dfe0da5b2b07e7049e98d955277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027001Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736248}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74f5054ec925..7b6246a2ade8 git log 74f5054ec925..7b6246a2ade8 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 kainino@chromium.org Generators for Emscripten Created with: gclient setdep -r src/third_party/dawn@7b6246a2ade8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I29bd31538c448acd6565a5763348569bf8b227d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736247}
-
Rachel Sugrono authored
Add subroutines to compose the Delete command handler, so the it is easy for some special clients to access these subroutines, e.g. the QuickView dialog. Add an optional dialog argument to the deleteEntries_() subroutine. The default argument is null which shows the default delete confirm dialog, so no change in behavior. For Quick View, the delete confirm dialog is provided by Quick View when calling this helper. No change in behavior, no new tests. Bug: 803259 Change-Id: I4b2fe2d7cfd35a3c602bf7aa0b869b11a51bb691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026827Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736246}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e0a0cb9ad54..1fbc1b7f92be git log 2e0a0cb9ad54..1fbc1b7f92be --date=short --first-parent --format='%ad %ae %s' 2020-01-29 fancl@chromium.org Fix sheriff-config tests Created with: gclient setdep -r src/third_party/catapult@1fbc1b7f92be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Icce5d3cfad3bc69c4e81915b3acec850122f4034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736245}
-
Luciano Pacheco authored
Set white background in the top level container and forces directory tree and file list to inherit it. Bug: 992821,992819 Change-Id: I610ec28fe06a092ada41ad268a18f3495d46b8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026552 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736244}
-
Kyle Horimoto authored
This CL adds the ability to sync in transport mode via SyncableServiceBasedModelTypeController. A follow-up CL converts SupervisedUserSyncModelTypeController to use transport mode. Bug: 1030454, 1043755 Change-Id: I6a49de5d8d5dd9c24422456fbdbc56683e64c002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016195 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736243}
-
Abhijeet Kandalkar authored
This CL uses new downcast helpers for classes, - SVGInlineFlowBox - SVGRootInlineBox Bug: 891908 Change-Id: Ia211ffb55e77e299c333a8bfd2ed19c053d0536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024987Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#736242}
-
Julie Jeongeun Kim authored
This CL changes ViewHostMsg_DocumentAvailableInMainFrame so that it is implemented in the LocalFrameHost interface and it moves DocumentAvailableInMainFrame() from RenderViewHostDelegate to RenderFrameHostDelegate. Bug: 1043758 Change-Id: I23d727cb39bf98b2b7412b92dc04d139fef3fa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016762Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#736241}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a8fa19f0574..44c75073811b git log 4a8fa19f0574..44c75073811b --date=short --first-parent --format='%ad %ae %s' 2020-01-29 spang@chromium.org Fuchsia: Disable GLES3 testing on Fuchsia ARM 2020-01-29 syoussefi@chromium.org Vulkan: Fix handling of inactive fragment outputs 2020-01-29 spang@chromium.org Vulkan: Disable global merge for volk 2020-01-28 spang@chromium.org Fuchsia: Implement SystemInfo on Fuchsia 2020-01-28 ynovikov@chromium.org Disable 'nodiscard' warning on MSVC for dEQP. Created with: gclient setdep -r src/third_party/angle@44c75073811b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ie5e52fa26115c791aec39c2740dc72bc71a20da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736240}
-
Khushal authored
If an image is greater than max texture size it can not be uploaded to the GPU and we keep a copy on the CPU instead for rasterization. While for GPU backed images adding mips requires re-allocating a new mipped texture, for these images it should be a no-op since its handled by skia internally. The existing code was erroneously trying to upload them. R=cblume@chromium.org Bug: 1046414 Change-Id: If88f76578dae99470991f7e4fb136107b94e23a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026227 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#736239}
-
Khushal authored
All workarounds have been removed, this removes the setup for applying these workarounds. This is the first step towards being able to assume SurfaceControl is turned on for all Q devices which will allow doing setup at app startup, before the native library is loaded and the GPU process is initialized. R=ericrk@chromium.org, vikassoni@chromium.org Bug: 1031636 Change-Id: Iecdfc335076089ba7887ba0d5111d4f70cf81c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015553 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736238}
-
Yutaka Hirano authored
Have Resource::CanReuse return false when the request method is not GET. This is harmless because currently all the preload requests and requests that can be served from the MemoryCache are GET requests, given that RawResources are not served from the MemoryCache. This change will allow us not to store the request body in Resource, which will be important when we introduce streaming upload because we do not want to copy a streaming request body. Bug: 688906 Change-Id: I5b1b01a6f003378f0ac33f528d209c610178fa29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024627Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736237}
-
Hitoshi Yoshida authored
- Changes Create() and FillMember() argument types from v8::Object to v8::Value - Refactor make_fill_dict_members_def() - Replace v8_value->IsUndefinedOrNull() with v8_value->IsNullOrUndefined() Bug: 839389 Change-Id: Id2776176ae49e033c57bd0241981b60a1f2c0e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026908 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736236}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad9110026bee..dcc8c5431bcb git log ad9110026bee..dcc8c5431bcb --date=short --first-parent --format='%ad %ae %s' 2020-01-29 csmartdalton@google.com Convert the "bool antialias" param in GrTessellator to an enum 2020-01-29 egdaniel@google.com Store GrSurfaceProxyViews on SkSpecial*_Gpu. Created with: gclient setdep -r src/third_party/skia@dcc8c5431bcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ie3d186f938c5c91b0bbc899b4850076c4055e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026996Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736235}
-
Hitoshi Yoshida authored
It is called from derived classes' FillMembersInternal. Bug: 839389 Change-Id: Icc214c548d8f02da13a594369c015043d4118593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026630Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#736234}
-
Jie Jiang authored
This change implements SendCachedDevices(), which should be called after Bluetooth service in Android starts, to make device cache synced between Chrome and Android. Here "cache devices" means devices that have been discovered (not necessarily paired or connected) but not yet expired. Some Android apps depend on this device cache, e.g., get info of paired devices. BUG=b:147401863 BUG=chromium:949918 TEST=Manually test with nRF: paired device can be seen in "BONDED" tab after reboot or restart Bluetooth. Change-Id: I80a813706770e9505b6b1db7a502739723e71f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000398 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736233}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8692a1901e0..1e5460f07009 Created with: gclient setdep -r src-internal@1e5460f07009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034774,chromium:1044793 Tbr: jbudorick@google.com Change-Id: I76557832a9e4c4b21a39e5b3ff535b680fa02dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026998Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736232}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad90d3c6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6cb70f31f7ed9b10d54402ce47cf35254399ee54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736231}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/821d564bc789..873d0470b40d git log 821d564bc789..873d0470b40d --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kainino1@gmail.com Make a source_set for libshaderc_spvc (#976) Created with: gclient setdep -r src/third_party/shaderc/src@873d0470b40d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I2eb8ab67eacae0f4fa2e76ea9f6c42e3e218e48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736230}
-
Eriko Kurimoto authored
This CL adds upgrade-indecure-requests web-platform-tests for module shared workers "sharedworker-module" is added to spec.src.json and it auto-generates tests. Bug: 824646 Change-Id: I3d75f4b7b1af93c12548331ad46e5f812205ea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024249Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#736229}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b6bf0b2546f3..5d3173be305d git log b6bf0b2546f3..5d3173be305d --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5146474c..fa85f826 (735951:736081) Created with: gclient setdep -r src/third_party/webrtc@5d3173be305d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ef6f8a4feef338fd1764ebb6ef65f17d140316c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736228}
-
Darren Shen authored
Extending by 3mths since we haven't launched the feature yet. Bug: 1043719 Change-Id: I28153a747b57918b73b13e4197fc7684beeaccd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023708 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#736227}
-
Alex Cooper authored
There are currently two separate implementations of the same code. Upcoming refactors to split the installation and consent flow logic from each other will make three implementations. Create a utils file so that the Android runtimes can share the implementation of this method. Fixed: 1046593 Change-Id: I55a20229f0150aea2f27df333245d31094cbee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026651 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#736226}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I32c2947ce269b9bf83057cfe152b3794154b7147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026471Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736225}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e5e522c140a2..94294b48c239 git log e5e522c140a2..94294b48c239 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 tsepez@chromium.org Avoid including string_view_template.h directly. 2020-01-28 tsepez@chromium.org Remove CPDF_Dest::GetRemoteName(). 2020-01-28 thestig@chromium.org Change various CMap code to take a ByteStringView. Created with: gclient setdep -r src/third_party/pdfium@94294b48c239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3fdcbab40660e9deb754212d640c985e46fe3bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736224}
-
Isabella Scalzi authored
Use |fakeMouseClick| instead of |simulateUiClick| and select the file to open the context menu on using |selectFile| rather than relying on right clicking. Also change |openQuickViewViaContextMenuCheckSelections| to use |fakeMouseClick| as well to see if |simulateUiClick| is the cause. Bug: 1038799 Change-Id: I7de92609e061b62bc351cfb4a5bef3eb0965a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026548 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736223}
-
sreejakshetty@chromium.org authored
Methods declared in content/public/common/navigation_policy.h |IsBackForwardCacheEnabled()|, |isProactivelySwapBrowsingInstanceEnabled()| are not used outside content/ are exposed in public. Moving these methods to content/common/ API to follow the policy: -> browser process only -> content/browser -> renderer process only -> content/renderer -> browser & renderer process -> content/common Change-Id: I42dd780646f7da832dba9067974ddbd9909fe1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019033 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736222}
-
yilkal authored
This CL prevents users from making multiple requests from the same tab for the same host address. The requests can be repeated by opening a new tab. The requests can be repeated in the next session. Bug: 1045155 Change-Id: If0a7549fe7509ff6ece8c1701e449294a85c56aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020543Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#736221}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/2d483ad845f1..5ef4f21a9 $ git log 1dc01cf32..5ef4f21a9 --date=short --no-merges --format='%ad %ae %s' 2020-01-28 wub gfe-relnote: Introduce kDefaultUdpPacketControlBufferSize and use it in QuicPacketReader as the control buffer size. No behavior change, not protected. 2020-01-28 fayang gfe-relnote: In QUIC, remove largest_sent_packets_ from unacked_packet_map. This only affects QUIC versions with TLS handshake. Protected by disabled gfe2_reloadable_flag_quic_enable_version_t* flags. 2020-01-27 rch gfe-relnote: n/a - Remove the #if MMSG_MORE wrapper around kNumPacketsPerReadMmsgCall in quic_packet_reader.h 2020-01-27 vasilvv Remove quic_bbr2_sender. 2020-01-27 wub gfe-relnote: In QuicPacketReader, change the use of QuicSocketUtils to QuicUdpSocketApi. Protected by --gfe2_restart_flag_quic_remove_quic_socket_utils_from_packet_reader. 2020-01-27 dschinazi Update IETF QUIC to draft 25 2020-01-27 fayang gfe-relnote: In QUIC move NeuterUnencryptedPackets and NeuterHandshakePackets from quic_sent_packet_manager to unacked_packet_map. Refactoring only, no functional change expected, not protected. 2020-01-27 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_delete_send_rst_stream_inner 2020-01-27 renjietang Remove using_default_max_streams_ from QuicStreamIdManager because the manager now has initial stream limit 0. 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_version_negotiated_by_default_at_server 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_log_ack_aggregation_stats. 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_exit_probe_bw_down_after_one_rtt. 2020-01-27 ianswett Deprecate gfe2_reloadable_flag_quic_use_common_stream_check 2020-01-26 bnc Buffer priority values in PRIORITY_UPDATE frames for not yet open streams. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I33f398b4add6b8c7fa86b08396cf4fb893ed41ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025569Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#736220}
-
Jie Jiang authored
Android use ReadRemoteRssi() to get the RSSI value for a connection. Currently we are using GetInquiryRSSI(), which cannot get the correct RSSI value for a connected device, and makes some Android apps unhappy. This change uses GetConnectionInfo() instead. BUG=b:147787450 TEST=Manually test with nRF and Fitbit. nRF can read RSSI value correctly; Firmware update of Fitbit works well now. Change-Id: I0dc13f58f430954772551165009d5ea7f26445c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004429 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736219}
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 1026641 Change-Id: Id22f4e3e66ce2127e4cec8a9ceddcf63c107abbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026311Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736218}
-
Sophie Chang authored
Note that I have not exposed the public interface yet since I want to make sure this is sound before migrating consumers over to this method. Bug: 1036490 Change-Id: Id44d5f09a17287a2ba28eb7593ebd41ff082bd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024164Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736217}
-
Ian Barkley-Yeung authored
Noted that two vlog messages in BrokerProcess::Init() are going to be referenced from ChromeOS integration tests, to warn people not to change them. https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2006009 is the CL adding the reference. BUG=chromium:1038463 TEST=tast -verbose run --extrauseflags chrome_internal my_crbook ui.ChromeCrashLoggedIn.* ui.ChromeCrashNotLoggedIn.* with this and 2006009 and 2004088 Change-Id: I4bec0bcdbb9fae631e4311d746fbb68a416f3709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006188Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736216}
-
Hans Wennborg authored
Bug: 1046362 Change-Id: Icdcc5226c4bb0ee6c8d58b33bb70f3494c55313e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026967Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736215}
-
Theresa Wellington authored
Previously, each client of SelectableItemView used <include> to embed modern_list_item_view inside a LinearLayout in their XML hierarchy. This created an odd dynamic where SelectableItemView only worked if the extending sub-class included this layout. In this CL, modern_list_item_view.xml is updated to include the wrapping LinearLayout, and SelectableItemView inflates this layout and attaches it to its view hierarchy, simplifying usage expectations. BUG=1003939 Change-Id: Ibeea314b4579c6b1eaa03e8c1ca60ab8c2010acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024495 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#736214}
-
Nick Diego Yamane authored
This is part of the patch series migrating PlatformEvent to ui::Event (formerly using XEvent) in Aura/X11 in order to eliminate this fundamental difference/incompatibility between Ozone and non-Ozone X11 ports. Design doc [1] describes in details such effort. This CL, particularly, is meant to ensure XEvent => ui::Event translation code (x11_event_translation.{h,cc}) is equivalent to constructing ui::*Event using the PlatformEvent ctors, the mechanism used so far to do such "translation". To achieve it, events_unittests have been modified to use the brand new X11 event translation code as well as fixing discrepancies found along the way. Most of them are trivial and this change does not bring any behavioral change. [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 965991 Change-Id: I1b738fd20c21233a611a0661b76da7fcdf176613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022322 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#736213}
-
Daniel Libby authored
This is used internally as ScrollGranularity enum value, so convert from being a double to the real type. Note that we're currently keeping the double version for script bindings of Blink's ScrollState. There is a behavioral change where the ScrollStateInit deltaGranularity is no longer round-tripped correctly but the ScrollCustomization feature was never shipped and no longer being pursued. R=bokan@chromium.org Bug: 1045306 Change-Id: I8092ebe8ee4833f2566b234660b8c4b5880e51f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026468Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736212}
-
Joshua Bell authored
A transaction watchdog timer intended to guard against hung renderers would be scheduled even if the transaction backend still had tasks to perform, which could be blocked on other backend work. The watchdog timer should only be started if the backend is only waiting on the front end. Add the extra condition. Bug: 1045585 Change-Id: I86e978faa9735e1b7a89a10660f1c747237b3c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026109Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#736211}
-
Hiroshi Ichikawa authored
Bug: 1023250 Change-Id: I9105894e5f3544cb52ef686b1abb8753455b3e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022023Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#736210}
-