- 16 Nov, 2020 40 commits
-
-
Swapnil authored
A browser test was missing to validate that the browser does not crash when multiple profiles are added. This browser test validates the same. Bug: 708210 Change-Id: I346b060cc5b20b631411044f71114d7b4603559d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041435 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#827715}
-
Luciano Pacheco authored
Add JS module generation for: //ui/file_manager/externs/background_window.js Add the method forceFileOperationErrorForTest() in the interface FileBrowserBackgroundFull and to its implementation FileBrowserBackgroundFullImpl. This is a preparation to run as JS modules and as SWA; to avoid the integration test harness to reach to global namespace `fileOperationUtil`. Bug: 1133186 Change-Id: Ic5e2d38762b030c827c887021e7e611ba846228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537285 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827714}
-
Maggie Cai authored
This CL refactors the AppsNavigationThrottle and all it's children to only handle navigation cancel and defer case (i.e. found a preferred app that can handle the url and redirect user to the app), and move all other functionality (show intent picker icon and bubble) to be called based on web contents observer from IntentPickerTabHelper. This CL is pure refactor with no functionality change. This is because currently if we automatically pop up the intent picker, it will show the apps from the first url, that we can find any apps, from the redirect chain. This will cause couple of issues: 1. If the apps that can handle the final url is not the same as the the apps that show up at the bubble, we will miss some apps. 2. If user dismissed the bubble and then click the icon again to show bubble, the apps will be different. 3. If the end url has no apps, and user dismissed the bubble and then click the icon to show bubble, nothing will show up. This CL changes the app checking and bubble showing time to when the navigation (and all redirects) is finished to overcome the above issues. (NOTE: Because the chromeos_apps_navigation_throttle code is due to deprecation, so only doing the minimum change to make sure it still works) BUG=853604 Change-Id: I6f83832dec1fdb6627df123ea31f51db8300b4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505689Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#827713}
-
Guido Trotter authored
- Add a WelcomeVideoController.pause() function - Make WelcomeVideoController.play() call play on the active video, too - Add a welcome screen hide() function, and call it from a new observer of the hidden attribute, when the screen becomes hidden - Call hideAllScreens() also when leaving oobe_welcome via onBeforeHide - Mark the active screen as not hidden in the welcome screen onBeforeShow(), to handle going back from the network and debug screens R=rsorokin@google.com Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Change-Id: Id5eecb1fa88bab598ab16e5152051fc8c14a6ca9 Fixed: 1123835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529100Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#827712}
-
Hirokazu Honda authored
This adds a test case of encoding NV12 Dmabuf VideoFrame with down-scaling; the input resolution is twice larger in width and height than one configured to VideoEncodeAccelerator. This can happen in WebRTC simulcast scenario when zero-copy capture feature is enabled. To not hit the smaller resolution's limitation, the test case is skipped if the resolution to be produced is less than 240x180. Bug: 1045825 Test: video_encode_accelerator_tests on atlas and kukui Change-Id: I11eac935aa2c6a03bcef0dfa533c8731d593d3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342535 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#827711}
-
Austin Tankiang authored
The test was flaking because a new banner was added to Drive. This banner has a "Learn more" button that can be used to dismiss the banner, so click it during the test. Bug: 1147306 Change-Id: If241639b7db35fd8a2cd6bfd87776d22c04e2874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538865Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#827710}
-
Fish Lin authored
This change adds a "mutable" option to flatbuffer template, let it using "--gen-mutable" flag to compile flatbuffer with non-const accessors for mutating FlatBuffers in-place. Bug: 1149150 Test: Compile flatbuffer see if it generates mutable header Change-Id: I42ce7dfcac5ee8496db56548391b205d0b056aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534550 Commit-Queue: Fish Lin <linfish@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#827709}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a15da341200e..b8a27ae001c2 2020-11-16 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from f6bc2a9be76e to 907123f96f40 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7969d2219319badd1daf35d46df76799e288ca1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827708}
-
Hirokazu Honda authored
The number of encoders is three in the concurrent encoder test case in video_encode_accelerator_tests. In the test case and 2160p encoding, creating shared memory for input frames fails on lower end devices due to a shortage of allowed handles. Decreasing the number of encoders should mitigate the fatal. Bug: b:170790027 Test: video_encode_accelerator_tests on cyan Change-Id: I669f026729c355e117b29389f08f66c05bcfa76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532541Reviewed-by:
-
zxliang authored
If a service appears in external_services_to_proxy, it is supposed to be registered and stored in services_ as well. BindInterface() should not query ServiceManager but instead should store this request through ServiceNotFound for later query when that particular external service is registered through RegisterExternalServices(..). Otherwise the binding process to this external service (which only has earlier-registered service_instance) will be silently dropped if the the client doesn't set any disconnection handler. Refer to go/ml-framework-standalone-binary-flakiness for more info. Bug: b/168555534 Test: CQ Change-Id: I2f791c924e1b23518704ad7237fc1e5624eaefd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537975 Commit-Queue: Zhaoxin Liang <zxliang@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#827706}
-
tby authored
We have logic for populating a ChromeUserMetricsExtension proto from JSON storage. This will soon be used in two places, so this CL moves it into its own function. While I'm here, I've also cleaned up the logic a little and added some extra safety to prevent us from crashing chrome in the case of an unexpected JSON format. I've also removed a TODO that isn't relevant anymore. Bug: 1148168 Change-Id: Iedcb514ae950f6a6ffec3690ddc7a82ba0b7616b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536421 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827705}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_SVG_RESOURCE_TYPE_CASTS() to DownCastTraits<> for the following classes, and removes DEFINE_LAYOUT_SVG_RESOURCE_TYPE_CASTS(). - LayoutSVGResourceClipper - LayoutSVGResourceFilter - LayoutSVGResourceMarker - LayoutSVGResourceMasker - LayoutSVGResourceRadialGradient This CL has no behavior changes. Bug: 891908 Change-Id: Ica5c540177b51e2e32d1e7c29518a060c2923c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538859 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827704}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac304ad84192..e22f384e6e94 2020-11-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia840e4bd9bd11ed464c3553023130d59abf3ec4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539646Reviewed-by:
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I0daf571aab4e9dc8a7f270ce64cb2b09b41362ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536582 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#827702}
-
Minggang Wang authored
The mojom interface KeepAliveHandle is used to keep alive the associated render process even after the frame is detached, and content::Context::WebURLLoaderImpl holds a pending remote of the KeepAliveHandle when creating a WebURLLoaderImpl object from renderer. As part of the OnionSoup project, this patch moves it into blink. Also, the method IssueKeepAliveHandle() used to create a KeepAliveHandle is moved from content.mojom.FrameHost to blink.mojom.LocalFrameHost, so we could issue a KeepAliveHandle directly inside blink in the future. Change-Id: I5dd9e4acc4743e83340955dab7cae0c901b2b61c Bug: 1110176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524284 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827701}
-
Luciano Pacheco authored
Follow from CL:2534553 move the duplicated code to app_util.js, satisfy the dependencies and re-use the code from app_util.js. Bug: 1148545, 1133186, 1113981 Change-Id: I7dc089a8cf1c371eb3d59702464839faf3004a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535900Reviewed-by:
-
Anupam Snigdha authored
This fix is a follow-up from a previous fix that changed the way we split the elements wrapped inside inline elements during indenting of more than one paragraphs. In this fix we also include elements such as textarea/input elements which are not inline/block level elements. This was found as a result of a clusterfuzz bug and I've included tests to check these cases. Test: web_tests/editing/execCommand/indent/indent_blockquote_with_inline_nested_paragraphs.html Bug: 1148859 Change-Id: I17b306a684fad185f60a433ab4d264a961ffb11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538532 Auto-Submit: Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827699}
-
David Munro authored
We added the StartLxd step a little while ago but didn't break it out into its own installer state then. Do so now so we can expose more granularity to users about installation and where launch/install is failing and because it'll be useful when we do timeouts. Bug: 1142319 Test: Manual, unit Change-Id: Iab11ecb5f79120e94119e9879b7228246e572b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537817 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827698}
-
Glen Robertson authored
Console errors are also logged to stderr so C++ devs can debug as before. Bug: 1149223 Change-Id: I050ba47184740bb7a08abf1469838f79f616105c Fixed: 1149223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537277 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#827697}
-
Darren Shen authored
It does not affect the test because SystemDecoder runs in a separate process, so setting the fake main entry does not affect SystemDecoder. Bug: 1148157 Change-Id: I99b5fac2da26be833f76063becbf586578d2965f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537253Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827696}
-
Eric Willigers authored
When navigator.share() fails with NotAllowedError, developers may find log messages useful to understand the failures. Change-Id: Ife338df5c8e97cc60de98ef4480d45ba8cdfa229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533215 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#827695}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605473970-18d5ebf07ab680b4396ec4f82e9b49e24c2d43e9.profdata to chrome-win32-master-1605484714-baf112bc95e811272919ec65bd3b64ed1dae8200.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I69335d2947adacbff3d755dce7f55395d5812687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538600Reviewed-by:
-
Darren Shen authored
They are currently compiled with the production code even though they are never used in production. Bug: 1148157 Change-Id: Ic115540344a42401c40601fd6167d33d2a8362d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539217Reviewed-by:
-
Bao-Duy Tran authored
The issue has existed ever since this entry was added. Ref: https://crrev.com/c/1124212 Bug: 1148670 Change-Id: I697fea43b2fb5cd660d8f3931ab0cff67c023007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537513Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#827692}
-
Darren Shen authored
Change-Id: I77f7d6cc963838d89a9a0cf83b038a4217ac987c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538856 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
-
Lei Shi authored
Add two properties for automation node, sentenceStarts and sentenceEnds, to calculate sentence boundary in a node's name. These two functions rely on i18n::BreakIterator, which is surfaced from ax_text_utils. AX-Relnotes: N/A Bug: 1143823 Change-Id: Ie05628e310f1850562069f83f7095e7d34277eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525604Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#827690}
-
Maggie Cai authored
This CL adds a check to avoid potential crash in FiltersHaveOverlap. The possible reason for this crash is that in M88, we briefly turned on the kIntentHandlingSharing flag, which result in a upgrade in the PreferredApp file format. After turning off the flag, the PreferredApp file is still upgrated, which result in comparing two intent filters with different number of conditions (one with action, the other without), which causes crash in the for loop. However this fix is actually not the best fix, because after turning on the flag again, there will be residual preferred app entries that will not be clean up in users PreferredApps file. The best fix is to downgrade the preferred app list when we found out the file version and the flag status does not match. BUG=1148617 Change-Id: I9d96691d663aa7603c8f37e6d1820b08aa9ef7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536666 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Tomasz Tylenda authored
BUG=1142502 TEST=none Change-Id: I4c668310ffc1903eab90a9e2152bf78bf621032e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536656Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#827688}
-
Noel Gordon authored
The example mojo code is being moved the SWA sample app. Remove it from SWA files app, leaving an empty shell that will be filled-in later. Bug: 1113981 Change-Id: If329ce6ba9df1bc08394892d67d6023f91cbeb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536581Reviewed-by:
-
Leo Zhang authored
The flag has been set enabled by default on M87. It's time to clean it up now. BUG=b:171846787 Change-Id: I3e32ee6de00e2df7bd315b1d06243980bc8f202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538860Reviewed-by:
-
Ian Kilpatrick authored
Due to a HTML specification change, the default UA stylesheet for modal dialog elements has changed: https://github.com/whatwg/html/pull/5936/files https://chromium.googlesource.com/chromium/src/+/be7281e188f22856bf9084d9f5c74a0f48eee1da Specifically for this bug max-width/max-height were set. This change explicitly resets the style for max-width/max-height to their initial values. Bug: 1148225 Change-Id: Ibf62fea46fc78206df4da240b1fb44f923b07415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538332Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#827685}
-
Hsin-Yu Chao authored
In commit 0bcb2086 we settled the Bluetooth mic node's priority to the same as headphones when it's in wideband speech mode. Now that Bluetooth WBS feature is ready on more platforms/models we need a switch to separate normal users and those who opt-in to try out the new feature during the feature stabilizing period. The switch mechanism is achieved by two things: (1) CrasAudioHandler queries the 'DeprioritizeBtWbsMic' value from CRAS and override BT mic to the lowest node priority if it's true. (2) The newly added bluetooth-wbs-dogfood feature flag will be used to stop (1) if it's set to enabled. The CRAS side change at http://crrev/c/2526821 R=enshuo, jennyz Bug: b/171763363 Change-Id: Ibace71c195434ca1ad935622cf29a4b68264315a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526861 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827684}
-
Wenbin Zhang authored
Sharding after algorithm update and some days after mac arm in use. Bug: chromium:1130157 Change-Id: I29ab5b4cf3e1cae39ba595e7374d4b5ff5d2d8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536800Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#827683}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605473970-858e020e397b6c69b02a6b98027a57d7f071f21b.profdata to chrome-win64-master-1605484714-e7960c8b645b53c1b4adeb64d7f205eadd5164b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If9bcbe986f97f1de1d388ac362dbf0f29132c380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539438Reviewed-by:
-
Darren Shen authored
Bug: 1148157 Change-Id: I96548155baa4226d32c2ab752cefd0326665d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537818Reviewed-by:
-
Ricky Liang authored
In the GPU process, GpuMemoryBuffer is stored and referenced using (buffer_id, client_id), where client_id is essentially the process that allocates (and usually owns) the GpuMemoryBuffer. When passing a GpuMemoryBuffer handle allocated by the Chrome OS video capture device, we need to invalidate the GpuMemoryBuffer id of the cloned handle before passing to the remote process to make sure we don't collide with another GpuMemoryBuffer allocated by the remote process that happens to have the same buffer_id. This CL invalidates the GpuMemoryBufferId before passing a GMB buffer from the browser to the renderer process. When the renderer process creates a SharedImage from the received GMB buffer, the GPU process will look up the real native pixmap handle through the DMA-buf fds in [1] because of the invalid GpuMemoryBufferId, instead of re-using a wrong pixmap handle in the cache. [1]: https://tinyurl.com/yymtv22y Bug: 993265 Change-Id: I58047207c53fa9dccb5b6c06166464b600aefbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368641 Commit-Queue: Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#827680}
-
Darren Shen authored
Impl & Test usually use the same namespace. NativeInputMethodEngine uses the chromeos namespace, so use the same namespace for the test file. Bug: 1148157 Change-Id: Idde400dcb320c8da1dc89335db8e734f4ec695b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532485Reviewed-by:
-
Chih-Yu Huang authored
Originally, V4L2StatefulVDBackend skipped flush when the V4L2 output queue is not streaming. However, it doesn't mean there is no pending requests needed to be flushed. This CL fixes this issue by introduing a new flag to track if there is any pending request. BUG=b:170728773 TEST=android.media.cts.AdaptivePlaybackTest#testH264_adaptiveReconfigDrc TEST=tast.video.DecodeAccel.{h264,vp8,vp9} Change-Id: I45d2b6072e47f23a3a61ccb622bef206ad1bb6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532027 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#827678}
-
Darren Shen authored
Remove unused default constructor and remove redundant comments that are better explained by the types themselves. Change-Id: Ia80404906241e592c4df33f4a97d26245a24440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533063 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I2d26ffbaee504748d97f2383a0c4cee6e0e7bace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538722Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827676}
-
