- 22 Sep, 2020 40 commits
-
-
Nick Diego Yamane authored
Recent refactors in surface code caused a regression in tab dragging. More specifically, when running on Wayland compositors that drop the DND session when the DND origin window gets destroyed (see [1] for further explanation). The crash happens due to a use-after-free issue in WaylandSurface event handlers, when the wl_surface::leave event comes in after its root window destruction (eg: a single-tab window being snapped into tab strip). To fix it, this CL unsets WaylandSurace's root_window when surface ownership transferring to WindowDragController is done. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2267637 R=msisov@igalia.com them containing 1 tab, then drag the tab from window 1 to window 2. Once it gets snapped into window 2 the drag session must keep responding to drag events, etc. Test: On a Gnome Shell Wayland session, open 2 Chromium windows, each of Bug: 896640 Change-Id: Ie31948099968ec9a932c44efde2985e6c4d7dea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422273 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#809301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/540c58aa5949..6a7c1f2e304e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rsorokin@google.com Change-Id: Ie8ba2c5a9d91660233010699197d7e1572b4705d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423963Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809300}
-
Rushan Suleymanov authored
Bug: 1127959 Change-Id: Icb7990bdc7ac2071ae6c13cc80a625c47c4a8d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423845 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#809299}
-
Matthias Körber authored
Change-Id: I7cdeead924974d382c09c9e2072473186200e98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421666 Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#809298}
-
Gyuyoung Kim authored
As content::ViewportStyle enum type was moved to Blink, it would be good if we can use it in the whole area without converting. So, this CL replaces the existing enum type and all uses with web_pref::WebViewportStyle after moving web_viewport_style.h from public/platform/web_viewport_style.h to public/common/web_preferences. Bug: 919392 Change-Id: I7443ea5642c36e609086ca52af87c5e66630bca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418597Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#809297}
-
Nela Kaczmarek authored
This CL removes the scoped logic from FakeAffiliationAPI and makes usage of AffiliationFetcherFactory in AffiliationBackend, where it's called to create an instance of AffiliationFetcherInterface. Bug: 1117447 Change-Id: Id0efc2da4fb88e96c84adcffbb7730edec0e485d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410863 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#809296}
-
Reda Tawfik authored
This CL sends the app name from native to java to use in the AllPasswordsBottomSheet in case if the credential is android credential. Remove unused properties (isAffiliationBasedMatch and isPublicSuffixMatch). Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1130572#c1 Bug: 1130572, 1104132 Change-Id: I872ed3f9df57d9e2e70ea91de4bab68fc907a7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414176Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#809295}
-
Sebastien Lalancette authored
Added the fieldtrial testing config change for this feature. Bug: 1110944 Change-Id: I435c42d7116cf38a760939f63ac7e70c4c10b0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421631Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#809294}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b653fdea2f19..9cf7a56afbcf 2020-09-22 hjd@google.com Merge "ui: Improve error message for invalid permalink" 2020-09-22 hjd@google.com Merge "Support loading traces from the Android Bug Tool" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I89150ea04ca95702fba33ddc313bf86ce1b7c50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809293}
-
Nick Diego Yamane authored
Modifies WaylandKeyboard::Delegate::OnKeyboardKeyEvent such that both wl_keyboard and zwp_text_input (IME) decode key codes the same way (by using Ozone's KeyboardLayoutEngine, xkbcommon, etc). Furthermore, this simplifies its function signature, making it easier to use to inject key events, such as in follow-up CL https://crrev.com/c/2417065. No functional changes are expected. R=msisov@igalia.com Bug: None Change-Id: Ia3610c5fbf9bb326c7f7ce4f1e4486083a348464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422429 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
Josh Nohle authored
(1) Simplify default device name creation now that we do not need to support non-ChromeOS platforms. (2) Use the given name (e.g., "Josh") instead of display name (e.g., "Josh Nohle") when creating the default device name (e.g., "Josh's Chromebook"). (3) Localize the default device name. (4) Now that default device name creations is synchronous, pass the default device name to the local device data manager. The Nearby Share service no longer needs to handle setting the default device name. (5) Set the default device name in the local-device-data manager constructor if the pref is empty. Fixed: b/168843120, 1127017 Change-Id: Ic023d1f696f1fd396277ffd9c8cc601f9b5cdcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423008Reviewed-by:James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#809291}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/52a588f3c9ba..aeda49ba5046 2020-09-22 cwallez@chromium.org Reuse BGL validation in default layout computations. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If9611aeb55c5b5e75683185288387ccb04aa77f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423541Reviewed-by:
-
Alice Wang authored
This CL refactors ProfileDataCache for monogram change in future. There is no behavior change in this CL. Bug: 1127886 Change-Id: Ib3349813730c8b9b065aa6ae9d559aa09c0efeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422948Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809289}
-
Boris Sazonov authored
Revise primary account check in AccountManagementFragment's sign-out flow. Since sign-out doesn't depend on sync consent - primary account should be queried using ConsentLevel.NOT_REQUIRED. Bug: 1130526 Change-Id: I411dc2d9312793ed0e80e7b63dce584a5cc026b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421897Reviewed-by:
-
Roman Sorokin authored
TBR=jomag@chromium.org,martiniss@chromium.org Fixed: 1130984 Bug: 1094203 Change-Id: Ib109934adddbe514f4141ab78988c31ccc200aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423715 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809287}
-
Anastasiia N authored
Screenshots: http://screen/3FWvACiYWV5ExsA, http://screen/8owuVEadT7uVtp4, http://screen/98f28fUHmSipZfp Fixed: 1099332 Change-Id: I05b13badbc391e677a809e5022dcf4fd480a7b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416460 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809286}
-
Matthias Körber authored
This CL adds support for settings and retrieving all structured address tokens and their corresponding statuses from the AutofillProfileSpecifics. Change-Id: I1b8a876fe565339fe4bfe1e2590819dde18d7cc0 Bug: 1128367, 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410038 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#809285}
-
Nikita Podguzov authored
This CL: * Changes the dialog modal type if it's anchored. * Removes the extension name from dialog header getter call, as corresponding string doesn't require it anymore. * Adds the ability to skip confirmation dialog, as it's complicated to interact with the dialog from the browser tests. Bug: 1128197 Change-Id: Ie830049dde68398f605fd59025c7f4c985e3434b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421673Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809284}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a485b3ae. With Chromium commits locally applied on WPT: 434c646e "[mathml] Make math display values on pseudo elements compute to flow" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ia8f9cd352694fae14e2fe8b25925103f935d22b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422586Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809283}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a8aa0a8f5d26..d53ca9807f41 2020-09-22 sadym@chromium.org Respect additional arguments in npm targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130513 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a6b225ce5e201934f665f9be9d523ec5adc68a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423540Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d0f8b8c9cc7..540c58aa5949 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rsorokin@google.com Change-Id: Iafcf76c715c24c0e5f69a107c60c8ee011180115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423534Reviewed-by:
-
Saurabh Nijhara authored
Due to historical reasons, force_install_metrics_unittest.cc contains tests for both ForceInstalledMetrics and ForceInstalledTracker classes. This CL moves the tests related to ForceInstalledTracker out of force_installed_metrics_unittest.cc into a separate file. Some new tests for ForceInstalledTracker are also added in this CL. Bug: 1086430 Change-Id: I8c49c61b0e1a4c25bbf57e7645fd5440acf970f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414309 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809280}
-
Mohamed Amir Yosef authored
Before this patch: The new protos were converted to the old protos before being parse by the FormStructure. After this patch: The new protos are parsed directly. Bug: 1114655 Change-Id: Ieb7d71c573e3010067aba250ab161be7946d203e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404584 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Roberto Moura authored
As described in the subsection "Thumb Strip to Tab grid transition" of the Thumb Strip Design Doc (go/bling-thumb-strip-design), in order to make a transition of layout in the tab switcher when the user goes from thumb strip to tab grid, we create the layout switcher and layout switcher provider, which allow the ViewRevealingVerticalPanHandler to trigger a layout transition in the grid view controller. The grid view controller implements the layout switcher protocol, and the tab grid view controller implements the layout switcher provider protocol. The tab grid coordinator connects the viewRevealingVerticalPanHandler to the layout switcher provider. Bug: 1127604, 1130037 Change-Id: Ibb170f6f1e69b70c0b20a6dd4dbff3daa507187c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408012Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#809278}
-
Miyoung Shin authored
This CL introduces chrome.dom.openOrClosedShadowRoot that is a read-only property to allow access to the closed shadow root in the Extension's content script. Bug: 778816 Change-Id: I933bc5d3996a74f46ee75181c535150901a5a46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319951 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#809277}
-
Alexander Yashkin authored
Change-Id: I5e90d529d0f9fd5b117d79ca2505aa83600701c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423506Reviewed-by:
-
Chris Sharp authored
The policy description was changed to say this policy was deprecated but the deprecated flag wasn't added. See https://chromium-review.googlesource.com/c/chromium/src/+/2215811 BUG=1086429 Change-Id: Ib9068ec4d0ad12272b71b9bd554933477f702606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419431Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809275}
-
Andreea Costinas authored
The PolicyCertService tracks which Profile has used a policy provided trust anchor by the user's email address. This CL fixes an issue in which the stored data is queried by the username hash instead of the email. Bug: 1106441 Test: unit test Change-Id: I0e0402f39068fbbc1b218cde0684c4fe6c1a880e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413489Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#809274}
-
Side Yilmaz authored
DownloadController defaults profile key to regular profile key in case of the profile is not reachable over download item. This CL changes the logic as below to prevent using regular profile key in incognito mode: - If download item provides a profile, use its key. - If not, get key from ProfileKeyStartupAccessor, as this means the code block runs in reduced mode. - If there is no key from ProfileKeyStartupAccessor, this means the incognito tab is closed and download will be destroyed when incognito goes away. In this case, just return. Bug: 1041781, 1075562 Change-Id: Id53485735891d9089cbf1e7a1c8c6e43cabc84a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413947 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809273}
-
Manuel Rego Casasnovas authored
In LayoutNG the overflow of positioned elements is already computed in LayoutNGBlockFlowMixin<Base>::AddLayoutOverflowFromChildren(), so we don't need to compute it again in the legacy code. Specifically positioned elements are already considered in NGPhysicalBoxFragment::ScrollableOverflowFromChildren(). BUG=1098231 Change-Id: I8e527617ae31ef564eeea57eb823ca93465cf62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391256 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809272}
-
dpapad authored
Replaces all instances of |#| as the numeric placeholder in pluralization strings with the new |{...}| format, as outlined in go/icu-message-migration. Bug: None Change-Id: I4e3409242e0b6bf94cb58de7327a381bfe237363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423404Reviewed-by:Rainhard Findling <rainhard@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809271}
-
Harry Cutts authored
Bug: 1114828 Test: Check the new flag appears in chrome://flags Change-Id: Iac50ad3843fccf6f94cba27c7ff322e99be0708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421298Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#809270}
-
Alan Cutter authored
This CL moves the call to GetPreinstalledWebApps() from SynchronizeExternalInstallOptions() to ScanDir() in preparation for adding metrics for enabled/disabled preinstalled web apps: https://chromium-review.googlesource.com/c/chromium/src/+/2418756 This enables the metrics to record for both JSON config files and hard coded install options. As part of this change ScanDir() is not just reading JSON config files and has been renamed to LoadInstallOptionsBlocking(). Other methods have been renamed to remove the "ScanDir" naming from the vicinity. Bug: 1128801 Change-Id: Ic95089c7c56c78f653c8aaa7683683fe2bd8f79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422022 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809269}
-
Roman Sorokin authored
TBR=beccahughes@chromium.org Bug: 1124983 Change-Id: I1f56f52732b5ad24cd6ab11fb47970eabf19407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423709Reviewed-by:
-
Antonio Gomes authored
This CL is a follow up of https://crrev.com/c/2414551, where AudioRendererSinkCacheImpl was moved to Blink core. BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifdaa4a5b68c4be2585307522629edc3e25f9a046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418911 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809267}
-
Matthias Körber authored
This CL adds support to store all address tokens and their verification statuses in the profile address table. Change-Id: Iad73aeb2e6464b872a8689b7077457cf39b01e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421450Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#809266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/82f83e6cda76..a8aa0a8f5d26 2020-09-22 jacktfranklin@chromium.org Reland "Fix ElementsBreadcrumbs mutation bugs." 2020-09-22 mathias@chromium.org Add final separator to Rendering tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5bf612ea4a9c66f4db7df6a8a7d0fc62a02eee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423531Reviewed-by:
-
Roman Sorokin authored
on Mac First failure on Mac10.13 Tests (dbg) https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20097 First failure on Mac10.14 https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/8525 suspect CL:2418018 TBR= Bug: 1130533 Change-Id: I2f3d46934ecb28a477d888df4422838a706d1b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421744Reviewed-by:
-
Roberto Moura authored
In order to allow the tab thumbnails to be up to date when the thumb strip is visible, the grid's collection view needs to be updated even when other view controllers are obscuring it. When selecting a new item from the collection view (blue highlight around the thumbnail), the item that is currently selected needs to be deselected to prevent multiple simultaneous selection. Bug: 1127604 Change-Id: Ic1e4a2dd4d0f2c269031b9d27b47b38c56b07a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410494Reviewed-by:
-
Andrey Zaytsev authored
Bug: 1128924, 1070620 Change-Id: Ib316e2a8e43eb1796b970ae340f9907210f58ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421374 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809262}
-
