- 27 Aug, 2020 29 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f2195b4..2a00f38a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I70ddc2d6f35c8ad166a434367ac411099dcf3aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802063}
-
Eugene Zemtsov authored
Bug: 1121793 Change-Id: Ia1e0cd7fb24bc004707485b57ff09672b8a3ae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378882Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#802062}
-
Michael Crouse authored
This change enables LiteVideo to rely on the Optimization Guide for hints rather than using a Finch supplied set of hosts. This change maintains both code paths and puts the optimization guide behind a Finch parameter. A future change will add a global blocklist to limit hints from being served on subframes from origins that LiteVideos do not perform well on. Bug: 1117064 Change-Id: Iabfb48df4bed15fec0a56d1c790627453581b637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369262 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802061}
-
chrome://flagsDale Curtis authored
Has been hidden since M76, so time to remove. R=cassew Fixed: 1110734 Change-Id: I4d07728d13b0df2420a58cae21ace36cba7af744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378632 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#802060}
-
Rakina Zata Amni authored
Currently we collect all DOMWrapperWorlds in a thread, so we might collect DOMWrapperWorld that don't have ScriptState (e.g. those with type kRegExp, created by text inputs) for hooking BFCache eviction, causing errors when trying to get the ScriptState. This CL makes sure we skip non-main/isolated worlds. Bug: 1117436 Change-Id: I6fa2f70446b18510bcfeb0997214b50086c4913a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377829 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802059}
-
Joe DeBlasio authored
This CL just adds a feature parameter to tune whether or not to use the keyword heuristic for eTLD+1 elision. The param defaults to true so that manually-opted-in users get the full elision behavior. Fixed: 1122309 Change-Id: I334305d9ada6044dadbdf39d283253aae51d26f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378739Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#802058}
-
Brandon Wylie authored
Bug: 1122310 Change-Id: I20a3aac84f4604c02c3744129a16394c8976bac1 TBR=fhorschig@chromium.org Change-Id: I20a3aac84f4604c02c3744129a16394c8976bac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378775Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802057}
-
Frédéric Wang authored
This reverts commit 421d2ad9. The test was failing on linux-chromeos-chrome internal bot because the CSSOMViewScrollCoordinates flag had not been enabled yet on it. However, that should no longer be an issue after [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2310799 Original change's description: > Disable DirectoryTree/FilesAppBrowserTest.Test/directoryTreeExpandHorizontalScrollRTL > > Failin on linux-chromeos-chrome internal bot since > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3955 > > Error like "[FAIL] [directoryTreeExpandHorizontalScrollRTL]: Tree should not scroll right > > This is blocking src-internal rolls (for >1 day). > > Tbr: majidvp@chromium.org, noel@chromium.org > Bug: 1061821, 1061670 > Change-Id: I27dd3fca5a5d9154519680b748c6dd054f2dd021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103012 > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750465} Bug: 1061821, 1061670 Change-Id: I12f490679d9d465b676318722282ef5f9fb190dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377489Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802056}
-
Jonah Chin authored
PaintImage::GetSkImage() is being deprecated. This CL cleans up more GetSkImage() callsites by using the new GetSwSkImage() API, other APIs directly on PaintImage, or using SkImageInfo to obtain image metadata. Bug: 1018894 Change-Id: Iad80746565a2a9b8193a6025893c0beda6fc7cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355100 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#802055}
-
Victor Fei authored
Google drive expand/collapse state is not being announced due to excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up discarding most events. For example, if we remove aria-hidden="true" on an ancestor node, which would cause that many of its descendants to remove their IGNORED states which triggering too many EVENT_OBJECT_SHOW and causes NVDA to drop the events. In reality, we only want EVENT_OBJECT_SHOW to be generated on the ancestor node where aria-hidden="true" is removed, so not to flood and confuse NVDA with excessive events. This change fixes the above issue by firing EVENT_OBJECT_SHOW on the root should the nodes of the entire subtree remove their IGNORED states. https://crrev.com/c/2309450 implemented suppressing excessive HIDE events, of which this CL is based on. Suppressing excessive REORDER events will be addressed in follow up patches. AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/ collapse state. Bug: 1019420 Change-Id: Icecf5d998ea666db4bf21a56f8b8b0b9a1e4aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337404 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802054}
-
Andrew Grieve authored
Bug: 1117222 Change-Id: Ifb7db199d0fb2b5d82cdef53f1eb5eccf2bb5363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377999 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#802053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdfdcf61cd4..14a9bffb3e9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4c867d0f3701b3c66a90c5bc467f6543c60318cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802052}
-
Christopher Cameron authored
Remove the option to specify a color space when calling createImageBitmap. Also remove the preserve_color_space parameter. None of these are used by existing behaviors. Their existence makes other cleanup harder. Bug: 1119507 Change-Id: I4ddcd76afff0a542c318a0035ad4559ff0022303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370727 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802051}
-
Yuri Wiitala authored
Fixes issues with UTCExploded() on certain 32-bit systems, where Time's in the near and distant future would result in exploded calendar fields in "random years past." This change solves the Y2038 problem for those systems. Hardens the UTC/LocalExploded() API, to guarantee all platforms will explode from the years 1601 to 30828 (at least), and clarifies how callers should check for a valid conversion. For platforms whose standard libraries are insufficient, the icu::Calendar implementation is used to provide the needed functionality. Fixes/Simplification to ensure base::Time::ToRoundedDownMillis...() will never do math that overflows int64_t's. Minor other tweaks in touched files. Fixes to a couple of unit tests in net/der and net/cert/internal. Bug: 1104442 Change-Id: I5f0e45879b8ee18cc7c253fa4a204443fdc27ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317864 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#802050}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d1609516687..68c8ed7aec14 2020-08-26 syoussefi@chromium.org Vulkan: More perf warnings 2020-08-26 geofflang@google.com Add support for P010 IOSurfaces 2020-08-26 jmadill@chromium.org Fix Linux build with Skia. 2020-08-26 jmadill@chromium.org Generalize zlib utils dir for Skia build. 2020-08-26 jonahr@google.com Fix SwANGLE suppressions of EGLIOSurfaceClientBufferTest 2020-08-26 ianelliott@google.com Vulkan: Fix TRex performance regression 2020-08-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from fb86cfb19849 to 94ee680cab4c (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1115621 Tbr: courtneygo@google.com Change-Id: Iac84acb5f79f5256104187a11e8d9932fdf23d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378654Reviewed-by:
-
Ian Kilpatrick authored
Per: https://www.chromestatus.com/feature/5680142707851264 In M85 we switched -webkit-line-clamp over to LayoutNG which had the (indended) side-effect of removing support for: -webkit-box-flex -webkit-box-ordinal-group -webkit-box-align -webkit-box-pack -webkit-box-direction When used with -webkit-line-clamp. This patch removes the -webkit-box-flex from LayoutDeprecatedFlexibleBox Bug: 305376 Change-Id: I51b49eb6c7fd20d3f15d15e262a513e0cddadefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375943 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802048}
-
Zhuoyu Qian authored
This CL rename the TextIteratorAlgorithm member GetText() to GetTextState(). Change-Id: I782bd5b8faaea7f220e15f5c3a8d929d40f17422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376928Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#802047}
-
Garrett Beaty authored
The master-only directory has been unwieldy and in order to support LTS an additional subset would be required which would make doing it by directory even more unwieldy. The addition of a library for conditionally defining LUCI resources depending on the branch means that the builders for a bucket can be located together and the branch_selector value controls which branches they are actually defined for. Bug: 1119446 Change-Id: I1dff1f8e6c0485e31fd902c383f02b37a3f0d138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378794Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#802046}
-
Tal Pressman authored
This reverts commit e2431d75. Reason for revert: Broke a number of chrome builders with the following error: Step _generate_buildfiles failed. Error logs are shown below: ERROR Unresolved dependencies. //chrome/browser/media/kaleidoscope/internal/resources/module:module(//build/toolchain/linux:clang_x64) needs //chrome/browser/resources/new_tab_page:module_descriptor(//build/toolchain/linux:clang_x64) Sample failed build: ci.chromium.org/p/chrome/builders/ci/linux-chrome/14497 Original change's description: > [webui][ntp] Move GN targets close to source files > > This is more consistent with the GN targets of other WebUIs. > > + Move module_wrapper.* to modules/. > > Change-Id: I23be97df455e8cb0a9ed35b15b184902b3fa1a9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376529 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802008} TBR=dpapad@chromium.org,tiborg@chromium.org Change-Id: Idb6c8115599e74333fab357cb2d40a040e8c0c82 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377038Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#802045}
-
Xiaohan Wang authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/48b037ba0de5..a1f3db690c65 $ git log 48b037ba0..a1f3db690 --date=short --no-merges --format='%ad %ae %s' 2020-08-26 xhwang Initialize `layout_map` on declaration Created with: roll-dep src/third_party/ffmpeg Tbr: dalecurtis@chromium.org Bug: 1119532,1119331 Change-Id: I528650fc59aea9d3a7bfd8ca16d3be225e1e0ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378872Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802044}
-
HyunJi Kim authored
Deprecate `-webkit-font-size-delta` due to low usage(0.007%) and replace it with `-internal-font-size-delta` for Editing module Intent : https://groups.google.com/a/chromium.org/d/msg/blink-dev/p1D2Fj8WTe0/p6uQY-oACAAJ Status Entry : https://chromestatus.com/feature/6267981828980736 Bug: 974092 Change-Id: I4b25c537d47eef508094bdfc498c824aaafeed2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358723Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#802043}
-
Xianzhu Wang authored
We would like to enable it for all web tests, but we still need to fix some failures before that. Enable the feature for specific unit tests. This prepares for letting blink feature status override chromium feature status. Bug: 1121839 Change-Id: I4a3c6b3e25dd7d0e7b14af8f244f449d5002aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378895Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/661b3a4411c6..1752e62f5c2a 2020-08-26 jalyn@microsoft.com Sources: Hide 'No watch expressions' when add button clicked If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1121450 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I711348e8f22719486d0bc43344e28c5577106b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378222Reviewed-by:
-
Yulun Wu authored
Bug: 1110757 Change-Id: I82d4009000baaaafcdd38f2eee67e0dae2d870bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376417Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802040}
-
Jiewei Qian authored
This CL adds browsertest to check Native File System showOpenFilePicker and showDirectoryPicker work in WebUIs, and the app gets read and write permissions of the opened file (or directory). This CL tests: - Open a file from a normal directory - Open a file from a sensitive directory (e.g. Downloads/) - Open a normal directory - Open a directory in a sensitive directory (e.g. Downloads/folder) This CL doesn't test for opening a sensitive directory, because this is currently disallowed by Native File System. Fixed: 1116896 Change-Id: Ic4f9823ca085025aaccecacf1544cc1ea36f1dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359809Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#802039}
-
Xianzhu Wang authored
It's disabled in chromium by default. It seems that it should be disabled by default and will be removed in the future. I guess it was status:stable in blink just for some tests using the feature to pass. Now only enable it for specific browser tests and unit tests. This prepares for letting blink feature status override chromium feature status. Bug: 1121839 Change-Id: Ie40cb0e7e71216be4798133849c80b5660c80869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375678Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Lei Zhang authored
This reverts commit 5e803e36. Reason for revert: Collided with https://crrev.com/801651 Original change's description: > Stop polling in PDFExtensionClipboardTest. > > Now that https://crbug.com/755826 has been fixed, tests that read from > the clipboard can use ClipboardMonitor to get notifications for when the > clipboard changes, instead of polling the clipboard. This is more > straight-forward, and hopefully more reliable. > > Bug: 1121446 > Change-Id: I53291e0957ee2bad8a565bb0d80ef0628be40e2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376765 > Reviewed-by: Stuart Langley <slangley@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802025} TBR=thestig@chromium.org,slangley@chromium.org Change-Id: I20774cf96cf6a64c5f593852004a2c079e790320 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378742Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802037}
-
Daniel Classon authored
Move the Play Store settings position in the Apps Page hierarchy to reflect their search tags and the actual positions in the HTML. Bug: 1084154 Change-Id: I9fa87fcf86aab6b8d8335aaed1d80e68678cb3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378734 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802036}
-
Joel Hockey authored
New chrome://flags#meda-notifications-counter flag, will remove media notifications from the notification counter in the status area when enabled. Bug: 1111881 Change-Id: I6d55362d58b538af6c3fef391e9b0bda46421f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370684 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#802035}
-
- 26 Aug, 2020 11 commits
-
-
Scott Violet authored
I ended up with two tests: . ContentStabilityMetricsProviderTest, what was ChromeStabilityMetricsProviderTest. . ChromeMetricsExtensionsHelperTest to verify ChromeMetricsExtensionsHelper. Also note that ChromeStabilityMetricsProviderTest was previously not run on android before. This is because the test was only added to the unit_tests target if plugins were enabled. As plugins aren't enabled on android, the test was never run. I removed some code to make it work. It would be nice to get coverage of "Stability.Android.RendererCrash" but I think that's out of scope of this work. BUG=1120537 TEST=this is a test only change Change-Id: I36b6f910b9e24e647b73e98ce84be1767a1900cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375703 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#802034}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d410c664e6e3..e7f2169b3665 2020-08-26 vadimsh@chromium.org Update cipd and vpython to latest versions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9c04b9813bea489435f9abd265262a4a9cf2b260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378220Reviewed-by:
-
David Black authored
c/b/u/ash/holding_space has similar requirements as applist to show icons for specific file types in its UI. To facilitate reuse, moving the existing file_icon_util to ash/public/cpp to avoid directly relying on c/b/u/app_list from c/b/u/ash. Bug: 1113775 Change-Id: Iafafecf19df4ffa195f9459610a53e768243a34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377319 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802032}
-
Jia Li authored
Previously it observes any services not just the ML Service. Bug: 1122160 Change-Id: I8a22d6bd770af25cf48851eab81f1272513663fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378692Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#802031}
-
David Black authored
HoldingSpaceClient is the browser client for the TemporaryHoldingSpace feature. This CL adds an API to open holding space items, though the use of this API will not be added until UI classes merged. Bug: 1112469 Change-Id: I93f9fb190e90af19e8b29b6e683bc3e8d6b9db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375601 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Xiaoling Bao authored
Change-Id: Ic2dbcb1870116daf85028aadba6d15da53402082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378716Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#802029}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64f3530dc37e..398ecf1876f1 2020-08-26 egdaniel@google.com Remove unused factories that take characterizations. 2020-08-26 bsalomon@google.com Enable glesfakev2 config on Android perf bots 2020-08-26 bungeman@google.com Format and comment SkScalarInterpFunc 2020-08-26 bsalomon@google.com Add config "glesfakev2". It runs GLES with the version faked as 2. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie693311df982ae034bb444c2fc94c1fcd68dc11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378656Reviewed-by:
-
Solomon Kinard authored
Bug: None Change-Id: I4a926b2326c10759ac01b92c27f99f9d9ddc342e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369333Reviewed-by:
Alex Mineer <amineer@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#802027}
-
Orin Jaworski authored
This CL prevents duplicate Pedal attachments from appearing in omnibox suggestions as a result of match upgrades. It was previously expected that duplicate matches, once buried, would not be used or shown again, but that is not the case when entity suggestions are involved. Bug: 1122183 Change-Id: I4539d51304cf3a1acad87ecbf80c7c51749a2398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376722Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802026}
-
Lei Zhang authored
Now that https://crbug.com/755826 has been fixed, tests that read from the clipboard can use ClipboardMonitor to get notifications for when the clipboard changes, instead of polling the clipboard. This is more straight-forward, and hopefully more reliable. Bug: 1121446 Change-Id: I53291e0957ee2bad8a565bb0d80ef0628be40e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376765Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802025}
-
Nnamdi Theodore Johnson-Kanu authored
Fixed: 1111477 Change-Id: I1d26d3063ad38d70dc38177d13a276905c7bd79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378000 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
