GitLab

BUG=715638

Review-Url: https://codereview.chromium.org/2850493002
Cr-Commit-Position: refs/heads/master@{#468612}

TraceEventMemoryOverhead is a rather simple class which only purpose is
accounting various sources of memory overhead due to tracing itself.
For debugging purposes it keeps track of the actual class causing
overhead, so that they can be inspected distinctly in the tracing UI
The current implementation was using a small_map indexed by
const char* pointer, which has a bunch of problems:
- base::small_map can degenerate into a STL map when exceeding the
  inline capacity, which in turn can cause some extra impredictability,
  see "[chromium-dev] Please avoid std::unordered_map".
- The map implicitly assumes that two identical string literals will have
  identical pointers, which is not true, esepcially in component builds.
- Any sort of map is a really over-engineered solution, given that the
  sources of overheads we care about are known a priori and are a
  manageable number.

Hence, this CL is switching the implementation of
TraceEventMemoryOverhead to be just enum-base, which ditches completely
the map.

BUG=717223

Review-Url: https://codereview.chromium.org/2857543002
Cr-Commit-Position: refs/heads/master@{#468611}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7641bfdd..54c14a48

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2853233002
Cr-Commit-Position: refs/heads/master@{#468610}

BUG=703184

Review-Url: https://codereview.chromium.org/2844273002
Cr-Commit-Position: refs/heads/master@{#468609}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584

Review-Url: https://codereview.chromium.org/2851593002
Cr-Commit-Position: refs/heads/master@{#468608}

The RequestFileSystemDialogView class had an unused member contents_view_ which is no longer needed after https://codereview.chromium.org/2816293002/diff/520001.

Removing this should fix the memory leak. Thanks to lazyboy for helping track down this leak.

BUG=717057
TBR=pkasting

Review-Url: https://codereview.chromium.org/2855663002
Cr-Commit-Position: refs/heads/master@{#468607}

This changes the AutofillCounter to indicate that autofill data is synced.

BUG=681523

Review-Url: https://codereview.chromium.org/2828083003
Cr-Commit-Position: refs/heads/master@{#468606}

This CL moves part of deferred initialization tasks from DeferredStartupHandler
to ProcessInitializationHandler to split responsibilities.

BUG=716454

Review-Url: https://codereview.chromium.org/2853513002
Cr-Commit-Position: refs/heads/master@{#468605}

Since the execution order of tasks across task queues is not
guaranteed[1], the task that controls the expiration of the virtual time
budget can run in a random order w.r.t. the tasks virtual time is
actually controlling. This patch makes the ordering deterministic by
using the control task queue (i.e., always the highest priority) to
reset the virtual time policy when the budget expires.

BUG=696001,701223

[1] https://codereview.chromium.org/2786083005/

Review-Url: https://codereview.chromium.org/2841463003
Cr-Commit-Position: refs/heads/master@{#468604}

Needed for reland of https://codereview.webrtc.org/2622263002/

BUG=webrtc:5880

Review-Url: https://codereview.chromium.org/2855783003
Cr-Commit-Position: refs/heads/master@{#468603}

The local VM is Mac-10.12 and the LayoutTests are passing, so force
swarming to also run on Mac-10.12

BUG=717344
TBR=dpranke@chromium.com,mcgreevy@chromium.org

Review-Url: https://codereview.chromium.org/2848253005
Cr-Commit-Position: refs/heads/master@{#468602}

This test should be part of https://codereview.chromium.org/2821303005
but at that time I didn't find the way to focus/unfocus an iframe.
The solution was to use internals.setFocused() for that purpose.

This patch adds a new test pretty similar to the one for windows
(fast/selectors/focus-within-window-inactive.html),
but checking what happens when an iframe loses and regains focus.

BUG=617371
TEST=fast/selectors/focus-within-iframe.html

Review-Url: https://codereview.chromium.org/2847803007
Cr-Commit-Position: refs/heads/master@{#468601}

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests --gtest_filter=DriveApiRequestsTest.*:DriveApiUrlGeneratorTest.*
BUG=715355

Review-Url: https://codereview.chromium.org/2854653004
Cr-Commit-Position: refs/heads/master@{#468600}

crrev.com/2823183003 was the first step towards removing the SizingOperation
enum which was added in the past as a convenient way to modify the track
sizing algorithm behaviour depending on whether the size was
indefinite/definite but also on whether we were computing the grid intrinsic
size or doing a layout. As mentioned in the CL above that was a mistake
because indefinite sizes do not always correspond to preferred widths
computations.

Now that we have the algorithm in a separate class with different strategies
the existence of that enum is no longer required. We can handle the
remaining code path using SizingOperation just by using the algorithm
strategies.

No new tests required as this does not imply a change in the behaviour.

Review-Url: https://codereview.chromium.org/2842413003
Cr-Commit-Position: refs/heads/master@{#468599}

The CSS Box Alignment spec states that we should ignore the collapsed
tracks when computing the Distribution Alignment space to assign to the
different grid tracks.

BUG=707633

Review-Url: https://codereview.chromium.org/2825133003
Cr-Commit-Position: refs/heads/master@{#468598}

Enable v8.rutimestats.browse_mobile and v8.runtimestats.browse_mobile_classic
benchmarks on reference builds. They were earlier disabled because these
benchmarks were failing on Nexus5 and Nexus6 bots.

Bug: 
Change-Id: Ia7819a540be28d802734fbc3e34c9c08d45428aa
Reviewed-on: https://chromium-review.googlesource.com/490287Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468597}

This change implements recent changes to the Credential Manager API
specification that introduce the |SecureContext| extended attribute on
its interfaces. Furthermore it removes
|RuntimeEnabled=CredentialManager| from the interfaces following the
discussion in http://crrev.com/2832813002.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ

BUG=715077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2844453002
Cr-Commit-Position: refs/heads/master@{#468596}

This finally aligns our typedef with the version in the spec. We can do so
now that our bindings code can convert any iterable object into a sequence.

The Headers::FillWith(const Header*, ...) overload has been kept though, as
it is used by other classes that may need to fill a Headers object with
another existing one (when initializing a Request object, for example).

BUG=705490
R=falken@chromium.org,mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2854613002
Cr-Commit-Position: refs/heads/master@{#468595}

This makes oilpan benchmarks no longer run on perf waterfall. However,
these benchmarks are still runnable locally & on try bot.

Bug: 717320
Change-Id: I4eb52a6a8306a03879c808821f25238dfc5bb49e
Reviewed-on: https://chromium-review.googlesource.com/492806Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#468594}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1bddf126..7641bfdd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2857493003
Cr-Commit-Position: refs/heads/master@{#468593}

The current factoring of BrowserPolicyConnectorChromeOS only allows to
swap out the device policy provider at initialization time, not at run
time.  As a consequence, we end up with the wrong device policy provider
after Chromad enrollment.  A browser restart is the easiest way to fix
this.

BUG=681817

Review-Url: https://codereview.chromium.org/2842163002
Cr-Commit-Position: refs/heads/master@{#468592}

With asynchronous checks, it can happen that multiple checks return that
the current page should be blocked. When trying to show an interstitial
page over another existing one, the old interstitial page automatically
is closed, which for the case of the supervised user interstitial would
close the whole tab if there is no navigation to go back to. Add a flag
in SupervisedUserNavigationObserver that stores whether an interstitial
is currently showing, and clear it when the interstitial is closed.

Because the SupervisedUserNavigationObserver is now used to store state,
it is required in order to show the interstitial, so the navigation will
now fail if the SupervisedUserNavigationObserver for a WebContents is
missing.

Also, remove the case where the interstitial immediately proceeds,
because the URL filter is always checked on the UI thread.

BUG=715981

Review-Url: https://codereview.chromium.org/2845053002
Cr-Commit-Position: refs/heads/master@{#468591}

Revert of Make InsertTextCommand not to apply style for empty selection (patchset #1 id:1 of https://codereview.chromium.org/2847763004/ )

Reason for revert:
Speculative revert, this seems to have broken some virtual/gpu/fast/canvas/ tests. More info on the associated bug.

BUG=717389

Original issue's description:
> Make InsertTextCommand not to apply typing style for empty selection
>
> This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
> applying typing style when selection after inserting text is empty since
> |ApplyStyle()| doesn't work with empty selection.
>
> The issue 714311 and the attached test case insert text into OPTION element to
> get empty selection after insertion, since we can't place selection inside
> OPTION element.
>
> BUG=714311
> TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
>
> Review-Url: https://codereview.chromium.org/2847763004
> Cr-Commit-Position: refs/heads/master@{#468080}
> Committed: https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b015232663b4fcd87

TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=714311

Review-Url: https://codereview.chromium.org/2853213002
Cr-Commit-Position: refs/heads/master@{#468590}

Revert of Remove FrameView::Root (patchset #2 id:20001 of https://codereview.chromium.org/2849383002/ )

Reason for revert:
This broke compilation (details later).

Today's sheriff

Original issue's description:
> Remove FrameView::Root
>
> BUG=637460
>
> Review-Url: https://codereview.chromium.org/2849383002
> Cr-Commit-Position: refs/heads/master@{#468588}
> Committed: https://chromium.googlesource.com/chromium/src/+/561e38ff8dc24f23f0293c54777bbc2eda99a2b5

TBR=haraken@chromium.org,dcheng@chromium.org,joelhockey@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637460

Review-Url: https://codereview.chromium.org/2857523002
Cr-Commit-Position: refs/heads/master@{#468589}

BUG=637460

Review-Url: https://codereview.chromium.org/2849383002
Cr-Commit-Position: refs/heads/master@{#468588}

BUG=637460

Review-Url: https://codereview.chromium.org/2849403002
Cr-Commit-Position: refs/heads/master@{#468587}

This documentation captures insights we've gained during initial
servicifications; hopefully it will be useful for future servicifications.

Review-Url: https://codereview.chromium.org/2849463006
Cr-Commit-Position: refs/heads/master@{#468586}

This change removes two unnecessary copies in CredentialsContainer::get
when federations are present in the CredentialRequestOptions.

BUG=400674

Review-Url: https://codereview.chromium.org/2848743003
Cr-Commit-Position: refs/heads/master@{#468585}

Back out the problem diagnosis CHECKs() added in r463124; condition not
triggered.

R=haraken
BUG=699269

Review-Url: https://codereview.chromium.org/2857503002
Cr-Commit-Position: refs/heads/master@{#468584}

BUG=

Review-Url: https://codereview.chromium.org/2850153004
Cr-Commit-Position: refs/heads/master@{#468583}

Fix compilation errors (rebased).

Original description:

Use TraceWrapperV8Reference instead. This CL doesn't remove
custom getter of PopStateEvent.state as more work will be
needed to remove custom bindings.

BUG=501866

Review-Url: https://codereview.chromium.org/2850383002
Cr-Commit-Position: refs/heads/master@{#468582}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9300a23423c0..01ea3803d6f5

$ git log 9300a2342..01ea3803d --date=short --no-merges --format='%ad %ae %s'
2017-05-01 ashleymarie [Telemetry] Removing multi-tab tests from LegacyPageTest

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6e67648fb68732412d8d737a779a4b01433b82e3
Reviewed-on: https://chromium-review.googlesource.com/492788
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468581}

This CL is a continuation of removing dependencies in the code on WebViewImpl, by
introducing the pure virtual class WebViewBase and moving methods from WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a direct
static cast to WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2854783003
Cr-Commit-Position: refs/heads/master@{#468580}

Team Drive files are loaded to /team_drives directory. This change will
show it in the UI.

Google Drive(volume)
 - My Drive
 - "Team Drives"
   - "ABC team drive"

Before the change, only the root entries and fake entries were shown
with special icon (as opposed to the folder icon) and label (from
localized string resource, as opposed to filename of each entry).

Now we are showing "Team Drives" and "ABC team drive" with the special
icon just like such root/fake entries.
However, the label of "ABC team drive" should be the name of the entry
(which comes from the name of a Team Drive). hasIndividualName property
is introduced for this reason.

TEST=tested manually with --team-drive
TEST=browser_tests --gtest_filter=FileManagerJsTest.*:GalleryBrowserTest*
BUG=684275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839863002
Cr-Commit-Position: refs/heads/master@{#468579}

This CL fixes a misnamed member in the drag and drop manager.

BUG=716257
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2853973002
Cr-Commit-Position: refs/heads/master@{#468578}

Everywhere else access to webcontents via tab_strip->GetWebContentsAt(i)
is checked. Missing check here may lead to crash in rare cases.

R=benwells@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2839403005
Cr-Commit-Position: refs/heads/master@{#468577}

The new icon is used in the new infobar only.
The icon in the old translate infobar and "main menu -> settings -> site settings" will remain unchanged at the moment.

BUG=703887

Review-Url: https://codereview.chromium.org/2846183002
Cr-Commit-Position: refs/heads/master@{#468576}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/14e9286b..1bddf126

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2855833002
Cr-Commit-Position: refs/heads/master@{#468575}

This completes one TODO (adding an error message to StoreClient),
and removes another obsolete TODO.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2858483002
Cr-Commit-Position: refs/heads/master@{#468574}

Recently imported test
external/wpt/media-source/mediasource-avtracks.html is occasionally
failing instead of crashing on WebKit Mac 10.9, so expanding the
test expectation to accommodate.

BUG=626703
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2856823002
Cr-Commit-Position: refs/heads/master@{#468573}