- 15 Aug, 2020 17 commits
-
-
Moe Ahmadi authored
Feature being launched in cr/326256148 - Enables ntp_features::kRealbox and omnibox::kZeroSuggestionsOnNTPRealbox which control the realbox and zero-suggest in realbox respectively. - Enables omnibox::kZeroSuggestionsOnNTP which should've been enabled in crrev.com/c/2175138. - Removes applicable fieldtrial_testing_config.json entries and adjusts test expectations. Change-Id: I1889e65c23e02624b85f0291600b26382e75f828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354993Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798392}
-
Becca Hughes authored
This CL moves the Kaleidoscope NTP module upstream into the Kaleidoscope repo. The public Kaleidoscope module is now responsible for loading the resources into the NTP page. Also adds the KaleidoscopeDataProvider to the NTP. BUG=1114862 Change-Id: Ibc255ea9d7fd05b10cb151d0f1e86b0f94b192cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354717 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798391}
-
Tarun Bansal authored
Change-Id: I46a7030d3444e57dc61b2663d79d9fc9217b2a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357467Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#798390}
-
Lei Zhang authored
This reverts commit 29499d24. Reason for revert: Broke the linux-chromeos-chrome bot. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7735 Original change's description: > Convert scanning app to system web app (SWA) > > The SWA uses a temporary icon and is hidden behind a feature flag that > is disabled by default. > > Bug: 1059779 > Change-Id: I9cee9b2de42a49285a8ee5ba2877d6394a7ca5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348539 > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798367} TBR=khorimoto@chromium.org,ortuno@chromium.org,jimmyxgong@chromium.org,jschettler@chromium.org Change-Id: I63c9b0497c709def532c052a8c6bdc4eb8f0a200 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358569Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798389}
-
Daniel Rubery authored
This CL changes the DownloadFeedbackService to know about the profile it is performing feedback for, and to use that profile to get the appropriate URLLoaderFactory. Bug: 1049833 Change-Id: I63b958cbfbcec2129315c7a680ca25eb1221d8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347224 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#798388}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Ic4c6561d5cdaf55b844dc96be9d9c50a96c08303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358031Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#798387}
-
Thomas Guilbert authored
This CL adds the ability to clone a blink::VideoFrame. Doing so creates a new VideoFrame, with a new reference to the same underlying media::VideoFrame. This allows users that want to keep a frame alive to pass a clone to workers or objects which might destroy the frame. An example use case might be a user sending cloned reference to different workers, which can then call destroy() on the frames without impacting each other's work. A user could also send a clone to VideoEncoder, to keep using the frame after the VideoEncoder is done with the clone and calls destroy on it. Bug: 1108023 Change-Id: Ia4f22f1429e466474fb87ce9700a54b87428440b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355092 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#798386}
-
Thomas Guilbert authored
This CL fixes VideoFrame constructor crash, when it is passed a closed ImageBitmap. This happens because the passed pointer is valid, but we use ImageBitmap::ImageBitmap() without checking its returns value. Change-Id: I04858a194026f3448e40a62d556153c32c8bdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357458 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
Always handle "avif" in FileExtensionToImageType(), whether the "AVIF" feature is enabled or not. The file-scope internal function FileExtensionToImageType() is only called on the return value of the virtual method ImageDecoder::FilenameExtension(). Therefore, the only way the image_extension argument is equal to "avif" is that AVIFImageDecoder::FilenameExtension() is called. So it does not need to check if the AVIF feature is enabled, because we still want to run AVIFImageDecoder unit tests when the AVIF feature is disabled. Test: blink_platform_unittests --enable-features=AVIF --gtest_filter=*AVIF* blink_platform_unittests --disable-features=AVIF --gtest_filter=*AVIF* Bug: 1116502 Change-Id: I17e0290fef25a508c4e87cbdc07a27ef0dac73b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357957Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#798384}
-
Lei Zhang authored
AutoplayMetricsBrowserTest.RecordAutoplayAttemptUkm is failing on non-Windows platforms as well. Bug: 1101841 Change-Id: I641bcbadd9e3ad52bcc4a5bc39bac08a4dbf34e5 Tbr: tommi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357619Reviewed-by:
-
Klaus Weidner authored
Propagate the "is_xr_overlay" fullscreen request type flag for OOPIF requests via mojo, and ensure that visibility is set correctly for out of process container iframe elements. Note for testing: Currently, Chrome on Android only enforces site isolation for sites with login active, and not on low memory devices. Run with the --site-per-process command line flag to override this. Bug: 1101193 Change-Id: Ic8736e90f28fbda2d6cb1f665cbd0804c3f38cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283968 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798382}
-
Marijn Kruisselbrink authored
This adds enterprise policies to enable auto-denying access to the file system via the native file system API to certain URLs. No policy yet for auto-granting, as that seems more dangerous, and also probably would be better in the form of granting access to specific paths rather than blanket access. Bug: 977764 Change-Id: Ie6d9f8c6cdef84ce922a7b110ab1424499157820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321240Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#798381}
-
Yuke Liao authored
Bug: 1116180 Change-Id: Ida6cf332036dec7bcfa2b78efbfb19a278e59a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357680 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798380}
-
Stephen McGruer authored
On Windows, handlers are not inherited by default (unlike unix). This includes stdout and stderr, so by default a process launched via CreateProcess does not send output to the same place as its parent. When running ChromeDriver manually in a terminal this is fine, since all the output ends up in the terminal anyway, but if ChromeDriver is launched programmatically then the root process cannot see the output from the browser: my_runner.exe --> chromedriver.exe --> chrome.exe In the above example, without inherited handles my_runner.exe does not see chrome.exe's output. The solution is to set the stdout and stderr handles to be the same ones that ChromeDriver is using, and make them explicitly inherited. Bug: 1109233 Change-Id: Iac18beed5583ea7b7830015d765f3670c86b652b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335355 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2a426bd66bc..df20c91466d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thestig@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099982 Tbr: thestig@google.com,juanmihd@google.com Change-Id: I011254c480ff501d0b818ce49d9e2380a4bbf68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798378}
-
Lei Zhang authored
DumpAccessibilityTreeTest.AccessibilityAriaMenuItemInGroup is failing. Bug: 1116627 Change-Id: I05ed4eba63137de5654a1652d45c5248df95fece Tbr: aleventhal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357463Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/27391a090ec2..2e5647c8eede 2020-08-14 jmadill@chromium.org Vulkan: Switch buffer barrier check. 2020-08-14 nguyenmh@google.com Add unittests of ANGLE commit message format check 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 61bf3be73c1e to 527e67e9d933 (1 revision) 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6b0de7007af5 to 1980311465cf (2 revisions) 2020-08-14 msisov@igalia.com X11 and Ozone: fix compilation of tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1085700 Tbr: ynovikov@google.com Change-Id: Id892f2233392dd77a87dc74117e949ddbe61c2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357589 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798376}
-
- 14 Aug, 2020 23 commits
-
-
Robert Ogden authored
The origin prober needs to support setting up a TLS connection, for which resolving DNS is the first step. This CL refactors the origin prober to make that first step possible. Bug: 1115731 Change-Id: I67cb45d707a608770954e56f7e3688c1e49a4372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356267 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/2c4978fa890c..d2bf0ba74c74 $ git log 2c4978fa8..d2bf0ba74 --date=short --no-merges --format='%ad %ae %s' 2020-08-14 fayang Log ping_received_delay in transport_connection_stats. Logging only, not protected. 2020-08-13 renjietang Do not send out MAX_PUSH_ID frame if the client sets max_push_id to 0(default value). 2020-08-13 fayang Add has_ack to QuicTransmissionInfo. Currently, only used for logging purpose, not protected. 2020-08-13 wub Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src OnPingFrame interface change R=dschinazi@chromium.org Change-Id: Idc7ec023e867d62957826dc3036fbd07e2549a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354165 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798374}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib80097142907d51210013bfe4b597813fb9f77bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358170Reviewed-by:
-
Mark Pearson authored
This cleans up the entries that should've been removed with https://chromium-review.googlesource.com/c/chromium/src/+/2341945 The only one left being is LINUX. Bug: 757605 Change-Id: If1b7f8347cf453b2e0937e01b569fb4b6baaf4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357933 Commit-Queue: Mark Pearson <mpearson@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798372}
-
Roman Aleksandrov authored
New time left estimation estimatites time user needs to wait for end of update process. Bug: 1111814 Change-Id: Ie2f10c554d5695c25e160b12bbeaea15efca8b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332443 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798371}
-
Miyoung Shin authored
This CL is parameterizing the Java bridge instrumentation tests to run with and without using Mojo in JavascriptInjector, running all the relevant tests and using JavaBridgeActivityTestRule#MojoTestParams for the ones that pass and JavaBridgeActivityTestRule#LegacyTestParams for the ones that fails. So, all tests still run for the old codepath. Bug: 1105928 Change-Id: Idb3ee3ed4d1cb49fa0fc37d7609ac2e8ef166177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348488Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#798370}
-
Xiaocheng Hu authored
The function decides whether we should update layout for getComputedStyle().getPropertyValue("block/inline-size") on an element, and it incorrectly returns false on SVG elements. This patch fixes it. Note: This patch makes the function identical to Width/Height::IsLayoutDependent(). Bug: 1115887 Change-Id: Ieb628e2e81ce02d95ac8a41a04b3aaa96d532829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354625 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798369}
-
Tommy Steimel authored
This CL adds two new methods to the KaleidoscopeDataProvider API which allow the page to query whether or not to show the first run experience and to tell the browser when first run is successfully completed. Bug: b:154517281 Change-Id: I18bafb0239b86384e42d45078b2184d8ed5d911b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354460Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798368}
-
Jesse Schettler authored
The SWA uses a temporary icon and is hidden behind a feature flag that is disabled by default. Bug: 1059779 Change-Id: I9cee9b2de42a49285a8ee5ba2877d6394a7ca5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348539 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798367}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: If38541941c0cf90f9947642d208bd16bd820a719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357515Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#798366}
-
Muyao Xu authored
This CL adds a mojo::Remote<mojom::Logger> in CastAppDiscoveryService to log unavailable (app_id, sink_id) pairs and socket not found errors. Bug: 687380, b/154273698 Change-Id: Ie284e9cb6bb06cd80b33826ca7bbe73fe2539eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347369 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#798365}
-
Renjie Tang authored
Change-Id: I661490736205537e9389cd5f7c1d029faff6f29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357132 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
Becca Hughes authored
Fixes a DCHECK crash where the MetaTable has already been created and we try to reuse it for the new DB. Change-Id: Ib1b0a96ae4a65fa606872cb10ad3f5183ee02558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357750Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#798363}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..a3fcf2574157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3212aef3679363229ba07dbb854accf2cb6fda9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357557Reviewed-by:
-
Wan-Teh Chang authored
Fix the ImageDecoderTest.CanDecodeType test failure when the AVIF feature is disabled. The ImageDecoderExternal::canDecodeType() method ultimately depends on what is added to image_types_ in the MimeUtil constructor: MimeUtil::MimeUtil() { ... for (const char* type : kSupportedImageTypes) image_types_.insert(type); #if BUILDFLAG(ENABLE_AV1_DECODER) ... if (base::FeatureList::IsEnabled(features::kAVIF)) image_types_.insert("image/avif"); #endif So the return value of ImageDecoderExternal::canDecodeType("image/avif") should match base::FeatureList::IsEnabled(features::kAVIF). Test: blink_unittests --enable-features=AVIF \ --gtest_filter=ImageDecoderTest.CanDecodeType blink_unittests --disable-features=AVIF \ --gtest_filter=ImageDecoderTest.CanDecodeType Bug: 1116502 Change-Id: Idb5a13f5cc4e78c0d9671b7460601a412936bec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357961Reviewed-by:Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3fcf2574157..22e7f7a0d7d7 2020-08-14 fmayer@google.com Merge changes Iaec38c7f,Ie21b649d,If460143b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1f1402520959c1ea9fdd85e6b4a21e73704120e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357555Reviewed-by:
-
Chase Phillips authored
This change relands the probabilistic corruption recovery feature that we previously had in our AppCache update job loading path. The goal with this change is to allow us to resolve corruption in some AppCaches without needing larger changes throughout the AppCache code. This was cherry picked (with merge conflicts resolved) from https://crrev.com/c/1869122 / commit 8c09070f. Bug: 1033703 Change-Id: Ib2a5dc70d3f64aad7e39461d8e0c888cd464b66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350188 Commit-Queue: Chase Phillips <cmp@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#798359}
-
Yuke Liao authored
This CL makes unit_tests to run in non-experimental mode so that it's Sheriffed and can run on CQ by default. Bug: 1116180 Change-Id: Id3b5554352eb52bb7ef7ab289ba805f6a5683ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357674Reviewed-by:
-
Joel Riley authored
This is needed as a first step to preserve grouping information for text nodes within an SVG. Grouping information will help Select-to-Speak properly re-order text nodes within an SVG to match a natural reading order. AX-Relnotes: n/a R=dmazzoni@chromium.org Bug: 892822 Change-Id: I29ad9db045df95fef0acb1a5bab5aa9337911211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352614Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#798357}
-
Peter Boström authored
Replaces methods like DialogModel::OnButtonPressed() with DialogModelButton::OnPressed(), so that those calls from DialogModelHost don't have to go through DialogModel. This also makes the callback for DialogModelButton mandatory and removes it from Params. The dialog buttons OK and Cancel are the exceptions that don't need one and use a NOTREACHED() lambda. The change also adds util::PassKey<DialogModelHost> to additional DialogModelField methods to narrow the public API from methods that are unnecessary for public consumption. Bug: 1106422 Change-Id: I8f50e1ce48b2862fce3be5054d6c788c41846f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354637 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
My Nguyen authored
Add the input methods list. The functions and tests are mostly carried over from os_languages_page. Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/5af70811-07e6-4ff3-bc1d-5fdfcd872d7c Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ib110db9290d27eacba6578a153843d6c93b67a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352452 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798355}
-
Ben Pastene authored
This reverts commit 72e0b5bb. Reason for revert: xenial builderless pool now has some idle bots Traffics back down; should be fine to re-enable experiments. Original change's description: > infra: Remove all CQ experiments while the CQ is overloaded. > > A small attempt at reducing overall traffic to various pools. > > Bug: 1116532 > Change-Id: I9c36e08a9babfa4a69d62bb246950ae48890e94c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357412 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798233} TBR=estaab@chromium.org,bpastene@chromium.org,gbeaty@chromium.org Change-Id: I1862724f7be1991b7545bd9ccf16c92f18e28394 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357466Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798354}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8b07b9f55a73..43f49b4d52a4 2020-08-14 herb@google.com static routines for direct map vertices 2020-08-14 herb@google.com signal no clipping required 2020-08-14 egdaniel@google.com Add support for vulkan non coherent advanced blends. 2020-08-14 mtklein@google.com Reland "move conditions for JIT into SkVM.h" 2020-08-14 egdaniel@google.com Support making a VkRenderPasses with self dependencies. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ia278650db6d9ea83d85623701d1edb3047d733c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357417Reviewed-by:
-
