- 03 Feb, 2020 40 commits
-
-
Manu Cornet authored
After the recently added getters for shelf components (nav widget, hotseat, status area) on the |Shelf| object itself (to make it clearer that they play a similar role to the |ShelfWidget|, reduce the chain of accessors to get those instances in a bunch of cases. Change-Id: Iabdbef446b3c3a70046eea957858a0cb0b323bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036651Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#737952}
-
yilkal authored
This CL ensures that chrome and web apps have a shared time limit against which to count their time usage. Bug: 1034551 Change-Id: Ia6b647dc8e5151dd95ddeeb96b29c9791ba1ce1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033848 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#737951}
-
Justin Cohen authored
2fd16e339294 Reformat all gn files 6c0f5ccaa872 Add NewReport::Reader to read back new reports 23a2da5e9558 [fuchsia] Only add fdio config if it's not already present 77baffaf931b Add iOS gn configs f36f46d1ec95 Roll crashpad/third_party/mini_chromium/mini_chromium/ 0512d4269..f58366399 (1 commit) 915862984c1e [log minidump] add option to log minidump in handler_main 75ea787a80c7 Adds plumbing for xcuitests with a placeholder test 3b007333a0fa Roll crashpad/third_party/mini_chromium/mini_chromium/ f58366399..0a3a80b04 (2 commits) 39116ab7230c Adds support for running iOS unittests via XCTest 46ad005e9265 Updates run_tests.py to support testing on iOS e386d703d60d Fix typo in handler_main 39a319d6a7a9 Roll buildtools/ 3e50219fc..62f9eb0d6 (8 commits) 56ec176fda7f Fix Chromium checkperms.py has shebang but not executable bit error Change-Id: Ib34dbb8f7ad08f7dcd122551b93d820fc74fb668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036398Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737950}
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/29324b698ccd..7835fcd45668 $ git log 29324b698..7835fcd45 --date=short --no-merges --format='%ad %ae %s' 2020-02-03 mfoltz [Cast Extension] Update files.gni. 2020-01-31 mfoltz [Media Router] Convert external_message_listener to use sender.origin. 2020-01-13 mfoltz Remove DIAL MRP 2020-01-07 mfoltz [MR extension] Lower the severity of provideSinks(): provider not found error 2020-01-06 mfoltz Add explicit '!' for non-null types as required by http://go/js-nullability 2019-12-04 mfoltz Delete invalid goog.provide'd namespace initialization 2019-11-27 mfoltz Don't load disabled extension MediaRouteProviders 2019-10-29 mfoltz Fix typo in unit_test_utils.js. 2019-10-09 mfoltz Fix or suppress upcoming JSCompiler type errors 2019-09-09 mfoltz Removed obsolete "cloud on" setting. 2019-09-05 mfoltz Removed log spam related to Weave being unavailable. 2019-09-05 mfoltz Re-ran genjsdeps. 2019-07-25 mfoltz [Media Router] Log finch experiments to feedback PSDs 2019-07-12 mfoltz Modify route creation metrics in extension DIAL MRP 2019-06-28 mfoltz [Mirroring Service] Remove audio checkbox from desktop picker 2019-06-21 mfoltz Make Media Router component extension tests support Jasmine 3 2019-06-18 mfoltz [MR extension] Don't call chooseDesktopMedia() with a tab ID 2019-06-10 mfoltz [Media Router component extension] Log feature states in feedback logs 2019-05-25 mfoltz [Media Router] Revise capture resolution selection algorithm. 2019-05-14 mfoltz Record MediaRouter.Dial.ParseMessage in DialProviderWrapper 2019-05-02 mfoltz Update metrics collection in DIAL MRP 2019-05-02 mfoltz Fix MirrorMediaStream test failure where mediaDevices is not defined 2019-04-18 mfoltz Fix a crash in mr.mirror.Session's constructor 2019-04-17 mfoltz Disable Adaptive Latency for Cast Mirroring. There are audio bugs caused by this feature. 2019-04-15 mfoltz Set route description in the ctor of mr.mirror.Session 2019-02-22 mfoltz Ads classes for the Web Sender 2019-01-08 mfoltz Fixes various potential XSS vulnerabilities in the MR extension. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src R=takumif@chromium.org Bug: 1047285 Change-Id: Ic02e060e44323be3b44a86fcc3a84f7e43b60683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036436Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737949}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I4c8779a19ca85b78dd378ef3afb999c414ecf493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036439Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737948}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23e2ad174cfa..bf3087f65d6a git log 23e2ad174cfa..bf3087f65d6a --date=short --first-parent --format='%ad %ae %s' 2020-02-03 reed@google.com add skvm for tablecolorfilter 2020-02-03 mtklein@google.com impl gather8/gather16 with gather32 2020-02-03 bsalomon@google.com Choose a less evil scale factor texel_subset_nearest_upscale decal tests 2020-02-03 fmalita@chromium.org [skottie] Cleanup: finalize adapter conversion 2020-02-03 mtklein@google.com test premul/unpremul are no-ops when a==1.0f Created with: gclient setdep -r src/third_party/skia@bf3087f65d6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I0b405fd78d342e8db87fa0af21bbd8dcb26d6747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737947}
-
Andrew Grieve authored
Advantages to having it live under //android_deps: * Maven version constraints are checked when resolving deps * Consistency / ease of future updates Bug: None Change-Id: I715f0a00b88268556ff533e89ffa42ec6ebfb66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035868 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#737946}
-
Andres Calderon Jaramillo authored
This CL creates a fuzzer for media::VaapiJpegDecoder. This component exposes an interface that takes raw JPEG data and uses libva to decode it using the hardware. Unfortunately, this interface is too simple: most fuzzing inputs will probably be invalid because they will fail at the parsing stage even before getting to libva. This is not useful because we already have a fuzzer for the media::JpegParser. Instead, we make this fuzzer more structure-aware so that we can inject more diverse inputs into the driver and exercise more code paths. The rationale is that the driver should fail cleanly on invalid inputs. To accomplish this, this CL: 1) Extracts the libva-poking functionality of the VaapiJpegDecoder into two private methods: MaybeCreateSurface() and SubmitBuffers(). 2) Defines a protobuf that mirrors the structure of the parameters of these two methods. 3) Uses libprotobuf-mutator to generate structured data that can be directly converted into the input for the two methods above. Bug: 1028051,1034357 Test: ./vaapi_jpeg_decoder_fuzzertest pixel-1280x720.textproto on sarien Change-Id: I9a1c957558d05343bdc0f371cd68adb2975ad7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967203Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737945}
-
Mugdha Lakhani authored
UrlBarControllerImpl will now call into the native counterpart to get the formatted URL to be displayed. This reuses Omnibox code from //components Bug: 1025607 Change-Id: I57005c4940b5deec0d92f094ee65e36f6dc6851b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023787Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#737944}
-
Peng Huang authored
With low end device mode, the android surface control should be disabled. Fix the problem by following GpuPreferences to enable or disable android surface control with Vulkan. Bug: 1033170 Change-Id: I1887be2cac0d17b3213c9271893b68b8bdfe35b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036403 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#737943}
-
yilkal authored
This is a reland of db4b7168 Original change's description: > Adds WebTimeActivityProvider. > > This CL adds WebTimeActivityProvider which is > BrowserListObserver, a TabStripModelObserver, > AppServiceWrapper::EventListener, and > WebTimeNavigationObserver::EventListener. It is hosted > in AppTimeController. > > The instance of this class observes > the TabStripModel of each Browser in BrowserList. It also > observes the WebTimeNavigationObserver instances of each WebContent > hosted in each Browser window. The instance also observes > AppServiceWrapper to learn about the activation/deactivation of > chrome application windows. > > WebTimeActivityProvider informs its observers when Chrome becomes > Active, Active with whitelisted content or inactive. > > Bug: 1034551 > Change-Id: I7d7dd3624ea4fb764c13e35f0ef542759cee8933 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020522 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737492} Bug: 1034551 Change-Id: I2109b4df2600f9796b593767a2ea5f3e197393a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035863Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737942}
-
Matt Menke authored
Bug: 1035887 Change-Id: If99ff578ad31f6dbd180041fe8b1b0623ef26569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033571Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737941}
-
Tao Bai authored
Bug: 1042048 Change-Id: I73ce0bbbc10eb54a9e602ff638e1c3ec49421715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033844 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737940}
-
Lukasz Anforowicz authored
In some scenarios (e.g. http range requests for linearized PDFs) the PDF plugin may need to initiate requests on behalf of the PDF's origin. Such requests are currently proxied by the renderer process hosting the plugin (i.e. the renderer hosting the PDF extension - mhjfbmdgcfjbbpaeojofohoefgiehjai) and therefore go through URLLoaderFactory that is locked via request_initiator_site_lock to a different origin (i.e. the origin of the PDF extension, rather than the origin of the website that hosts the PDF file). Before this CL, such requests would be classified by CorsURLLoaderFactory::IsSane and VerifyRequestInitiatorLockWithPluginCheck as incorrect and possibly malicious. After this CL, the request_initiator checks are relaxed by PluginServiceImpl::FindOrStartPpapiPluginProcess using a new mechanism similar to AddCorbExceptionForPlugin exemption available for Flash. We don't want to relax request_initiator_site_lock checks for renderer processes hosting arbitrary origins from the web, so as a defense-in-depth the CL adds a CHECK to FindOrStartPpapiPluginProcess that verifies the origin lock of the renderer process that is granted the extra capabilities. Relevant tests: - ChromeFindRequestManagerTest.FindInChunkedPDF (tests that range request do not result in a request initiator lock mismatch) - PDFExtensionTest.EnsureInternalPluginDisabled (tests that the PDF plugin may only be embedded in trustworthy contexts) - PDFExtensionTest.RedirectsFailInPlugin (the 'noRedirectsSucceed' testcase tests non-range requests initiated by the PDF plugin) Bug: 1027173b Tbr: creis@chromium.org Tbr: nasko@chromium.org Tbr: yhirano@chromium.org Change-Id: I9a8f284a8927b1230c5088f8c46aca118e934c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036558Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737939}
-
jonross authored
We temporarily converted non_skia_renderer_swiftshader_blink_web_tests into a skia_renderer_swiftshader_blink_web_tests while we fixed some issues with the default baselines for SkiaRenderer on Linux: https://chromium-review.googlesource.com/c/chromium/src/+/1989866 We have now landed all the updated rebaselines, and SkiaRenderer is once again the default for blink_web_tests on Linux. This change is to convert the modified test suite back to being non-SkiaRenderer so that we have some testing of the off-state while Finch trials are on-going. As a part of that the original non-SkiaRenderer baselines (from before the patch list above) have been copied into the flag-specific folder for this test suite. TEST=non_skia_renderer_swiftshader_blink_web_tests Bug: 1039401 Change-Id: I25d7ff5eeebb65c16689811247e001b6f5c3e612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015778Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#737938}
-
David Black authored
Bug: b:148080975 Change-Id: I538b8b2af8cd4df5e7efc276b769c8009c942006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036351Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#737937}
-
Mark Schillaci authored
This CL addresses issues with complex structures nested inside links on Android. We now never consider a link as a leaf node to ensure that the entire structure is traversable. We update the method IsInterestingOnAndroid to make simple cases un-interesting to prevent double navigation issues. We also change the AccessibilityNodeInfo passed to TalkBack to prevent structure from being too verbose when read. Unit test expectations updated to account for change. Bug: 1018555 Change-Id: I0b0d60f0ec69f400023c21ad92f3fbe69f08d378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955098 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737936}
-
Filip Gorski authored
TBR=wychen@chromium.org Bug: 1048268 Change-Id: I2f2f9ea2bcc22e83a5ff7d208a137752fd873d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036404 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#737935}
-
Ehimare Okoyomon authored
Put all common cookie controls methods into a service so android can use these as well. Then move the web-specific support to new CookieControlsHandler that implements the web version. Bug: 1040091 Change-Id: I422664a2d8e11e94cb4102c5cb8aa4494f83db3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019109 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#737934}
-
Orin Jaworski authored
This CL triggers keyword search mode when the keyword button is pressed on the button row. The button label is taken from SelectedKeywordView, which is refactored slightly to expose internationalized label names. The refactor also eliminates persistent member |profile_| because it is only used in one place where a parameter suffices. Bug: 1046523 Change-Id: Ifb0c0d14059cfb4d866b04d2c63cb97796713024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033907 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#737933}
-
Miriam Zimmerman authored
BUG=N/A TEST=N/A Change-Id: Id28dc53a9265fba56f1cd1b9a6879a1208b55ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036650Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#737932}
-
Victor Fei authored
Refactored AXTree::PopulateOrderedSetItems, which is used for computing set size and position in set, to make it more straight forward. I made no change in the actual algorithm. This change is needed to prepare for various tasks for exposing PosInSet and SetSize for various elements Change-Id: I2d4883bd5e3132ebbed721abb547bc24f5be0f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020544Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737931}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences direct Bug: 1022108 Change-Id: I5bd6ce1ac802ff3a77e2173fdaf51226ee89702d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033629Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#737930}
-
Jinsuk Kim authored
This CL increases margin between the tiel and RHS icon in preview tab. Bug: 1047890 Change-Id: I96fcbd68b25a467c13a525d94c17976184812959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032699Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737929}
-
Natalie Chouinard authored
This reverts commit 359bdf76. Reason for revert: Proguard removes fragments in release mode Original change's description: > [Settings Refactor] Move autofill settings > > Move autofill settings alongside autofill code. > > Bug: 1047357 > Change-Id: Id5679d4392e23cff775dfcefa41930af9ab0f602 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031538 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737874} TBR=rouslan@chromium.org,twellington@chromium.org,chouinard@chromium.org Change-Id: I56bcf1ea3cdb276ee18d242ab858531f8081d673 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036635Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737928}
-
Vasiliy Telezhnikov authored
When the surface is not in current frame, but was in previous we set buffer for it to nullptr to get release fences. Sometimes it leads to flickering black. This CL sets visibility for those surfaces to fix it. Bug: 1046792 Change-Id: I5b1324e2dd9f217724a3980181ccd42aba2e4098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035299Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#737927}
-
Eugene But authored
Bug: 1048256 Change-Id: I5ae4d08216fb0b7cbce03efa692252a755ffd307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036557 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#737926}
-
Colin Blundell authored
This CL changes WebLayer to use the //components/security_interstitials SSLErrorHandler that is used by //chrome rather than the custom fork that it has been using to date. As part of this change, WebLayerSecurityBlockingPageFactory is augmented to create the blocking page types that were not necessary before (as they were never created in the fork). With this change, WebLayer now shares the core logic for determining which interstitial to show on SSL errors with Chrome. Bug: 1030692 Change-Id: Ibd1dadb9d03937cf578fd785ae4b32c943283749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028068 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#737925}
-
John Williams authored
This change potentially has some privacy implications, but the relevant people agreed it's not a problem and doesn't require a formal review. My original email asking if I need a review is included below: I have a very small Chrome change I'd like to land that might be considered privacy-sensitive, but it's so small I'm not sure a full review is warranted. The change I want to make is to the desktop picker dialog that appears when you use the "Cast..." feature to project your desktop to another device. Currently, when you choose the "Cast desktop" option and click a device to cast to, a dialog appears asking what you'd like to share. In the typical usage of this dialog, the user can choose the whole screen (or potentially one of multiple screens), or an application window. In the case of casting, on every platform except Linux, the only option is to cast a screen, and in the typical case where the user only has a single screen, the dialog feels like an unnecessary step in what is already a multi-step process, so I'd like to bypass it entirely in that case. The privacy concern is that even when there is only one option for the user to pick, the dialog still serves the purpose of making the user aware they're about to share the contents of their screen and gives them a chance to prevent it from happening. This seems like a genuine concern in the original use case of the dialog, which can be opened from third-party JavaScript code through the chrome.desktopCapture.chooseDesktopMedia function and used to send the resulting video stream to an arbitrary destination. In the case of casting, the dialog is opened by C++ code in Chrome itself only after the user has gone through the following steps: - Open the Cast dialog, either from the right-click menu, the Cast icon in the toolbar, or a Cast icon embedded in a page that uses the Cast API. - Click the "Sources" button at the bottom of the dialog. - Choose "Cast desktop" from the menu. - Click on a Cast receiver (e.g. a Chromecast on the LAN) in the Cast dialog. This, to me, seems like more than enough to ensure that a user really does intend to broadcast their screen, and the final two steps of clicking a thumbnail of the screen and then clicking "Share" are entirely redundant. Finally, there are a few points I'd like to clarify. First, I only want to expose the ability to bypass the dialog to native code, not the JavaScript API. The current version of the Cast dialog invokes the desktop picker from JavaScript code, but we're moving to an all-native implementation. Second, even though the Cast dialog can be opened from third-party code embedded in a web site, if the user chooses "Cast desktop" from the dialog, nothing that happens afterward involves any third-party code. (That seems pretty confusing from a UX standpoint, but harmless w.r.t. privacy.) Finally, I only want to bypass the dialog in the case where the user only has a single screen, so there's no possible confusion about which screen will be shared. Bug: 637643 Change-Id: I07784aacd0e0fa6b4ea35378535e1e237fb8c57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032088Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#737924}
-
Daniel Rubery authored
This CL makes all call sites explicitly indicate which scans are allowed to be performed. Change-Id: I5f0211594de3d48b8c45f15f260461f298088bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032016 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737923}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, when a device had an end of life (EOL) date set, we would show a message in the future tense telling the user when the EOL date would occur. This was confusing if the device had already passed the EOL date, since that date should have been in the past tense. This CL adds a new, past-tense string and displays it when appropriate. Fixed: 1045687 Change-Id: I09c17a00a2c67fda505feabd30d216a09e5e25e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033342Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#737922}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78f5b92a0b6b..6da434932c2e git log 78f5b92a0b6b..6da434932c2e --date=short --first-parent --format='%ad %ae %s' 2020-02-03 lalitm@google.com Merge "tp: make sql value accessors const" 2020-02-03 treehugger-gerrit@google.com Merge "processor: Allow fallback to tid/pid_overrides for new-style TrackEvents" Created with: gclient setdep -r src/third_party/perfetto@6da434932c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f884db17da20abbcf54130a42db553fb12de4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737921}
-
Daniel Nicoara authored
Simplify the resizing logic. We're only supposed to be resized by the embedder, so only resize when we're told to. This way we no longer need to worry about the case when a WebContents is embedded inside another WebContents as there's no size updates on the main one. Bug: b/147376354 b/148398442 Test: Verified resizes are applied to the EXO surface. Change-Id: I70d2578bfe91018680b052af3dccf698c5303c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032201Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#737920}
-
Ana Salazar authored
Sets the height of the arrow button to match the bounds of the other shelf buttons to place the tooltip at the same height. Bug: 1043009 Change-Id: I7c83a825c41a5378eefc520023dcc25e6e25de64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033821Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#737919}
-
Avi Drissman authored
This reverts commit 50cf1bfe. Reason for revert: give people time to update Original change's description: > Require the 10.15 SDK to build Chromium. > > BUG=1023913 > > Change-Id: Ibd15e2c76413639c0caf8d1d255add07a815bcdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033986 > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737904} TBR=avi@chromium.org,rsesek@chromium.org Change-Id: I38a384dcec4cfca06a4de27e20a9c52d78e5dfea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036378Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737918}
-
Avi Drissman authored
This reverts commit 2a99fe61. Reason for revert: going to give people some leeway Original change's description: > Update documentation for requiring the 10.15 SDK. > > BUG=1023913 > > Change-Id: Ib92e5904843229f4e4d1d1fb2cdfa12cfb8db54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032077 > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737908} TBR=ellyjones@chromium.org,avi@chromium.org Change-Id: I647d4d86ed348608251f5b3b3d2fb07bb43040a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036633Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737917}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/522a6a0e..43c981c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id997a7f457f487cbab2a95de23f6f10bd0453693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035721Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737916}
-
Andrew Luo authored
Change-Id: I1a7c3150565a92624a6b4042b5cee296fbb1486c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035067Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737915}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. The usage in AccountManager code isn't related to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. on enrolled device, see screen/v3dTEPoVGyg Bug: 1042400 Test: updated existing browser_test Test: Account manager WebUI shows correct domain for primary account Change-Id: Ied51c6aec99b34436a8c308a1ab0d2a569e00a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031642 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737914}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db9ce1e03ccc..ba64534cd9d9 Created with: gclient setdep -r src-internal@ba64534cd9d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045987 Tbr: jbudorick@google.com Change-Id: Iea79598ca0d1dfed62de797f1f0ee1bf4e5455c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737913}
-