- 25 Feb, 2020 40 commits
-
-
Gauthier Ambard authored
This CL make sure that the existing test will be passing once BVC is contained instead of presented. Bug: 1038034 Change-Id: I5f1afda124e5aaa6ed4e76191737b18302b1f511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070161 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744261}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie72c3a3e8525590e9b4035b4b0ca44f159dcd0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744260}
-
Andrew Solovey authored
Chrome OS Account Manager's UI does not automatically refresh itself for newly unauthenticated accounts. This makes re-auth inconvenient for users who may have Account Manager's UI already open and will not see a re-auth button for newly unauthenticated accounts. Observe |signin::IdentityManager::Observer:: OnErrorStateOfRefreshTokenUpdatedForAccount| to refresh accounts settings UI. R=sinhak@chromium.org Bug: 1053993 Change-Id: Ia1558e67eeb781f9a011ffd4503f3eca007dc867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066761 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#744259}
-
Dave Tapuska authored
This will allow us to move some methods to WebFrameWidget that don't really belong on the WebWidget. Change-Id: I1b04bbb638a9d0f089ab85748e6445e7c148af00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070835Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#744258}
-
Vadym Doroshenko authored
Before this CL, if a field contains value X, and Password Manager wants to fill the same value X, Password Manager sets this field in the state Autofilled. Setting the field to be autofilled is not necessary, since it doesn't add new information. Moreover it destroys information, that this information came from website, not from Password Manager. This CL makes Password Manager skips setting such field in Autofill mode. More details how it breaks accounts.google.com on the bug. Bug: 1055275 Change-Id: I741ec23b7947c3322fe719b256d94f7c00dd3a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072178 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#744257}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4dc19c38c0c5..aa09ca69e417 git log 4dc19c38c0c5..aa09ca69e417 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 jmadill@chromium.org Vulkan: Update ContextVk command buffer access methods. Created with: gclient setdep -r src/third_party/angle@aa09ca69e417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I210534a9899c7c268a2bf612887ceb65697ebefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072297Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/585ded41b502..384e239655c4 git log 585ded41b502..384e239655c4 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@384e239655c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic897e6f7b22195e9d4b49ab04d2307b00a6fcb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072156Reviewed-by:
-
Mythri A authored
Google earth is now using a WASM version and hence the old version is no longer very useful as a representative of real world. This story is also flaky on certain platforms. Bug: chromium:1050636 Change-Id: If53246f9722030c6afe07150a55c7415a7282c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061809 Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744254}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b3a779a2a6e..b5cd962aec5d Created with: gclient setdep -r src-internal@b5cd962aec5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5cf24ba66d0580a8e45b9deb7a99a22144d175f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072153Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744253}
-
Ramin Halavati authored
Nicolas is currently the most up to date expert on this folder. Change-Id: I94f5abbcd27ab8f4e424ceecb52c406e0b205c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071935Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#744252}
-
Anton Bikineev authored
This fixes DCHECK crashes in IncrementalMarkingStart: DCHECK(!IsGCForbidden()); Bug: 1035962 Change-Id: I240d838106b22be123c3150e098329141ebfb9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072240Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#744251}
-
Anatoliy Potapchuk authored
The test was flaky in the race condition when we were trying to perform a user exit, while creating a new user. It is fixed here https://crrev.com/c/2066717. Bug: 964333 Change-Id: I124c48c1c7d55b69ae9c998a34ffed796207134c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070410Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744250}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad7552d17891..b9ee1cfe480f git log ad7552d17891..b9ee1cfe480f --date=short --first-parent --format='%ad %ae %s' 2020-02-25 taylori@google.com Merge changes Ie224e1d2,I1350517d,Ie4b5c91e Created with: gclient setdep -r src/third_party/perfetto@b9ee1cfe480f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I81cf8a92044b0dc9a3582c69ef7fab736b088c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072154Reviewed-by:
-
Aya ElAttar authored
chrome://management Bug: 888981 Change-Id: I2f645d9bda7e28e93d47994ed839b2bcbde2b8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041666 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 1039697 Change-Id: Ied0f97df085594347a8e404b91c00f8ba0933690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071697 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#744247}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0434e293..156331ab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a18cda451ae457e10edf51488105086e8b11284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070867Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744246}
-
Courtney Edwards authored
At the moment -debug-info-kind=constructor is unsupported by xcode clang. Error example: error: invalid value 'constructor' in '-debug-info-kind=constructor' https://ci.chromium.org/p/webrtc/builders/ci/iOS%20API%20Framework%20Builder/16174 Bug: 1050118 Change-Id: Iff98ca1d830e6280b3dcb38362fb8351e9336cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072238Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Courtney Edwards <courtneyfe@chromium.org> Cr-Commit-Position: refs/heads/master@{#744245}
-
Eric Boren authored
I don't think this is being used any more. Change-Id: Ia24dbd35d86613872048da520db151ba527e9d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070596Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Boren <borenet@google.com> Cr-Commit-Position: refs/heads/master@{#744244}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/fa147af4a525..5b1a37af5633 git log fa147af4a525..5b1a37af5633 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 drott@chromium.org Fix for CFF space glyph regression (#57541). Created with: gclient setdep -r src/third_party/freetype/src@5b1a37af5633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: 1054371 Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I9ae22cc93d8d54fbe0341a3c655523e459da3200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072147Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Alex Chau authored
- Remove SharingUseDeviceInfo flag everywhere - Clean up of backward compatibility code will be done separately Bug: 1050189 Change-Id: I85cb689f23a0cacaa6d665b936f48b9bd100f89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066902 Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744242}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8910ea5f1c7b..fb6e3e48d51d git log 8910ea5f1c7b..fb6e3e48d51d --date=short --first-parent --format='%ad %ae %s' 2020-02-25 geofflang@google.com Combine extinst-name and extinst-output-base into one arg. (#3200) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fb6e3e48d51d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Ifd46d332ad5a43e6d4d22df3fd78ac51a492dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071899Reviewed-by:
-
Jose Lopes authored
All these callbacks correspond to events in the EME spec which can be fired repeatedly: https://www.w3.org/TR/encrypted-media/ Documentation: * https://cs.chromium.org/chromium/src/media/base/content_decryption_module.h?rcl=f78bd037011b88c648d5c46ffa5031295ac2cc61&l=186 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I0a3c09125eb1013271db70c0ff58168115c89dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054084 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744240}
-
Side Yilmaz authored
incognito. This CL update the profile passing to HelpAndFeedback activity from AssistantCoordinator. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. Therefore, this CL receives profile object(i.e., regular or off-the-record profile) from active tab in AssistantCoordinator. Bug: 1041781 Change-Id: I2a33594067fb6639307035970ab17069a38fcff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062333Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744239}
-
Simon Que authored
Bug: 726475 Change-Id: I0494eea41f2ff9b6f555bed3bdc43613cc7a470d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059693Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#744238}
-
Olya Kalitova authored
Clearing preference with container configuration state in Crostini remover so when Crostini is reinstalled after removal it would be considered not yet configured. Test: none Bug: 1055503 Change-Id: Ibb83d2c1fc928a9816575f57437f6ce88d34832c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069335Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#744237}
-
Jose Lopes authored
This callback sometimes is called as a once callback (i.e., one-shot) and sometimes as a repeated callback, as shown in the following location: * https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?rcl=29f314a3cb94a50602cc2231553db3230c892d45&l=2655 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I96446bd9a150f68132e891c50a79c711e8931993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051275 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b7de61aa0e6..585ded41b502 git log 1b7de61aa0e6..585ded41b502 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 wolfi@chromium.org Revert "Use 1000 not 1024 for kB and MB calculations" Created with: gclient setdep -r src/third_party/devtools-frontend/src@585ded41b502 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifdf6f0500ddeee297f8dd901a32af9c30056f360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072139Reviewed-by:
-
Aya ElAttar authored
As per discussion through DD: - Added a flag to extensions API permissions to denote if it should trigger a warning or not - Added a function to ManifestPermissions to mimic API permissions; if they should trigger a warning or not Bug: 888981 Change-Id: I61567c4efbddf665c82137b5308f05ba1459c8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038774 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92a7efd95625..3b3a779a2a6e Created with: gclient setdep -r src-internal@3b3a779a2a6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0f72590ea8883651cfdaa246f874bdfa9ba5ccb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071903Reviewed-by:
-
Daniel Vogelheim authored
We're currently using union types for Trusted Types checks. We currently only provide String overloads for the cases where we need them. This adds an overload for ScriptURL, to prepare for upcoming changes to remove the union types. Bug: 1043136 Change-Id: I0ed192aa9bc1ee7a5dc01fa38ee98d6d6843d407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066730Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#744232}
-
chrome://media-appTrent Apted authored
The actual fix is just to add `allow="fullscreen"` to the guest <iframe>, but we want to ensure we're setup for testing things like this. The Mock app_main.js is updated to support mock loading of videos as well as images, and the test message API is updated with a mechanism to pass a command (i.e. to invoke <element>.requestFullscreen()`). language_in=ECMASCRIPT_2018 is added to typechecking flags to permit use of the {...spread} operator. The test case tickles a DCHECK in Blink's layout logic (crbug.com/1052791). A neat enough workaround for that is to remove the `overflow: hidden` style from the main frame before attempting to fullscreen a video element. The DCHECK is hit in manual interaction as well, but seems to be innocuous when DCHECKs are disabled. Bug: chromium:1052791, b/146459531 Change-Id: I234a82b2c33d238252815d80da14b7cc1e106a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055951 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#744231}
-
Colin Blundell authored
With this class having been componentized it no longer makes sense to have "Chrome" in its name. After discussion we decided on "Stateful" to replace "Chrome", as the key difference between this class and the default //content-level SSLHostStateDelegate is that this class retains state about the user's discussions on proceeding past SSL errors. Bug: 1030692 Change-Id: I8271ef4b19a2cbf9862f818c42aa8978b022e725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066906 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#744230}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1247e7af. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" ea6dba31 "Align <pattern> and <*Gradient> attribute collection" 7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7d606ced7b77655180fc3c0bb58e97da2c106e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071955Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744229}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7bf34d527913..3eb0df2c199c git log 7bf34d527913..3eb0df2c199c --date=short --first-parent --format='%ad %ae %s' 2020-02-25 dberris@chromium.org Pinpoint: Add back change arg for backwards compat Created with: gclient setdep -r src/third_party/catapult@3eb0df2c199c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Ie16e9a4e3d58fed899f6bc56259366023a3dbfb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071901Reviewed-by:
-
David Jean authored
Default implementation returns true. Bug: 1049638 Change-Id: Ibf58f726f1bd3252ae18bf3ec18703a2b69d7097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062209Reviewed-by:
-
Anders Hartvoll Ruud authored
The incoming position needs to be converted to a uint64 before shifting. Otherwise, we lose the top four bits. This led to a bug where matched rule number 4096 would cause crashes, because the rule index is stored in the high 16 bits of the position. We lost four of those bits, and the bigest value we can store with 12 bits is 4095. Bug: 1055043, 1055080 Change-Id: Ifbac439873d4fdd72f6c0e32c9eaf993dece4fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066928Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#744226}
-
Jose Lopes authored
The time source callback is defined in: * https://cs.chromium.org/chromium/src/media/base/time_source.h?rcl=2c5cf4277d1861737c131e556a9137693048f4e3&l=19 It's used as a mechanism for injecting a function that converts timestamps, and can be called repeatedly as shown by the following call sites: * https://cs.chromium.org/chromium/src/media/renderers/video_renderer_impl.cc?rcl=2c5cf4277d1861737c131e556a9137693048f4e3&l=852 * https://cs.chromium.org/chromium/src/media/renderers/video_renderer_impl.cc?rcl=2c5cf4277d1861737c131e556a9137693048f4e3&l=859 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I87b63583307c40a175bf65ef36537d7afedcce11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051991Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#744225}
-
Jose Lopes authored
The callback is defined in: * https://cs.chromium.org/chromium/src/media/base/media_drm_storage.h?rcl=93b74ef636646fe318a62ff163267462e965f4cc&l=102 The callback is used in a factory class, and therefore can be called multiple times: * https://cs.chromium.org/chromium/src/media/base/android/android_cdm_factory.cc?rcl=7c0e3c60bc4ecdff5706afe3b99b22afff1e2d2e&l=85 The evidence that it can be called multiple times is the counter that is incremented every time the factory is called: * https://cs.chromium.org/chromium/src/media/base/android/android_cdm_factory.cc?rcl=7c0e3c60bc4ecdff5706afe3b99b22afff1e2d2e&l=89 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I04d2ffd274b9490bdfc87929d6ff752297f46cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050501Reviewed-by:
-
Gang Wu authored
Change-Id: I135dc9762c13d4fdffc2a3984e94bccf517c27db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069497Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744223}
-
Eriko Kurimoto authored
This CL removes TestExpectation 'Timeout' from shared-worker-import-referrer.html. By checking the recent build, this test no longer seems to timeouts. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=virtual/omt-worker-fetch/external/wpt/workers/modules/shared-worker-import-referrer.html This is fixed by this CL by adding <meta name="timeout" content="long"/> https://chromium-review.googlesource.com/c/chromium/src/+/2055913 Bug: 1049689 Change-Id: I292cec294be402b0f389a230885fefc09a251e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071340Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#744222}
-
