- 11 Sep, 2019 40 commits
-
-
Nina Satragno authored
The welcome screen is no longer used. Slay the zombie code. Bug: 1002590 Change-Id: I0ef7c5e6df668ee3fa383b466ff90fe7c85401cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797803 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#695687}
-
danakj authored
R=avi@chromium.org Change-Id: I37cf7910f88251abb29f550c26e0ef57236527e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798572Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#695686}
-
Ivana Zuzic authored
If an empty password is entered in the password editing activity and someone tries to press save, a message that the password field is required appears and the activity stays open. If everything is ok with the data, the activity closes, for now without actually performing the save. Bug: 377410 Change-Id: I1bc75d3a6c538b9e8c7b819e916d0588b1fb4763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798325 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695685}
-
https://crbug.com/996337.Lucas Gadani authored
This reverts commit d631bcd2. Reason for revert: We have enough data from this dump. Original change's description: > Add DumpWithoutCrashing to debug https://crbug.com/996337. > > Bug: 996337 > Change-Id: I18d8fee2f27842abd3ab48cb5bde90815afba5ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785078 > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694873} TBR=alexmos@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 996337 Change-Id: I8ccca0add4031683153f2407b2c1120bcb05eaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797695Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695684}
-
Vladislav Kuzkokov authored
Declare std::unique_ptr specializations for CUPS in one place. Change-Id: Iffa00a1cfb4167ff4b46fdbffcfd4c367ffe1ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782880 Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695683}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ba1705c6af4..ff060eef97db git log 0ba1705c6af4..ff060eef97db --date=short --no-merges --format='%ad %ae %s' 2019-09-11 yvesg@webrtc.org Disable AudioDeviceTest unittests under sanitizers. Created with: gclient setdep -r src/third_party/webrtc@ff060eef97db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I1e001c0268be517e3db5d395930425abceaa3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695682}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adab81b1. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5f9caba6df22844277b49184ac7e479bdc49e5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798273Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695681}
-
Jonathan Backer authored
Each SkMatrix44::set call calls recomputeTypeMask. By using a batch call we reduce the number of times that this is called. Bug: 974359 Change-Id: If3f31c939da9efc72727af8e8dfa10db46321fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797654Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#695680}
-
Nathan Zabriskie authored
This change adds FrameTokenGenerators to CompositorFrame builders in ClusterFuzz. During normal operation subsequent CompositorFrames are expected to have incremented |frame_token|'s, this change makes fuzzed frames follow that behavior. Bug: 997147 Change-Id: Ib41ac8318bb2c14edfd0d9b51061f3fbde490df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787992Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695679}
-
Peter Boström authored
Fixes regression after refactoring of DownloadItemView where the new view implementation is not focusable (but a subset of its children are). DownloadShelfView returns a DownloadItemView as its first focusable item (totally reasonable), but since the item itself is not focusable we need to forward focus to the open button inside it. I still think it's reasonable to focus an unfocusable item if its children are focusable, so ideally a fix would change ::SetFocusedView to focus the first focusable child (if any) or otherwise clear focus. There's a TODO present inside AccessiblePaneView to address this. Bug: chromium:1000998 Change-Id: I071d1c59401b35f251cd429ae3b5892462f91adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798086Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#695678}
-
Christopher Thompson authored
Bug: 1002687 Change-Id: I7a8801c81e6901d637e771c7a5873f8c49eaa979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797326 Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#695677}
-
Dan Sanders authored
Frame visibility is affected by CSS display while page visibility is not. Bug: 999006 Change-Id: Ia2ee70f6222d88474cea92fd28c8da77269f3a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797131Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695676}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/56df7910b051..120e7d6766e4 git log 56df7910b051..120e7d6766e4 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 bsalomon@google.com Make building in Chrome with base/logging.h included in SkTypes.h work. Created with: gclient setdep -r src/third_party/skia@120e7d6766e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I2f54b859fa5a26b13f5fe2e9aac29035a23c3c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798762Reviewed-by:
-
Daniel Rubery authored
The unconsented primary account is the best notion of profile identity for our purposes, since the additional download warnings do not depend on consenting to Sync. (They are gated behind the Safe Browsing enabled preference). Bug: 917190 Change-Id: I61c1a8d5e47865f61e052ac75de03560e7b52e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793445 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#695674}
-
Steve Kobes authored
This was added to improve performance of the original algorithm. Since we have launched the sweep line algorithm (go/janktrackingsweepline), granularity snapping is no longer used or needed. Bug: 1000716 Change-Id: I3c15b5fa70de04b98802f858438b7dbfc4f16539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791438Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#695673}
-
Matt Falkenhagen authored
Follow-up to r689181. This converts code added since then. Bug: 824858 Change-Id: Ia576dd7ed3bf197771fbf3c94cb16ca74657efcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797953 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695672}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cebb9635a5d5..fccbd75b5718 git log cebb9635a5d5..fccbd75b5718 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 bclayton@google.com Update Marl to 59068ee4 Created with: gclient setdep -r src/third_party/swiftshader@fccbd75b5718 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140546382 Change-Id: I3a9823aaee8ba6c585a6ea5830f7dc27df0041a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797090Reviewed-by:
-
Fernando Serboncini authored
When doing RAF, Worker thread priority changes to DISPLAY. Bug: 995235 Change-Id: I44479a6c0c918c24996776cdb1619993d6cd9ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796482 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695670}
-
Lei Zhang authored
Currently it initializes some DirectWrite code on Windows in unit tests that is only intended to be called once per process, whereas PdfCompositorImplTest constructs multiple PdfCompositorImpl objects and ends up calling that repeatedly, which then fails. Avoid doing this, as the DirectWrite code is not needed in the test. Bug: 1002663 Change-Id: I741690466d3111f0095a070bd64f39ebfb835804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797225Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695669}
-
Evan Stade authored
These were found by attempting to compile the chrome target on Linux. A few slightly more complex updates are left out, but this covers most of the directory. Note that BrowserList/Observer can't be used with ScopedObserver because Add/RemoveObserver are statics. Bug: 998625 Change-Id: I9c0f22ab98d4632ef33240e7dc4cd77f24b17496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789970 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695668}
-
Vladislav Kaznacheev authored
On smaller screen it is possible that there is no room for a submenu on either side of the parent menu. In this case instead of changing the side just move the submenu the minimum necessary amount to fit the screen (see screenshots in the bug). Bug: 991227 Test: MenuControllerTest.TestSubmenuFitsOnScreen Change-Id: I149849e9b2cf44de1b79f45854c49af3f5fe9eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790475Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 940068 Change-Id: Ibf46c4aacf8aa29d4b1ca96aab6d40309f3f5b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788462Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#695666}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9dbfeac8b553..d9456b258e20 git log 9dbfeac8b553..d9456b258e20 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 tobine@google.com Vulkan: Enable further dEQP 3.1 tests Created with: gclient setdep -r src/third_party/angle@d9456b258e20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Iecd5f6c6499b004dd0ae9f1923573bd1a95cb881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798385Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61336619eaf0..e1fb182f7519 Created with: gclient setdep -r src-internal@e1fb182f7519 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia5b646a5279e283e65d6818f346b3d77f8779c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798207Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695664}
-
Yi Gu authored
When a targeting falls back to the slow path, it would be great if we know why. This patch adds async hit test reasons to PrintHitTestData(). Bug: None Change-Id: I3307742c5479050c9b541e741a51b2c75da25392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797649Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695663}
-
danakj authored
Web tests turn off auto-resize in between tests, and pass in an empty size to say that the size should be left alone. Since the widget will be resized for the next test anyways, leaving it at some arbitrary size is not useful. However the IPC to reset for the next test, and to reset from the old test race with each other, so we need to be careful not to stomp on the reset for the next test which sees a size. The early out in RenderWidget::OnSynchronizeVisualProperties() comes from way back in RenderViewImpl::OnDisableAutoResize() which was being called from the test runner in https://codereview.chromium.org/14859017. Instead, have the test runner disable auto-resize and go down a different code path in the TestRunner code. Then pass an empty size to RenderWidget, which will indicate to it to reuse the existing size. R=dcheng@chromium.org Bug: 1790464 Change-Id: I21495aa2ce1e04543d10c80ed4d5286d67dde01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789967 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695662}
-
Xiyuan Xia authored
The UMA is sent in session manager daemon when the browser process calls StopSession to request shutdown. CL of session manager daemon: https://crrev.com/c/1792200 Bug: 999213 Change-Id: I18db3c0516d1d2de07ba6d1c8eeb3438fb173754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792786 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#695661}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/75ba649d..472d39ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2979bf7f11bf22807fd79b6c4cf478f7fcb8df63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798269Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695660}
-
Raphael Kubo da Costa authored
Follow-up to commit 5b9b01f7 ("Get the distribution name from os-release instead of lsb_release"). Borrow the comment from commit e4b86646 ("Store SupportedCodecs in KeySystemInfo and KeySystems") to explain why we need to have BASE_EXPORT in both the function's declaration in the header as well as its definition in the .cc file. Bug: 420439 Change-Id: I3616fe8a8db138a66e29df1d2debaa022a170404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796549 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Juanmi Huertas authored
It was implemented to reset to black, but it should be transparent black, fixing also the broken tests that were validating the wrong behaviour. Bug: 1001609 Change-Id: I68e51628bd36e19b2c332da60239e6a48ebecf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796442Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695658}
-
Juanmi Huertas authored
It was being set as transparent white, which was the same result, but it was not really what it should be. This fix also brings consistency with ImageBitmapRenderingContext Bug: 1002657 Change-Id: I22baa4935d7e9e0c2adc724b8c3d7e5cb444f15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796764 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
-
Eric Karl authored
This feels like an oversight in the GPU-side callback path. The normal IPC path always makes current (and some backing seem to rely on this). Change-Id: I4b8b765f5b8c5c2243dc21609ff139a7347a27c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793747 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695656}
-
Ionel Popescu authored
This CL adds drop shadow support for popups on Windows when the FormControlsRefresh feature is enabled. In order to add the drop shadow, the Window used for popups (TYPE_MENU) is decorated with the WS_THICKFRAME style. Since WS_THICKFRAME also provides a frame, the remove_standard_frame flag is set as we are interested in keeping just the drop shadow. Since drop shadow is not supported on Windows versions without DWM composition, then the drop shadow is replaced by a thin-line border by using the WS_BORDER style. Bug: 1000898 Change-Id: I04588d8d1703cb98f4b7a239f9cf46d742324a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786247Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695655}
-
Andrei Chulkov authored
This CL adds two new metrics to be recorded for the onboarding. Both of them represent the result of the password saving flow, which can either be one of the infobar dismissals or an earlier dismissal of the onboarding dialog. The first metric is recorded for all saving prompts and the second is only recorded if the onboarding was actually shown during the current flow. Bug: 983445 Change-Id: I8af3d451fa0b365632cb0c980a10a48f5c1785ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796342 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#695654}
-
Ross McIlroy authored
Change-Id: I2a9fab5f1032cecc842534617f57b1b7c1db54d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798502 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#695653}
-
Marina Ciocea authored
Register the shared tab with MediaStreamCaptureIndicator, to indicate that the shared tab is being captured. Bug: 980110 Change-Id: Ib81567f59ae9d978e57ebd481fb7ac41dd207e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796671Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#695652}
-
Jérôme Lebel authored
Unified consent feature flag is always on. Bug: 951313 Change-Id: I2c80c83039c628a88781f80979c7e20dd9a1412f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798602 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#695651}
-
Khushal authored
R=fserb@chromium.org Change-Id: I82fb78805c3cb7f71329a245594d30c0c7503041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797124 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Fernando Serboncini authored
Legacy timer was never implemented on Worker.RAF, so we always return the same value for both. Since they are identical, we might as well not use "legacy". Bug: 995235 Change-Id: I370171b6b2a082bbc850cd35956244b191611f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796083 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Yue Ru Sun authored
Bug: 996823 Change-Id: I74170c9ce3008e40c280d0b7ccb58ffc10793364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784878Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#695648}
-
