- 10 Oct, 2019 40 commits
-
-
Mugdha Lakhani authored
BackgroundSyncScheduler code was returning an incorrect delayed_processing_info for Periodic Background Sync. This change fixes that. Change-Id: Ic5aa4505de2613bea5cd676de8faeca76100eb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851424 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#704564}
-
Oriol Brufau authored
This patch extends the syntax of the list-style-type property to accept arbitrary string values in order to customize the marker contents. I have followed the same approach as https://crrev.com/c/879135 did for the display property. When a string is specified for list-style-type, the patch sets it to a special EListStyleType::kString, and the string is stored in an extra field. As a result of this split, list-style-type doesn't use as much auto generated code now, e.g. EListStyleType is not automatically generated. Intent to Implement and Ship: list-style-type: <string> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GojYpoeDbqc Spec: https://drafts.csswg.org/css-lists/#valdef-list-style-type-string Bug: 687946 TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-002.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-003.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-004.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005a.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005b.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-006.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-computed.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-valid.html TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001a.html TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001b.html This patch makes some ::marker tests in css-pseudo fail, but this is expected because ::marker has not been implemented yet. Change-Id: I5743b99bc1a8e66679235874623c82650860ea29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841472 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704563}
-
Miyoung Shin authored
This CL converts XRSessionController{Ptr, Request} in chrome and device to the new Mojo type, and use pending_remote<XRSessionController> in isolated_xr_service.mojom. This CL also remove unnecessary InterfaceSet and it is replaced with RemoteSet. Bug: 955171, 965668 Change-Id: I388f1be9010b6c91a0f1fa00bfc719accd457f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846418 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704562}
-
Dominik Röttsches authored
TBR=kinuko, lanwei Bug: 1011225 Change-Id: I39eb153ac8a3b25b5f0c73af370f498abf3aac8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852088Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704561}
-
Kent Tamura authored
Bug: 1012098 Change-Id: I266825bc3482fbc82c00fa9ef96d7b269c03a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852345Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#704560}
-
Hans Wennborg authored
It's needed in builds that don't set use_v8_context_snapshot, such as when cross-compiling from Linux to Windows. The gn file already lists snapshot_blob.bin as a dependency in that case, but it never actually made it into the installer. Since the file is usually always built, this puts it in a section of chrome.release that's only included conditionally. Bug: 803591,858874 Change-Id: I26de080231ced9812110d9524dcec990bf3bbee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844991Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#704559}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0b81401..35d020e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3919cede137629d62e300bb08da57c8aee0d86f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851648Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704558}
-
Dominik Röttsches authored
This reverts commit 7b3a80a2. Reason for revert: Suspected to break chromeos-kevin-rel bot and webrtc.DecodeAccelUsedVP8, see https://crbug.com/1013105 Original change's description: > media/gpu: Use PortConfig to store ImageProcessor's i/o config. > > ImageProcessor stores input and output's configuration with > VideoFrameLayout object and VideoFrame::StorageType. However, > VideoFrameLayout is unable to represent proprietary format, e.g. MT21, > so it is not suitable to represent IP's input/output config. > > Instead of storing individual configuration properties (format, > visible_size, color_plane_layout, storage_type), we modify an existing class, > ImageProcessor::PortConfig, to store ImageProcessor's input/output > configuration. > > BUG=1004727, 1005636 > TEST=Run VDA test on elm and kukui > Pass image_processor_test > > Change-Id: I720b8ba41db8c5d4e0d1c42ea41f3d4ba27d3ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817858 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Auto-Submit: Shuo-Peng Liao <deanliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704499} TBR=dcheng@chromium.org,deanliao@chromium.org,mcasas@chromium.org,sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I6802f787c6f4567c4a0492681da1b1ded27182fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004727, 1005636, 1013105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852089Reviewed-by:
-
Kent Tamura authored
The new behavior is behind the 'CustomStatePseudoClass' runtime flag. Explainer: https://github.com/w3c/webcomponents/blob/gh-pages/proposals/custom-states-and-state-pseudo-class.md Bug: 1012098 Change-Id: Ia0d1e145cf6589868c7c39d3b1c51fdf2b41bc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800138 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Marc Treib authored
This is mostly for consistency with GetBestMatches. Bug: 1011399 Change-Id: I7369ee04a735c830b30d20bd1b826a66b77d759a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845714 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#704555}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c18c9ff6bc30..82f84c4b8f19 git log c18c9ff6bc30..82f84c4b8f19 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 ehsannas@gmail.com Use a longer timeout for Bazel tests. (#2956) 2019-10-09 rharrison@google.com Remove non-existent files from BUILD.gn (#2955) 2019-10-09 alanbaker@google.com Disable scope validation for OpReadClockKHR (#2953) 2019-10-09 cwallez@chromium.org CMake: Add support for building with emscripten (#2948) 2019-10-09 stevenperron@google.com Update CHANGES 2019-10-08 stevenperron@google.com Link cfg and dominator analysis in the context (#2946) 2019-10-08 afdx@google.com spirv-fuzz: add transformation and pass to construct composites (#2941) 2019-10-08 paulthomson@users.noreply.github.com reduce: improve remove unref instr pass (#2945) 2019-10-08 afdx@google.com spirv-fuzz: add disabled test to document known issue (#2942) 2019-10-08 afdx@google.com spirv-fuzz: Add fuzzer pass to change selection controls (#2944) 2019-10-07 jeremy-lunarg@users.noreply.github.com Enable OpTypeCooperativeMatrix specialization (#2927) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@82f84c4b8f19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I456b94b4f5b9360c2b6bd6584274fddd438d1b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704554}
-
Maksim Moskvitin authored
ApplyRemoteCreationWithoutValidGUIDOrOCII disabled on TSAN* and ASAN*. ApplyRemoteCreationWithValidGUID had missed MAYBE prefix, after fix disabled on TSAN*. Bug: 1012603, 1012222 Change-Id: I0166e39441b0c5d4bf666521f678e66bb558c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848702 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704553}
-
Ionel Popescu authored
Bug: 994219 Change-Id: I1250e61b7482e957396bc02b6a748e126dcb0a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844271 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#704552}
-
chrome://versionRobbie Gibson authored
The uses the <picture> element to select different sources for the logo image based on the device's mode. It also moves the white logo files to the same place as the existing files for consistency. There are corresponding CLs to move the google_chrome logo files as well. Bug: 1006216 Change-Id: I146382b7608b4769306886df81bd80cd051cef86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825418 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#704551}
-
Noel Gordon authored
When the user is resizing the app using the splitter, and the tree has has overflow-y content, a scroll bar appears. That is annoying. Fix by hiding directory scroll bars while the splitter is active. Bug: 1002790 Change-Id: Ie03c75f020a9f0cf573b7c46bf0d204190e68d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851789Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704550}
-
Hiroshige Hayashizaki authored
The previous CL [1] was intended to add use counter only, but actually accidentally stopped execution of scripts moved between different element documents under a same context document. This CL partially reverts [1], and makes such scripts evaluated again as before. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1843509 Bug: 721914 Change-Id: I13f5dbdff46c14a5da49e436994cf73a7dd88373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851524 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#704549}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c5e0ac757a11..ad5f71649e21 git log c5e0ac757a11..ad5f71649e21 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3c7ff8d4f0a1..82f84c4b8f19 (10 commits) Created with: gclient setdep -r src/third_party/angle@ad5f71649e21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: Id174c3f64769f0a0dba9eebe0f632d637a6a557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851766Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces |NGInlineCursor| member functions for painitng selection: - MoveToContainingLine() - MoveToFirstChild() - MoveToLastChild)( - MoveToLastLogicalLeaf() - Replacement for NGPaintFragment::InlineFragmentsFor() * MoveTo(const LayoutObject&) * MoveToNextForSameLayoutObject() - MoveToNextSibling() - TryToMoveToFirstChild() - TryToMoveToLastChild() - Property getters for detecting line break * Current{Base,Resolved}Direction() * CurrentSize() * CurrentStyle() * CurrentText{Start,End}Offset() * IsAtomicInline() * IsBeforeSoftLineBreak() * IsHiddenForPaint() * IsEllipsis() * IsLineBreak() * Rename |NGInlineCursor::IsAtEnd()| to |IsNull()| because |MoveTo{First,Last}Child()| set cursor to null if current position has no children. * Rename |NGFragmentItem::ChildrenCount()| to |DescendantsCount()| to avoid confusion with immidieate children count and descendants count. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1832843 Paint selection with NGFragmentItem Bug: 982194 Change-Id: Icc09d380371f08477fcc9a45ae0c03c50968a3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851885 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Hajime Hoshi authored
This adds new metrics for eviction by back-forward navigation: BackForwardCache.EvictedReason. BackForwardCache.EvictedReason records the reason why the page is evicted, e.g., by JavaScript execution. This CL is a split of the CL for all the metrices: https://chromium-review.googlesource.com/c/chromium/src/+/1782233 Bug: 1004676 Change-Id: Ieea66f2ae6ed30fb836262632ab39b450698a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820701 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Eric Willigers authored
ExternalInstallOptions and InstallManager::InstallParams now contain DisplayMode instead of LaunchContainer. This allows minimal-ui to be supported by InstallManager. TBR=jonmann@chromium.org Bug: 1009909 Change-Id: I13adaf8f834f2cb2d8e80d7ad3bffc24b9d9d73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849471Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#704545}
-
Adam Rice authored
Implement compression for "gzip" and "deflate". The implementation is hidden behind the ExperimentalCompressionStream flag. For unit tests, we compress and stream and uncompress it with pako, and we make sure its output is the same as our original data. The original CL was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1849376 due to failures on the MSAN and leak bots. The compression-stream.any.js test has been modified from the original version of this CL to improve performance, and also marked as slow. TBR=kinuko Bug: 999091 Change-Id: I3952f500cd1ea614397fdf47771e037546583a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851584Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704544}
-
Jan Wilken Dörrie authored
This change makes the Touch To Fill implementation robust against a quick double tap before opening the sheet. It does this by introducing a new flag in the renderer, that is only unset once a user has dismissed the Touch To Fill sheet. Until then each focus event will result in a call to PasswordAutofillDriver::ShowTouchToFill() if the other conditions are met. Prior to this change a user could trigger both the Touch To Fill sheet and the soft keyboard by a quick double-tap on an input field before the Touch To Fill sheet was expanded. Now this doesn't happen anymore, as a keyboard will only be shown after the user has explicitly dismissed the Touch To Fill sheet. Bug: 1012236 Change-Id: Ie207789fe35aced4f94e3a5433adee016f0738eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848696 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704543}
-
Sigurd Schneider authored
This simplifies determining whether a location is inside a CSS header in the front-end (the front-end doesn't have to request the source to determine the end line:column from the start line:column and the size). Before/After: https://imgur.com/a/OFdQBNL Bug: chromium:1005789, chromium:1005708, chromium:1004203 Change-Id: I4c660c2a5f901cfe24d022b2636926ecf99254ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821721 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Monica Basta authored
Use the concatenation of GAIA name and profile name as the identity of the profile to be shown in the User Menu and the profile switcher. With the efforts towards encouraging the use of multiple profiles, it becomes more important to show a clear identity for the profile and clear transitions on events like sign in, enable sync, sign out. If no primary account or unconsented primary account exists for the profile, the local profile name is used. Otherwise, we show the concatenation of GAIA name and profile name in this format: |GAIA name (profile name)|. The only exception where we only show the GAIA name is if the profile name is a substring of the GAIA name. The implementation is behind a kill switch |kConcatenateGaiaAndProfileName| enabled by default. Bug: 1012182 Change-Id: I27626d9e9c77f38698db1012abf5e3fceccc266d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845766Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#704541}
-
Sergio Villar Senin authored
In order to remove the dependency, the contents of the header file were merged in the already existing third_party/blink/public/common/notifications/notification_constants.h Bug: 1008303 Change-Id: Ic22f381d031475d00b2614640bad5022717ab74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848694 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1007760 Change-Id: I899d8944d5a54b317f274ae24f716cce39ef9600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849488 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 64b82d94. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If78e608f3a641b86ea3308fcfe67abfaa3ee660e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851647Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704538}
-
Juan Antonio Navarro Perez authored
Test is flaky on Lollipop Tablet Tester TBR=boliu@chromium.org Bug: 1010034 Change-Id: Ie0de96720fe2396da9032b1cc745445c06dfab61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851707Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704537}
-
Richard Knoll authored
This moves all required data to display sharing dialogs into the view itself instead of having to call through to the controller. User actions are bound back to the controller via weak pointers. This is a cleaner fix for a UAF issue caused by different lifetimes of controller and view and prevents further similar issues here. TBR=pkasting@chromium.org Bug: 1000934 Change-Id: I34b4695fb6cdddb96c0e7bbf5d7edd36c5e729db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789149 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704536}
-
Eric Seckler authored
This reverts commit 79081496. Reason for revert: cause of the flakiness was identified and reverted Original change's description: > Disabling flaky ChromeTracingDelegateBrowserTest tests. > > Tbr: skyostil@chromium.org > Bug: 1012218 > Change-Id: If238d6632769c3f4faa4fde81d53b26ba83bdf01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847293 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703677} TBR=phoglund@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012218 Change-Id: I69ed751afd7cf328232c2b303933dc9c66fa4fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852204Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#704535}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aa9175d6761d..e6b95e45544d git log aa9175d6761d..e6b95e45544d --date=short --no-merges --format='%ad %ae %s' 2019-10-10 primiano@google.com Merge "build: support target sysroot" Created with: gclient setdep -r src/third_party/perfetto@e6b95e45544d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2b00c0bbdcb71ded3a851a9f0da2bb74e321d833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851769Reviewed-by:
-
Benoît Lizé authored
This CL turns load-bearing comments into thread annotations checked by the clang static analyzer. Comments were actually out-of-date already (as it wasn't specified that is_young_ must be protected by the mutex), though the code was correct. No behavior change, and besides the annotations, unit tests have to change as they need locking to access a variable. Bug: 924164 Change-Id: Iecac23df0c2e61f4d42be105387fa6bf7605d8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849854Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704533}
-
Robbie Gibson authored
The root cause for the bug is that the fakebox fades out as it scrolls up in landscape. After it gets all the way offscreen, its alpha is 0. Once that happens, Voiceover doesn't recognize it as a view, so there's no way to go back up to get it in view. To prevent this, this CL sets the minimum alpha of the fakebox/header to 0.01, so Voiceover will still see it. It still shouldn't affect the actual visibility because the fakebox is behind the toolbar by the time it fades out, so it still won't be visible. Bug: 985726 Change-Id: Ibbb3947561e13a6312bcdc8973c7c71c25e728cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849676Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#704532}
-
François Beaufort authored
https://dawn.googlesource.com/dawn.git/+log/e16a901fb853..91b2142ee44d $ git log e16a901fb..91b2142ee --date=short --no-merges --format='%ad %ae %s' 2019-10-10 beaufort.francois Change setVertexBuffers to setVertexBuffer Created with: roll-dep src/third_party/dawn Bug: 877147 Change-Id: Ia4bb0d2e0aa2e3f41c74c7a24e509198214f38b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848387Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#704531}
-
Juan Antonio Navarro Pérez authored
This reverts commit b5385fa9. Reason for revert: Appears to have broken VR render tests https://crbug.com/1013009 Original change's description: > Fix default font used in VR text element > > The VR code is using the default font "sans-serif". > The Font (and FontList) on that platform is the PlatformFontSkia > When creating the font with the literal "sans-serif", there is > not matched typeface. > > The function creating the typeface has a fallback path that try > "sans" which is the resulting typeface used. > > see: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_skia.cc?l=53 > > This CL avoid to use that fallback logic. Instead, we rely on > the FontList behavior to use the default system font with the default > constructor. > > > R=alcooper@chromium.org > > Change-Id: I612502f32d77787b8f0346c0fc23cd65b68e3013 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847902 > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704279} TBR=klausw@chromium.org,etienneb@chromium.org,alcooper@chromium.org Change-Id: I7a54e9bf314a67661e625cbb4d838eea73560b75 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852424Reviewed-by:
-
Gyuyoung Kim authored
This reverts commit 7cf54149. Reason for revert: This CL broke the build on bots. Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 12 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I034377bb4772d565567ced5dd15f58a6440ee1ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849741 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#704527} TBR=kinuko@chromium.org,tkent@chromium.org,gyuyoung@igalia.com Change-Id: Id98d6c344506431061536680b2f15a9547a83496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851635Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704529}
-
https://crrev.com/c/1842316Kinuko Yasuda authored
Adding a prefix tentatively, which is probably a bad fix TBR=bdea@chromium.org Change-Id: Ic9614606fbf8a96bdd8229ab7c842e5e16907f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851630Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#704528}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I034377bb4772d565567ced5dd15f58a6440ee1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849741Reviewed-by:
-
Fredrik Söderquist authored
This removes the ResolveFirstInterval() function, in favor of just passing the appropriate arguments to ResolveInterval(). The |is_waiting_for_first_interval_| is cleared in the StartedActiveInterval() callback (when the first interval starts), and SVGSMILElement::CurrentIntervalIsActive() is simplified to only check if |next_interval_time_| has been reached. Because of this, the initial value of that member field is changed to Earliest(). Bug: 998526 Change-Id: I56103218fd210fbcd11076f20757b06319f5a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848692Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#704526}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5224ac45e460..a441815f4dc3 git log 5224ac45e460..a441815f4dc3 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 vapier@chromium.org lint: clean up arguments-differ warnings with func signatures Created with: gclient setdep -r src/third_party/chromite@a441815f4dc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic6854311040a659d2ee681c26d5639fbeabc8cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851765Reviewed-by:
-
