- 05 Aug, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596606694-35c6f8535b14ce15b4839555c5550c892d549ecc.profdata to chrome-win64-master-1596628771-86348d2a61736525bb253851ce1433e67dea13ba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I1a61c24d74eda3e493a7f8c1c0cb7929b9dd4f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795054}
-
Takuto Ikuta authored
This is revert of https://crrev.com/c/2337833 , but remove unused import too. Bug: 1112996 Change-Id: Id0370a6e321b861a27e6415702934eb5f24d1ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336323 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#795053}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1JFK-SPk-TANPt1g1i8wpIJc8nPsu8wzT/view?usp=sharing Bug: 1063856 Change-Id: Ibe3f9c5086384dc7187fdd43d5eaea952e639b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332709Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#795052}
-
Ben Mason authored
This reverts commit 54c22ea1. Reason for revert: IDS_AUTOFILL_ASSISTANT_INIT_MESSAGE_PASSWORD_CHANGE.png.sha1 needs to be a sha1 not a PNG file Original change's description: > [Autofill Assistant] Add custom onboarding informational text for password change intents > > Design mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8e7b42d005_0_56 > > Bug: 1110309 > > Change-Id: Id0e4316e71d57b80271c0a596cd4de505dc1e54b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332164 > Reviewed-by: Marian Fechete <marianfe@google.com> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Commit-Queue: Milica Selakovic <selakovic@google.com> > Cr-Commit-Position: refs/heads/master@{#794544} TBR=kolos@chromium.org,arbesser@google.com,marianfe@google.com,selakovic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110309 Change-Id: Iab189bf597780556cb4e49984da57a7058e4173b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339596Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#795051}
-
Haiyang Pan authored
According to estimation, 2000 bots are needed to support full CQ traffic. Currently there are 200 bots in the fleet pool. So it should be suffcient to support 2% traffic. Bug: 997376 Change-Id: Ic7976aeb95646f8b92e2f66f5f5c4d41461ce87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333822Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#795050}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596621162-a1892525031f11bea0534e52833cec57e313f57e.profdata to chrome-win32-master-1596628771-e32af535197a262fe54680b0a1a803a0983bdd0a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4b4bf7c746de9d20b8f396cc0c9dfe145acef415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339574Reviewed-by:
-
Adlai Holler authored
This unblocks removing the old API. Bug: skia:104662 Change-Id: I6abe863ee1d74dddef9cfaa6e61c4ee3602d7d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335640 Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795048}
-
Nate Fischer authored
No change to logic. This adjusts padding and margins for consistency with the crash UI (most stuff should be 8dp now). This also splits the warning message into its own layout file. This will be necessary for a follow-up change to move the warning text into the ListView so it can be scrolled off screen. Bug: 1111172 Test: Manual Change-Id: I8bf87c633ec6fc8cc0aa85f581e9825c6a9dff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330291Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795047}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce4c3060..1e0d126c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icae20850a058c13899b26477adb77496542c93c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339215Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795046}
-
David Schinazi authored
This information was incorrectly missing. R=nharper@chromium.org Bug: 1112925 Change-Id: I17643ebaeee02eb9d5e63f0630bce66939a3e536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337542 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795045}
-
Liquan (Max) Gu authored
Change: * Move createShippingSection and rename it createShippingSectionForPaymentRequestUI to be explicit that it's for PR UI. * Move PaymentAppComparator into the ui package because it only serves for the ui purpose. Bug: 1102522 Change-Id: Ibde545ce1a6447abf7240d9bdbee32496e26bb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331743Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795044}
-
Hans Wennborg authored
Bug: 1112506 Change-Id: Ice8b1deeabb449c8cedf0f59f8688d9ac0b4a073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339455 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#795043}
-
Roman Sorokin authored
It's been enabled for a long time Bug: 935613 Change-Id: I5aef1f2f797859fa855756276139a0d94bb82397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339336 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#795042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2052b3bd9a5..011b0075cd53 2020-08-05 mathias@chromium.org Adopt new CheckAuthorizedAuthor parameter name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6aecfef5596c3208d10f4bc31f692c1801acf92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339436Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f68444a445f7..9a43f48ed4cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia498a0d6fb1daa5824b737ae7b132722e6212e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339206Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/23c5b63d1c68..9a43f48ed4cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I05fc53a24ff13997f3ceb94c8be5e25b19c6448a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339208Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8b3601324fde..f9f6adb625c4 2020-08-05 apodtele@gmail.com [truetype] Retain OVERLAP_SIMPLE and OVERLAP_COMPOUND. 2020-08-05 apodtele@gmail.com * src/truetype/ttgload.c (TT_Load_Glyph): More tracing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I444d5bb5b85b05e6df710eae878987eac42018d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339196 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#795038}
-
Daniel Murphy authored
The new error pathway populated the manifest pointer as a nullptr. The code can assume that this is never a nullptr, so instead just create a dummy empty manifest on the stack and send a pointer to that. Bug: 1110771 Change-Id: If358b4d7251b0a6a858cf91e511dda60ba02ee89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327277Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#795037}
-
Aaron Leventhal authored
Newer screen readers such as JAWS 2021 use selection events on the Omnibox suggestions rather than value changes from the Omnibox. This change improves the accessible names of the suggestions. - Include additional messaging, e.g. tab switch button is available - Do not include "n of m" positional info in the name, since this is now made available semantically via the accessibility API. Also adds more tests to ensure that important pieces of text are included in the Omnibox friendly values and the suggestion names. AX-Relnotes: friendlier Omnibox announcements with JAWS 2021 Bug: 1109780 Change-Id: Ie0f5073df0114e5ceed105e9e87e53f79264f847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337400 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795036}
-
Clark DuVall authored
This is necessary to allow DFMs to call native code correctly. This will be helpful in experimenting with making WebLayer a DFM. Bug: 1105096 Change-Id: Ibd8e3b25f9a18e8dc26337cd3f2a4b550066c19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337288 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#795035}
-
Adam Langley authored
This change adds desktop-side, disabled-by-default, preliminary support for communicating with phones over USB so that they can act as a security key. This requires phone-side changes too that are forthcoming. Android supports an “accessory” mode[1] that allows USB communication with apps on the phone. This involves sending vendor commands to the device to request that it switch into this mode and then watching the USB bus for the device to reappear in the new configuration. Once that's complete, data can be exchanged. There's no good way, however, of knowing which USB devices are phones. And it seems unwise to blast vendor commands at every attached USB device each time we start a WebAuthn transaction. Therefore this is only attempted for devices that are connected during the transaction. We do, however, remember which accessory devices we previously configured and can use them immediately if still connected. In the future, the UI could plausibly allow the user to select the device from a list rather than connect it. Although I'm unsure whether that's actually useful. [1] https://source.android.com/devices/accessories/aoa BUG=1002262 Change-Id: Ia58632d89c83a60559b59146d69bd2638a597f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310193 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#795034}
-
Dan Harrington authored
Bug: 1111806 Change-Id: I7662de6b7117a5434417a7b430b54bc042817175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333995Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#795033}
-
Josh Nohle authored
Bug: b/157685298 Change-Id: I502eb7923a4620e0dfbc4edde178e4cc3f2d043f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332869 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#795032}
-
Mohsen Izadi authored
This reverts commit 873b558a. Reason for revert: The reverted CL does not seem to be in the range for the failure, but apparently detected as the culprit by sheriff-o-matic. Relanding to see if the failure repros again. Original change's description: > Revert "Re-add field trial testing config for DisableLatencyRecoveryDesktop" > > This reverts commit 26f4c62b. > > Reason for revert: chromeos-eve-chrome build failures > > Original change's description: > > Re-add field trial testing config for DisableLatencyRecoveryDesktop > > > > Based on the data gathered from running the experiment on canary/dev and > > beta, it seems that the disabling latency recovery for both main and > > impl threads is an overall performance win. So, we are going to > > re-enable the (now-expired) experiment on stable and move forward with > > its gradual rollout. > > > > Bug: 993895 > > Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790549} > > TBR=mohsen@chromium.org,rkaplow@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 993895, 1113101 > Change-Id: Ibfebd16583e4f4670d808b80eb00360f0e744ce0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338214 > Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794951} TBR=mohsen@chromium.org,rkaplow@chromium.org,ayaelattar@chromium.org # Not skipping CQ checks because this is a reland. Bug: 993895 Bug: 1113101 Change-Id: Id2b1108ebe66938f76c3b60370f5dd3f9681a932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339594Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795031}
-
Roger Tawa authored
This reverts commit 027aa92e. Reason for revert: This change breaks the chromeos builder: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome See builds: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/9123 https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/9124 Error is: ../../base/cpu_affinity_posix_unittest.cc:108: Failure Expected equality of these values: __sched_cpucount (sizeof (cpu_set_t), &set) Which is: 4 expected_little_cores Which is: 6 Original change's description: > base: Add API to restrict thread affinity to little cores on Android > > Adds functions that facilitate setting the CPU affinity of a given > thread or process to all little cores on the system. > > We intend to use this API to run a power experiment. > > Bug: 1111789 > Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794998} TBR=dcheng@chromium.org,skyostil@chromium.org,eseckler@chromium.org Change-Id: I969b4cd892c341f5e0612be6d571de461b4bb6c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339498Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#795030}
-
Carlos IL authored
Currently the ElideAnimation starts even if there are no visible changes (i.e. the animate from state is equal to the animate to state), this causes bugs in behaviors that rely on knowing if an animation is running. This CL adds an early return to ElideAnimation::Start if animate from and animate to states are the same. Bug: 1112848 Change-Id: I99966d555c586ba367bfb5ee57429d98d3458318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335760Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#795029}
-
Yuki Shiino authored
Since we cannot create an appropriate named constructor when a context is detached, returns ES undefined as a compromise. Bug: 839389, 1112227 Change-Id: I529962c80620ba431c87c71936fbcd7d016db225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339234Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#795028}
-
Owen Min authored
Based on crbug.com/166153, the base::TickClock still advances on Win and Mac even when the device is suspended. However, the WallClockTimer's doc claims that the TickClock always stop during power suspension which is updated here. We also add unit tests to make sure the WallClockTimer is able to cover this case. Bug: 1112516 Change-Id: I866a55c9b23c9460716fa6796c33fce5b62150cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333041 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795027}
-
Miguel Casas authored
The original CL was reverted due to crashes in betty initialization: betty is a VM which doesn't support VA, so the VideoDecoderPipeline constructed-destructed a VaapiVideoDecoder, hitting an unprotected nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. TBR=andrescj@chromium.org Original CL description ----------------------------------------------- Certain platforms and codecs suffer from horrible artifacts (Intel BYT, H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of error in the tracking of the VASurfaces lifetime in the driver: every time we get a new resource from the pool to decode onto, this is imported into libva as a VASurface: this works fine almost everywhere but doesn't play well in these old platforms (see CreateSurface() body). This CL adds a map that keeps the ref-counted VASurfaces alive and indexed by the unique GpuMemoryBufferId until the VA Context is destroyed. In so doing, we're basically observing the "contract" of va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all contexts using these surfaces have been destroyed". [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 Bug: b:142019786 b:143323596 Change-Id: I593763ec02dad7bba240c8fed9e71de21637a231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#795026}
-
lijunsong authored
Test HTMLDetectorCache_SkipSomePredictions was deleted during resolving Bug 949519. This CL ports the test to the current FormDataParser. Bug: 1090694 Change-Id: Ia48a825099577536e407ef1f324899b0276fce91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299179Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94fc43a9ebbf..c1e871e8a532 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ayaelattar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ayaelattar@google.com Change-Id: I2c1537bd121e9edd27ead6a2ae3bf4ffddad18e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339194Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795024}
-
Renato Silva authored
The visibility of the elements within LoginAuthUserView (password field, pin pad) are now being controlled based on the InputFieldMode, which is determined by the authentication methods a user has. Additionally, the user's PIN length is now being provided to this view to use, if it is exposed. Bug: 1075994 Change-Id: Iad0bbc793e52a790856ae0dde3aae7369c16b390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332663 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#795023}
-
Antonio Sartori authored
If a Content-Security-Policy frame-ancestors directive is enforced, then the X-Frame-Options header is ignored. However, if the frame-ancestors directive is report-only, the X-Frame-Options header is checked and the frame possibly blocked. However, in this second case, we must still check whether we have to send a Content-Security-Policy violation report. Bug: 1097078 Change-Id: I9768a3859184ac1d35bd938f45cc40e111e2af4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339115Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#795022}
-
Antonio Gomes authored
Target interface: blink::mojom::RemoteMainFrame. CL also removes WebTextAutosizerPageInfo struct [1] in favor of using blink::mojom::TextAutosizerPageInfo directly. [1] third_party/blink/public/platform/web_text_autosizer_page_info.h Bug: 1102440, 919392 R=dtapuska@chromium.org Change-Id: Id02e7712cd1291636bd6052445702d87fe2a5cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314129Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#795021}
-
Peter Kasting authored
As requested in https://bit.ly/chromium-readme-tracker . Bug: none Change-Id: Ib25c6c9cb7a72ffbbca308b61295aab6018012ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336181 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795020}
-
Rushan Suleymanov authored
ComputeChildNodeIndex performs linear search to find appropriate index for the updated or created remote bookmark node. It might lead to quadratic time during some updates. In practice, this only affects huge quantities of local bookmarks and updates. This CL changes the algorithm to logarithmic search. Bug: 1084150 Change-Id: I605228ad4cd7db82a1e6777a5f4b35538783dde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336084 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795019}
-
Reda Tawfik authored
This CL adds controller and view native files and Java bridge of |FillingPasswordsFromAnyOrigin| feature. 1) Initiates |AllPasswordsBottomSheetController| with |ContentPasswordManagerDriver| and |PasswordStore| from |PasswordAccessoryControllerImpl|. 2) The controller initiates |AllPasswordsBottomSheetView|. 3) The controller gets the credentials from |PasswordStore| and send them to the view in |Show| method. Bug: 1104132 Change-Id: Ic7d7fb504b7f1a2a7438426588f5487877ef0069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299350 Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795018}
-
Victor Fei authored
Google drive expand/collapse state is not being announced due to excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up discarding most events. For example, if aria-hidden="true" is set on an ancestor node, which would cause that node many of its descendants to be set to IGNORED state which triggering too many EVENT_OBJECT_HIDE and causes NVDA to drop the events. In reality, we only want EVENT_OBJECT_HIDE to be generated on the ancestor node where aria-hidden="true" is set, so not to flood and confuse NVDA with excessive events. This change fixes the above issue by firing EVENT_OBJECT_HIDE on the root should the entire subtree changes to IGNORED state. Suppressing excessive SHOW/REORDER events will be addressed in follow up patches. AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/ collapse state. Bug: 1019420 Change-Id: I4fdabd6740630a149c1b22cdb3180d2f75807b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309450 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795017}
-
Karel Král authored
Implement a helper to get string representation out of C++ types. Use this to provide tracing of typemapped parameters of mojo auto-generated methods. TBR=fdoray@chromium.org Bug: 1103623 Change-Id: I61e1422bae5647e042aaf1f2718682323fba2db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324846 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795016}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3d5cdeff. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" 27a0731b "Origin isolation: add WPTs for contentDocument/frameElement" 281fe1fb "Reland "[COOP] Access reporting. Fix the python server."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ic9ef6c4fd9cb75fad82533ea022a1f01dce3cf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339214Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795015}
-
