- 28 Mar, 2020 2 commits
-
-
Matt Jones authored
Instead of accessing the ReaderModeManager via Tab and ChromeActivity, a reference to the manager is passed to the native infobar when it is created and pulled back up to java when needed. This also allowed for the removal of the GetTab native method. Bug: 952703 Change-Id: Iaacbbda08e28d013538d44c9b985020c175de1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122471 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754230}
-
Juanmi Huertas authored
This reverts commit 9184313f. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1065575 Various Win 7 bots are failing these newly added tests. Reverting, feel free to reland if this was not the culprit, but to reland, add the failing bots to ensure it works there: Win 7 Tests x64, Win7 Tests Original change's description: > Add tests for D3D11DefaultTextureWrapper > > Also fixes binding P010. > > Change-Id: Iba389bf5f883662d1ac2f7aa396992ff662d009d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107054 > Auto-Submit: Frank Liberato <liberato@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754168} TBR=liberato@chromium.org,tmathmeyer@chromium.org Change-Id: I2ffcd42d6dff66dfae7f2487837d65c02507cc6f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125469Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#754229}
-
- 27 Mar, 2020 38 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/99508c1ce389..4d7c749b7610 git log 99508c1ce389..4d7c749b7610 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 johnkslang@users.noreply.github.com Merge pull request #2159 from neslimsah/master Created with: gclient setdep -r src/third_party/glslang/src@4d7c749b7610 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I5e841cdfcce51aaf90220fc148dff94ce167d22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754228}
-
Robert Liao authored
Sample Histogram Output: Histogram: NativeTheme.GetSystemColor recorded 775 samples, mean = 0.0 (flags = 0x41) 0 --------------------------------------O (775 = 100.0%) 1 ... Histogram: NativeTheme.GetSystemColor.UsesColorProvider recorded 775 samples, mean = 1.0 (flags = 0x41) 0 O (0 = 0.0%) 1 --------------------------------------O (775 = 100.0%) {0.0%} 2 O (0 = 0.0%) {100.0%} BUG=1057754 Change-Id: I0712864599a0bf18cf30e9e02eb0b3230afcf9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124887 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#754227}
-
Matt Jones authored
Previously, if another feature tried using the scrim while the old one was still visible, the first user's would not be hidden correctly. This patch ensures the previous scrim is replaced before showing the new one and adds a test for this behavior. Bug: 1065370 Change-Id: Iaa0c873a519d41e02b6ab98b87c84a89da06fe0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124983Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#754226}
-
Haiyang Pan authored
This is to fix the failure of weblayer_instrumentation_test_apk Bug: 1032336 Change-Id: I3c044c6986e0ef071ae1573ef620a31d2056c310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106078Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#754225}
-
Tom Anderson authored
This is a reland of 2c2f5494 Original change's description: > Remove GTK scale factor workarounds > > The workarounds were initially added to fix rendering issues > when the scale factor was an odd value like 1.01. Hopefully > the fractional scale factor support in Chrome is now good > enough to handle these cases. > > This change prevents unexpected scale factor behavior like > 1.25 remapping to 1.0. > > BUG=1033552 > R=oshima > > Change-Id: I1d22c1ddcf463fed12061ef265d2a6b4a4bcbeb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121179 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753653} CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-trusty-rel Bug: 1033552 Change-Id: Ia0ce07eb61efa56a7c0d3e3ade4a167d73510f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124889 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#754224}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7e0699a25089..d03b15b2f9f5 git log 7e0699a25089..d03b15b2f9f5 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jmadill@chromium.org Vulkan: Mask out Depth/Stencil RTs in feedback loops. 2020-03-27 timvp@google.com Vulkan: Move cached samplers/images and has*() to ProgramExecutable 2020-03-27 jmadill@chromium.org Fix feedback loop clearing detection. 2020-03-27 jmadill@chromium.org Update OWNERS information. 2020-03-27 jmadill@chromium.org Support masking out DS feedback loops in RenderTargetCache. 2020-03-27 geofflang@chromium.org D3D11: Serialize and deserialze mImage2DUniforms. Created with: gclient setdep -r src/third_party/angle@d03b15b2f9f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I5ecd364518f629d8b89fb612fd65a35e0e71c492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125110Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a35ca2b5e91d..ca9a03f92fbd git log a35ca2b5e91d..ca9a03f92fbd --date=short --first-parent --format='%ad %ae %s' 2020-03-27 aerotwist@chromium.org [e2e] Adds various helpers; tidies up env vars Created with: gclient setdep -r src/third_party/devtools-frontend/src@ca9a03f92fbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iae2170727f3b0b3fca7a1e9d7f8efd0ff4070666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125167 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.continuousMouseScrollBy with gpuBenchmarking.smoothScrollBy in the wheel event paging vertical scrolling tests. To simulate paging scrolling, we can set scroll_by_page to be true in smoothScroll function. Bug: 1047176 Change-Id: Id9964bc2fcec4ce88cbe2d09fa562b4a163af7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111072 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754221}
-
Jeff Yoon authored
- lib/ci.star updated to make 11c29 default cache and property - ci.star updated to remove configs for ToTiOS to use defaults - iPhone 6S device added to variants.pyl - GN args set in mb_config.pyl. - tests use same test set at ToTiOS Generated files: - cr-buildbucket.cfg - chromium.ci.json - chromium.clang.json Bug: 1055164,912681 Change-Id: Iedb2650ebcbbd1c1c085ce4d12a2eb22cbe51852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113082 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#754220}
-
Julien Isorce authored
Recently Angle got support for an EGL backend. When selected this backend uses the EGL library provided by the graphic driver. For example Mesa on Desktop Linux (or even the NVIDIA prorietary driver on Desktop). The new Angle's DisplayEGL is selected by passing: --use-gl=angle --use-angle=gl-egl --use-gl=angle --use-angle=gles-egl The legacy Angle's DisplayGLX is still selected when passing: --use-gl=angle --use-angle=gl --use-gl=angle --use-angle=gles Bug: angleproject:4328 Change-Id: Icddba01e7cfa542fc2f57a11f2374098e482a48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123645 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754219}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3665d28e6e71..81431f5034b4 git log 3665d28e6e71..81431f5034b4 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 yunchao.he@intel.com Add validation tests for resource usage tracking - 2 2020-03-27 enga@chromium.org Merge BindGroupLayout and ShaderModule BindingInfos 2020-03-27 cwallez@chromium.org Vulkan: Load functions for surface extensions we support. 2020-03-27 cwallez@chromium.org Metal: Don't crash on invalid shaders 2020-03-27 cwallez@chromium.org Vulkan: Free recording context semaphores on destroy. 2020-03-27 cwallez@chromium.org Vulkan: Use EXT_metal_surface instead of MVK_macos_surface 2020-03-27 cwallez@chromium.org Vulkan: Make GatherSurfaceInfo use ResultOrError 2020-03-27 cwallez@chromium.org Vulkan: Don't use vulkan.h's prototypes. Created with: gclient setdep -r src/third_party/dawn@81431f5034b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I08ae8f4c83f327a7d9e14b1b9a751c644a2ad80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125177Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4085.6-1584959535-benchmark-83.0.4091.0-r2 to 83-4085.6-1584959535-benchmark-83.0.4094.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8ebf5d842438e76b02bc527c573d61b68621bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125236Reviewed-by:
-
Matt Mueller authored
Bug: 634484, 1040681 Change-Id: I38a15bf4aa52ee6106a782237ca579938aa6886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947630 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754216}
-
Lei Zhang authored
Rename it to setLoadCompleteCallback, since its behavior changed over time and this is what it does now. Rename some related variables to be consistent and do a couple random cleanups along the way. Change-Id: Ibb6571923e0dc6e5f7198df91123b663a176b899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124212Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#754215}
-
Matt Mueller authored
This makes it clear that this is just a chrome netlog invention and not some standard. Change-Id: I2585ba02121eb604e97b08449502ddfdb31408cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124238Reviewed-by:
-
Chris Harrelson authored
Non-lazy images don't show this icon. It's incorrect to show such an icon just because an image is loading. In addition, it messes up the intrinsic sizing heuristics for aspect ratio. Both lazy and non-lazy images still show a broken image icon when images fail to load via HTTP failure. Bug: 997606, 1045745 Change-Id: I5dc6bac50a1c43395057e37547864e9e3fc13b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109330 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#754213}
-
Jordan Taylor authored
This change makes it easier for timelines to compare against previous timeline values. It also allows timelines to produce a phase in addition to a current time. Timeline phase allows animations to correctly apply fill modes. Spec issue discussion: https://github.com/w3c/csswg-drafts/issues/4325 Bug: 1046833 Change-Id: I1354f69afd04efe498a53b2f8839a83b8d6153c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112586Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#754212}
-
Lei Zhang authored
Convert all implementations and callers. Simplify some surrounding code along the way. Change-Id: Icee22f3802e634180f8c6ad0eab23bad81965ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124107Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#754211}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3ca41df3d3ba..de3f38a72c48 git log 3ca41df3d3ba..de3f38a72c48 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 sugoi@google.com Fix Android.bp following the SPIRV-Tools update 2020-03-27 bclayton@google.com Regres: Switch to building with LLVM 10 Created with: gclient setdep -r src/third_party/swiftshader@de3f38a72c48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1a0f05383100ab16d6180da2da9b89a56bcb90ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125169Reviewed-by:
-
Nektarios Paisios authored
Blink doesn't always remove all deleted whitespace at the end of a textarea even though it will have adjusted its value attribute, because any extra layout objects that might happen to exist in its layout tree are invisible. Similarly, the value attribute is not updated when an autocomplete popup is visible in a native text field. Therefore, We stop relying on the value attribute for hypertext and text boundary calculations when a text field originates from Blink and use its inner text instead. We detect this by checking if the text field has descendants in the internal accessibility tree. For finding the next / previous text boundary, e.g. the next line start, we need to access the inline text boxes that represent each text span. Similarly, for exposing the text on a node on Windows IA2 and Linux ATK, including the value of an autocomplete popup we rely on hypertext calculation. Before this patch and in the case of a web-based native text field, the text in the field was retrieved from the HTML value attribute. This could cause a mismatch, if the text that is produced by concadenating all the inline text boxes was different from the contents of the value attribute. With this patch, we switch to BrowserAccessibility/AXPlatformNodeBase::GetInnerText to compute the inner text of a subtree. To do this, we need to correct GetInnerText to collect text from all leaf nodes, and not only text-only objects. For example, <button aria-label="button"></button> will have no text-only children, but will still need to expose the text of its label in AtkText and IAccessibleText. This patch surfaced an issue with placeholder text in <textarea> and <input> fields which was not previously exposed in hypertext. Split off from: https://chromium-review.googlesource.com/c/chromium/src/+/2110471/18 when there is a blank line at the end of a textarea. R=dmazzoni@chromium.org, aleventhal@chromium.org Relnotes: Screen reader correctly announces "blank", instead of a random character, Bug: 1044410 Change-Id: I64ad2502c729076858fe52fc64d1ed1fda3cff1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122718 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#754209}
-
Scott Violet authored
This also changes the client library to throw (runtime) exceptions in certain scenarios. This is an incompatible change to the client library, but prior to this we would have hit DCHECKs, and Alihan agreed with this change, so I'm going for it. BUG=none TEST=none Change-Id: I9ee43b8c61c999245ab5a8bd4e90a21b8aca42e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124299Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754208}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I62bbeb997ac53d694463c585b3229183020a7888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124074 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754207}
-
rbpotter authored
cr.define and function(() calls can't be used in the same file when autogenerating Polymer 3 code. Move the Callback enum to the browser proxy, and delete the Component enum as it is unused. Bug: 1026426 Change-Id: Ib44c7c9f83eca07b03abca2167b47da93f24e97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125017Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754206}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d94f8ea2b545..b3e593c1ba1e git log d94f8ea2b545..b3e593c1ba1e --date=short --first-parent --format='%ad %ae %s' 2020-03-27 sokcevic@google.com Escape AST string before writing to tokens 2020-03-27 sokcevic@google.com Enable test for git_rebase_update on Windows Created with: gclient setdep -r src/third_party/depot_tools@b3e593c1ba1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9ae8983ebd5b2551f5cdc19b0379d7f128e84583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125168Reviewed-by:
-
Robert Sesek authored
The network_service_test_helper_ is created conditionally in the constructor, and it's undefined behavior to dereference a null pointer. Bug: 1064609 Change-Id: Ic9c79ef049225d1172e568c39d14c9528e3e78d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124538 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: 1065499 Change-Id: I6384dec15c652aa0bbbb9f52e9c6381d07dbd23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124976Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754203}
-
Becca Hughes authored
This is a reland of 25e37730 The fix is to loosen the assertion on the time fields which have a different format on win7. Original change's description: > Reland "[Media Feeds] Add feed items to WebUI" > > This is a reland of 0bbf0f94 > > Original change's description: > > [Media Feeds] Add feed items to WebUI > > > > This adds the feed items to the WebUI. You > > can select a feed to show the content. > > > > BUG=1058187 > > > > Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758 > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753441} > > Bug: 1058187 > Change-Id: I7ec8a25ba03d192341e6d02eccfba991b4156504 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121450 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753712} Bug: 1058187 Change-Id: I69f0f6dbe336d7a46b2c3d2e4e251256d37390d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124630Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#754202}
-
Tom Anderson authored
Tab dragging interacts poorly with tiling WMs since the window is constrained by the WM, which will ignore move/resize requests from Chrome. To address this, this CL makes the window unmanaged for the duration of the tab drag, so that the WM will not intercept our move requests. BUG=416119 R=sky CC=msisov,nickdiego Change-Id: Ida494a80fc0fca86171bd493d6d0e7a424c326b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119756 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754201}
-
Tommy C. Li authored
This feature surfaces an X button next to deletable suggestions in the omnibox. Enable this flag by default for rollout with M83. Bug: 1205 Change-Id: Ic3f18d20aeef3959b8ff3f7ab1338bb17db1ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124907Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754200}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4502a6360996..dd82c211fcb5 git log 4502a6360996..dd82c211fcb5 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 treehugger-gerrit@google.com Merge "traced_perf: mallopt(M_PURGE) when going quiescent" Created with: gclient setdep -r src/third_party/perfetto@dd82c211fcb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I04059e061d7cdff5f53b7f3068577da8ed944999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124060Reviewed-by:
-
Tim Judkins authored
Adds histogram logging to extension navigations caused by tabs.create, tabs.update, windows.create and browser.openTab (the latter only being used by apps), detecting if the URLs passed to those functions have the devtools scheme. Bug: 1049265 Change-Id: I7ac97e66ecf31d01d571936614a2d509deb6af9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102784Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#754198}
-
Peng Huang authored
Right now, the vulkan_tests can only run with X11. This CL make it work with android. Note: vulkan_tests is not running on any bots right now. Bug: 1065499 Change-Id: Ie8f9c452d2a77beb8e3c8d4c1fa715a8b708c2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125009 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#754197}
-
Livvie Lin authored
Fixes the case where a full HTTP URL will show in the omnibox, but get removed when clicking into the omnibox to edit. This patch will retain the HTTP scheme so that it's easier to add an 's' to attempt navigation to HTTPS. Bug: 1061576 Change-Id: I94d96bcb89b20a8c8bf2fc63dd5825d25f799907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122861 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754196}
-
Marijn Kruisselbrink authored
Color should be different in for example dark mode, so make sure to get the color from the current theme. Bug: 1065451 Change-Id: I581605d4f4c52f2ca2a50126e1a20d9ec865c2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125034 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#754195}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4085.6-1584956258-benchmark-83.0.4091.0-r2 to 83-4085.6-1584956258-benchmark-83.0.4094.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie79981394a2c345a7f729494c39b6935ec3d04f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125111Reviewed-by:
-
edchin authored
In recent CL: crrev.com/c/2122820, EXPECT_EQ was inadvertently changed to ASSERT_EQ. This CL fixes that recent mistake. Change-Id: I239e980a7ae7b24ae709faeff3e57be3078c2b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125018 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754193}
-
Robert Ogden authored
Bug: 1023485 Change-Id: I8581e00f867b04e5312df0ea1fabdb06690c4d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121086Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#754192}
-
Robert Ogden authored
This CL actually makes a working feature out of Isolated Prerender. Now, prefetches done by the tab helper will be taken and used by the navigation interceptor and replayed over mojo channels via FromString Loader. For ease of manual testing, this CL also adds some command line flags: * override proxy hosts * set unlimited number of prefetches per SRP Additionally, the following changes are also made: * remove the FromSRP feature flag, consolidating under kIsolatePrerenders * testing for probing moves to browser tests instead of unittests * isolation of prerenders support removed, but code stubs left in place since that support will be re-added soon * small mojo receiver leak fixed * added prefetch timeout Bug: 1023485 Change-Id: I7b4d9e30a3e125b525b7b10ce5151b82570c84f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118397 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
