- 24 Sep, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cbf276fd..c38bb894 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebfd7d4ce71422995b4c0461842a52db5f7281d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822997Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699496}
-
Joel Hockey authored
Enterprise policy can disable crostini backup and restore. When it is disabled, we remove the 'import-crostini-image' FileHandler from FilesApp. Bug: 1003944 Bug: 1006112 Change-Id: I46a58a751002c308eeae3e07be796b956dba5818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808979 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#699495}
-
Tom Anderson authored
BUG=419673 R=thestig Change-Id: I89433586961352e0f74d58c4f78caa0c5da61e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820024 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699494}
-
ssid authored
Trace metadata is almost always discarded in discard buffer mode of perfetto tracing. For this case, add metadata at beginning of the trace. Handles cases when generators are added while tracing. Change-Id: I911794fba1e7b460ca1a7a3a54599a8c05678d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812248 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#699493}
-
Reid Kleckner authored
Note, this is a functional change! The boolean condition as written simplified to be always true. I updated the code to work as I believe the author intended it to work, and am assuming that tests will catch any undesired change in behavior. R=qinmin@chromium.org Bug: 1007367 Change-Id: I87ca8c91f4b65bf8a28164d301bbbf242f5fdc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822717 Auto-Submit: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#699492}
-
Carlos Caballero authored
MessageLoopForIO is going away soon. Using SingleThreadTaskEnvironment will not work here as this code just needs to forward tasks to the real TaskRunner registered in a different shared library. See function comment for JNI_CronetTestUtil_PrepareNetworkThread for all the details. Bug: 891670 Change-Id: Ia9c99c4617338a2cfcd5be33fee49afd19e04eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795425Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#699491}
-
Leonard Grey authored
This reverts commit 933fab83. Reason for revert: Test was reverted in r699467 Original change's description: > Sheriff: Mark external/wpt/webxr/xrWebGLLayer_constructor.https.html leaky > > TBR=alcooper@chromium.org > > Bug: 1007304 > Change-Id: I6c05567f32e02a9d17c429ed8eaa9e03b0cac7b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822739 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699484} TBR=lgrey@chromium.org,alcooper@chromium.org Change-Id: I554fe7fe99f1e2579c2861f914ac02b6bec87b55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822826Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#699490}
-
Eugene But authored
The test is flaky on device and simulator. TBR=javierrobles@chromium.org Bug: 1007455 Change-Id: I55c4b98dbaa890cfc841350785b8e08a18c9488f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823319Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699489}
-
Leonard Grey authored
These are currently disabled for a subset of bots but have been flaking generally: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVAsSBUZsYWtlIkljaHJvbWl1bUBjb250ZW50X3VuaXR0ZXN0c0BJbmRleGVkREJEaXNwYXRjaGVySG9zdFRlc3QuUHV0V2l0aEludmFsaWRCbG9iDA https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYQsSBUZsYWtlIlZjaHJvbWl1bUBjb250ZW50X3VuaXR0ZXN0c0BJbmRleGVkREJEaXNwYXRjaGVySG9zdFRlc3QuT3Blbk5ld0Nvbm5lY3Rpb25XaGlsZVVwZ3JhZGluZww TBR=dmurph@chromium.org Bug: 995716, 989723 Change-Id: Ib8c97339ee28aad8c803acba47dccf10e1ec0d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822825Reviewed-by:
-
Kurt Horimoto authored
This CL adds OverlayRequestCancelHandler, an object supplied to the OverlayRequestQueue that can cancel an individual request. A default option is available that cancels requests for all committed, document- changing navigations. Other overlays that may want to cancel using different heuristics can supply a custom cancel handler subclass. Bug: 1005613 Change-Id: I1113e26a52f9b910195be2a5a35416f3cc994dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812362 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699487}
-
Christopher Thompson authored
Add component installer, configuration API, and the various plumbing to add it to Chrome. The installer and configuration is largely based on the existing Safety Tips component (i.e., safety_tips_component_installer.h/cc and safety_tips_config.h/cc). Bug: 989607 Change-Id: If48016acc8032eacf2eb0393795fc5e66dcc892c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769634 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699486}
-
Khushal Sagar authored
R=fserb@chromium.org Bug: 900706 Change-Id: Ib58c4bf7125493786418731d4882c711fce9900a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820014 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699485}
-
Leonard Grey authored
TBR=alcooper@chromium.org Bug: 1007304 Change-Id: I6c05567f32e02a9d17c429ed8eaa9e03b0cac7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822739Reviewed-by:
-
Michael Crouse authored
This change creates the interface for the PredictionModels to be used in the OptimizationGuide Prediction System. The interface provides a factory method for creating the ModelTypes supported by the current client. The interface implements functions common to all PredictionModels, including the version and providing the set of features required for the model to be executed. The Prediction API function is pure virtual so that all concrete implementations can implement the evaluation methods specific to their ModelType. The Slow Page Prediction model will be of DecisionTree ModelType. The next change will implement the decision tree evaluation. Once the PredictionManager and ModelFetcher is in place, a browsertest will be implemented to test the IsValid proto checks for ModelType and ClientModelFeatures which cannot be easily unittested. Bug: 1001194 Change-Id: Ifae7af2712568405909632e1ae2e6beca2e001da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817582Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#699483}
-
kylechar authored
This CL adds OutputSurface::Capabilities::supports_dc_video_overlays. In a previous CL I added supports_dc_layers. This only indicates the support for direct composition though, not direct composition video overlays, so a second flag is necessary. Bug: 1007055 Change-Id: I8b916f3051c595b3be98d639b26c04ac23bb977d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822018 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#699482}
-
Boris Sazonov authored
Migration to PreferenceFragmentCompat allows using getString method from that class instead of more lengthy alternatives like getResources().getString. No behavior change should occur from this CL. Bug: None Change-Id: I05bcef1fbba40cb171684ecc54a70b400a020bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822937 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#699481}
-
Eric Stevenson authored
This is a reland of 89cc7c83 Reason for reland: Verified that downstream has rolled past the CL removing the downstream usage. Original change's description: > JNI refactor: Remove unused method from UrlUtilities.java. > > Downstream usages have been updated to use proxy native methods. > > Bug: 929661 > Change-Id: I05cb9a3a520ae58006395f3826487f92f14e5e74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818871 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698919} Bug: 929661 Change-Id: Ief1ae5461d9425db788afc385ea36f3df96c0f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821742Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699480}
-
Austin Tankiang authored
This code was used to retrieve images from drive back when the legacy sync client was around. It can be safely removed now that DriveFS is the default. Bug: 1003238 Change-Id: I3348661cd0e5fec3f837f52e1aa60e99416520bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820402 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Benjamin Beaudry authored
This change is an optimization of AsTextPosition(). It's part of the larger performance improvement related to the expensive calls to MaxTextOffset(). AXposition::CreatePositionAtStartOfDocument() calls repetitively AxTextPosition() to allow converting from a tree position and to a text position and back, but this required calling MaxTextOffsetInParent() a lot. In a simple navigate-by-word situation, every call to AsTextPosition() would call MaxTextOffsetInParent uselessly. This change fixes it. There is no need to get the MaxTextOffset of an AXPositionInstance when the |text_offset_| will be positioned at the beginning of the anchor. We expect to position the text_offset_ of a Text Position at the beginning of the anchor when |text_offset_| is either invalid, already at 0 or less than the actual new_offset. All I did was adding a check for these conditions before calling MaxTextOffsetInParent(). I measured the perf difference with a trace captured with WPR and analyzed with WPA. In both cases, the traces consist of 10 words read by Narrator with navigate-by-word navigation. Without patch: ExpandToEnclosingUnit: 2,169 ms CreatePositionAtStartOfDocument: 103 ms With patch: ExpandToEnclosingUnit: 1,851 ms CreatePositionAtStartOfDocument: <1 ms Bug: 928948 Change-Id: I41d896dd25519eaba6a8c82d0ffacd3fbdedd909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811221 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699478}
-
Renjie Tang authored
Change-Id: I092ee4860dc1de33dcb0ed1171e5acbbe17b8471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819841 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699477}
-
Steven Bennetts authored
This adds GetNetworkCertificates to the mojo API. A follow-up CL will use the new api in the Settings WebUI. Bug: 1001598 Change-Id: If754a6955f10ee23264dd2a4e976922928258b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817201 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699476}
-
Connie Wan authored
Change-Id: Ia11827685185902bfd443f64af48cb2fca5b1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822028Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#699475}
-
Shakti Sahu authored
For cancelled downloads, we unregister DownloadController as an observer, before the download is cancelled. Hence the infobar doesn't get the onDownloadUpdated callback. We need to cancel the infobar right before cancelling the download. Bug: 1007167 Change-Id: I3d1e186b63515320fddeef9c567668a8a9a437e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822817Reviewed-by:
-
Sam McNally authored
On ChromeOS, PlatformUtilTest tests indirectly result in the global SystemNetworkContextManager instance being set, initialized with the local state PrefService owned by the TestProfileManager managed by BrowserWithTestWindowTest. When the second test in the fixture runs, the retained PrefService pointer is dangling, resulting in a use-after-free. Add a conditional SystemNetworkContextManager cleanup to BrowserWithTestWindowTest::TearDown() to avoid leaking it between tests. Re-enable PlatformUtilTest.OpenFolder now that it passes reliably. Bug: 1004639 Change-Id: I03c9d06cb98c258a3db8741e6f2576f887cdb705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821697 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Tom Anderson authored
R=pkasting BUG=None Change-Id: Ife6d481a840fc23b7aac527de332e4185d744ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822841 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699472}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f07a36341330..4c2146f2ca2a git log f07a36341330..4c2146f2ca2a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 brianosman@google.com Interpreter: Add bitwise shift operators Created with: gclient setdep -r src/third_party/skia@4c2146f2ca2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I11904cab592f3b121153932a66e6e8ea2153394f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821963Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699471}
-
Eugene But authored
The tests are flaky on iPhone/iPad, device/simulator. Flakiness was not observed on iOS 12. TBR=danyao@chromium.org Bug: 1007432 Change-Id: I0f6ce5d20b2bee9eb550d60036124033038cb1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822844Reviewed-by:
-
Sasha McIntosh authored
Part of an ongoing cleanup of unused format uyvy. Bug: 988538 Change-Id: I327b4a3931cc16a51ccc370ed1730aad36f2ae75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810801Reviewed-by:
-
Adam Ettenberger authored
|LowestCommonAnchor| is always cheaper than |LowestCommonAncestor| when the ancestor position data is not needed. I made some low-hanging optimizations to AXPosition after adding |CreateAncestorPosition|, since in many cases the position was being discarded after calling |LowestCommonAncestor|. Note that |LowestCommonAncestor| is equivalent to calling |CreateAncestorPosition| with the result of |LowestCommonAnchor|, so this is an improvement whenever |LowestCommonAnchor| is not the same as the anchor of the initial position. In any other case, there will be no difference in performance. The methods that took this optimization are : * CreateNextWordStartPosition * CreatePreviousWordStartPosition * CreateNextWordEndPosition * CreatePreviousWordEndPosition * CreatePreviousFormatStartPosition * CreateNextFormatEndPosition * CreateBoundaryStartPosition * CreateBoundaryEndPosition Bug: 928948 Change-Id: Ie25f5dfb293c604e0c34f348d276edac14d35ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814670 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
-
Alex Cooper authored
xrWebGLLayer_constructor was mistakenly updated to require user activation though the spec does not explicitly require it in this case since the inline session does not request any features. Even were it to require this, the way that it was structured caused there to not be a promise set when the ".then" was caused, giving a script error. This change essentially reverts WPT Commit 16d4388, and was discussed with Mozilla when deciding which way to fix it. Bug: 1007304 Change-Id: I824f63cb172aed5928c55224b31c00803b5ddaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822821 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#699467}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/67309ef93c4f..af3fdc069d52 git log 67309ef93c4f..af3fdc069d52 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 gustaf@webrtc.org AEC3: Suppression filter handles multiple channels Created with: gclient setdep -r src/third_party/webrtc@af3fdc069d52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I66bd0e276abd212e4b99ab28b0843d211ad6d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821962Reviewed-by:
-
Christian Biesinger authored
As per this intent to implement: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/blink-dev/hbhKRuBzZ4o Spec: https://github.com/WICG/intrinsicsize-attribute/issues/16 Bug: 979891 Change-Id: I0f9ffa1584fa12a41393ef05daffb7238c97e990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790472 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699465}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iae0d597135571893f290ecd20c284aceee68d750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822282Reviewed-by:
-
Yi Gu authored
crrev.com/c/1787118 skipped kHitTestAsk for root_view. However, it did not reset the flag and async_hit_test_reasons when the target is returned. Bug: 999576 Change-Id: I9ba111af29687b2c86b0a69c8cd7e3df83686de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818432Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699463}
-
Peter Kasting authored
Bug: 82078 Change-Id: I3bbe1dbbf33aaf3c700b35b55576a8f41334aab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820538 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699462}
-
Eugene But authored
The flakiness was observed on iOS 13/13, iPhone/iPad, device/simulator. TBR=javierrobles@chromium.org Bug: 1007421 Change-Id: I75ee2ff2f2c6fc8c04be7d6307db03445c28fc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822979Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/59ab7b718b08..b87974eebeaa git log 59ab7b718b08..b87974eebeaa --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ahassani@chromium.org Revert "chromeos_config: disable lakitu builders" Created with: gclient setdep -r src/third_party/chromite@b87974eebeaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I684e7c6d6eb9629d053d93087929a39674aa5eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822281Reviewed-by:
-
Mustapha Jaber authored
This change adds support for navigation-controls media feature, which will initially be used to detect if the user agent supplies a back button present in its UI. This media feature will allow apps to avoid the "double back button" problem by letting them conditionally display a back button depending on whether the user agent is already displaying one. The logic for updating navigation-controls from its default state has not yet been implemented. Spec: https://github.com/fallaciousreasoning/backbutton-mediaquery Bug: 822944 Change-Id: If8bc5054c0591f7e822277a83119273b69aef0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802195 Commit-Queue: Mustapha Jaber <mustjab@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699459}
-
Aaron Leventhal authored
See intent to implement and ship on feature dashboard: https://www.chromestatus.com/feature/4666935918723072 TBR=kinuko@chromium.org Bug: 1006767 Change-Id: I1b5eb7d2f324c4008578e7f7e1cb08a9288520f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816803 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699458}
-
Gavin Williams authored
Bug: 1001056 Change-Id: I326b21b3e25e472fa15dc9bd9d9c97feb688ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815542Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#699457}
-
