- 15 Oct, 2018 40 commits
-
-
Michael Lippautz authored
Bug: 843903 Change-Id: I9271138dfcdf72cd67965ada3b3e8b03b3b89222 Reviewed-on: https://chromium-review.googlesource.com/c/1277803Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599613}
-
Marc Treib authored
Also add a ForTest suffix since it's only used in tests. Bug: 865936 Change-Id: I207e72a19905d77003aee1d9a4d951bbeaed105d Reviewed-on: https://chromium-review.googlesource.com/c/1280428 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599612}
-
Sergio Villar Senin authored
It was using the SinginManager API instead. The unit test was partially migrated too as the object now receives the IdentityManager as argument. The test still uses some APIs that will be eventually replaced by follow up CLs. Bug: 890791 Change-Id: I7a2f18bd8ce01eec85954b716b9064a914b613e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278788Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599611}
-
David Roger authored
Dasher accounts generally are not allowed to signout, because they may have synced data that belongs to their administrator, and this data must not leave their account. The intended way to remove a dasher account from Chrome is to delete the associated profile. Due to this restriction, aborting signin was not possible for a dasher account, even though the UI was shown. This results in a bad user experience where the user clicks on the "cancel" button, but signin is actually not cancelled. The fix implemented here is to allow the user to signout without deleting the profile. This is acceptable because the data has not been synced yet. Bug: 864761, 804360 Change-Id: Iffbcde87ee242ada2815cd13d0bf8c660726d900 Reviewed-on: https://chromium-review.googlesource.com/c/1278734Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599610}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/fb462224c0..445998d7ac Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/fb462224c0..445998d7ac Bug: None Change-Id: I33633b8471e968656eea5fd6c3c5bd8acba1c188 Reviewed-on: https://chromium-review.googlesource.com/c/1273139Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#599609}
-
Morten Stenshorne authored
TBR=foolip@chromium.org,kojii@chromium.org Change-Id: I3c7257c49e863229ffaa49b9519cb509e9fb7091 Reviewed-on: https://chromium-review.googlesource.com/c/1278733Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599608}
-
Arthur Sonzogni authored
Bug: None. Change-Id: I029c610108b54ea703ffa6afa7b5bdee22fc87e2 Reviewed-on: https://chromium-review.googlesource.com/c/1276567Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#599607}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8de6fec..6a25b208 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: I928bd61eb317067542db2f8062e07cf4494f3792 Reviewed-on: https://chromium-review.googlesource.com/c/1280123Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599606}
-
Rakina Zata Amni authored
This CL moves find-in-page scoping methods and idle task to a new class, FindTaskController and use the term "finding" instead of "scoping" there. FindTaskController is responsible for managing IdleFindTask, and notifying TextFinder of matches etc, so that TextFinder can manage markers, tickmark, notifying frame etc. Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I20701ec0542acb40ace471891a490612e73d700b Reviewed-on: https://chromium-review.googlesource.com/c/1278074 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#599605}
-
Florent Castelli authored
TBR=rmcilroy@chromium.org Bug: 863599 Change-Id: I01b49946bc5e704aaad0ae6aa39867417462eb26 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280427Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599604}
-
Darren Shen authored
This is a reland of a643a13e Changed it to use HideKeyboardByUser instead of HideKeyboardImplicitlyBySystem as we do not want to reshow the VK if there's focus (see description of HideKeyboardImplicitlyBySystem). A "proper" fix is to actually allow clients to specify whether an input field should bring up the VK (like inputmode="none" in HTML). Then we can just remove this special case code. TBR=jamescook@chromium.org, xdai@chromium.org Original change's description: > [VK] Hide the virtual keyboard when we enter window overview mode. > > When we enter window overview mode (e.g. by dragging the top of an app), > we need to hide the virtual keyboard because: > > 1) It blocks the overview mode UI for no reason. > 2) The previews of windows have blank space at the bottom because that's > where the keyboard is. > > Bug: 893856 > Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2 > Reviewed-on: https://chromium-review.googlesource.com/c/1278565 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599561} Bug: 893856 Change-Id: Ibe9a1873cda3972520c75338db1b108d6274e005 Reviewed-on: https://chromium-review.googlesource.com/c/1280098Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#599603}
-
Sergio Villar Senin authored
It's currently using the SigninManager API to retrieve the currently authenticated account's email. Replaced by the IdentityManager equivalent API so it could eventually use the identity service. Bug: 890778 Change-Id: Icff574cb51ee2ae32bb0e5edc8f658c0061e0343 Reviewed-on: https://chromium-review.googlesource.com/c/1280265Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Nikita Podguzov authored
There is no "DeviceSetting" field in ManagedProperty, so it should be replaced with "SharedSetting". Bug: 877424 Change-Id: I09254246be27ead01a43aa79a648a12d3382daeb Reviewed-on: https://chromium-review.googlesource.com/c/1277790Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#599601}
-
Andrew MacPherson authored
This is a reland of 96b1bcfd Original change's description: > Implement the IAudioClient3 interface to allow lower output latency > for use in Web Audio via the latencyHint. Update AudioParameters > adding HardwareCapabilities with min_ and max_frames_per_buffer > representing the min and max buffer sizes supported by the audio > hardware so that requested buffer sizes can be appropriately clamped > in AudioLatency::GetExactBufferSize(). > > Bug: 316908 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ibafe6d917ec4d57a16092f040b57b4ff27ed54b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1165236 > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> > Cr-Commit-Position: refs/heads/master@{#597497} Bug: 316908 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I804e9546332ba00e69a032e587e451bc75b7f022 Reviewed-on: https://chromium-review.googlesource.com/c/1269527Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#599600}
-
Florent Castelli authored
TBR=drott@chromium.org Bug: 895257 Change-Id: I21c5097c48a46ce8cf3843dd179f69d628c23f0d No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280422Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce051618ed0f..1569ee5f6ea3 Created with: gclient setdep -r src-internal@1569ee5f6ea3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I333bf4bfb3e89052d0f5757a2b5a7b84d440f97c Reviewed-on: https://chromium-review.googlesource.com/c/1280106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599598}
-
Kamila authored
Allow adding exceptions of blocked sites, with ADD SITE EXCEPTIONS button, when JS is allowed by default. Currently, adding exceptions is only possible when JS is blocked by default. Bug: 748109 Change-Id: I215366ce1596f00bba46b6a5896afcf1d2b902ba Reviewed-on: https://chromium-review.googlesource.com/c/1261518Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#599597}
-
Keiichi Watanabe authored
Use prefix "UsingRealWebcam_" for names of tests that require real webcam and add checking whether webcam is found or not. Accordingly, exclude such test cases from test suites for devices that have no camera. and it failed. and it passed. and it passed. Bug: 893494 Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado) Test: Run capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado) Test: Run capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin) Change-Id: I9ba9657b47afadf6f3128cdcb91e74e1793040b4 Reviewed-on: https://chromium-review.googlesource.com/c/1278432Reviewed-by:Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599596}
-
Daniel Bratell authored
There is both a ::safe_browsing::switches namespace and a ::switches namespace. If you inside the safe_browsing namespace write |switches| it will map to ::safe_browsing::switches if that namespace is known to exist. In some jumbo builds where many cc files are compiled together the compiler knows about that namespace and chooses it wrongly. There is a style guide instruction to not use sub namespace names that are identical to top level namespace names, probably for this reason, so maybe all sub namespaces named |switches| should be given new names, the same way that has already happened to some |features| namespaces. This patch is a small trivial fix, add a :: prefix to |switches| to make it clear which |switches| namespace is intended. Change-Id: I2f39ca26b2174455b94eeadd8b6cfb756248a6c9 Reviewed-on: https://chromium-review.googlesource.com/c/1278729Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#599595}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/abd997aa7cf2..428854931e68 $ git log abd997aa7..428854931 --date=short --no-merges --format='%ad %ae %s' 2018-10-10 wl Minor. 2018-10-07 wl A missing Unicode cmap is not a fatal error. 2018-10-07 wl Fix handling of FT_CONFIG_OPTION_ADOBE_GLYPH_LIST (#54794). 2018-10-07 wl Whitespace. 2018-10-07 wl Minor comment improvement. 2018-10-03 wl [ftgrays] Fix typo in stand-alone mode (#54771). 2018-10-02 wl [psaux] Fix segfault. 2018-10-02 wl [psaux] Fix numeric overflow. 2018-10-02 wl [pshinter] Handle numeric overflow. 2018-09-27 apodtele Align FreeType with standard C memory management. 2018-09-26 apodtele Typo. 2018-09-25 wl Typo. 2018-09-25 wl Fix handing of `FT_Bool'. 2018-09-23 apodtele [bdf] Speed up charmap access. 2018-09-22 apodtele * src/base/ftobjs.c (ft_glyphslot_reset_bimap): Another tweak. 2018-09-21 apodtele * src/base/ftobjs.c (ft_glyphslot_reset_bimap): Further tweak. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1177 Change-Id: Ifd64ec309073f0eb6c54423c316f5c234d57a6fc Reviewed-on: https://chromium-review.googlesource.com/c/1273558Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#599594}
-
Florent Castelli authored
TBR=ricea@chromium.org Bug: 895246 Change-Id: I4d9d000fcd011dce830c7b0b163655b59c4ae49e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280244Reviewed-by:
-
Matthew Cary authored
The bugs below suggest that under thinLTO, the system health orderfile regresses memory, as well as performance (the latter probably even without thinLTO). This CL reverts back to the simpler orderfile. Bug: 758566,893981,894827 Change-Id: I93c898dd7c8d55311ac3aed08815c610573c49c2 Reviewed-on: https://chromium-review.googlesource.com/c/1277804Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#599592}
-
Henrik Grunell authored
Example log line: AudioService: AudioStreams=enabled, OutOfProcess=enabled, LaunchOnStartup=enabled, Sandbox=enabled, ApmInAudioService=enabled Bug: 888971 Change-Id: I17cb7b1acafa7ff41c5fe9de67ed176c9008c7a7 Reviewed-on: https://chromium-review.googlesource.com/c/1278752Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#599591}
-
Yutaka Hirano authored
It's now not used. Bug: 875153 Change-Id: Ia7d42f503617563c1d4e82c9eaa0c67aae36baa1 Reviewed-on: https://chromium-review.googlesource.com/c/1275487Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#599590}
-
Adam Rice authored
When blink::BodyBuffer::StartLoading failed , the ScriptPromiseResolver was left unresolved, resulting in a DCHECK when it was destroyed. Resolve it explicitly in this case, to avoid the DCHECK and retain the invariant. BUG=893015 Change-Id: Ib437986c6dc0d8b40e8ed0040f8796387d94feb6 Reviewed-on: https://chromium-review.googlesource.com/c/1278613Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#599589}
-
Florent Castelli authored
TBR=nednguyen@google.com Bug: 895238 Change-Id: Ice423436c23c47a4334edf0928afe143c211286c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280242Reviewed-by:
-
Kenichi Ishibashi authored
Before this CL we recorded worker ready time just after getting a mojo pointer to the controller service worker, but getting the mojo pointer doesn't guarantee that the controller service worker is actually running. This means that the recorded timing didn't capture worker startup delay. To have more accurate timing, use |dispatch_event_time| of ServiceWorkerFetchEventTiming as worker ready time. |dispatch_event_time| is recorded just before dispatching a fetch event so this is reasonable. Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 877972 Change-Id: Ifb8e905095794770dd8a4973e1e0d569ccfde00e Reviewed-on: https://chromium-review.googlesource.com/c/1278459 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#599587}
-
BUG=762641 TBR=achuith@google.com Change-Id: I20f03272b5b8fffca13ebaafac94237c2668ef51 Reviewed-on: https://chromium-review.googlesource.com/c/1280144 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599586}
-
Roman Sorokin authored
BUG=chromium:887577,chromium:875480 Change-Id: I0579e0694e1e4f7c9ed3f1988f623b2558a36e40 Reviewed-on: https://chromium-review.googlesource.com/c/1278167Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599585}
-
Max Rebuschatis authored
Bug: 837834 Change-Id: I7d3b81b0ae2290e58d18a623dc0f573afe83d955 Reviewed-on: https://chromium-review.googlesource.com/c/1197225Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#599584}
-
Tetsui Ohkubo authored
This CL implements stacking notification counter at the top that shows number of hidden notifications above the visible area. NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: I829c75ae4642c7cf0d7408defe3d59c1a68977a2 Reviewed-on: https://chromium-review.googlesource.com/c/1278690Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#599583}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I5e8b2d3d3e2d0975cc5713fdae4b85969308a906 Reviewed-on: https://chromium-review.googlesource.com/c/1264435Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599582}
-
Darren Shen authored
This reverts commit a643a13e. Reason for revert: <INSERT REASONING HERE> Original change's description: > [VK] Hide the virtual keyboard when we enter window overview mode. > > When we enter window overview mode (e.g. by dragging the top of an app), > we need to hide the virtual keyboard because: > > 1) It blocks the overview mode UI for no reason. > 2) The previews of windows have blank space at the bottom because that's > where the keyboard is. > > Bug: 893856 > Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2 > Reviewed-on: https://chromium-review.googlesource.com/c/1278565 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599561} TBR=jamescook@chromium.org,xdai@chromium.org,shend@chromium.org Change-Id: Ie5ff6ccd70f24b40ba861c08de1467f87f7fcd62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893856 Reviewed-on: https://chromium-review.googlesource.com/c/1280093Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e99cee81..b8de6fec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: Ib9034fdf308773f720c8d730ad239845a93f4daf Reviewed-on: https://chromium-review.googlesource.com/c/1279961Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b20c6f0282d..ce051618ed0f Created with: gclient setdep -r src-internal@ce051618ed0f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I74734ac8304f52666d6ffee16779e10b41bded09 Reviewed-on: https://chromium-review.googlesource.com/c/1280104Reviewed-by:
-
rhalavati@chromium.org authored
Removal of user data from Android Media and WebRTC notifications is enabled. Bug: 629887 Change-Id: Iafda3010a7b0079e7220be2fbca0d67522a75407 Reviewed-on: https://chromium-review.googlesource.com/c/1278626Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#599578}
-
tzik authored
This CL contains IWYU fixes and an ADL elimination in order to maintain base::Optional replaceable with std::optional. color_helpers.cc and navigation_url_loader.h used to depend on the indirect include directives around base/optional.h, that will be unavailable on the C++17 mode build. In render_widget_unittest.cc, a base::Bind name is pulled by base::Optional on the parameter type of HandleCallback, which will be unavailable after base::Optional is replaced with std::optional. Tbr: dtrainor@chromium.org Change-Id: I132b02da61484f72020e9f7fb5b12c8a21a22d37 Reviewed-on: https://chromium-review.googlesource.com/c/1280063 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599577}
-
Sergei Datsenko authored
Those have absolutely no need to be forward-declared and it just makes navigating through the file a pain. BUG=chromium:883637 Change-Id: I13b671d077e8a778ca79ceb33272c757cea427a0 Reviewed-on: https://chromium-review.googlesource.com/c/1280089Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#599576}
-
Kent Tamura authored
* Document::sequential_focus_navigation_starting_point_ count be a disconnected Range if a shadow tree including a focused element is disconnected. Introduce Range::FixupRemovedNodeAcrossShadowBoundary() to keep connected nodes in the Range. * Range::FirstNode() can be a ShadowRoot if a focused element in it is disconnected. We use FlatTreeTraversal instead of ElementTraversal to find a neighbor element. Bug: 705786 Change-Id: I51986133fd2ce01fe14a96d19c0ab4e477667feb Reviewed-on: https://chromium-review.googlesource.com/c/1278408 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
The parameter |scope| is unused, remove it. The member |scope_| of ServiceWorkerProcessManagerTest is unused, remove it also. BUG= Change-Id: I32dbdc1502ff6b8b121ca4d1f09cec325d1b9cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1278453 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
