GitLab

This CL fixes an invalid reference when ENABLE_BASE_TRACING is disabled.

It is done by moving all references to tracing clases inside the trace
event macro, which is compiled out when base tracing is disabled.

Change-Id: I3cde469873163ac457fc9d1057b02f6da17b6632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535610
Commit-Queue: Salvador Guerrero <salg@google.com>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826994}

Moving appropriate builders into it.

Bug: chromium:1127088
Change-Id: Ie4bc188c2ef86a8f87e7b9d606c34d06651ced50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534177
Auto-Submit: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826993}

This allows reading the Managed Preferences equivalent of the existing
preference path allow rules in common.sb.

This also allows reading ~/Library/Preferences/com.apple.security.plist
in network.sb.

Bug: 1134449
Change-Id: I42d414e5133c5931907d38c2bdb26d1431f837e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535650Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826992}

... decryptable ones.

Before this CL, if the sync server sent an update for "ServerId"
encrypted with an unknown key, then sent an update for the same id
encrypted with a known key, the data type would remain blocked.

The CL fixes this by removing any entry in entries_pending_decryption_
with the same id as an incoming successfully decrypted update.

Fixed: 1148359
Change-Id: I56ef2d8c73686ff9375cfd1ff7d48da1a5fe53c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535230Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#826991}

- Added phone name to the notification and fix the text layout according
to spec.
- Added IDs to access app name and summary text in NotificationViewMD
for customization.

Screenshots:
https://screenshot.googleplex.com/3sbTp3UdCCbmEHZ
https://screenshot.googleplex.com/62qWt4XimsUwMKB
https://screenshot.googleplex.com/5ie8JCirGmYpeS2
https://screenshot.googleplex.com/5KvapXRjX9zBKXP

Bug: 1106937,1126208
Change-Id: I401566ad05e248a724f3665f0c1e4c9d1a7891c5
Fixed: 1147264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532041Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826990}

This CL replaces most calls to NavigateFrameToURL(...) with
EXPECT_TRUE(NavigateToURLFromRenderer(...)).  Note that not all such
calls have been replaced (e.g. this CL skips the ones where the
naive/mechanical replacement would have caused test failures).

For motivation (i.e. why NavigateFrameToURL is slightly undesirable)
please see the linked bug.

Bug: 1148049
Change-Id: I5b341c3e7cc2e0774d905705b2ca891dc0be862f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532855
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826989}

Unit and browser tests to be added in a follow-up. Tested against local
service implementation.

Design doc: go/permission-predictions-client-doc

Bug: 1138595
Change-Id: Ie685853401f5ecc76fa7821092cf962f49cad0dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526681
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Ravjit Singh Uppal <ravjit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826988}

This reverts commit 6e5cadb7.

Reason for revert: compile failure
https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/22520?

Original change's description:
> Added support for one-time geolocation permission grants on desktop.
>
> Expanded the current permission request dialog to have the possibility
> to accept the permission for only one time.
>
> The permission will be invalidated when all the tabs with that origin
> are closed or navigated away from, or if a day has elapsed since the
> grant, whichever comes earlier.
>
> Bug: 1147918
> Change-Id: I9f0cc029d0bd2cae56e433d8ba753e73495476f4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483832
> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826981}

TBR=vasilii@chromium.org,engedy@chromium.org,ravjit@chromium.org

Change-Id: I511823b3a656f211c472d76a9cce2d30ca7ab644
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1147918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536153Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826987}

This CL adds metrics to track the position of a closed tab from
both filtered and unfiltered lists.

Bug: 1099917
Change-Id: I32ee18442cf965a05d7d92152ffc730c34674538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530260
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826986}

Add a base::Feature to control Manifest V3 support. If disabled, all
Manifest V3-based extensions will fail to load. This should only be
used as a last resort, and is very much a kill-switch (rather than a
gradual ramp-up tool).

By default, this feature is enabled (allowing manifest v3 extensions).

Bug: 1147344
Change-Id: I3e30ad76fce12bae584a625c81e3759b31d9478e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520333Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826985}

This enables use of ThumbnailSchedulerImpl in ThumbnailTabHelper.

Bug: 1090038
Change-Id: Ie1961e142d48f4c821a668e46fe804449b050725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532910Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826984}

Ran `tools/clang/scripts/upload_revision.py 418f18c6cdfe56e77669e2f4d3df3bca1020156d`.

Bug: 1147865
Change-Id: I4d734771fb846367d5bcf33b31293e04039c4f4b
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:mac-arm64-rel
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532714Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826983}

Test: Manually tested on Dut.
Fixed: 1146655
Change-Id: If922581c6987815dacf4277359dcf2ff98a4bd31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532309
Commit-Queue: Judy Wang <shidi@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826982}

Expanded the current permission request dialog to have the possibility
to accept the permission for only one time.

The permission will be invalidated when all the tabs with that origin
are closed or navigated away from, or if a day has elapsed since the
grant, whichever comes earlier.

Bug: 1147918
Change-Id: I9f0cc029d0bd2cae56e433d8ba753e73495476f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483832
Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826981}

I'm flushing my queue of niggles that I've noticed over time:

1. The |Callback| interface in |CableAuthenticator| is moot. It always
   calls |CableAuthenticatorUI|, which is in the same package. There's
   even an |mUi| member already.
2. In a couple of cases calls were moved to the |mTaskRunner| thread,
   but since the Mojo network interface only works on the UI thread, we
   know that's the UI thread now and thus the transition is moot.
   Replace them with asserts.
3. A number of methods were more public than needed. If not specified,
   Java defaults to package-private, which works for a lot of cases
   here.

BUG=1002262

Change-Id: Ieee4ab7fc9c1f3ae339d661b2ed5ce6e1adb28ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531178
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#826980}

Any change to DSE should cause the search prefetch cache to be cleared.
While it is only necessary to clean up when url or search post params
change, it is healthier to clean up whenever DSE changes state.

Bug: 1138647
Change-Id: I6f995b5423464decd823a33b9c71262cf3999c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515365
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826979}

Roll Chrome Mac PGO profile from chrome-mac-master-1605182400-7fb6cfb0609ea611bc3a38e3ac52d34b26c93566.profdata to chrome-mac-master-1605203985-0458f2948c8ea3f9d90fd537422a290135941c1f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia6fa53fd930e191af8419008d90f38a4001e7296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535931Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826978}

The motivation behind this is to remove usages of
registerMessageCallback() test helper in order to eventually fully
remove it. The usage in device_page_tests.js is actually the last
usage of this helper.

Bug: 1148403
Change-Id: I734fe61bfd7bdd7c440658618ac5486c3c1d06a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534152
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826977}

With that policy admins can override whether modules are shown on the
new tab page.

Bug: 1142878
Change-Id: I9d7683b587fa1f1b8fd1e7f861f6789bc96e179e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531181
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826976}

CastOptionsProvider has to be part of the implementation library.
This was broken in 48d00622

Bug: 1057099
Change-Id: Idf2f0c56ff8fc65f83b22ddef77d3bca9361b148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534401Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826975}

For the purposes of measuring the Simplified Domain Display
experiment, we're using a Suspicious Site Safety Tip, but we're
removing the call to action buttons because we don't want to push the
user towards what to do; rather, we want to direct their attention to
the omnibox and then use the simplified domain UI to make a decision
about what to do.

This change therefore removes the buttons and Learn More link for the
Suspicious Site Safety Tip.

Bug: 1146471
Change-Id: I6101d1af604571a8b439f7096dab356795794962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532871
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826974}

The UKM added is similar as the existing UMA metrics
TrustedWebActivity.QualityEnforcementViolation.
Add the UKM to help us identify popular sites that violate the
quality criteria often.

New UKM collection review:
https://docs.google.com/document/d/1zBXtJ9D8JBbBNtNdQhWhjHMz0Lry3h5MCgUOpxphfCs/edit#

This CL also fixes a bug with the QualityEnforcementViolation UMA:
When record the "Crashed" metric, the general metric will also be
recorded again.
Luckily we are not enabled the crashing part , so there should have
impact on the collected data.

Bug: 1147483
Change-Id: Id250c7037e951558be12186568f5520d48528354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530591Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826973}

Fixed: 1147714, 1147717

Change-Id: I067f651bdfaaf9459c9321fa9238d18f816d0bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534792Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Javier Flores <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826972}

Roll Chrome Linux PGO profile from chrome-linux-master-1605182400-0a4bd93b21630824fe02bcc8b97bd908ea587b84.profdata to chrome-linux-master-1605203985-a72b3d0424c525881821dc3609a4c23423acaf56.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I7abbe7a128e804d02bea924f58788d8596634f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535552Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826971}

Change-Id: I745619cefd609214b4c98b460224886159d76ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535219Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Devon O'Brien <asymmetric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826970}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I288bd7602fdddceba1755668757b68e2c04a34ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826969}

This CL translates the path-to-regexp parser from typescript to c++.
Its based on the code here:

https://github.com/pillarjs/path-to-regexp/blob/125c43e6481f68cc771a5af22b914acdb8c5ba1f/src/index.ts#L126-L232

We deviate from the path-to-regexp code in some terminology and output
structure.  In particular, we output a list of Part structures with
types of kFixed, kRegex, kSegmentWildcard, or kFullWildcard as discussed
in the design doc:

https://docs.google.com/document/d/17L6b3zlTHtyxQvOAvbK55gQOi5rrJLERwjt_sKXpzqc/edit#heading=h.ymw6rim68920

Note, this CL does deviate from the design doc as well in that we are
translating a more modern version of path-to-regexp than originally
planned.  This uses a "{...}?" style grouping for applying modifiers.
We also do not yet fully include support for the "*" wildcard character.
As such the grammar in the design doc does not really apply fully to
this CL.

Bug: 1141510
Change-Id: I1c3e4ef76587496301d2171fa9f76b51754dce0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518206
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826968}

Currently the initial position of the mouse can trigger the various
mouse event handlers for window cycle items. This causes the focus ring
to be set on unexpected items, despite the user just using their
keyboard.

This CL makes the window cycle event filter track the user's initial
mouse position, filtering mouse events until the user actually moves
their mouse or they click, drag, etc.

Test: manual + added
Bug: 1143275
Change-Id: I6a3b160aa2beb10e32c3b15b2d25e6f70cc5ca2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529569
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826967}

When waiting for a reply from a request, XCB (under some circumstances)
may only flush the request queue up to the request in question.  This
may cause unnecessary round trips.  To avoid this, add an explicit flush
where necessary.

R=sky

Bug: None
Change-Id: Ifaa1a43103517668b963d644d7ee628bbd1dc935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533397
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826966}

This CL modifies the frame-tree/session-history walk mechanism to only
consider WebContents in the same BrowsingContext as the WebContents
that is currently navigating and making the OIOI decision. This is to
prevent OIOI state from leaking between BrowsingContexts.

Bug: 1148379
Change-Id: I72bb4c0e3e6ffabbc8828eb2d59cae9e48b59b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534260
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826965}

Add // nongncheck for broker_service.h for a few files in
//chromecast/browser, otherwise the gn check will fail for gn
check on missing the gn target broker_service, even though it
is included already by arg  and buildflag
ENABLE_EXTERNAL_MOJO_SERVICES.

Bug: 169104485
Test: CQ
Change-Id: Iffe34806ed2e51fdb91216425a6133d0d5ba826b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533735Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhaoxin Liang <zxliang@google.com>
Cr-Commit-Position: refs/heads/master@{#826964}

Added two missing strings to show on reading list page when the list
is empty.

Bug: 1148480
Change-Id: Ifee700a0c873058e883a5a151ec14415cc4f2d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535016
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826963}

Per jamescook's remark in [1], feature will be deprecated in Lacros.

[1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit?disco=AAAAKwfILZM

After this, BrowserNonClientFrameViewAsh can be renamed
(ChromeOS suffix) and adopted in Lacros builds as well.

BUG=1113900
R=jamescook@chromium.org

Change-Id: Ic4b74fe7af16da17fc4ea12b5b3464d8759549f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532611Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#826962}

Bug: None
Change-Id: I1c0e69f6d9ac9bc38ff530de1d5034e893d1797e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521214Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826961}

This change replaces the hard coded "6.1.1715.1442/en (GGLL)" client
version with version_info::GetProductNameAndVersionForUserAgent() in
FormStructure::Encode{Query,Upload}Request().

Fixed: 1148394
Change-Id: I40b1b293a0cde586c7b22c4237dec7702a254ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535330
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826960}

Disable
org.chromium.android_webview.test.AndroidScrollIntegrationTest#testFlingScroll
due to flaky

Bug: 1147938
Change-Id: Ic701876e9c09399309b06827d1384b665b9b9509
Tbr: boliu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535554Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826959}

If browser is in fullscreen mode, the location bar isn't visible and
chip UI isn't visible too. This CLs implements using bubble UI in
fullscreen mode. It also fixes closing behaviour for permissions that
use bubble UI when chip feature is enabled.

Bug: 1148332
Change-Id: I7a519d0dc892f660c7ced39195338d60b4193d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532577
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826958}

The cancel button was added back due to privacy team's concern. UI
reviewers requested swapping the positions of the help button and
the cancel button, and adding button style to the cancel button.
Screenshot of this implementation has received a LGTM on UI review
thread.

Bug: b:156258540, b:144861739
Change-Id: I60d0bd83e305e2c737fad01cce67ee2c7b563cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531014
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826957}

BUG=851650

Change-Id: I56d69fa06ec030abad513ab61820dfb983f0473e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530196
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826956}

This change adds additional network diagnostic routines to the
connectivity diagnostics application:
  - HTTP Firewall
  - HTTPS Firewall
  - HTTPS Latency

Bug: chromium:1142857
Change-Id: I67810a58203d8eb45a5f75c94c5d3179b9627530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530593Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Trent Begin <tbegin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826955}