- 19 Mar, 2020 40 commits
-
-
Liviu Tinta authored
PointerCapture should work for Shadow DOM elements based on Pointer Events specification. Add web platform tests to ensure PointerCapture works with shadow DOM elements. Bug: 810882 Change-Id: I5f183afaab17689551f78903acba3e74f8cd49f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096112 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751687}
-
Delan Azabani authored
This CL migrates the comparisons that check whether an @ is @import or @charset from DeprecatedEqualIgnoringCase to EqualIgnoringASCIICase. They weren’t migrated as part of <https://crrev.com/c/2015875> and <https://crrev.com/c/2108441> because while DeprecatedEqual has an overload for StringBuilder and char* arguments, EqualASCII has no similar overload, and the simplest solution (replacing _rule with _rule.ToString()) is more inefficient than we’re comfortable with. Rather than adding similar special-case EqualASCII overload, I propose that we make StringBuilder implicitly convertible to a StringView that borrows its defined part, by way of a unary constructor. Google’s C++ style forbids this, but I think it’s appropriate here, because implicit conversions allow StringBuilder to participate in the plethora of utility functions that are only defined over StringView, just like String, AtomicString, LChar*, UChar*, and so on. These changes are potentially author-facing, but I’ve optimistically made them without any additional tests based on Rick Byers’ reasoning on blink-dev [1]. Please let me know if that’s not sufficient here. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ Bug: 627682 Change-Id: Ib60c84288f47ca4431db0a2dd8003d226b3f3bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106983Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/master@{#751686}
-
Randy Rossi authored
If we are already in one finger passthrough mode triggered by press on the edge, don't allow other fingers to clobber the initial press. Otherwise we will never send the release for the first finger. Bug: None Test: display assistant with screen reader enabled, back gesture Change-Id: I742102eeb3fad05f7a32b6c7cdd34b9036f6ddaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108866 Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#751685}
-
Evan Stade authored
Bug: 1007826 Change-Id: Ie65fbc4382a397145e085081cca188b37138d5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106393 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#751684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30a60eed32c2..3adef6f2983c Created with: gclient setdep -r src-internal@3adef6f2983c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1c0f2f2d6729cd0501e390c6e44efa54a1706a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109884Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751683}
-
Bryan McQuade authored
This patch refactors the page load metrics DidFinishNavigation logic, to support the needs of bfcache and in particular https://chromium-review.googlesource.com/c/chromium/src/+/2007095. Prior to this change, DidFinishNavigation was overly complex. It conditionalized various logic on the should_track boolean and had nested if/else branches which were difficult to follow. This change breaks DidFinishNavigation into a logical progression of steps: 1. finalize and destroy the previous tracker if we have a newly committed document 2. stop tracking the new commit if we should not track it 3. otherwise, invoke the navigation commit or fail callback for the new commit This does change the relative ordering of some operations, but all of these ordering changes are safe. In particular, previously, we ran (2) before (1). It is safe (and arguably more correct) to change the order since the operations in these 2 steps do not interact with each other. We also used to only invoke NotifyClientRedirectTo on the previous tracker if we were tracking the newly committed navigation. This was arguably incorrect, and we should have been invoking NotifyClientRedirectTo on the previous tracker unconditionally as part of committing a new navigation. Given that NotifyClientRedirectTo only logs UMA histograms for internal metrics tracking, there is not risk of affecting any critical metrics due to making this change. Change-Id: I1d0dba7f887a288adef35e95780844b3aed17397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107902Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#751682}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ic7c4f8bb6ae05db2debb827abe9c7ab565abb6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108312Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#751681}
-
Scott Violet authored
This was used to trigger different modes in the renderer. This wasn't the right way to do this, rather tests should use a special fieldtrial. This wasn't working because finch wasn't wired up. Now that finch is wired up the right config is being loaded and this code is not necessary (and wrong). BUG=1049426 TEST=covered by wpt Change-Id: Ifbe095a29033511b506395b195cc12e0485f8122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109146Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751680}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fabad157059d..1171d314efc7 git log fabad157059d..1171d314efc7 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 bsalomon@google.com Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots""" 2020-03-19 bsalomon@google.com Remove MoltenVK support 2020-03-19 bsalomon@google.com Use SkColorMatrix_RGB2YUV in image_from_yuv_textures Created with: gclient setdep -r src/third_party/skia@1171d314efc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I4e8484c259bb64dfc106bf76b8b87f57ee632710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751679}
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: Ifff2a6c8951ae53bcd068d5bed3abd54d0fafeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094305 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#751678}
-
Sadrul Habib Chowdhury authored
Add a browser-test to make sure that the throughput metrics are reported for scrolls. This does not validate what the actual reported metric is, rather this just verifies that some metric is reported. BUG=1035460 Change-Id: Idaa8f45efd28e51267b81bc4389709f7831ad555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099292 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#751677}
-
Anastasiia Nikolaienko authored
Add component and strings for parents list screen which allows the user to select parent who will approve the EDU account sign-in. See screenshots: http://go/crb/1043108#c2 Bug: 1043108 Change-Id: Ice90aa2234831cc79394b488c7d3c9b8def1485b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007755 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
-
Alexander Timin authored
Initially this was introduced for metrics purposes, but now this is superseded by tracking the number of WebContents associated with a given BrowsingInstance in the browser process. R=dcheng@chromium.org Change-Id: I0b35e675620ac0338977a180bdeaec668b8911e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091490 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751675}
-
Viktor Semeniuk authored
This CL changes the way visibility of 'No result view' is calculated. The label will be shown only if: - user had successful check with 0 compromised passwords found - user is signed in - breach detection is turned on in settings Bug: 1061496 Change-Id: I9f1e4b5f7aef51749b970964c2b701ee2193ba53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108501 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751674}
-
Gauthier Ambard authored
This CL clean up the code now that the omnibox button has been replaced by the new tab button. Bug: 974751 Change-Id: If2cc6aaac285ee9df884dafe5cf41ee268435cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102729 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751673}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7cbdcaef5c81..b6414c9da662 git log 7cbdcaef5c81..b6414c9da662 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 szuend@chromium.org Rename legacy global for protocol_client to ProtocolClient 2020-03-19 aerotwist@chromium.org [global] Remaps self.UI.viewManager 2020-03-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-19 szuend@chromium.org Rename namespace import for protocol_client to ProtocolClient 2020-03-19 aerotwist@chromium.org [global] Remaps self.UI.zoomManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@b6414c9da662 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f7132d4a0066a4930c2ed2f68b1ce29b36d7f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109881Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I6d14781969a8fdbe47c10870d43cde59f49fa427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106811Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751671}
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::InsertBefore|. In this function, the position is given as an iterator. Change-Id: I5f9e79e78b42eeded0daebf43df669485bf40c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108313 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751670}
-
Alexander Timin authored
R=csharrison@chromium.org CC=alexmos@chromium.org BUG=728571 Change-Id: I60c9855338b0074d51ede9819dfe09381ba104b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104048 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Jamie Madill authored
This reverts commit 03474222. Reason for revert: Suspected for failures in WebGL tests. See issue for more details. Bug: 1062940 Original change's description: > [Blink Heap]: Marking uses jobs API. > > Note: This CL enables feature BlinkHeapConcurrentMarking to get > the desired behavior. However, we should land enabling > BlinkHeapConcurrentMarking on its own first. > > active_markers + GlobalPoolSize() is used to determine > the desired number of workers. > > NotifyConcurrencyIncrease() is called periodically from > ConcurrentMarkingStep() if GlobalPoolSize() > 0, > to make sure enough workers are scheduled. > > CancelableTaskScheduler is no longer used and deleted in this CL. > > Benchmark v8.browsing_desktop on win-10-perf browse:news:cnn:2018: > blink-gc-atomic-pause-mark-transitive-closure: 13% improvement > blink-gc-atomic-pause-sweep-and-compact: 5% improvement > blink-gc-complete-sweep: 34% improvement > blink-gc-total: 2% improvement > https://pinpoint-dot-chromeperf.appspot.com/job/136a60ce620000 > > Bug: 1046343 > Change-Id: Ie2957abf200037ccacc017b1e38dc41f47811ee0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029609 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751502} TBR=haraken@chromium.org,mlippautz@chromium.org,etiennep@chromium.org,omerkatz@chromium.org Change-Id: I14a613a4fb54de640505d384c53b89507d02b1c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109970Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#751668}
-
Yann Dago authored
This test was flaking due to being overly sensitive to the granularity of base::Time::Now. This CL fixes it by using wider data ranges. Bug: 1059863 Change-Id: I87030c66de38df1704b9488f8baf2ac994885786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106415 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751667}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3411c20dad7..30a60eed32c2 Created with: gclient setdep -r src-internal@30a60eed32c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6eb2d33715ed513d505dab7032daf6e6c8e2ca1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109876Reviewed-by:
-
Clemens Arbesser authored
Bug: 1062715 Change-Id: I292622cea5d570335ad1004d7417e64aecb1497a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107623 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751665}
-
Manu Cornet authored
Change-Id: Ic9e61ec64caf8c338ec8e485c23e43c111d344be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108160Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751664}
-
Side Yilmaz authored
Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates NewTabPageLayout class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Id016428da394de240b0592e64064b8cddf233c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089766Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751663}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64e0899efa07..7cbdcaef5c81 git log 64e0899efa07..7cbdcaef5c81 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 aerotwist@chromium.org [global] Remaps self.Workspace.workspace 2020-03-19 tvanderlippe@chromium.org Update jsdoc_validator 2020-03-19 pfaffe@chromium.org Handle script language and code offset reported from the backend 2020-03-19 pfaffe@chromium.org Update CDP 2020-03-19 mathias@chromium.org Simplify list of vision deficiencies 2020-03-19 szuend@chromium.org [cleanup] Remove Promise.resolve async migration path in Linkifier 2020-03-19 szuend@chromium.org [cleanup] Enforce return type of LiveLocation delegate to be a Promise Created with: gclient setdep -r src/third_party/devtools-frontend/src@7cbdcaef5c81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700,chromium:1011811,chromium:1032016,chromium:1057569,chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6dcbeedca84487b6a173e885fe78aa771387bc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109877Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I89bb8a535daf6d824157579e01cacfcd462ed496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109874Reviewed-by:
-
Maxim Kolosovskiy authored
Assistant (no integration test yet) This CL implements the action for the "Change password" button in the credentials leak dialog. The button triggers an Autofill Assistant flow for password change. TODO: the integration test will be implemented in another CL once a compilation trick works (https://chromium-review.googlesource.com/c/chromium/src/+/2074761/38/chrome/browser/password_manager/chrome_password_manager_client.h#258). Bug: 1057608 Change-Id: I1d584b6e735a1bd3736221a1fee35c4215b15c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106190 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751660}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d99b64678d6a..fabad157059d git log d99b64678d6a..fabad157059d --date=short --first-parent --format='%ad %ae %s' 2020-03-19 csmartdalton@google.com Remove ln "-T" option from cavaskit demo Created with: gclient setdep -r src/third_party/skia@fabad157059d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I80d2a218393ba62212984cd96f2cea5ccb8c1ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109873Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/93bcaae44524..e55f0c338495 git log 93bcaae44524..e55f0c338495 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 yekuang@google.com Fix mb.py when using `isolate archive` Created with: gclient setdep -r src/third_party/webrtc@e55f0c338495 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1062881 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c5f7919e84b388365bfb276e1adac420022a38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109870Reviewed-by:
-
Vasiliy Telezhnikov authored
If while checking for fences we get VK_DEVICE_LOST_ERROR we perform cleanup by calling vkWaitForDeviceIdle and calling all cleanup callbacks and destroying fences. All destroyed fences should be considered as passed after this point to avoid waiting on them. This is speculative fix for gpu process hangs. Bug: 1062731 Change-Id: I18253126e646158735e813e72a143969717db6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108915Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751657}
-
Victor Hugo Vianna Silva authored
This CL exposes an API that will allow the user to change their opt-in status, eventually triggering a reauth flow. This new API will be used later by chrome://settings Bug: 1049141 Change-Id: I37a69e31ca4b351e6bc8558a42b27d8d2da3f822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097987 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#751656}
-
Christian Dullweber authored
Bug: 1062595 Change-Id: If72893eb9fbc1f8b28c92cf4880247973b288bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107589Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#751655}
-
Christoph Schwering authored
This CL only shows the banner to users who are signed in, have at least one password, and haven't run the bulk password check yet. Bug: 1062269 Change-Id: Idbf622e501e961d169fe57e5606d8acb4b5b00f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107524 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
-
Dominik Röttsches authored
Fixed: 1056027, 1057339 Tbr: sergeyu Change-Id: Icd1f88c1cbdfe86ac096b5c209b7c819c3dc6043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109692Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#751653}
-
Marc Treib authored
This will be required for tests that cover both the profile store and the account store (e.g. in https://crrev.com/c/2105380). Unfortunately it breaks some expectations in existing tests that used to leave PasswordForm::in_store unset; this CL updates those expectations. TBR=jzw for straightforward change in cwv_autofill_data_manager_unittest.mm Bug: 1058339 Change-Id: I8a4653df0f48648995ba169f29811f1175fbe660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106086 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#751652}
-
Finnur Thorarinsson authored
If the remote process dies, the callback function will null out the service connection (mIRemoteService). At that point we should abort further still image decoding to prevent a crash. Bug: 1060818, 656015 Change-Id: I4301a272b189ff27d3344f1917a09ff61ed502b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102650 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.42-1584352428-benchmark-82.0.4085.10-r1 to 82-4044.42-1584352428-benchmark-82.0.4085.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I597b9ce655b7fe27196ad6bf033ba794eaab36c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107519Reviewed-by:
-
Mike West authored
This reverts commit bd41828b. Reason for revert: `external/wpt/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html` has been failing since this landed (https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87591?blamelist=1#blamelist-tab) Original change's description: > Remove workaround [1] to add a placeholder for lazyload images. > > Bug: 992765, 999019, 995119, 999209, 1045745 > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1773869 > > Change-Id: I80fa5a67740f6c8918e531dedb8bc77ec7f09bbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103708 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751428} TBR=szager@chromium.org,chrishtr@chromium.org,sclittle@chromium.org,rajendrant@chromium.org Change-Id: If2a39274a5c23b758866aa5dfdb30ad0ba57b2dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992765, 999019, 995119, 999209, 1045745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108508Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#751649}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53a925b3221a..c3411c20dad7 Created with: gclient setdep -r src-internal@c3411c20dad7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2052bfff8e2b5623793f084178c865f24572b7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108759Reviewed-by:
-
